GNU bug report logs - #18969
25.0.50; byte compiler warnings don't conform to GCS

Previous Next

Full log

Message #16 received at 18969 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: tom <at> tromey.com, 18969 <at> debbugs.gnu.org
Subject: Re: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS
Date: Thu, 05 Dec 2019 12:44:00 +0100

Tom Tromey <tom <at> tromey.com> writes:

> I got this warning from the byte compiler:
>
> q.el:2:8:Warning: value returned from (aref v 0) is unused
>
> This doesn't fully conform to the GNU Coding Standards.
>>From (info "(standards) Errors")
>
>     If you want to mention the column number, use one of these formats:
>
>          SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE
>          SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE
>
> The output here is missing a space after the ":".

Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> writes:

> On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote:
>> The output here is missing a space after the ":".
>
> I wrote a quick fix for it.  But I'm not sure if this is the best approach:
>
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index 392f6ee..d2bbefa 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry)
>                             byte-compile-last-warned-form))))
>        (insert (format "\nIn %s:\n" form)))
>      (when level
> -      (insert (format "%s%s" file pos))))
> +      (insert (format "%s%s " file pos))))
>    (setq byte-compile-last-logged-file byte-compile-current-file
>         byte-compile-last-warned-form byte-compile-current-form)
>    entry)

This was never installed at the time, but it does seem that we are
breaking against GNU Coding Standards.  Does anyone object to
installing the above change?

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.