From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 05 21:58:44 2014 Received: (at submit) by debbugs.gnu.org; 6 Nov 2014 02:58:44 +0000 Received: from localhost ([127.0.0.1]:50660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmDHX-0007Ut-4w for submit@debbugs.gnu.org; Wed, 05 Nov 2014 21:58:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35984) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmDHT-0007Uk-Ad for submit@debbugs.gnu.org; Wed, 05 Nov 2014 21:58:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmDHK-0006c7-PN for submit@debbugs.gnu.org; Wed, 05 Nov 2014 21:58:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmDHK-0006bz-MH for submit@debbugs.gnu.org; Wed, 05 Nov 2014 21:58:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XmDHD-0005Ha-Ib for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 21:58:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XmDH5-0006Z9-Le for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 21:58:23 -0500 Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:34316) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1XmDH5-0006YB-B3 for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 21:58:15 -0500 Received: (qmail 20320 invoked by uid 0); 6 Nov 2014 02:58:11 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy3.mail.unifiedlayer.com with SMTP; 6 Nov 2014 02:58:11 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id C8y71p00H2f2jeq018yAc7; Thu, 06 Nov 2014 01:58:10 -0700 X-Authority-Analysis: v=2.1 cv=ON60g0qB c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=X1qvojbhiZEA:10 a=9xtqfDhBUH5p0ySE9yAA:9 a=_O_VeBSb9OShEbH_:21 a=m6FduDgv-pgiPl4h:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=yz8QxBAzyqktPiKkVNXm7KvupzJUzm03nGDGkbgyiNA=; b=PFT9Qasi+HxEUQE2wu4ZehBheJ4bFJkefbGOagZbk/6S0dK87FobAV3b+sblpA/orqpUrM7cZ2a1wzCksX/cyttuCAG0TS11ZYrYLIk0yLU2UwMY2GYe8RFIDPNdrlRK; Received: from [71.33.139.67] (port=35012 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.82) (envelope-from ) id 1XmDGx-0002ic-U9; Wed, 05 Nov 2014 19:58:08 -0700 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 25.0.50; byte compiler warnings don't conform to GCS X-Attribution: Tom Date: Wed, 05 Nov 2014 19:58:04 -0700 Message-ID: <87wq79ghmr.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.33.139.67 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I got this warning from the byte compiler: q.el:2:8:Warning: value returned from (aref v 0) is unused This doesn't fully conform to the GNU Coding Standards. >From (info "(standards) Errors") If you want to mention the column number, use one of these formats: SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE The output here is missing a space after the ":". Also I think the "W" in warning should probably not be capitalized. I note that GCC doesn't do this. In GNU Emacs 25.0.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.9) of 2014-11-02 on bapiya Repository revision: 118270 larsi@gnus.org-20141103010307-bxryy53hat500i4w Windowing system distributor `Fedora Project', version 11.0.11404000 Configured using: `configure --prefix=/home/tromey/Emacs/install' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t flyspell-mode: t which-function-mode: t global-auto-revert-mode: t desktop-save-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill Recent input: d , SPC t h e r e ' s SPC n o t SPC m u c h SPC C-z n C-h i C-s s t a n d C-s C-a m C-s w a r n i n g : C-s C-s C-a s e r r o r C-g C-s e r r o r : C-s C-s C-s C-a 1 C-v n n n m e r r C-z n C-/ t h e i t ' s SPC a SPC s t i l l SPC c o n v e n i e n t SPC t o SPC u s e SPC ' p o p ' SPC a n d SPC C-h f r e m o v p o p C-z n z n l C-z n t h e r e SPC i s n ' t SPC a SPC c o n v e n i e n t SPC s u b s t i t u t e . C-x 1 M-v C-p C-b C-b C-b C-b C-e M-b M-b M-b , SPC C-n , SPC a n d SPC i t t h e r e SPC i s o SPC t h e r e SPC i s n ' t SPC a n y t h i n g SPC u s e f u l SPC t o SPC b e SPC d o n e SPC a b o u t SPC t h i s SPC w a r n i n g . M-q C-f C-f C-c C-c y e s C-z n C-z n M-x M-p Recent messages: Making completion list... Type C-x 1 to delete the help window. z is undefined Mark set Sending... Mark set [2 times] Sending via mail... Sending email Sending email done Sending...done Load-path shadows: /home/tromey/.emacs.d/elpa/css-mode-1.0/css-mode hides /home/tromey/Emacs/install/share/emacs/25.0.50/lisp/textmodes/css-mode /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.0.50/lisp/play/bubbles Features: (mailalias view xterm shadow emacsbug python json elcomp mail-hist find-dired pcmpl-unix pcmpl-gnu shell make-mode flow-fill mule-util bbdb-gui bbdb-hooks sort gnus-cite smiley shr-color color shr browse-url mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings cl gnutls network-stream starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source tls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader idutils derived log-edit message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util eieio-opt speedbar sb-image ezimage dframe dabbrev help-mode debug copyright misearch multi-isearch edebug texinfo sh-script smie executable sgml-mode org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs smerge-mode diff-mode easy-mmode bug-reference goto-addr add-log vc-arch vc-mtn vc-hg jka-compr dired vc-sccs vc-svn vc-cvs vc-rcs vc-bzr cc-mode cc-fonts cc-guess cc-menus cc-cmds vc-git flyspell ispell diminish projectile edmacro kmacro pkg-info find-func lisp-mnt epl grep compile dash s appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify desktop frameset cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-button wid-edit erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat format-spec auth-source cl-macs gv eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core cl-loaddefs cl-lib gnus-util mm-util mail-prsvr password-cache thingatpt pp advice help-fns vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb timezone ange-ftp comint ansi-color ring server savehist dwarf-mode-autoloads gdb-shell-autoloads jabber-autoloads lisppaste-autoloads pydoc-info-autoloads info-look info easymenu weblogger-autoloads package epg-config bbdb-autoloads time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 1069522 168854) (symbols 48 101419 15) (miscs 40 42592 4764) (strings 32 316083 71200) (string-bytes 1 7505203) (vectors 16 97711) (vector-slots 8 2099685 83602) (floats 8 563 1012) (intervals 56 60524 9259) (buffers 976 233) (heap 1024 260455 33054)) Tom From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 06 15:28:00 2014 Received: (at 18969) by debbugs.gnu.org; 6 Nov 2014 20:28:00 +0000 Received: from localhost ([127.0.0.1]:52101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmTex-0003TY-O2 for submit@debbugs.gnu.org; Thu, 06 Nov 2014 15:28:00 -0500 Received: from ptmx.org ([178.63.28.110]:51038) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XmTev-0003TP-Lc for 18969@debbugs.gnu.org; Thu, 06 Nov 2014 15:27:58 -0500 Received: from localhost (localhost [127.0.0.1]) by ptmx.org (Postfix) with ESMTP id E78D52C739; Thu, 6 Nov 2014 21:27:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ptmx.org Received: from ptmx.org ([127.0.0.1]) by localhost (ptmx.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yBE-EEmDwkDp; Thu, 6 Nov 2014 21:27:54 +0100 (CET) Received: from descartes.localnet (chello080109100138.16.15.univie.teleweb.at [80.109.100.138]) by ptmx.org (Postfix) with ESMTPSA id 8B6E62C706; Thu, 6 Nov 2014 21:27:52 +0100 (CET) From: =?ISO-8859-1?Q?R=FCdiger?= Sonderfeld To: bug-gnu-emacs@gnu.org Subject: Re: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS Date: Thu, 06 Nov 2014 21:27:33 +0100 Message-ID: <2099525.NlHqIGAjEz@descartes> User-Agent: KMail/4.13.3 (Linux/3.13.0-37-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <87wq79ghmr.fsf@tromey.com> References: <87wq79ghmr.fsf@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 18969 Cc: Tom Tromey , 18969@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote: > The output here is missing a space after the ":". I wrote a quick fix for it. But I'm not sure if this is the best appro= ach: diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 392f6ee..d2bbefa 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry) byte-compile-last-warned-form)))) (insert (format "\nIn %s:\n" form))) (when level - (insert (format "%s%s" file pos)))) + (insert (format "%s%s " file pos)))) (setq byte-compile-last-logged-file byte-compile-current-file byte-compile-last-warned-form byte-compile-current-form) entry) > Also I think the "W" in warning should probably not be capitalized. > I note that GCC doesn't do this. Not sure if there is a good solution for this. The warning levels are=20= predefined in the variable `warning-levels'. They could be changed to = lower=20 case but that would break cases when there is no prefix. Regards, R=C3=BCdiger From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 29 21:37:42 2019 Received: (at control) by debbugs.gnu.org; 30 Sep 2019 01:37:43 +0000 Received: from localhost ([127.0.0.1]:56350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEkdC-0000WS-Mh for submit@debbugs.gnu.org; Sun, 29 Sep 2019 21:37:42 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:43407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEkdB-0000WB-F0 for control@debbugs.gnu.org; Sun, 29 Sep 2019 21:37:41 -0400 Received: by mail-pg1-f178.google.com with SMTP id v27so6431072pgk.10 for ; Sun, 29 Sep 2019 18:37:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VybA9Y18u3/DKXOq5v+o4GWeSCNZjwP6Lt2fT5ff2ms=; b=hzAanfXz8NJBugs4ezsrK4NEkQwSHz8p+idyL6Phd/WjtjQwSUD+przD3p+TiTtLff 4NkibaVqbec9kuH4xGH4gsjXYuoqqGdO8hrXD94sD9B1VEQteRJBP+esN2N2fL08Lutf x0ZHvrYOuH4A9i24Y21bNr8kZyc1iGYHhpi6HsMVGG47ZV6fWyYebGdgu9OSEOZn0Ka2 /UMX18KvbEsbQ8vu7lSrU2bTbUZjotDELWU481ewtTzSkRYYIPTXFgRrnkClKYf3rVr3 zwUAFo1G/T+ZVYoceOyWwY3IQsPdl/EBi+IPR59Tzh51/gIQ99TdpTUMdv+p0LFn5jDF W/5Q== X-Gm-Message-State: APjAAAUXpdhgRqv6ta3WMrlNq42xy0lsHlWatuuDXyTa+r6mEcPtTfA6 FaLJOIZKcZKL7AFow1/cHFbIOzhjDPopLBVO426Tf7yA/og= X-Google-Smtp-Source: APXvYqx9WZAlNmEIN5tZ8WSsmU8CRAgXuM3gANgMLmHZA5e8qGpq5bZ/MZPcQfjZKIjc6zwQjvfp4msL7YoM8jx1NCg= X-Received: by 2002:a63:720f:: with SMTP id n15mr20820335pgc.198.1569807455589; Sun, 29 Sep 2019 18:37:35 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Mon, 30 Sep 2019 03:37:24 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 18969 + patch quit Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.178 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.215.178 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 18969 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 06:44:10 2019 Received: (at 18969) by debbugs.gnu.org; 5 Dec 2019 11:44:10 +0000 Received: from localhost ([127.0.0.1]:43175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icpYI-000836-Dq for submit@debbugs.gnu.org; Thu, 05 Dec 2019 06:44:10 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:47660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icpYH-00082t-6t for 18969@debbugs.gnu.org; Thu, 05 Dec 2019 06:44:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4rV7kF4fq89au2X+v6qIgwjTfTAayiShUhkVvY1PoGc=; b=EEdZNMlOgM1YtnCzT72wgrfAj0 T93jyFsDJ/9D4usdAq3+egk7E0VIDJ+AB/PpgRofSaD5bNW+xSU3ti2RA1RYy0bOIDGdQzqmR8gbU CZSgI1MmTY9Cw1dZ8oQaS/IiTy84e4u0y8/P7CyApGlyvV2l0SGDSyEA//bCmBouifvlDB/cpmGlZ d3549nff17BlQZWXXFyXnnhQN1jiBnLjx8yTA53DukEq+EtU7LJmlMkcDkEHv+G3+nH+KxKf5N5zc a1YjLc0nQb35vkWqRJZ9C+tM01x4FvJ8vjlYYUOJKa7l6JoW12gzQ1P0vp09t0vXyb2GJwcXBAbt7 xYv2238w==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:45562 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1icpYA-001OUu-D9; Thu, 05 Dec 2019 06:44:02 -0500 From: Stefan Kangas To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Subject: Re: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS In-Reply-To: <2099525.NlHqIGAjEz@descartes> (=?utf-8?Q?=22R=C3=BCdiger?= Sonderfeld"'s message of "Thu, 06 Nov 2014 21:27:33 +0100") References: <87wq79ghmr.fsf@tromey.com> <2099525.NlHqIGAjEz@descartes> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 05 Dec 2019 12:44:00 +0100 Message-ID: <87h82ff14v.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18969 Cc: tom@tromey.com, 18969@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tom Tromey writes: > I got this warning from the byte compiler: > > q.el:2:8:Warning: value returned from (aref v 0) is unused > > This doesn't fully conform to the GNU Coding Standards. >>>From (info "(standards) Errors") > > If you want to mention the column number, use one of these formats: > > SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE > SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE > > The output here is missing a space after the ":". R=C3=BCdiger Sonderfeld writes: > On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote: >> The output here is missing a space after the ":". > > I wrote a quick fix for it. But I'm not sure if this is the best approac= h: > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 392f6ee..d2bbefa 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry) > byte-compile-last-warned-form)))) > (insert (format "\nIn %s:\n" form))) > (when level > - (insert (format "%s%s" file pos)))) > + (insert (format "%s%s " file pos)))) > (setq byte-compile-last-logged-file byte-compile-current-file > byte-compile-last-warned-form byte-compile-current-form) > entry) This was never installed at the time, but it does seem that we are breaking against GNU Coding Standards. Does anyone object to installing the above change? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 05:34:28 2019 Received: (at 18969) by debbugs.gnu.org; 31 Dec 2019 10:34:28 +0000 Received: from localhost ([127.0.0.1]:33770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEr6-0002YK-0S for submit@debbugs.gnu.org; Tue, 31 Dec 2019 05:34:28 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:37874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEr5-0002Y6-3o for 18969@debbugs.gnu.org; Tue, 31 Dec 2019 05:34:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0HYUDwYMjdOgnjs7om4rya68IxQ+3j6k32slVDCv7rw=; b=UqSbQ+/n+n5mN4sHLizaoYsjQw Ak5OLiS8LH8lwvcG/X14QBTT0f818UE1zsw2QF5Tl3W3oENWVU8LkX9wxDdHjLc4+Ac5UaGjDNEVX yP3pd7yJi3utqnbyAZjpUSjyKq+mjQk1Jz8064Gb0KYOHfKuET6RF1VRa2NdiueSI+BfojKZJSy4I dDRIxRxhSdBQeABuk3jCjMW5tWM1LHxvtaF8VBaMKaQ4n0CCTJ8FuIj3KsFKRTKmxzzyg9ye+Kbyi LHX8EpvULTVf7BW1gO5CRz29NfcUvZj5Gfty6cc92pM89XVcK7einhXdtD4ggXxNJm9YI1E9d4koy MgLGiWZw==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52194 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1imEqy-001iNW-K6; Tue, 31 Dec 2019 05:34:20 -0500 From: Stefan Kangas To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Subject: Re: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS In-Reply-To: <87h82ff14v.fsf@marxist.se> (Stefan Kangas's message of "Thu, 05 Dec 2019 12:44:00 +0100") References: <87wq79ghmr.fsf@tromey.com> <2099525.NlHqIGAjEz@descartes> <87h82ff14v.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Tue, 31 Dec 2019 11:34:18 +0100 Message-ID: <87r20kbx79.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18969 Cc: tom@tromey.com, 18969@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Tom Tromey writes: > >> I got this warning from the byte compiler: >> >> q.el:2:8:Warning: value returned from (aref v 0) is unused >> >> This doesn't fully conform to the GNU Coding Standards. >>>>>From (info "(standards) Errors") >> >> If you want to mention the column number, use one of these formats: >> >> SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE >> SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE >> >> The output here is missing a space after the ":". > > R=C3=BCdiger Sonderfeld writes: > >> On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote: >>> The output here is missing a space after the ":". >> >> I wrote a quick fix for it. But I'm not sure if this is the best approa= ch: >> >> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el >> index 392f6ee..d2bbefa 100644 >> --- a/lisp/emacs-lisp/bytecomp.el >> +++ b/lisp/emacs-lisp/bytecomp.el >> @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry) >> byte-compile-last-warned-form)))) >> (insert (format "\nIn %s:\n" form))) >> (when level >> - (insert (format "%s%s" file pos)))) >> + (insert (format "%s%s " file pos)))) >> (setq byte-compile-last-logged-file byte-compile-current-file >> byte-compile-last-warned-form byte-compile-current-form) >> entry) > > This was never installed at the time, but it does seem that we are > breaking against GNU Coding Standards. Does anyone object to > installing the above change? I have seen no objections within 3 weeks, so I'll go ahead and install this change on the master branch within a couple of days. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 20:11:49 2020 Received: (at 18969) by debbugs.gnu.org; 19 Jan 2020 01:11:49 +0000 Received: from localhost ([127.0.0.1]:42520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isz81-00016U-GE for submit@debbugs.gnu.org; Sat, 18 Jan 2020 20:11:49 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:49830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isz7w-000167-Ik; Sat, 18 Jan 2020 20:11:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cVOr40f98pcosan/E/H6cKV5OPnpzWqh4YR4PSfMOA4=; b=uURqjLbsa3C+OOxbI+h1ejJnyR Zp3RD9bfhcbnn5YFOYj3MgZvDrERIXw8zoKFJsgQKT6RG5+nFvE8eOGGzUpOJbbvpW7YNV1Q97DIq 4lfQvsQHyC8oI99d04WdC+3H7b0oaBJXzxf7aC5j5m4BGP572bpma1bKDWoWEDgo5oV6ZKGiiGegl uis8KIJhCBMJppNOnoB5DTjxmOi/NmEZPwgXEQBJX5AIeSO+O7nMiPZhkEoc66zi+NYf67LUVIPZe rk5w0JsYy2m9X5Q9e1769X1sKB/ZFDfEYjBCSXZ2hUn8VMVpDBvhs2AzRMI8dcFTz8P9xrqTN6GcG D98iXuMg==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:51212 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isz7p-0015ku-Ko; Sat, 18 Jan 2020 20:11:37 -0500 From: Stefan Kangas To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Subject: Re: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS In-Reply-To: <87r20kbx79.fsf@marxist.se> (Stefan Kangas's message of "Tue, 31 Dec 2019 11:34:18 +0100") References: <87wq79ghmr.fsf@tromey.com> <2099525.NlHqIGAjEz@descartes> <87h82ff14v.fsf@marxist.se> <87r20kbx79.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 19 Jan 2020 02:11:34 +0100 Message-ID: <87sgkcuu61.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18969 Cc: tom@tromey.com, 18969@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 18969 28.1 thanks Stefan Kangas writes: > I have seen no objections within 3 weeks, so I'll go ahead and install > this change on the master branch within a couple of days. Now pushed to master as commit 0e57792395. Closing. Best regards, Stefan Kangas From unknown Sat Jun 21 05:19:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Feb 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator