From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 05 00:51:06 2014 Received: (at submit) by debbugs.gnu.org; 5 Nov 2014 05:51:06 +0000 Received: from localhost ([127.0.0.1]:49395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XltUo-0001bm-IP for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:51:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40438) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XltUl-0001bd-Dk for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:51:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XltUg-0001Yr-AD for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:51:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XltUg-0001Yl-7U for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:50:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XltUb-0007Sn-4o for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:50:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XltUT-0001VN-9V for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:50:53 -0500 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:47861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XltUT-0001VB-3g for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:50:45 -0500 Received: by mail-wi0-f180.google.com with SMTP id hi2so957323wib.13 for ; Tue, 04 Nov 2014 21:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=JBimSE/XubPA/PibVsnS67UkA0OOv374fEz6/Su0z2U=; b=UOygh8ENCLHgtpNobYEG02Uy04Zm4K3Pl+RFrb7jnJmWQAlYAQ3JxWtnd44kDJAP6S RbbPLUKx0bYCo8AB3iEnKnTrYEmzkV9IgDCSYY4Nks9I+sh2Q7vzm5RCjomDNdR8Ujeg mrQrPj15N+H64E8LE9icesz7VV6xJSbNoPX4Af85xgGt0AgaPWXuJ/jGPdIo8mjIi9+k 8jTWw//CCMFIf0X6oSXVX9DXm29GYm+PbxQE0JKCOqjoO6CfqG0zSG58slDSOAYyPYOc ULxLwJBH2TsNmiOrspO+Uj/aDoGGiI2AxOLCE+FVYWD1L9HVOLjKFRhkjotL+KwCizzA BDlw== X-Received: by 10.195.13.114 with SMTP id ex18mr16766851wjd.111.1415166644089; Tue, 04 Nov 2014 21:50:44 -0800 (PST) Received: from axl ([82.102.116.197]) by mx.google.com with ESMTPSA id m6sm3288563wiy.16.2014.11.04.21.50.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Nov 2014 21:50:43 -0800 (PST) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 24.4.51; eshell-pcomplete removes asterisk when attempting completion Date: Wed, 05 Nov 2014 07:50:39 +0200 Message-ID: <86tx2ei4b4.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Open a new Eshell session. 2. Type `*'. 3. Press `TAB' (invoking `eshell-pcomplete'), or `M-x pcomplete', or `M-x completion-at-point'. 4. See the asterisk removed as the completions buffer is displayed. I don't think it makes much sense (just replace it when a completion is inserted), and it's quite inconvenient when `pcomplete-completions-at-point' is used from company-mode during idle completion, as reported here: https://github.com/company-mode/company-mode/issues/218 In GNU Emacs 24.4.51.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2014-11-03 on axl Repository revision: 117658 michael.albinus@gmx.de-20141102112256-548dk6al63uy76uh Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.1 LTS From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 00:20:36 2017 Received: (at 18951) by debbugs.gnu.org; 1 Nov 2017 04:20:36 +0000 Received: from localhost ([127.0.0.1]:44881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9kW4-0004X0-KN for submit@debbugs.gnu.org; Wed, 01 Nov 2017 00:20:36 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:33753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9kW1-0004Wm-S3 for 18951@debbugs.gnu.org; Wed, 01 Nov 2017 00:20:35 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 9E69246EF2 for <18951@debbugs.gnu.org>; Wed, 1 Nov 2017 05:20:27 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id 0Ju2nzc4yhEp for <18951@debbugs.gnu.org>; Wed, 1 Nov 2017 05:20:25 +0100 (CET) From: Daniel Kraus To: 18951@debbugs.gnu.org Subject: eshell-pcomplete removes asterisk when attempting completion Date: Wed, 01 Nov 2017 12:16:57 +0800 Message-ID: <871slid45i.fsf@kraus.my> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18951 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Friendly bump. The issue is now 3 years old, is there anything I can do to help get it fixed? With all the new eshell hype I'm experimenting with switching more of my workflow to eshell and would like instant company autocompleteion (instead of always using (helm-)esh-pcomplete). Thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 08:47:04 2017 Received: (at 18951) by debbugs.gnu.org; 1 Nov 2017 12:47:04 +0000 Received: from localhost ([127.0.0.1]:45089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9sQB-00029Z-VR for submit@debbugs.gnu.org; Wed, 01 Nov 2017 08:47:04 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:56112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9sQA-000296-KN for 18951@debbugs.gnu.org; Wed, 01 Nov 2017 08:47:03 -0400 Received: by mail-io0-f171.google.com with SMTP id p186so5689908ioe.12 for <18951@debbugs.gnu.org>; Wed, 01 Nov 2017 05:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yrL8RJ4po3pQFWW5lQJmniGJ7FCaf7dX5by8BVh4vog=; b=AZgvoPfxuWKwXS3AWLS8zQT/jcoDcJI652zuXmUgg0yq4GTBUAGCT1QxuE3mTBYkiN P8jUcFQ0JWGGbd6V90mVBarDLHVpJ5eS0AyolAjKjXvm6862x70S1V4XLSpcVslwTqR7 b3sXEPGhjE7kbsXnc16P3wAlwtrjxNZFG1ZvMYGL7u52om3LxKxiZaBQSte0lWLXlqmg vj7ICsZz3+v/hVamyoE1yeHfOdbXEuA1KJOGegr9qdOEgAhgxbxmTSU/4zz7H8sz1iZK SzFi4IaiMEkrYVFo/9Oo1WfSE0aF5p0IYLXeoENEa0TWoCdO59Keoiy+SeGY0AZ4paAP 3KZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=yrL8RJ4po3pQFWW5lQJmniGJ7FCaf7dX5by8BVh4vog=; b=g7fJTQ6A9rCso24fE78K8oc2I8D3EFr6Cfv4o4rRffoFI9Vis1WpLk3DXLfv50SHZk mKN4LCewB5dJacoXxxLBILwLBSx7iLIMLBgfbMye4wnVsKHlnw4U3+IPx2i3Cn5Ez/fy 3nxqWp0pdTGVEucOio3Vc6nVoUXbg4/VAektmpXSlU5AIoTCMTEgqjF9SH/JFtt//lm6 b1WYm5RK77iTExTX+/Fw9ZO1AKXK0gmQ2k1TXEQr0UFPEje+7ouKGFNJXvU32gedCUDe bipMO9eKg9a02oxNP9HpwnCSkg9vpz+kZL7ufO1WvWY8ttDUni3cRjHvnFBF8Dc6ZpIs 6yZw== X-Gm-Message-State: AMCzsaWN7D8jI+d5Fo8/UckZGgEWG1so8VoV93hAE3KW1XH8Pbv2Lzqa g+6RHl1AiIxJvNtcq2445b4vdg== X-Google-Smtp-Source: ABhQp+TrdFvSnYkJAZNwjPYXtl4N/i1DJ1Mm9mQ8H8UkVM+odyk43RpXzEoDChRtI1MOsGUfhSRtkg== X-Received: by 10.107.132.100 with SMTP id g97mr6561949iod.47.1509540416431; Wed, 01 Nov 2017 05:46:56 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k83sm218443iod.35.2017.11.01.05.46.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Nov 2017 05:46:55 -0700 (PDT) From: Noam Postavsky To: Daniel Kraus Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> Date: Wed, 01 Nov 2017 08:46:53 -0400 In-Reply-To: <871slid45i.fsf@kraus.my> (Daniel Kraus's message of "Wed, 01 Nov 2017 12:16:57 +0800") Message-ID: <87efpi9neq.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 18951 Cc: 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Daniel Kraus writes: > The issue is now 3 years old, is there anything I can do to help get > it fixed? A good start would be to step through eshell-pcomplete with edebug and find the piece of code which deletes the asterisk. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 03:00:29 2017 Received: (at 18951) by debbugs.gnu.org; 2 Nov 2017 07:00:29 +0000 Received: from localhost ([127.0.0.1]:46782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA9UL-00070J-B8 for submit@debbugs.gnu.org; Thu, 02 Nov 2017 03:00:29 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:44402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA9UI-0006zx-St for 18951@debbugs.gnu.org; Thu, 02 Nov 2017 03:00:27 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 714CF4705B; Thu, 2 Nov 2017 08:00:20 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id b5zpL7At8qx1; Thu, 2 Nov 2017 08:00:17 +0100 (CET) References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> From: Daniel Kraus To: Noam Postavsky Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion In-reply-to: <87efpi9neq.fsf@users.sourceforge.net> Date: Thu, 02 Nov 2017 15:00:00 +0800 Message-ID: <877ev9p3m7.fsf@kraus.my> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18951 Cc: 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Noam Postavsky writes: > A good start would be to step through eshell-pcomplete with edebug and > find the piece of code which deletes the asterisk. It's in `pcomplete-parse-arguments` (in pcomplete.el) Line 776 on master: ``` (when (and begin (not pcomplete-show-list)) (delete-region begin (point)) (pcomplete-insert-entry "" pcomplete-stub)) ``` Hope that helps. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEcQ53mjqaZIoGsbLHwcjWP4hO+ckFAln6wnAACgkQwcjWP4hO +clgYQgA1QuyxcznnU1v1syIKjoX70yxB7quRMDJnX7yrCPEDVIoCq8frAYqviTJ NOZZXT3LpT70ufVAdbGwWqS5/Z6eAxEUGxvEWenDelRlWv1YSAoryJDCTr6c/XDs Eti/fci3x8f3J1TI9hp9mNayGZ6PO7LMhGMZDm3yt83r+iV0xe5DpP8xVg6DZ60g jOqOKn0sGMPEBnywfDX+6alo47eHR+f6N9ntnaJbJccYZelSN83x06BRgVyWH7L9 lKB/sZXjiz809MDbY6e+an3KBakUMa/HsGMnoZSmS3QbubrAqOfa1frM+udbYI06 8hn97P3nA2rhhYejAka7vzoZTKqoRw== =wu2r -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 07:32:25 2017 Received: (at 18951) by debbugs.gnu.org; 2 Nov 2017 11:32:25 +0000 Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADjU-0000nd-3f for submit@debbugs.gnu.org; Thu, 02 Nov 2017 07:32:25 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:56178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADjR-0000nP-UQ for 18951@debbugs.gnu.org; Thu, 02 Nov 2017 07:32:22 -0400 Received: by mail-io0-f179.google.com with SMTP id p186so13141292ioe.12 for <18951@debbugs.gnu.org>; Thu, 02 Nov 2017 04:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aYz1T/pilocvA9J/ZqUDSpu3iFEeZ4RUUqrnMOsoiAk=; b=BJBpnbhSgHJsH+CCbRcgY5o4pruqW0TzUaw2OjsOC7jnwYH7iodD4bvR9WbXPFn5kg DbKMo4lUdCEC3elP2tdDNPuHVPoQlt/8fQUz3Yq3urBMqYW8jkQVrU3AjxVi28pVGrxB tm3TsLHSS+qcHFvOpneSeTLJ1RUSHuxj1Z/8XyBOz/ibUVvvoBLM0fl93I1oh+sEJ34w c+htLGu4qDhA/5z3PcyNqHWf+9icd3N4EV1LtWTQPzOGT91iVGkKG6ufRnLaQTA1KfWR z5Kr9ua+v4q89sAP/Odcv7k2Vk+epIwnsLnihqOrotT1e287TycurLrPCO8Elb1al33Y ooTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=aYz1T/pilocvA9J/ZqUDSpu3iFEeZ4RUUqrnMOsoiAk=; b=O/hvY2T7ThynfyqJiB9VGzejkfLyhMPpe1XxwiE227MPujFypSKkiO8XOZ4a3V9I6Q 671DLeV/eKaEhhO9PYzVLbnp1AvUULnJcjzoL9cSmSsIk+JRhX4Y4uhPXyotJa3mlvxG aArlgQk7WJEd5MdbK2DkjWjJIglgOdDydAlhvUz2zPWwfFVdypnyhJEltnwWNg1QI2bH QUAYvYKIgaTNHwz4Fi9B1CKGI6K/YOeoHK7yAl7dpBiLUUW41u1iCpqcdjG8Gm5j5VVQ ksi1SUc/vr9K04T4zdMydcURV6vYeJQeZTR8MO8aoBFGsqFbWB+AXWIi7RtSlJL0q0Ad rpjQ== X-Gm-Message-State: AMCzsaU63cTif5gXwM0aarMY19Ajo1r69YoTKfc74yBATrPNVk6QmMD2 HrBvEr28/Q1sdqKtwLh0qVW+fw== X-Google-Smtp-Source: ABhQp+SS3jICYabky3sgQwGFOiObW+WWoHqmU++B54QQjHaZdssRwtpXM+nEh6IuVlXo0iJsI9oEDQ== X-Received: by 10.36.108.67 with SMTP id w64mr1989134itb.126.1509622335875; Thu, 02 Nov 2017 04:32:15 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q191sm1037093itb.1.2017.11.02.04.32.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 04:32:14 -0700 (PDT) From: Noam Postavsky To: Daniel Kraus Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> Date: Thu, 02 Nov 2017 07:32:13 -0400 In-Reply-To: <877ev9p3m7.fsf@kraus.my> (Daniel Kraus's message of "Thu, 02 Nov 2017 15:00:00 +0800") Message-ID: <87po909arm.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 18951 Cc: 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Daniel Kraus writes: > Noam Postavsky writes: > >> A good start would be to step through eshell-pcomplete with edebug and >> find the piece of code which deletes the asterisk. > > It's in `pcomplete-parse-arguments` (in pcomplete.el) > Line 776 on master: > ``` > (when (and begin (not pcomplete-show-list)) > (delete-region begin (point)) > (pcomplete-insert-entry "" pcomplete-stub)) > ``` Hmm, does this do the right thing? --- i/lisp/pcomplete.el +++ w/lisp/pcomplete.el @@ -772,7 +772,7 @@ pcomplete-parse-arguments (setq c (cdr c))) (setq pcomplete-stub (substring common-stub 0 len) pcomplete-autolist t) - (when (and begin (not pcomplete-show-list)) + (when (and begin (> len 0) (not pcomplete-show-list)) (delete-region begin (point)) (pcomplete-insert-entry "" pcomplete-stub)) (throw 'pcomplete-completions completions)) From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 10:16:28 2017 Received: (at 18951) by debbugs.gnu.org; 2 Nov 2017 14:16:28 +0000 Received: from localhost ([127.0.0.1]:48065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAGIF-000572-T9 for submit@debbugs.gnu.org; Thu, 02 Nov 2017 10:16:28 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:49997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAGID-00056k-GR for 18951@debbugs.gnu.org; Thu, 02 Nov 2017 10:16:26 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 56C0146FC6; Thu, 2 Nov 2017 15:16:19 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id VbZK-M7HWd0G; Thu, 2 Nov 2017 15:16:17 +0100 (CET) References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> <87po909arm.fsf@users.sourceforge.net> From: Daniel Kraus To: Noam Postavsky Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion In-reply-to: <87po909arm.fsf@users.sourceforge.net> Date: Thu, 02 Nov 2017 22:15:53 +0800 Message-ID: <8760assr52.fsf@kraus.my> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18951 Cc: 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Noam Postavsky writes: > Hmm, does this do the right thing? > > --- i/lisp/pcomplete.el > +++ w/lisp/pcomplete.el > @@ -772,7 +772,7 @@ pcomplete-parse-arguments > (setq c (cdr c))) > (setq pcomplete-stub (substring common-stub 0 len) > pcomplete-autolist t) > - (when (and begin (not pcomplete-show-list)) > + (when (and begin (> len 0) (not pcomplete-show-list)) > (delete-region begin (point)) > (pcomplete-insert-entry "" pcomplete-stub)) > (throw 'pcomplete-completions completions)) I didn't test it too much if something else breaks but it seems to work. pcomplete doesn't remove the * and company mode also seems to work without problems now. Thanks --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEcQ53mjqaZIoGsbLHwcjWP4hO+ckFAln7KJkACgkQwcjWP4hO +cmRmggA1CDfP6nM9oJV2PcQOQ1reuKJEzcLE0vK92yr+ioADr6wEDY7TagaUwZF uigyGvlYpKqPNDeNcKuEQFyOvtU0W3ToYiihmdpOIiiWxhcti0V4nUA5HVd/m/1E SBmLVU/P6T6WOekaBkaSrSZSZEDdGFdjvx74ulvly4vs46ptVXMxrMPVrrzTrieg 402dqVOqpHkUd7Sye/gmR+HlTBg3TbJrddB1w19hyYI/v2IkMfq5s7cJqPqk/eif iQCXv/v8U9Qze7MhQxkDkMtODbVOy+YhZuZ27uSEG6R/CA7bc8MAk00p1FVfI8kG ZLk8p/pAashaMlfQ2lCafPugLutC0A== =UWGp -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 17:25:45 2017 Received: (at 18951) by debbugs.gnu.org; 3 Nov 2017 21:25:45 +0000 Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAjTE-0004LA-VP for submit@debbugs.gnu.org; Fri, 03 Nov 2017 17:25:45 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:44728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAjTD-0004Kt-GR for 18951@debbugs.gnu.org; Fri, 03 Nov 2017 17:25:43 -0400 Received: by mail-wm0-f43.google.com with SMTP id n74so4125010wmi.1 for <18951@debbugs.gnu.org>; Fri, 03 Nov 2017 14:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pElr8EXSCi8J9t1/ENtsqb2Wr1lLJ2WKo5ZBlTtitJM=; b=eLHmbhRLDYQu0TV4apVZBTc6CObvpmqNodTLxBSA9lnHbWouhC7gxHqVxAJx3Q3XPU 8RCSRBvJzEOV9kWgYObIIo++jzMtoLYgwL1OzttLO+/bRo7w+PkaIzqNXxbpy04w1sC+ mD9Mn6CYFVZZiebjniYMYtTE4CI4bkOMqMJTVbgzC7pp+bRxsqZbSZ+9l+FQOG2UPraD WQfTjapr+y9/WjypFACJph6eSOG0g8reB2/eEpPAtu1LoYPyXnwrFMNiTFVLscScfg6g yqUx7iUZliLlo8YfZCI4MjJ/zceNX1VYaXI08XHWoE2MsEBiULZeiEA0JeCbK/zAV3EC I5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pElr8EXSCi8J9t1/ENtsqb2Wr1lLJ2WKo5ZBlTtitJM=; b=IewkDM5HxdTGo9o/Z+DN3AT0TCCTTrAY+wAKUMz/cUqEAYTJoRSq+OFm/kYqCG4mgh oypY+BqbX5KbewUPWqcubrkAK7cnjFtAFhKSVuKri8Mg5O/5FO2u5s6NecHppPYOh1TE aOTHAWMaprvg5HFuk3Qc+GFIV4aSFifE4+bmRyySfpWYt6nKeq9OAKL6SQl7L79NJDXi O0lRvGbLUijgsL+YqnF1YHkT8ceLmVRmQBxd+Ct8SCaAAMiuyb4ZMgypPZAT0tB4KqJ2 7uKn1vJc2tDyTUPnQce+HIHTCZn+mQVlLaLCnb80o9w8DEGF2mJmZljC3//DsFRFDVtp uHSA== X-Gm-Message-State: AMCzsaWSSkUe5w8sN4cQ1dlMPQeMgjx3zPO2SxV3Mp2HNTlyp4bhOQcg IJRAWjIbgwTctlznJ0rlw/yvkonu X-Google-Smtp-Source: ABhQp+SjDkrRATx14jNy/M54RALIiUKNO41QMTU9h+XnqhcuD+UL61+p0FiqPNAq51ouSHNSi6TFGA== X-Received: by 10.80.172.74 with SMTP id w10mr10459625edc.257.1509744337637; Fri, 03 Nov 2017 14:25:37 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id o55sm7535099edc.90.2017.11.03.14.25.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2017 14:25:36 -0700 (PDT) Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion To: Daniel Kraus , Noam Postavsky References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> <87po909arm.fsf@users.sourceforge.net> <8760assr52.fsf@kraus.my> From: Dmitry Gutov Message-ID: Date: Fri, 3 Nov 2017 23:25:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 In-Reply-To: <8760assr52.fsf@kraus.my> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18951 Cc: 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 11/2/17 4:15 PM, Daniel Kraus wrote: > > Noam Postavsky writes: > >> Hmm, does this do the right thing? >> >> --- i/lisp/pcomplete.el >> +++ w/lisp/pcomplete.el >> @@ -772,7 +772,7 @@ pcomplete-parse-arguments >> (setq c (cdr c))) >> (setq pcomplete-stub (substring common-stub 0 len) >> pcomplete-autolist t) >> - (when (and begin (not pcomplete-show-list)) >> + (when (and begin (> len 0) (not pcomplete-show-list)) >> (delete-region begin (point)) >> (pcomplete-insert-entry "" pcomplete-stub)) >> (throw 'pcomplete-completions completions)) > > I didn't test it too much if something else breaks but it > seems to work. pcomplete doesn't remove the * and company > mode also seems to work without problems now. Looking good in my testing, and fixes the problem. Thanks! pcomplete-completion-at-point is still buggy, of course, but no worse than before. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 12:17:37 2017 Received: (at 18951) by debbugs.gnu.org; 5 Nov 2017 17:17:37 +0000 Received: from localhost ([127.0.0.1]:52492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOYD-0006Ds-Hg for submit@debbugs.gnu.org; Sun, 05 Nov 2017 12:17:37 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:50326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOYC-0006DW-1n; Sun, 05 Nov 2017 12:17:36 -0500 Received: by mail-io0-f181.google.com with SMTP id 97so13354702iok.7; Sun, 05 Nov 2017 09:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/2sS6xfRua++iCx2pNW4tPI07sH/i+1d6FmLYf1/GLE=; b=FFxwEyIuXtoOrZZn2Sj1Kc4O9DnzsrrGA5Cd6GgYeRHJJsBQNBY3bf/DySOUFShD4C CAq1ajyvStS1yv8MiRKlSWzoX+wX5VKbwDG+og99eRXGiZUvtj+nB20dQh3+hu0LkF1t AW7cSYL9CQa2FdhunCWLugOzlTS2cWjJhQMWgLwP3y3PNc0+AkdTlCvQssSxmcpAepPo oJHUHzleIKpBDOeCCEu5+Z4fe6JppTNExpQ1h76SyTzldJjiEdnaGSkx8QVplUaX6fw5 lQL1CslBZfUE90RGQ17AkR0XWN5ML7OCZjc41OG5vy+X/s9EhkivSWLAxjp5mv/OmEIP MWTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/2sS6xfRua++iCx2pNW4tPI07sH/i+1d6FmLYf1/GLE=; b=FFHQy7iI5AflelEhQ/VN7desZ6pT4EK7A07QDzZluh1lr+/tVh2WmDuspdJCD82jgA eFc11EErnx6obnu0sjZmvRkkMoAVjjrg/CQk8VlYVPr3zh/z9xz+6Gw7GLqohPQx7snO 4ncHOk2B7tWaO65YnLnY32MYQP35/XP/HHYCWwxc9k6FP9EjdJfEVImFQAbqdsaj151R Xpj+nygjYE8WNGtoWUGzRs/Ob4u+vB7Qd+dv4oqMW+eesxq72YEXc5m0Ps5noNORlGCk e3rH49ODrG+jE8kbUBKWXR9fdaaoyzqfoXeA19Hb+2Hv3/6ZJOLZlFMogGmTzzPc0o9c vOUQ== X-Gm-Message-State: AJaThX6PENtqFfLtfJuDdAZ6/BAxe0pjxKEfv1Ol/CGxfOMEDSjSaYfH xP2S4FxhexkzP/ANiaN5mdps1w== X-Google-Smtp-Source: ABhQp+Qp8a6RNVSt5Hs46d46uxXlTUOae5gzI/sQISOMHMh4LUclOy+z6TiByUWZ5j7jaBH7f4hkwg== X-Received: by 10.107.174.206 with SMTP id n75mr4619588ioo.43.1509902249879; Sun, 05 Nov 2017 09:17:29 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v5sm4665517iog.78.2017.11.05.09.17.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 09:17:28 -0800 (PST) From: Noam Postavsky To: Dmitry Gutov Subject: Re: bug#18951: eshell-pcomplete removes asterisk when attempting completion References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> <87po909arm.fsf@users.sourceforge.net> <8760assr52.fsf@kraus.my> Date: Sun, 05 Nov 2017 12:17:27 -0500 In-Reply-To: (Dmitry Gutov's message of "Fri, 3 Nov 2017 23:25:34 +0200") Message-ID: <87fu9s7ihk.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 18951 Cc: Daniel Kraus , 18951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 18951 fixed close 18951 26.1 quit Dmitry Gutov writes: > On 11/2/17 4:15 PM, Daniel Kraus wrote: >>> --- i/lisp/pcomplete.el >>> +++ w/lisp/pcomplete.el >>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments >>> (setq c (cdr c))) >>> (setq pcomplete-stub (substring common-stub 0 len) >>> pcomplete-autolist t) >>> - (when (and begin (not pcomplete-show-list)) >>> + (when (and begin (> len 0) (not pcomplete-show-list)) >>> (delete-region begin (point)) >>> (pcomplete-insert-entry "" pcomplete-stub)) >>> (throw 'pcomplete-completions completions)) >> >> I didn't test it too much if something else breaks but it >> seems to work. pcomplete doesn't remove the * and company >> mode also seems to work without problems now. > > Looking good in my testing, and fixes the problem. Thanks! > pcomplete-completion-at-point is still buggy, of course, but no worse > than before. Okay, pushed to emacs-26. [1: 5d744e032f]: 2017-11-05 11:36:20 -0500 Don't replace user input when completion prefix is empty (Bug#18951) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d744e032fee9ce60446a3cc0cf7c2e681ace465> From unknown Thu Sep 11 14:10:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Dec 2017 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator