From unknown Thu Sep 11 11:56:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18950: 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Nov 2014 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18950@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14151653213963 (code B ref -1); Wed, 05 Nov 2014 05:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2014 05:28:41 +0000 Received: from localhost ([127.0.0.1]:49387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xlt96-00011q-2R for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38238) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xlt8l-00011N-KW for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlt8f-00020P-At for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8f-000204-7W for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8Z-00046C-5C for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlt8T-0001zc-5j for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:07 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:44127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8S-0001yg-VE for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:01 -0500 Received: by mail-wi0-f182.google.com with SMTP id d1so953436wiv.3 for ; Tue, 04 Nov 2014 21:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=DkWLTOejV/GhnKzGXnoUw++3/Hvvakg48Vn0SKrEEqs=; b=mTUmysuAPSexDgUOdYLhHEsY4/8NZ7YPxAisP4wBZwoIuP1WZWXc60UwWDGIWw0tEp xoi1BzeS86T98N2kns1SNFPqjWgF5fMkV0lKxhlyBcc9wNv33QIAxP8zosa6D3+/7F86 txWS1Ti1UkDAbmygdfCEx48xfF8yt2mzciTl0MJq9eTDUDAlYsWhswpFAeywvnIYplsQ +AQEreJNwZncnLo1rWTtd7SWMo/fibE4keHDPvnXJwNLgoZb5ki45QWfFjc6QJaPkGgL kH1xDxI+UQoaXK5b2Jm8PESJ75USQx5GyGQ1gnFmS58/p2BD/hc2NLIcwjoFBjT//wNb SwVw== X-Received: by 10.180.91.49 with SMTP id cb17mr28927879wib.30.1415165279299; Tue, 04 Nov 2014 21:27:59 -0800 (PST) Received: from axl ([82.102.116.197]) by mx.google.com with ESMTPSA id t9sm2717647wjf.41.2014.11.04.21.27.58 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Nov 2014 21:27:58 -0800 (PST) From: Dmitry Gutov Date: Wed, 05 Nov 2014 07:27:56 +0200 Message-ID: <86wq7ai5cz.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. M-x eshell 2. (setq pcomplete-cycle-completions nil) 3. Type `*', press TAB. 4. See an error, like: Debugger entered--Lisp error: (wrong-type-argument stringp ("Anki/" "Audiob= ooks/" "Desktop/" "Documents/" "Downloads/" ...)) file-name-directory(("Anki/" "Audiobooks/" "Desktop/" "Documents/" "Downl= oads/" ...)) (if (file-name-directory filename) (pcomplete-executables) (if (and (> (l= ength filename) 0) (eq (aref filename 0) eshell-explicit-command-char)) (se= tq filename (substring filename 1) pcomplete-stub filename glob-name t)) (l= et* ((paths (eshell-parse-colon-path eshell-path-env)) (cwd (file-name-as-d= irectory (expand-file-name default-directory))) (path "") (comps-in-path ni= l) (file "") (filepath "") (completions nil)) (while paths (setq path (file= -name-as-directory (expand-file-name (or (car paths) "."))) comps-in-path (= and (file-accessible-directory-p path) (file-name-all-completions filename = path))) (while comps-in-path (setq file (car comps-in-path) filepath (conca= t path file)) (if (and (not (member file completions)) (or (string-equal pa= th cwd) (not ...)) (file-executable-p filepath)) (setq completions (cons fi= le completions))) (setq comps-in-path (cdr comps-in-path))) (setq paths (cd= r paths))) (pcomplete-uniqify-list (if glob-name completions (setq completi= ons (append (and (eshell-using-module ...) (funcall ... filename)) (eshell-= winnow-list (mapcar ... ...) nil (quote ...)) completions)) (append (and (o= r eshell-show-lisp-completions (and eshell-show-lisp-alternatives ...)) (al= l-completions filename obarray (quote functionp))) completions))))) (let ((filename (pcomplete-arg)) glob-name) (if (file-name-directory file= name) (pcomplete-executables) (if (and (> (length filename) 0) (eq (aref fi= lename 0) eshell-explicit-command-char)) (setq filename (substring filename= 1) pcomplete-stub filename glob-name t)) (let* ((paths (eshell-parse-colon= -path eshell-path-env)) (cwd (file-name-as-directory (expand-file-name defa= ult-directory))) (path "") (comps-in-path nil) (file "") (filepath "") (com= pletions nil)) (while paths (setq path (file-name-as-directory (expand-file= -name (or ... "."))) comps-in-path (and (file-accessible-directory-p path) = (file-name-all-completions filename path))) (while comps-in-path (setq file= (car comps-in-path) filepath (concat path file)) (if (and (not ...) (or ..= . ...) (file-executable-p filepath)) (setq completions (cons file completio= ns))) (setq comps-in-path (cdr comps-in-path))) (setq paths (cdr paths))) (= pcomplete-uniqify-list (if glob-name completions (setq completions (append = (and ... ...) (eshell-winnow-list ... nil ...) completions)) (append (and (= or eshell-show-lisp-completions ...) (all-completions filename obarray ...)= ) completions)))))) eshell-complete-commands-list() ... 5. (setq pcomplete-cycle-completions t) -> and it works fine again. In GNU Emacs 24.4.51.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2014-11-03 on axl Repository revision: 117658 michael.albinus@gmx.de-20141102112256-548dk6al6= 3uy76uh Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.1 LTS From unknown Thu Sep 11 11:56:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled References: <86wq7ai5cz.fsf@yandex.ru> In-Reply-To: <86wq7ai5cz.fsf@yandex.ru> Resent-From: samer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jan 2015 04:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 18950@debbugs.gnu.org Received: via spool by 18950-submit@debbugs.gnu.org id=B18950.14212952096162 (code B ref 18950); Thu, 15 Jan 2015 04:14:02 +0000 Received: (at 18950) by debbugs.gnu.org; 15 Jan 2015 04:13:29 +0000 Received: from localhost ([127.0.0.1]:57217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBboG-0001bJ-CW for submit@debbugs.gnu.org; Wed, 14 Jan 2015 23:13:28 -0500 Received: from samertm.com ([162.243.37.26]:57378 helo=mail.samertm.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBboD-0001bB-Qr for 18950@debbugs.gnu.org; Wed, 14 Jan 2015 23:13:26 -0500 Received: by mail.samertm.com (Postfix, from userid 1010) id 0733882104; Thu, 15 Jan 2015 04:13:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on o-server X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from samertm.com (localhost [127.0.0.1]) by mail.samertm.com (Postfix) with ESMTP id 09BAE81A1E; Thu, 15 Jan 2015 04:12:48 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 14 Jan 2015 20:12:48 -0800 From: samer Message-ID: <4fd05af1b84870c40eae10fa421aa17c@samertm.com> X-Sender: samer@samertm.com User-Agent: Roundcube Webmail/0.9.5 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, The function pcomplete-parse-arguments wasn't completing the input when pcomplete-cycle-completions was nil, and so pcomplete would pass control to one of eshell's completion functions, which would blow up when given a list by pcomplete-arg (which is strange, because it's valid for pcomplete-arg to return a list). But there is no reason for pcomplete-parse-arguments to care about whether the user wants to cycle completions, as only really matters in pcomplete-stub. The following patch fixes the bug by making pcomplete-parse-arguments not care about the value of pcomplete-cycle-completions. Best, Samer Changes from HEAD~1 to working tree 2 files changed, 6 insertions(+), 2 deletions(-) lisp/ChangeLog | 5 +++++ lisp/pcomplete.el | 3 +-- Modified lisp/ChangeLog diff --git a/lisp/ChangeLog b/lisp/ChangeLog index f413526..c904e03 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-01-15 Samer Masterson + + * pcomplete.el (pcomplete-parse-arguments): Parse arguments + regardless of pcomplete-cycle-completions's value. (bug#18950) + 2015-01-04 Dmitry Gutov Add mouse interaction to xref. Modified lisp/pcomplete.el diff --git a/lisp/pcomplete.el b/lisp/pcomplete.el index 17327ea..7bcf2c1 100644 --- a/lisp/pcomplete.el +++ b/lisp/pcomplete.el @@ -755,8 +755,7 @@ this is `comint-dynamic-complete-functions'." pcomplete-index 0 pcomplete-stub (pcomplete-arg 'last)) (let ((begin (pcomplete-begin 'last))) - (if (and pcomplete-cycle-completions - (listp pcomplete-stub) ;?? + (if (and (listp pcomplete-stub) ;?? (not pcomplete-expand-only-p)) (let* ((completions pcomplete-stub) ;?? (common-stub (car completions)) From unknown Thu Sep 11 11:56:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jan 2015 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: samer Cc: 18950@debbugs.gnu.org, Dmitry Gutov Received: via spool by 18950-submit@debbugs.gnu.org id=B18950.142133440329445 (code B ref 18950); Thu, 15 Jan 2015 15:07:02 +0000 Received: (at 18950) by debbugs.gnu.org; 15 Jan 2015 15:06:43 +0000 Received: from localhost ([127.0.0.1]:57824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBm0Q-0007eq-Q8 for submit@debbugs.gnu.org; Thu, 15 Jan 2015 10:06:43 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:53762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBm0P-0007eh-Fc for 18950@debbugs.gnu.org; Thu, 15 Jan 2015 10:06:41 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0FF6dOa020435; Thu, 15 Jan 2015 10:06:40 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2F51716E8; Thu, 15 Jan 2015 10:06:39 -0500 (EST) From: Stefan Monnier Message-ID: References: <86wq7ai5cz.fsf@yandex.ru> <4fd05af1b84870c40eae10fa421aa17c@samertm.com> Date: Thu, 15 Jan 2015 10:06:39 -0500 In-Reply-To: <4fd05af1b84870c40eae10fa421aa17c@samertm.com> (samer@samertm.com's message of "Wed, 14 Jan 2015 20:12:48 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.4 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.2, LNG_SB_1=0.2, RV5187=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5187> : inlines <1768> : streams <1373836> : uri <1842492> X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > - (if (and pcomplete-cycle-completions > - (listp pcomplete-stub) ;?? > + (if (and (listp pcomplete-stub) ;?? I haven't had time to look more closely at the bug and the code, but if this indeed works, then it looks like a good change. Stefan From unknown Thu Sep 11 11:56:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dmitry Gutov Subject: bug#18950: closed (Re: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled) Message-ID: References: <54B87949.4040402@yandex.ru> <86wq7ai5cz.fsf@yandex.ru> X-Gnu-PR-Message: they-closed 18950 X-Gnu-PR-Package: emacs Reply-To: 18950@debbugs.gnu.org Date: Fri, 16 Jan 2015 02:38:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1421375882-11884-1" This is a multi-part message in MIME format... ------------=_1421375882-11884-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18950: 24.4.51; Wrong type argument: stringp on completing an asterisk in = eshell with pcomplete-cycle-completions disabled which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18950@debbugs.gnu.org. --=20 18950: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18950 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1421375882-11884-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18950-done) by debbugs.gnu.org; 16 Jan 2015 02:37:12 +0000 Received: from localhost ([127.0.0.1]:58311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBwme-00034g-3g for submit@debbugs.gnu.org; Thu, 15 Jan 2015 21:37:12 -0500 Received: from mail-la0-f51.google.com ([209.85.215.51]:58027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YBwmb-00034R-CF for 18950-done@debbugs.gnu.org; Thu, 15 Jan 2015 21:37:09 -0500 Received: by mail-la0-f51.google.com with SMTP id ms9so16818182lab.10 for <18950-done@debbugs.gnu.org>; Thu, 15 Jan 2015 18:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=+BUI5BslXWqMbMwT79xDs+0z1N1rrrxGWujYWuPXVhk=; b=dFtJrwjWQ3otykoiqtmtRnVehHUvARkFNM4I8o3h5u/D/NsdW2/wBHOkNFE/iulg75 sTGxMFL99O0+94zEvJHOiorcw//RpVhWfRi5OaMPACuPVo12mE+XTtIMtXWa9QyyqQW+ DBJ7c1RZ0h4tOnoQPwaCihC0Z3XQiL9S27kLcGKRq8OzZ5Wu9LgCf2d300R8yYRG7b/C FxD79KPJmYQXEgTxTpYN0KKfkGLEo/nBISxcv+r+KqWs419Q1wKZKEKpqMEnOV7Y8gse KC3FHL9Y9hF0JVPYMCy6hjMhzUbxHk93KmAQOqRgFVX50ox23isDSpttps3UW9mIS103 y8dA== X-Received: by 10.152.19.7 with SMTP id a7mr13131326lae.16.1421375823312; Thu, 15 Jan 2015 18:37:03 -0800 (PST) Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id e7sm477002lbq.33.2015.01.15.18.37.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 18:37:02 -0800 (PST) Message-ID: <54B87949.4040402@yandex.ru> Date: Fri, 16 Jan 2015 05:36:57 +0300 From: Dmitry Gutov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 MIME-Version: 1.0 To: Stefan Monnier , samer Subject: Re: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled References: <86wq7ai5cz.fsf@yandex.ru> <4fd05af1b84870c40eae10fa421aa17c@samertm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18950-done Cc: 18950-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 01/15/2015 06:06 PM, Stefan Monnier wrote: >> - (if (and pcomplete-cycle-completions >> - (listp pcomplete-stub) ;?? >> + (if (and (listp pcomplete-stub) ;?? > > I haven't had time to look more closely at the bug and the code, but > if this indeed works, then it looks like a good change. It does. Installed and marked as "tiny change". Thanks, Samer! ------------=_1421375882-11884-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Nov 2014 05:28:41 +0000 Received: from localhost ([127.0.0.1]:49387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xlt96-00011q-2R for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38238) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xlt8l-00011N-KW for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlt8f-00020P-At for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8f-000204-7W for submit@debbugs.gnu.org; Wed, 05 Nov 2014 00:28:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8Z-00046C-5C for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xlt8T-0001zc-5j for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:07 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:44127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xlt8S-0001yg-VE for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 00:28:01 -0500 Received: by mail-wi0-f182.google.com with SMTP id d1so953436wiv.3 for ; Tue, 04 Nov 2014 21:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=DkWLTOejV/GhnKzGXnoUw++3/Hvvakg48Vn0SKrEEqs=; b=mTUmysuAPSexDgUOdYLhHEsY4/8NZ7YPxAisP4wBZwoIuP1WZWXc60UwWDGIWw0tEp xoi1BzeS86T98N2kns1SNFPqjWgF5fMkV0lKxhlyBcc9wNv33QIAxP8zosa6D3+/7F86 txWS1Ti1UkDAbmygdfCEx48xfF8yt2mzciTl0MJq9eTDUDAlYsWhswpFAeywvnIYplsQ +AQEreJNwZncnLo1rWTtd7SWMo/fibE4keHDPvnXJwNLgoZb5ki45QWfFjc6QJaPkGgL kH1xDxI+UQoaXK5b2Jm8PESJ75USQx5GyGQ1gnFmS58/p2BD/hc2NLIcwjoFBjT//wNb SwVw== X-Received: by 10.180.91.49 with SMTP id cb17mr28927879wib.30.1415165279299; Tue, 04 Nov 2014 21:27:59 -0800 (PST) Received: from axl ([82.102.116.197]) by mx.google.com with ESMTPSA id t9sm2717647wjf.41.2014.11.04.21.27.58 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Nov 2014 21:27:58 -0800 (PST) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Date: Wed, 05 Nov 2014 07:27:56 +0200 Message-ID: <86wq7ai5cz.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. M-x eshell 2. (setq pcomplete-cycle-completions nil) 3. Type `*', press TAB. 4. See an error, like: Debugger entered--Lisp error: (wrong-type-argument stringp ("Anki/" "Audiob= ooks/" "Desktop/" "Documents/" "Downloads/" ...)) file-name-directory(("Anki/" "Audiobooks/" "Desktop/" "Documents/" "Downl= oads/" ...)) (if (file-name-directory filename) (pcomplete-executables) (if (and (> (l= ength filename) 0) (eq (aref filename 0) eshell-explicit-command-char)) (se= tq filename (substring filename 1) pcomplete-stub filename glob-name t)) (l= et* ((paths (eshell-parse-colon-path eshell-path-env)) (cwd (file-name-as-d= irectory (expand-file-name default-directory))) (path "") (comps-in-path ni= l) (file "") (filepath "") (completions nil)) (while paths (setq path (file= -name-as-directory (expand-file-name (or (car paths) "."))) comps-in-path (= and (file-accessible-directory-p path) (file-name-all-completions filename = path))) (while comps-in-path (setq file (car comps-in-path) filepath (conca= t path file)) (if (and (not (member file completions)) (or (string-equal pa= th cwd) (not ...)) (file-executable-p filepath)) (setq completions (cons fi= le completions))) (setq comps-in-path (cdr comps-in-path))) (setq paths (cd= r paths))) (pcomplete-uniqify-list (if glob-name completions (setq completi= ons (append (and (eshell-using-module ...) (funcall ... filename)) (eshell-= winnow-list (mapcar ... ...) nil (quote ...)) completions)) (append (and (o= r eshell-show-lisp-completions (and eshell-show-lisp-alternatives ...)) (al= l-completions filename obarray (quote functionp))) completions))))) (let ((filename (pcomplete-arg)) glob-name) (if (file-name-directory file= name) (pcomplete-executables) (if (and (> (length filename) 0) (eq (aref fi= lename 0) eshell-explicit-command-char)) (setq filename (substring filename= 1) pcomplete-stub filename glob-name t)) (let* ((paths (eshell-parse-colon= -path eshell-path-env)) (cwd (file-name-as-directory (expand-file-name defa= ult-directory))) (path "") (comps-in-path nil) (file "") (filepath "") (com= pletions nil)) (while paths (setq path (file-name-as-directory (expand-file= -name (or ... "."))) comps-in-path (and (file-accessible-directory-p path) = (file-name-all-completions filename path))) (while comps-in-path (setq file= (car comps-in-path) filepath (concat path file)) (if (and (not ...) (or ..= . ...) (file-executable-p filepath)) (setq completions (cons file completio= ns))) (setq comps-in-path (cdr comps-in-path))) (setq paths (cdr paths))) (= pcomplete-uniqify-list (if glob-name completions (setq completions (append = (and ... ...) (eshell-winnow-list ... nil ...) completions)) (append (and (= or eshell-show-lisp-completions ...) (all-completions filename obarray ...)= ) completions)))))) eshell-complete-commands-list() ... 5. (setq pcomplete-cycle-completions t) -> and it works fine again. In GNU Emacs 24.4.51.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2014-11-03 on axl Repository revision: 117658 michael.albinus@gmx.de-20141102112256-548dk6al6= 3uy76uh Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.1 LTS ------------=_1421375882-11884-1--