GNU bug report logs - #18938
Emacs 24.3: newline-and-indent has two undo boundaries

Previous Next

Package: emacs;

Reported by: Samuel Wales <samologist <at> gmail.com>

Date: Mon, 3 Nov 2014 19:26:01 UTC

Severity: normal

Tags: fixed

Fixed in version 24.4

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18938 in the body.
You can then email your comments to 18938 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#18938; Package emacs. (Mon, 03 Nov 2014 19:26:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Samuel Wales <samologist <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 03 Nov 2014 19:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Samuel Wales <samologist <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Bastien <bzg <at> gnu.org>, 11774-done <at> debbugs.gnu.org,
 Martin Pohlack <mp26 <at> os.inf.tu-dresden.de>, Toby Cubitt <tsc25 <at> cantab.net>
Subject: Emacs 24.3: newline-and-indent has two undo boundaries
Date: Mon, 3 Nov 2014 12:25:30 -0700
Reporting as suggested by Stefan.

In order to bunch up undos by 1 instead of the hardcoded 20, I do this:

  (add-hook 'post-self-insert-hook #'undo-boundary 'append)

This or advice used to work, then around Emacs 24.1 it stopped
working.  Stefan patched it in 24.3.  It now works in most cases.  The
history is in this Debian bug:

  Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost

I use undo-tree 0.6.6.  The bug also occurs with it turned off.

When I press RET when it is bound to newline-and-indent, the newline
and the indentation are undone separately.  I expected the RET to be
undone.

This is a minor issue for me, but might point to other cases.

Thanks.

Samuel




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18938; Package emacs. (Thu, 20 Nov 2014 23:02:01 GMT) Full text and rfc822 format available.

Message #8 received at 18938 <at> debbugs.gnu.org (full text, mbox):

From: Samuel Wales <samologist <at> gmail.com>
To: 18938 <at> debbugs.gnu.org
Subject: Re: bug#18938: Acknowledgement (Emacs 24.3: newline-and-indent has
 two undo boundaries)
Date: Thu, 20 Nov 2014 16:01:10 -0700
I found more places where this bug occurs.  A major [i.e. common] one
is that M-RET in Org will create a new headline, but undo requires two
steps.

-- 
The Kafka Pandemic: http://thekafkapandemic.blogspot.com

The disease DOES progress.  MANY people have died from it.  And
ANYBODY can get it.

Denmark: free Karina Hansen NOW.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18938; Package emacs. (Thu, 31 May 2018 23:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 18938 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Samuel Wales <samologist <at> gmail.com>
Cc: Bastien <bzg <at> gnu.org>, Martin Pohlack <mp26 <at> os.inf.tu-dresden.de>,
 Toby Cubitt <tsc25 <at> cantab.net>, monnier <at> iro.umontreal.ca,
 18938 <at> debbugs.gnu.org
Subject: Re: bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries
Date: Thu, 31 May 2018 19:55:34 -0400
tags 18938 fixed
close 18938 24.4
quit

Samuel Wales <samologist <at> gmail.com> writes:

> Reporting as suggested by Stefan.
>
> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>
>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>
> This or advice used to work, then around Emacs 24.1 it stopped
> working.  Stefan patched it in 24.3.  It now works in most cases.  The
> history is in this Debian bug:
>
>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost
>
> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>
> When I press RET when it is bound to newline-and-indent, the newline
> and the indentation are undone separately.  I expected the RET to be
> undone.

Seems to be fixed in 24.4




Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 31 May 2018 23:56:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 24.4, send any further explanations to 18938 <at> debbugs.gnu.org and Samuel Wales <samologist <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 31 May 2018 23:56:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#18938; Package emacs. (Fri, 01 Jun 2018 00:21:02 GMT) Full text and rfc822 format available.

Message #18 received at 18938 <at> debbugs.gnu.org (full text, mbox):

From: Samuel Wales <samologist <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Bastien <bzg <at> gnu.org>, Martin Pohlack <mp26 <at> os.inf.tu-dresden.de>,
 Toby Cubitt <tsc25 <at> cantab.net>, monnier <at> iro.umontreal.ca,
 18938 <at> debbugs.gnu.org
Subject: Re: bug#18938: Emacs 24.3: newline-and-indent has two undo boundaries
Date: Thu, 31 May 2018 17:20:48 -0700
yes, it seems to be fixed in 24.4.1 on debian jessie.  i do not have
access to other versions.

thank you.

On 5/31/18, Noam Postavsky <npostavs <at> gmail.com> wrote:
> tags 18938 fixed
> close 18938 24.4
> quit
>
> Samuel Wales <samologist <at> gmail.com> writes:
>
>> Reporting as suggested by Stefan.
>>
>> In order to bunch up undos by 1 instead of the hardcoded 20, I do this:
>>
>>   (add-hook 'post-self-insert-hook #'undo-boundary 'append)
>>
>> This or advice used to work, then around Emacs 24.1 it stopped
>> working.  Stefan patched it in 24.3.  It now works in most cases.  The
>> history is in this Debian bug:
>>
>>   Re: [O] bug#11774: bug#11774: org-mode causes undo boundaries to be
>> lost
>>
>> I use undo-tree 0.6.6.  The bug also occurs with it turned off.
>>
>> When I press RET when it is bound to newline-and-indent, the newline
>> and the indentation are undone separately.  I expected the RET to be
>> undone.
>
> Seems to be fixed in 24.4
>


-- 
The Kafka Pandemic: <http://thekafkapandemic.blogspot.com>

The disease DOES progress. MANY people have died from it. And ANYBODY
can get it at any time.

"You’ve really gotta quit this and get moving, because this is murder
by neglect." ---
<http://www.meaction.net/2017/02/03/pwme-people-with-me-are-being-murdered-by-neglect>.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 29 Jun 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 76 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.