GNU bug report logs - #18936
ERC: lexical-binding in 24.4 breaks erc-send-pre-hook

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18936: closed (ERC: lexical-binding in 24.4 breaks
 erc-send-pre-hook)
Date: Tue, 04 Nov 2014 20:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 04 Nov 2014 15:08:57 -0500
with message-id <jwvk33awwyf.fsf-monnier+emacsbugs <at> gnu.org>
and subject line Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
has caused the debbugs.gnu.org bug report #18936,
regarding ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18936: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18936
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: xristos <xristos <at> sdf.lonestar.org>
To: bug-gnu-emacs <at> gnu.org
Subject: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
Date: Mon, 03 Nov 2014 10:00:46 -0500

From erc.el, erc-send-pre-hook documentation:

"To change the text that will be sent, set the variable STR which is
used in `erc-send-current-line'."

From erc.el:5272, function `erc-send-input'

    (let ((str input)
	  (erc-insert-this t))
      (setq erc-send-this t)
      (run-hook-with-args 'erc-send-pre-hook input)

STR is dynamically bound.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: xristos <xristos <at> sdf.lonestar.org>
Cc: 18936-done <at> debbugs.gnu.org
Subject: Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
Date: Tue, 04 Nov 2014 15:08:57 -0500

> From erc.el, erc-send-pre-hook documentation:
> "To change the text that will be sent, set the variable STR which is
> used in `erc-send-current-line'."

Indeed.  I installed the patch below which should fix it.


        Stefan


=== modified file 'lisp/erc/erc.el'
--- lisp/erc/erc.el	2014-02-10 01:34:22 +0000
+++ lisp/erc/erc.el	2014-11-04 20:06:00 +0000
@@ -5268,6 +5268,7 @@
       (beep))
     nil)
    (t
+    (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
     (let ((str input)
 	  (erc-insert-this t))
       (setq erc-send-this t)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.