GNU bug report logs - #18936
ERC: lexical-binding in 24.4 breaks erc-send-pre-hook

Previous Next

Package: emacs;

Reported by: xristos <xristos <at> sdf.lonestar.org>

Date: Mon, 3 Nov 2014 16:41:01 UTC

Severity: normal

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 18936-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: xristos <xristos <at> sdf.lonestar.org>
Cc: 18936-done <at> debbugs.gnu.org
Subject: Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
Date: Tue, 04 Nov 2014 15:08:57 -0500

> From erc.el, erc-send-pre-hook documentation:
> "To change the text that will be sent, set the variable STR which is
> used in `erc-send-current-line'."

Indeed.  I installed the patch below which should fix it.


        Stefan


=== modified file 'lisp/erc/erc.el'
--- lisp/erc/erc.el	2014-02-10 01:34:22 +0000
+++ lisp/erc/erc.el	2014-11-04 20:06:00 +0000
@@ -5268,6 +5268,7 @@
       (beep))
     nil)
    (t
+    (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
     (let ((str input)
 	  (erc-insert-this t))
       (setq erc-send-this t)
This bug report was last modified 10 years and 284 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.