From unknown Thu Sep 11 02:24:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook Resent-From: xristos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Nov 2014 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18936@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141503285515221 (code B ref -1); Mon, 03 Nov 2014 16:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Nov 2014 16:40:55 +0000 Received: from localhost ([127.0.0.1]:47756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlKgY-0003xQ-JF for submit@debbugs.gnu.org; Mon, 03 Nov 2014 11:40:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59609) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlJN5-0001fT-PQ for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJMq-0005ZJ-N7 for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMq-0005ZF-Kh for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMj-00022y-4R for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJMZ-0005Vr-Fq for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:20 -0500 Received: from mail.suspicious.org ([66.175.219.125]:37894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMZ-0005Tz-B7 for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:11 -0500 Received: from samadhi.lan (69-84-100-215-dhcp.mia.fl.atlanticbb.net [69.84.100.215]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: night) by mail.suspicious.org (Postfix) with ESMTPSA id C7FB917AFC2 for ; Mon, 3 Nov 2014 15:00:47 +0000 (UTC) From: xristos Date: Mon, 03 Nov 2014 10:00:46 -0500 Message-ID: <7mppd4pbvl.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Mon, 03 Nov 2014 11:40:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From erc.el, erc-send-pre-hook documentation: "To change the text that will be sent, set the variable STR which is used in `erc-send-current-line'." >From erc.el:5272, function `erc-send-input' (let ((str input) (erc-insert-this t)) (setq erc-send-this t) (run-hook-with-args 'erc-send-pre-hook input) STR is dynamically bound. From unknown Thu Sep 11 02:24:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: xristos Subject: bug#18936: closed (Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook) Message-ID: References: <7mppd4pbvl.fsf@sdf.lonestar.org> X-Gnu-PR-Message: they-closed 18936 X-Gnu-PR-Package: emacs Reply-To: 18936@debbugs.gnu.org Date: Tue, 04 Nov 2014 20:10:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1415131802-14509-1" This is a multi-part message in MIME format... ------------=_1415131802-14509-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18936@debbugs.gnu.org. --=20 18936: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18936 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1415131802-14509-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18936-done) by debbugs.gnu.org; 4 Nov 2014 20:09:02 +0000 Received: from localhost ([127.0.0.1]:49201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlkPW-0003kf-89 for submit@debbugs.gnu.org; Tue, 04 Nov 2014 15:09:02 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:27874) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlkPT-0003kD-3M for 18936-done@debbugs.gnu.org; Tue, 04 Nov 2014 15:08:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvAMAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+yDmDGgQCAoEcFwEBfIQDAQEDAVYjBQsLNBIUGA0kiEsJy3IBAQEBAQEEAQEBAR6RCAeESwWLZKY8gW+EFh+CegEBAQ X-IPAS-Result: AvAMAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+yDmDGgQCAoEcFwEBfIQDAQEDAVYjBQsLNBIUGA0kiEsJy3IBAQEBAQEEAQEBAR6RCAeESwWLZKY8gW+EFh+CegEBAQ X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="95955575" Received: from 69-165-143-59.dsl.teksavvy.com (HELO ceviche.home) ([69.165.143.59]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Nov 2014 15:08:58 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 66A8D660D4; Tue, 4 Nov 2014 15:08:57 -0500 (EST) From: Stefan Monnier To: xristos Subject: Re: bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook Message-ID: References: <7mppd4pbvl.fsf@sdf.lonestar.org> Date: Tue, 04 Nov 2014 15:08:57 -0500 In-Reply-To: <7mppd4pbvl.fsf@sdf.lonestar.org> (xristos@sdf.lonestar.org's message of "Mon, 03 Nov 2014 10:00:46 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18936-done Cc: 18936-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > From erc.el, erc-send-pre-hook documentation: > "To change the text that will be sent, set the variable STR which is > used in `erc-send-current-line'." Indeed. I installed the patch below which should fix it. Stefan === modified file 'lisp/erc/erc.el' --- lisp/erc/erc.el 2014-02-10 01:34:22 +0000 +++ lisp/erc/erc.el 2014-11-04 20:06:00 +0000 @@ -5268,6 +5268,7 @@ (beep)) nil) (t + (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention. (let ((str input) (erc-insert-this t)) (setq erc-send-this t) ------------=_1415131802-14509-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Nov 2014 16:40:55 +0000 Received: from localhost ([127.0.0.1]:47756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlKgY-0003xQ-JF for submit@debbugs.gnu.org; Mon, 03 Nov 2014 11:40:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59609) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XlJN5-0001fT-PQ for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJMq-0005ZJ-N7 for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMq-0005ZF-Kh for submit@debbugs.gnu.org; Mon, 03 Nov 2014 10:16:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMj-00022y-4R for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlJMZ-0005Vr-Fq for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:20 -0500 Received: from mail.suspicious.org ([66.175.219.125]:37894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlJMZ-0005Tz-B7 for bug-gnu-emacs@gnu.org; Mon, 03 Nov 2014 10:16:11 -0500 Received: from samadhi.lan (69-84-100-215-dhcp.mia.fl.atlanticbb.net [69.84.100.215]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: night) by mail.suspicious.org (Postfix) with ESMTPSA id C7FB917AFC2 for ; Mon, 3 Nov 2014 15:00:47 +0000 (UTC) From: xristos To: bug-gnu-emacs@gnu.org Subject: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook Date: Mon, 03 Nov 2014 10:00:46 -0500 Message-ID: <7mppd4pbvl.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 03 Nov 2014 11:40:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From erc.el, erc-send-pre-hook documentation: "To change the text that will be sent, set the variable STR which is used in `erc-send-current-line'." >From erc.el:5272, function `erc-send-input' (let ((str input) (erc-insert-this t)) (setq erc-send-this t) (run-hook-with-args 'erc-send-pre-hook input) STR is dynamically bound. ------------=_1415131802-14509-1--