GNU bug report logs - #18898
Two portability patches

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mark H Weaver <mhw <at> netris.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18898: closed (Two portability patches)
Date: Wed, 12 Nov 2014 06:01:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 12 Nov 2014 00:59:10 -0500
with message-id <874mu5hscx.fsf <at> yeeloong.lan>
and subject line Re: bug#18898: Two portability patches
has caused the debbugs.gnu.org bug report #18898,
regarding Two portability patches
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18898: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18898
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thomas Klausner <wiz <at> NetBSD.org>
To: bug-guile <at> gnu.org
Subject: Two portability patches
Date: Thu, 30 Oct 2014 00:36:08 +0100

[Message part 3 (text/plain, inline)]

Hi!

The attached patches against git as of right-now fix two issues:

1.

test does not generally support '==' as comparison operator.
    
It's a bash(1) feature; not even GNU coreutils test(1) supports it.
Use '=' instead.


2.

NetBSD provides newlocale and strcoll_l, but not uselocale.

Please merge them.

Thanks,
 Thomas

[0002-test-does-not-generally-support-as-comparison-operat.patch (text/plain, attachment)]

[0001-NetBSD-provides-newlocale-and-strcoll_l-but-not-usel.patch (text/plain, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: Thomas Klausner <wiz <at> NetBSD.org>
Cc: 18898-done <at> debbugs.gnu.org
Subject: Re: bug#18898: Two portability patches
Date: Wed, 12 Nov 2014 00:59:10 -0500

Thomas Klausner <wiz <at> NetBSD.org> writes:

> test does not generally support '==' as comparison operator.
>     
> It's a bash(1) feature; not even GNU coreutils test(1) supports it.
> Use '=' instead.

Fixed in 03242f398f3520b1b27caf5885c8d5600094f944.

> NetBSD provides newlocale and strcoll_l, but not uselocale.

Fixed in 30c5982a9548a0ca0ea46111beb490f06d74a40a.

FYI, the patch you provided was not sufficient, because it neglected to
arrange for HAVE_USELOCALE to be set by configure.  This meant that the
thread-aware locale API would _never_ be used.

These commits are on the stable-2.0 branch and will be included in Guile
2.0.12.  I'm closing this bug now.

     Thanks,
       Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.