GNU bug report logs - #18840
24.4; nt/README.W32: obsolete snippet

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18840 in the body.
You can then email your comments to 18840 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 10:47:36 +0100

This snipped from the file nt/README.W32:
-------------------------
* Preliminaries

  Along with this file should be four subdirectories (bin, libexec,
  share, and var).
-------------------------
is obsolete, since now this file is placed under
'share/emacs/VERSION/' on the binary distribution.

So, it should be either reworded or removed.


In GNU Emacs 24.4.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.3.9600
Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252


-- 
Dani Moncayo

Message #8 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dani Moncayo <dmoncayo <at> gmail.com>
Cc: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 18:04:31 +0200

> Date: Sun, 26 Oct 2014 10:47:36 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> 
> This snipped from the file nt/README.W32:
> -------------------------
> * Preliminaries
> 
>   Along with this file should be four subdirectories (bin, libexec,
>   share, and var).
> -------------------------
> is obsolete, since now this file is placed under
> 'share/emacs/VERSION/' on the binary distribution.
> 
> So, it should be either reworded or removed.

Actually, I think that file should be manually copied to the top-level
directory, after "make install" finishes.  Otherwise, the probability
of it being discovered by users is probably close to zero.

Thanks.

Message #11 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 17:49:39 +0100

>> This snipped from the file nt/README.W32:
>> -------------------------
>> * Preliminaries
>>
>>   Along with this file should be four subdirectories (bin, libexec,
>>   share, and var).
>> -------------------------
>> is obsolete, since now this file is placed under
>> 'share/emacs/VERSION/' on the binary distribution.
>>
>> So, it should be either reworded or removed.
>
> Actually, I think that file should be manually copied to the top-level
> directory, after "make install" finishes.  Otherwise, the probability
> of it being discovered by users is probably close to zero.

That's a possibility, but I think we also should:

* Reword that section to make it independent of the location of the
  README.W32 file (the current wording is not valid for the copy in
  'share/emacs/VERSION').

* Tell the user _not_ to copy the top-level README.W32 when setting up
  his/her Emacs setup (individual packages should not pollute the top
  level directory).

For example, something along these lines:

=== modified file 'nt/README.W32'
--- nt/README.W32       2014-10-09 00:47:30 +0000
+++ nt/README.W32       2014-10-26 16:33:39 +0000
@@ -21,12 +21,19 @@

 * Preliminaries

-  Along with this file should be four subdirectories (bin, libexec,
-  share, and var).
+  The binary distribution has these top-level directories:
+
+  + bin: <explain briefly its contents>
+
+  + libexec: <explain briefly its contents>
+
+  + share: <explain briefly its contents>
+
+  + var: <explain briefly its contents>

 * Setting up Emacs

-  To install Emacs, simply unpack all the files into a directory of
+  To install Emacs, simply unpack the top-level directories into a directory of
   your choice.  To complete the installation process, you can
   optionally run the program addpm.exe in the bin subdirectory.  This
   will put an icon for Emacs in the Start Menu under

-- 
Dani Moncayo

Message #14 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dani Moncayo <dmoncayo <at> gmail.com>
Cc: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 19:17:10 +0200

> Date: Sun, 26 Oct 2014 17:49:39 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> Cc: 18840 <at> debbugs.gnu.org
> 
> -  Along with this file should be four subdirectories (bin, libexec,
> -  share, and var).
> +  The binary distribution has these top-level directories:
> +
> +  + bin: <explain briefly its contents>
> +
> +  + libexec: <explain briefly its contents>
> +
> +  + share: <explain briefly its contents>
> +
> +  + var: <explain briefly its contents>

This is OK (and I don't think we must describe the contents of each
subdirectory, but I will certainly not object to it).

>  * Setting up Emacs
> 
> -  To install Emacs, simply unpack all the files into a directory of
> +  To install Emacs, simply unpack the top-level directories into a directory of
>    your choice.

None of this is accurate.  Instead, we should say

  To install Emacs, simply unpack the binary zip into a directory of
  your choice.

Thanks.

Message #19 received at 18840-done <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18840-done <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 18:55:21 +0100

>> -  Along with this file should be four subdirectories (bin, libexec,
>> -  share, and var).
>> +  The binary distribution has these top-level directories:
>> +
>> +  + bin: <explain briefly its contents>
>> +
>> +  + libexec: <explain briefly its contents>
>> +
>> +  + share: <explain briefly its contents>
>> +
>> +  + var: <explain briefly its contents>
>
> This is OK (and I don't think we must describe the contents of each
> subdirectory, but I will certainly not object to it).

Ok.  (I didn't describe them because I wouldn't know how, especially
with "share" and "var").

>>  * Setting up Emacs
>>
>> -  To install Emacs, simply unpack all the files into a directory of
>> +  To install Emacs, simply unpack the top-level directories into a directory of
>>    your choice.
>
> None of this is accurate.  Instead, we should say
>
>   To install Emacs, simply unpack the binary zip into a directory of
>   your choice.

Ok.  (I changed "zip" with "package" to make it more neutral wrt the
compression format)

Committed & closing this bug.

Thank you.

-- 
Dani Moncayo

Message #22 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 19:05:32 +0100

> Committed & closing this bug.

I've just realized that this should have gone to emacs-24, not the
trunk.  Sorry.

(I could back port this to emacs-24 is someone tell me how, or what
doc to read).

-- 
Dani Moncayo

Message #25 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dani Moncayo <dmoncayo <at> gmail.com>
Cc: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 20:24:38 +0200

> Date: Sun, 26 Oct 2014 19:05:32 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> 
> > Committed & closing this bug.
> 
> I've just realized that this should have gone to emacs-24, not the
> trunk.  Sorry.
> 
> (I could back port this to emacs-24 is someone tell me how, or what
> doc to read).

You could simply apply the diffs, it's no big deal in this case.

If you want bzr to do the job for you, then the following will do it:

  cd emacs-24 && bzr merge -r 118218..118219 ../trunk

Then "bzr ci" as usual, but please be sure to say in the commit
message that this was "backported from trunk", so that the next merge
from emacs-24 to the trunk will skip this commit.

Thanks.

Message #28 received at 18840 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 18840 <at> debbugs.gnu.org
Subject: Re: bug#18840: 24.4; nt/README.W32: obsolete snippet
Date: Sun, 26 Oct 2014 19:40:05 +0100

>> (I could back port this to emacs-24 is someone tell me how, or what
>> doc to read).
>
> You could simply apply the diffs, it's no big deal in this case.
>
> If you want bzr to do the job for you, then the following will do it:
>
>   cd emacs-24 && bzr merge -r 118218..118219 ../trunk
>
> Then "bzr ci" as usual, but please be sure to say in the commit
> message that this was "backported from trunk", so that the next merge
> from emacs-24 to the trunk will skip this commit.

Done & thank you.

-- 
Dani Moncayo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.