From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 25 11:07:37 2014 Received: (at submit) by debbugs.gnu.org; 25 Oct 2014 15:07:37 +0000 Received: from localhost ([127.0.0.1]:35384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xi2wK-0002Mc-8C for submit@debbugs.gnu.org; Sat, 25 Oct 2014 11:07:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50658) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xi2wI-0002MO-6S for submit@debbugs.gnu.org; Sat, 25 Oct 2014 11:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xi2wC-0001eP-2V for submit@debbugs.gnu.org; Sat, 25 Oct 2014 11:07:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xi2wC-0001eL-0V for submit@debbugs.gnu.org; Sat, 25 Oct 2014 11:07:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xi2wB-0004bh-7t for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2014 11:07:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xi2wA-0001e9-FY for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2014 11:07:27 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:61315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xi2wA-0001e3-8h for bug-gnu-emacs@gnu.org; Sat, 25 Oct 2014 11:07:26 -0400 Received: by mail-wi0-f177.google.com with SMTP id ex7so3291192wid.16 for ; Sat, 25 Oct 2014 08:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=umf/CVu/AqwlPLo6sFNmmKq4dhyJtIdR9drHpFMUd8s=; b=VDxwSY0eU493cqXcXPWvThZu2QHnAiwSzpBpt0xEGBEo7bUsp7Rl5P5Tdw0tQPO8el MBoU4QkT286La0eK6IE28DdlSYd+vO5HMgJ3bZJbbGV+kSxvtIV+Xv6L0tkG+tQtp+vO t9CsBt+IesFgCzMko35R8oyE6vYW16wtdMRj0u3tBnYaAEvuYve+9Cw/C3YwsTzC4MnT ItWv00qXPxboJpAQ6aTusRh3Y4YIZ6GeccfETSbGyb4Q9NyEOL5IybbhLq5qSpXu1uQy p4u/TK+W9O66j6CDo4m+j3UWzKrEb3dDC66xM6Z0UAPzMl4fliWBIVdFvkUMIpvr4p2m zr1Q== MIME-Version: 1.0 X-Received: by 10.194.170.167 with SMTP id an7mr12185757wjc.57.1414249645408; Sat, 25 Oct 2014 08:07:25 -0700 (PDT) Received: by 10.217.152.70 with HTTP; Sat, 25 Oct 2014 08:07:25 -0700 (PDT) Date: Sat, 25 Oct 2014 17:07:25 +0200 Message-ID: Subject: 24.4; Early collision warning when 'create-lockfiles' is set to nil From: Dani Moncayo To: bug-gnu-emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recipe: 0. emacs -Q 1. Eval: (setq create-lockfiles nil) 2. Visit some file 3. With another program, update the visited file. 4. Try to make some change to the buffer. ------------ Without step 1, Emacs does TRT, i.e., it detects that I'm trying to make the first change to a buffer whose file has already changed since it was visited, so it warns me with: foo changed on disk; really edit the buffer? (y, n, r or C-h) But with step 1, Emacs doesn't warn me until I try to save the buffer; then it shows me this: foo has changed since visited or saved. Save anyway? (yes or no) (BTW: the above message does not get archived in the *Messages* buffer. Why not? I think it should, as with the first warning) Well, I think that Emacs should warn me on step 4, regardles of whether I did step 1 or not. I set `create-lockfiles' to nil in my init file because I don't want Emacs to create temporary files of any kind, but obviously I want to be warned whenever I am about to change a buffer whose file has changed on disk after it was last read by Emacs. I observe this bug both with the last 24.4 release and with the trunk. In GNU Emacs 24.4.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.3.9600 Important settings: value of $LANG: ENU locale-coding-system: cp1252 -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 28 05:30:33 2014 Received: (at control) by debbugs.gnu.org; 28 Oct 2014 09:30:33 +0000 Received: from localhost ([127.0.0.1]:37183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xj36l-0007Jo-I0 for submit@debbugs.gnu.org; Tue, 28 Oct 2014 05:30:32 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:47226) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xj36h-0007JZ-Hk for control@debbugs.gnu.org; Tue, 28 Oct 2014 05:30:28 -0400 Received: by mail-wi0-f175.google.com with SMTP id h11so6669729wiw.14 for ; Tue, 28 Oct 2014 02:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=FLfIDWUQ/4BVFL/XUqnmzzyjMVO3OzctH89VK+W4EtQ=; b=Lh/8l7/SvjykQFrayovEDnsfREkBja2veZQf+t4+uvYOaP4fa3sTUu0UozkrXvuKWy q4B6b0h958Yx1LI4pC0MEDR9mkHmAW9fRMqq6Wzh1QTYMYjv7G2X6HedEnb1cb9cPn61 Ah3np1YnQK4sO4t8OUfQt4nymv0Yrufpyr5i3rwuw0Tr4iDsu8Fgkvpnt2yk5eZzUfa0 bPZTn/zDw1eMXRKlLLLQIKvDd/oKtyGzIhOWjK5g6Sx9KATzuAyQlxy922OlMRhP22C2 i6zyOFwFsxMx9uR7QnjMI4yAZw5K1hkRQbQqlQWOQUowZk0+KXkvKg+NBDerUzIonWyY nd4w== MIME-Version: 1.0 X-Received: by 10.180.90.237 with SMTP id bz13mr27088026wib.50.1414488621357; Tue, 28 Oct 2014 02:30:21 -0700 (PDT) Received: by 10.217.152.70 with HTTP; Tue, 28 Oct 2014 02:30:21 -0700 (PDT) Date: Tue, 28 Oct 2014 10:30:21 +0100 Message-ID: Subject: Bug# 18828: set severity to "normal" From: Dani Moncayo To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) severity 18828 normal (I don't know why its current severity is "wishlist". I did't specify a severity when I submitted it, and I don't see a change in the severity either...) -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 14 02:54:48 2015 Received: (at 18828) by debbugs.gnu.org; 14 Mar 2015 06:54:48 +0000 Received: from localhost ([127.0.0.1]:45636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YWfyB-0004tq-13 for submit@debbugs.gnu.org; Sat, 14 Mar 2015 02:54:47 -0400 Received: from mail-we0-f182.google.com ([74.125.82.182]:33764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YWdUk-0000tR-IS for 18828@debbugs.gnu.org; Sat, 14 Mar 2015 00:16:15 -0400 Received: by wejb47 with SMTP id b47so4497173wej.0 for <18828@debbugs.gnu.org>; Fri, 13 Mar 2015 21:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=4nqzT28ajqNYg8bi0FwLcXGOjmwPgZrHZK13X74yd6w=; b=0+0QNosNvg3bLybuGAXsoVL5ioQV8FjXgVBAIkf7XPlmuc0RoaZoTExhWStz4hRQD7 lAMAuRBfgXE1xyDw9B3J5lEcnEk6s/e9K5AuuDewe9YsxMPSYGhox1g4nneGI9git0Y0 JvpvEnHZJl4LFKKZyX8LO3fBhkhO/WlOL2V+RCU4m7ep0YYQ4HNeHsSZKQnoAVbUI9C0 K5M7goao766+qd03Hk3elN/2jh8kM7Sx2MwF5NxsHWKQtJsEcOIyuOrhcXRVAFGKEfX9 DdTBEKaEsrr8gkttVtx58WhNCxniWYIyg0N/TxCQ9sR2iHO85nm2iLyPpF7BNjZJoZnJ YYFw== X-Received: by 10.180.104.66 with SMTP id gc2mr145260075wib.34.1426306573900; Fri, 13 Mar 2015 21:16:13 -0700 (PDT) Received: from [192.168.2.2] (w-79.cust-5765.ip.static.uno.uk.net. [95.172.231.79]) by mx.google.com with ESMTPSA id ew5sm5354063wic.14.2015.03.13.21.16.12 for <18828@debbugs.gnu.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2015 21:16:13 -0700 (PDT) Message-ID: <5503B51D.3080100@gmail.com> Date: Sat, 14 Mar 2015 04:12:13 +0000 From: Daniel Lopez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: 18828@debbugs.gnu.org Subject: 24.4; Early collision warning when 'create-lockfiles' is set to nil Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 18828 X-Mailman-Approved-At: Sat, 14 Mar 2015 02:54:45 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) I've noticed this too. (setq create-lockfiles nil) seems to turn off both the creation of lockfiles (which are used to alert you if you start to modify a file which another Emacs session concurrently has open in a modified, unsaved state); and the feature of prompting you if you start to modify a file which has changed on disk from what is visible in the buffer since you opened or last reverted it. I find myself wanting the latter feature but not the former. In particular, the latter feature will detect if the file contents have been changed by another application, whereas the lockfiles feature will only detect if the file is currently being edited by another instance of Emacs. So the 'create-lockfiles' variable should be limited to only control the former feature, and maybe there should be another setting for turning the latter feature on and off, though I wouldn't want to turn if off myself. Daniel From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 05:59:36 2015 Received: (at 18828) by debbugs.gnu.org; 29 Apr 2015 09:59:36 +0000 Received: from localhost ([127.0.0.1]:55602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnOmG-0006Wt-3f for submit@debbugs.gnu.org; Wed, 29 Apr 2015 05:59:36 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38612) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnOmE-0006Wg-8l for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 05:59:34 -0400 Received: by wiun10 with SMTP id n10so59485591wiu.1 for <18828@debbugs.gnu.org>; Wed, 29 Apr 2015 02:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=TyyJXwSP9LQvyfOfq8/WNJzO6WbR9zeHT6qOlL26O+w=; b=iknO8oMOmwPwDqotTdKoBgR+RYWlqEndJvixrtglQDSqrLTOcZccl5+oODTnDtxF4i 4g7jmNpgG2V84Q5UGQdEeEEQSefCxrsvRBpofbg7h/QL8zLMQ4szHY/4QspDKphH7bUj xjDC7Dwyq9Y5Z6DRkml1D9+MUUcpF4XOJYRfFUko2DabB7PN2uxuulk5Z6wS8B8NB3zp Lr2EPPqU6oPGHVh6QrEVVtdf/bYX0bc2samoyPZuhYop/+jasJPZMxcXl6VP01Qc8wEe 51aaotVKdqGL6IFiYLcUDar5xHeb0IOHJPkbcCIkc1uuH5i+m6N7IweyGe0MK15dlfne Qqbw== MIME-Version: 1.0 X-Received: by 10.180.83.193 with SMTP id s1mr4185973wiy.22.1430301568428; Wed, 29 Apr 2015 02:59:28 -0700 (PDT) Received: by 10.28.0.6 with HTTP; Wed, 29 Apr 2015 02:59:28 -0700 (PDT) In-Reply-To: <5503B51D.3080100@gmail.com> References: <5503B51D.3080100@gmail.com> Date: Wed, 29 Apr 2015 11:59:28 +0200 Message-ID: Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil From: Dani Moncayo To: 18828@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18828 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ping? -- Dani Moncayo "looking forward to the fix for this bug" From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 11:44:25 2015 Received: (at 18828) by debbugs.gnu.org; 29 Apr 2015 15:44:26 +0000 Received: from localhost ([127.0.0.1]:56518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnU9x-0008Aq-Ga for submit@debbugs.gnu.org; Wed, 29 Apr 2015 11:44:25 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50362 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnU9v-0008Ah-AF for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 11:44:23 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YnU9t-0004LX-S8; Wed, 29 Apr 2015 11:44:21 -0400 From: Glenn Morris To: Dani Moncayo Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil References: <5503B51D.3080100@gmail.com> X-Spook: mindwar Verisign EuroFed counter terrorism CID BLU-97 A/B X-Ran: &+mhcX"?/wR3%Vi;b@gi7]%$1]%@) (Dani Moncayo's message of "Wed, 29 Apr 2015 11:59:28 +0200") Message-ID: <6ea8xrey7e.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 18828 Cc: 18828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Dani Moncayo wrote: > Ping? Don't set create-lockfiles to nil? That's the traditional mechanism by which Emacs manages this stuff. Making it work with that feature disabled is not a high priority. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 11:53:52 2015 Received: (at 18828) by debbugs.gnu.org; 29 Apr 2015 15:53:52 +0000 Received: from localhost ([127.0.0.1]:56562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUJ5-0008Rj-HR for submit@debbugs.gnu.org; Wed, 29 Apr 2015 11:53:51 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35602) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUJ3-0008RV-UM for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 11:53:50 -0400 Received: by wgyo15 with SMTP id o15so33245015wgy.2 for <18828@debbugs.gnu.org>; Wed, 29 Apr 2015 08:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9VIuS1XciHcoCzQR6Uj0Phrd9EbNot+dCGBpzihegbw=; b=XampgUXIPCqZD2YDYjkCirBhYgUguqyapo8q4ZlmOkTE/GEGrHloALAnfhvzlI4r9Y 7NGoSA5T0XSA9wtjO0oSNy2q9GTPDdaWj4buOhnyPY5sFIodinVGrRcfrn3oAadSW5Uj yqp9tVEMhE5MvC5ioBsHtW4BiadOjWkHg9gYUcYjh0DVoESI8UjFh6RHYoKtjoTUgF+6 m/Lk/RB1SuQlD44sEBNonu65rIf8tGr6TmXP3vYKcbTgvQlJkhbJPbTH3fqf6+F4tnY5 awItlm8EAHbcqrMiNGubP6XzbDnHiZy1doXtvpGLH2rZmjONvW4cTv4IBCv4W34csBeJ AJCQ== MIME-Version: 1.0 X-Received: by 10.194.89.70 with SMTP id bm6mr41510027wjb.146.1430322824120; Wed, 29 Apr 2015 08:53:44 -0700 (PDT) Received: by 10.28.0.6 with HTTP; Wed, 29 Apr 2015 08:53:44 -0700 (PDT) In-Reply-To: <6ea8xrey7e.fsf@fencepost.gnu.org> References: <5503B51D.3080100@gmail.com> <6ea8xrey7e.fsf@fencepost.gnu.org> Date: Wed, 29 Apr 2015 17:53:44 +0200 Message-ID: Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil From: Dani Moncayo To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18828 Cc: 18828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> Ping? > > Don't set create-lockfiles to nil? > That's the traditional mechanism by which Emacs manages this stuff. Well, that's not what some users (like myself) may want. I don't like those temporary files, specially on auto-sync directories (e.g. dropbox, google drive, etc), for obvious reasons. > Making it work with that feature disabled is not a high priority. Ok. Thanks. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 11:57:32 2015 Received: (at 18828) by debbugs.gnu.org; 29 Apr 2015 15:57:32 +0000 Received: from localhost ([127.0.0.1]:56573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUMe-00006T-0Z for submit@debbugs.gnu.org; Wed, 29 Apr 2015 11:57:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50757 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUMd-00006M-4M for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 11:57:31 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YnUMc-0007kK-GB; Wed, 29 Apr 2015 11:57:30 -0400 From: Glenn Morris To: Dani Moncayo Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil References: <5503B51D.3080100@gmail.com> <6ea8xrey7e.fsf@fencepost.gnu.org> X-Spook: Fedayeen FTS2000 undercover IDEA AUTODIN Exon Shell X-Ran: fV=A$\swMp7)KbQXf=[Hp/_xfq}5 (Dani Moncayo's message of "Wed, 29 Apr 2015 17:53:44 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 18828 Cc: 18828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Dani Moncayo wrote: >> Don't set create-lockfiles to nil? >> That's the traditional mechanism by which Emacs manages this stuff. > > Well, that's not what some users (like myself) may want. Can only fall back to "patches welcome" then. :( Though sadly we cannot promise to apply patches in a timely fashion. :( From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 29 12:16:48 2015 Received: (at 18828) by debbugs.gnu.org; 29 Apr 2015 16:16:48 +0000 Received: from localhost ([127.0.0.1]:56616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUfI-0001Wc-38 for submit@debbugs.gnu.org; Wed, 29 Apr 2015 12:16:48 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:37541) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnUfE-0001Qe-QS for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 12:16:46 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NNK00H00SRO6R00@mtaout28.012.net.il> for 18828@debbugs.gnu.org; Wed, 29 Apr 2015 19:15:12 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNK00H0OT5CWM10@mtaout28.012.net.il>; Wed, 29 Apr 2015 19:15:12 +0300 (IDT) Date: Wed, 29 Apr 2015 19:16:19 +0300 From: Eli Zaretskii Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil In-reply-to: X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <83lhhaucz0.fsf@gnu.org> References: <5503B51D.3080100@gmail.com> <6ea8xrey7e.fsf@fencepost.gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18828 Cc: 18828@debbugs.gnu.org, dmoncayo@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Glenn Morris > Date: Wed, 29 Apr 2015 11:57:30 -0400 > Cc: 18828@debbugs.gnu.org > > Dani Moncayo wrote: > > >> Don't set create-lockfiles to nil? > >> That's the traditional mechanism by which Emacs manages this stuff. > > > > Well, that's not what some users (like myself) may want. > > Can only fall back to "patches welcome" then. :( Here you go (if no one objects, I will push this in a few days): --- src/filelock.c~0 2015-01-26 14:45:50 +0200 +++ src/filelock.c 2015-04-29 13:46:42 +0300 @@ -669,10 +669,6 @@ lock_file (Lisp_Object fn) struct gcpro gcpro1; USE_SAFE_ALLOCA; - /* Don't do locking if the user has opted out. */ - if (! create_lockfiles) - return; - /* Don't do locking while dumping Emacs. Uncompressing wtmp files uses call-process, which does not work in an uninitialized Emacs. */ @@ -690,9 +686,6 @@ lock_file (Lisp_Object fn) #endif encoded_fn = ENCODE_FILE (fn); - /* Create the name of the lock-file for file fn */ - MAKE_LOCK_NAME (lfname, encoded_fn); - /* See if this file is visited and has changed on disk since it was visited. */ { @@ -707,27 +700,35 @@ lock_file (Lisp_Object fn) } - /* Try to lock the lock. */ - if (0 < lock_if_free (&lock_info, lfname)) + /* Don't do locking if the user has opted out. */ + if (create_lockfiles) { - /* Someone else has the lock. Consider breaking it. */ - Lisp_Object attack; - char *dot = lock_info.dot; - ptrdiff_t pidlen = lock_info.colon - (dot + 1); - static char const replacement[] = " (pid "; - int replacementlen = sizeof replacement - 1; - memmove (dot + replacementlen, dot + 1, pidlen); - strcpy (dot + replacementlen + pidlen, ")"); - memcpy (dot, replacement, replacementlen); - attack = call2 (intern ("ask-user-about-lock"), fn, - build_string (lock_info.user)); - /* Take the lock if the user said so. */ - if (!NILP (attack)) - lock_file_1 (lfname, 1); + + /* Create the name of the lock-file for file fn */ + MAKE_LOCK_NAME (lfname, encoded_fn); + + /* Try to lock the lock. */ + if (0 < lock_if_free (&lock_info, lfname)) + { + /* Someone else has the lock. Consider breaking it. */ + Lisp_Object attack; + char *dot = lock_info.dot; + ptrdiff_t pidlen = lock_info.colon - (dot + 1); + static char const replacement[] = " (pid "; + int replacementlen = sizeof replacement - 1; + memmove (dot + replacementlen, dot + 1, pidlen); + strcpy (dot + replacementlen + pidlen, ")"); + memcpy (dot, replacement, replacementlen); + attack = call2 (intern ("ask-user-about-lock"), fn, + build_string (lock_info.user)); + /* Take the lock if the user said so. */ + if (!NILP (attack)) + lock_file_1 (lfname, 1); + } + SAFE_FREE (); } UNGCPRO; - SAFE_FREE (); } void From debbugs-submit-bounces@debbugs.gnu.org Mon May 04 17:13:03 2015 Received: (at 18828) by debbugs.gnu.org; 4 May 2015 21:13:03 +0000 Received: from localhost ([127.0.0.1]:34053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpNfi-0006eQ-JY for submit@debbugs.gnu.org; Mon, 04 May 2015 17:13:02 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpNfg-0006dz-88 for 18828@debbugs.gnu.org; Mon, 04 May 2015 17:13:00 -0400 Received: by wizk4 with SMTP id k4so136496855wiz.1 for <18828@debbugs.gnu.org>; Mon, 04 May 2015 14:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XofN95xvQL54oBpjY5EW7xnMQGYHyWL7drtYuNJzQsM=; b=IpnFoyiyKFQVUsa+Yld4WwG/DmOyWqV7xHrm1PSxZJu5m8juu2rQIrBUeAriT01ck0 eSrFfdPrdnuUnqnHKALB8NdQXI2XI5NPWESuJQrl/+Y4uWafZy1ttzVL2mlh3E3htlup kz3GjbLKeWP30xOC6/Jf08cSPt7Usl6hl6AKo2LhVpWHM7ZgFSLvo94pOMtTJWqX2tXF fjuRaOjdoRQXjUXBsaYfM5jbT50uVrRWWihSWQ4/BBD+eSLJrizAdd1+03UF0hZVvfL/ c97xMp9Abk5lJt33zR5e+2GsKs/xasSHblRfF8/2fL1vj2h4hWfpVwFCGGrtcY7hEWaz UAzA== MIME-Version: 1.0 X-Received: by 10.180.83.193 with SMTP id s1mr850232wiy.22.1430773974776; Mon, 04 May 2015 14:12:54 -0700 (PDT) Received: by 10.28.0.6 with HTTP; Mon, 4 May 2015 14:12:54 -0700 (PDT) In-Reply-To: <83lhhaucz0.fsf@gnu.org> References: <5503B51D.3080100@gmail.com> <6ea8xrey7e.fsf@fencepost.gnu.org> <83lhhaucz0.fsf@gnu.org> Date: Mon, 4 May 2015 23:12:54 +0200 Message-ID: Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18828 Cc: 18828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Here you go (if no one objects, I will push this in a few days): Hi Eli, I've tested your patch and seems to fix the problem. Thank you so much. -- Dani Moncayo "looking forward to this commit" From debbugs-submit-bounces@debbugs.gnu.org Fri May 08 05:22:16 2015 Received: (at 18828-done) by debbugs.gnu.org; 8 May 2015 09:22:16 +0000 Received: from localhost ([127.0.0.1]:38253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqeU3-0005dF-Ur for submit@debbugs.gnu.org; Fri, 08 May 2015 05:22:16 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:57674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqeU1-0005d1-Ti for 18828-done@debbugs.gnu.org; Fri, 08 May 2015 05:22:14 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NO000J00XU0OG00@a-mtaout20.012.net.il> for 18828-done@debbugs.gnu.org; Fri, 08 May 2015 12:21:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NO000J47Y0FL830@a-mtaout20.012.net.il>; Fri, 08 May 2015 12:21:51 +0300 (IDT) Date: Fri, 08 May 2015 12:22:04 +0300 From: Eli Zaretskii Subject: Re: bug#18828: 24.4; Early collision warning when 'create-lockfiles' is set to nil In-reply-to: X-012-Sender: halo1@inter.net.il To: Dani Moncayo Message-id: <83pp6bpgoz.fsf@gnu.org> References: <5503B51D.3080100@gmail.com> <6ea8xrey7e.fsf@fencepost.gnu.org> <83lhhaucz0.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 18828-done Cc: 18828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 4 May 2015 23:12:54 +0200 > From: Dani Moncayo > Cc: 18828@debbugs.gnu.org > > > Here you go (if no one objects, I will push this in a few days): > > Hi Eli, > > I've tested your patch and seems to fix the problem. > > Thank you so much. Thanks, I pushed it. From unknown Fri Sep 05 18:57:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Jun 2015 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator