GNU bug report logs - #18825
eww does not handle file:/file/name properly

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18825: closed (eww does not handle file:/file/name properly )
Date: Sun, 02 Nov 2014 21:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 02 Nov 2014 16:08:24 -0500
with message-id <87mw89cnuf.fsf <at> lifelogs.com>
and subject line Re: bug#18825: eww does not handle file:/file/name properly
has caused the debbugs.gnu.org bug report #18825,
regarding eww does not handle file:/file/name properly 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18825: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18825
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: eww does not handle file:/file/name properly 
Date: Sat, 25 Oct 2014 12:17:50 +0000

[Message part 3 (text/plain, inline)]

Package:  emacs
Severity: minor
Tags:     patch

	The condition currently employed in ‘eww’ for file: scheme URIs
	is a bit more restrictive than necessary:

   156	;;;###autoload
   157	(defun eww (url)
   158	  "Fetch URL and render the page.
   159	If the input doesn't look like an URL or a domain name, the
   160	word(s) will be searched for via `eww-search-prefix'."
   161	  (interactive "sEnter URL or keywords: ")
   162	  (cond ((string-match-p "\\`file://" url))
   163	        ((string-match-p "\\`ftp://" url)
   164	         (user-error "FTP is not supported."))

	While RFC 1738 does not allow for no-authority file: URIs,
	RFC 3986 makes the authority part optional /in general,/ and
	recognizing file:/name as synonymous to file:///name looks like
	a common extension over the RFC 1738 syntax.

	I thus suggest the condition to be relaxed to only include a
	single slash after ‘file:’.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 4 (text/diff, inline)]

--- eww.el
+++ eww.el
@@ -159,7 +159,7 @@ eww (url)
 If the input doesn't look like an URL or a domain name, the
 word(s) will be searched for via `eww-search-prefix'."
   (interactive "sEnter URL or keywords: ")
-  (cond ((string-match-p "\\`file://" url))
+  (cond ((string-match-p "\\`file:/" url))
         ((string-match-p "\\`ftp://" url)
          (user-error "FTP is not supported."))
         (t

[Message part 5 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18825-done <at> debbugs.gnu.org
Subject: Re: bug#18825: eww does not handle file:/file/name properly
Date: Sun, 02 Nov 2014 16:08:24 -0500

On Sat, 25 Oct 2014 12:17:50 +0000 Ivan Shmakov <ivan <at> siamics.net> wrote: 

IS> -  (cond ((string-match-p "\\`file://" url))
IS> +  (cond ((string-match-p "\\`file:/" url))

Thanks for the patch; applied in your name.  Closing.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.