From unknown Wed Jun 18 23:12:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18806 <18806@debbugs.gnu.org> To: bug#18806 <18806@debbugs.gnu.org> Subject: Status: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 Reply-To: bug#18806 <18806@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:12:00 +0000 retitle 18806 grep -rP getline crashes prematurely (without displaying all = results) on invalid UTF-8 input with LC_ALL=3Den_US.UTF-8 reassign 18806 grep submitter 18806 Shlomi Fish severity 18806 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 23 07:15:51 2014 Received: (at submit) by debbugs.gnu.org; 23 Oct 2014 11:15:51 +0000 Received: from localhost ([127.0.0.1]:60624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhGMx-0008IQ-0c for submit@debbugs.gnu.org; Thu, 23 Oct 2014 07:15:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43932) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhGMt-0008IB-9n for submit@debbugs.gnu.org; Thu, 23 Oct 2014 07:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhGMh-0002a0-HK for submit@debbugs.gnu.org; Thu, 23 Oct 2014 07:15:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhGMh-0002Zu-3j for submit@debbugs.gnu.org; Thu, 23 Oct 2014 07:15:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhGMb-0000JF-1H for bug-grep@gnu.org; Thu, 23 Oct 2014 07:15:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XhGMU-0002WM-RW for bug-grep@gnu.org; Thu, 23 Oct 2014 07:15:28 -0400 Received: from gateway02.websitewelcome.com ([69.41.242.20]:42841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XhGMU-0002Vh-Mb for bug-grep@gnu.org; Thu, 23 Oct 2014 07:15:22 -0400 Received: by gateway02.websitewelcome.com (Postfix, from userid 5007) id 666B5203E1375; Thu, 23 Oct 2014 06:15:18 -0500 (CDT) Received: from gator4065.hostgator.com (gator4065.hostgator.com [192.185.4.76]) by gateway02.websitewelcome.com (Postfix) with ESMTP id 601DD203E1323 for ; Thu, 23 Oct 2014 06:15:18 -0500 (CDT) Received: from [109.66.62.240] (port=47586 helo=telaviv1.shlomifish.org) by gator4065.hostgator.com with esmtpa (Exim 4.82) (envelope-from ) id 1XhGMP-0000be-WC for bug-grep@gnu.org; Thu, 23 Oct 2014 06:15:18 -0500 Received: from telaviv1.shlomifish.org (telaviv1.shlomifish.org [127.0.0.1]) by telaviv1.shlomifish.org (Postfix) with ESMTP id B8A0F26005F for ; Thu, 23 Oct 2014 14:15:16 +0300 (IDT) Date: Thu, 23 Oct 2014 14:15:16 +0300 From: Shlomi Fish To: bug-grep@gnu.org Subject: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 Message-ID: <20141023141516.200e4093@telaviv1.shlomifish.org> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.25; x86_64-mageia-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4065.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - shlomifish.org X-BWhitelist: no X-Source-IP: 109.66.62.240 X-Exim-ID: 1XhGMP-0000be-WC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (telaviv1.shlomifish.org) [109.66.62.240]:47586 X-Source-Auth: shlomif@shlomifish.org X-Email-Count: 1 X-Source-Cap: c2hsb21pZjtzaGxvbWlmO2dhdG9yNDA2NS5ob3N0Z2F0b3IuY29t X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hi all, see: https://github.com/shlomif/grep-bug-big5-utf8-from-IO-All You can cd to the directory and run "bash -x REPRODUCE.bash" (After seeing that it does not do anything harmful). I am getting: shlomif@telaviv1:~/GREP-test$ LC_ALL=en_US.UTF-8 grep -rP getline grep-test/ grep-test/round_robin.t:while (my $line = $io->getline || $io->getlinegrep: internal PCRE error: -32 with the latest git grep. Regards, Shlomi Fish -- ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ UNIX Fortune Cookies - http://www.shlomifish.org/humour/fortunes/ Xena the warrior princess can meet King David for breakfast and Julius Caesar for lunch. Without time travel. Please reply to list if it's a mailing list post - http://shlom.in/reply . From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 23 17:06:51 2014 Received: (at 18806) by debbugs.gnu.org; 23 Oct 2014 21:06:52 +0000 Received: from localhost ([127.0.0.1]:33320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhPat-0001Cp-7V for submit@debbugs.gnu.org; Thu, 23 Oct 2014 17:06:51 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:48309) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhPap-0001CX-Vx for 18806@debbugs.gnu.org; Thu, 23 Oct 2014 17:06:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id EA1F5A600CE; Thu, 23 Oct 2014 14:06:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uCw2Rc5X3OdD; Thu, 23 Oct 2014 14:06:33 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id F3D59A60097; Thu, 23 Oct 2014 14:06:32 -0700 (PDT) Message-ID: <54496DD8.1060203@cs.ucla.edu> Date: Thu, 23 Oct 2014 14:06:32 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Shlomi Fish , 18806@debbugs.gnu.org Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 References: <20141023141516.200e4093@telaviv1.shlomifish.org> In-Reply-To: <20141023141516.200e4093@telaviv1.shlomifish.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 18806 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 10/23/2014 04:15 AM, Shlomi Fish wrote: > internal PCRE error: -32 > > with the latest git grep. I am not seeing a problem with that test case on my platform. I am running Fedora 20 x86-64, and compiled grep with GCC 4.9.1 (which I built myself) and linked with the standard Fedora package pcre-8.33-6.fc20.x86_64. I also tried building with the Fedora GCC in 32-bit mode, and couldn't reproduce the bug there either. Possibly it's a libpcre problem? I tested with grep commit b2490802defe3c3bf7ef0036a4515d006a08a769 and grep-bug-big5-utf8-from-IO-All commit 9469e6e5be97d631c02bcfdbe814f43d1bb2df56. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 05:26:39 2014 Received: (at 18806) by debbugs.gnu.org; 24 Oct 2014 09:26:39 +0000 Received: from localhost ([127.0.0.1]:33503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhb8o-0004L4-Ja for submit@debbugs.gnu.org; Fri, 24 Oct 2014 05:26:38 -0400 Received: from gateway02.websitewelcome.com ([69.93.115.20]:55696) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhb8m-0004Ku-3q for 18806@debbugs.gnu.org; Fri, 24 Oct 2014 05:26:37 -0400 Received: by gateway02.websitewelcome.com (Postfix, from userid 5007) id 3D43B23910206; Fri, 24 Oct 2014 04:26:35 -0500 (CDT) Received: from gator4065.hostgator.com (gator4065.hostgator.com [192.185.4.76]) by gateway02.websitewelcome.com (Postfix) with ESMTP id 38B2E239101D3 for <18806@debbugs.gnu.org>; Fri, 24 Oct 2014 04:26:35 -0500 (CDT) Received: from [109.66.62.240] (port=54097 helo=telaviv1.shlomifish.org) by gator4065.hostgator.com with esmtpa (Exim 4.82) (envelope-from ) id 1Xhb8k-0003IL-Mw; Fri, 24 Oct 2014 04:26:34 -0500 Received: from telaviv1.shlomifish.org (telaviv1.shlomifish.org [127.0.0.1]) by telaviv1.shlomifish.org (Postfix) with ESMTP id DE5A726005F; Fri, 24 Oct 2014 12:26:32 +0300 (IDT) Date: Fri, 24 Oct 2014 12:26:32 +0300 From: Shlomi Fish To: Paul Eggert Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 Message-ID: <20141024122632.4e1875cd@telaviv1.shlomifish.org> In-Reply-To: <54496DD8.1060203@cs.ucla.edu> References: <20141023141516.200e4093@telaviv1.shlomifish.org> <54496DD8.1060203@cs.ucla.edu> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-mageia-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4065.hostgator.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - shlomifish.org X-BWhitelist: no X-Source-IP: 109.66.62.240 X-Exim-ID: 1Xhb8k-0003IL-Mw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (telaviv1.shlomifish.org) [109.66.62.240]:54097 X-Source-Auth: shlomif@shlomifish.org X-Email-Count: 1 X-Source-Cap: c2hsb21pZjtzaGxvbWlmO2dhdG9yNDA2NS5ob3N0Z2F0b3IuY29t X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Mr. Eggert, On Thu, 23 Oct 2014 14:06:32 -0700 Paul Eggert wrote: > On 10/23/2014 04:15 AM, Shlomi Fish wrote: > > internal PCRE error: -32 > > > > with the latest git grep. > > I am not seeing a problem with that test case on my platform. I am > running Fedora 20 x86-64, and compiled grep with GCC 4.9.1 (which I > built myself) and linked with the standard Fedora package > pcre-8.33-6.fc20.x86_64. I also tried building with the Fedora GCC in > 32-bit mode, and couldn't reproduce the bug there either. > > Possibly it's a libpcre problem? [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.93.115.20 listed in list.dnswl.org] 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-Debbugs-Envelope-To: 18806 Cc: 18806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Mr. Eggert, On Thu, 23 Oct 2014 14:06:32 -0700 Paul Eggert wrote: > On 10/23/2014 04:15 AM, Shlomi Fish wrote: > > internal PCRE error: -32 > > > > with the latest git grep. > > I am not seeing a problem with that test case on my platform. I am > running Fedora 20 x86-64, and compiled grep with GCC 4.9.1 (which I > built myself) and linked with the standard Fedora package > pcre-8.33-6.fc20.x86_64. I also tried building with the Fedora GCC in > 32-bit mode, and couldn't reproduce the bug there either. > > Possibly it's a libpcre problem? [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.93.115.20 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) Hi Mr. Eggert, On Thu, 23 Oct 2014 14:06:32 -0700 Paul Eggert wrote: > On 10/23/2014 04:15 AM, Shlomi Fish wrote: > > internal PCRE error: -32 > > > > with the latest git grep. >=20 > I am not seeing a problem with that test case on my platform. I am=20 > running Fedora 20 x86-64, and compiled grep with GCC 4.9.1 (which I=20 > built myself) and linked with the standard Fedora package=20 > pcre-8.33-6.fc20.x86_64. I also tried building with the Fedora GCC in=20 > 32-bit mode, and couldn't reproduce the bug there either. >=20 > Possibly it's a libpcre problem? I discovered a slightly different test case for it. Try running: =C2=AB `which grep` --color -rP getline grep-test =C2=BB =46rom the command line. See this for a screenshot on Fedora: * http://www.shlomifish.org/Files/files/images/gnu-grep-on-fedora.png >=20 > I tested with grep commit b2490802defe3c3bf7ef0036a4515d006a08a769 and=20 > grep-bug-big5-utf8-from-IO-All commit=20 > 9469e6e5be97d631c02bcfdbe814f43d1bb2df56. I tested with grep commit b2490802defe3c3bf7ef0036a4515d006a08a769 . Regards, Shlomi Fish --=20 ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ http://www.shlomifish.org/humour/bits/facts/Summer-Glau/ Tomorrow never dies, unless Chuck Norris volunteers to take it out of its misery. =E2=80=94 http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply . From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 12:45:58 2014 Received: (at 18806) by debbugs.gnu.org; 24 Oct 2014 16:45:58 +0000 Received: from localhost ([127.0.0.1]:34250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhhzx-0008DS-CL for submit@debbugs.gnu.org; Fri, 24 Oct 2014 12:45:58 -0400 Received: from mailgw01.kcn.ne.jp ([61.86.7.208]:45306) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhhzs-0008D3-81 for 18806@debbugs.gnu.org; Fri, 24 Oct 2014 12:45:54 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw01.kcn.ne.jp (Postfix) with ESMTP id F1DE980309 for <18806@debbugs.gnu.org>; Sat, 25 Oct 2014 01:45:43 +0900 (JST) Received: from mail01.kcn.ne.jp ([61.86.6.180]) by imp01 with bizsmtp id 74lj1p0073t2w9Z014lj4S; Sat, 25 Oct 2014 01:45:43 +0900 X-OrgRCPT: 18806@debbugs.gnu.org Received: from [10.120.1.49] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail01.kcn.ne.jp (Postfix) with ESMTPA id 8BC575A8259; Sat, 25 Oct 2014 01:45:43 +0900 (JST) Date: Sat, 25 Oct 2014 01:45:42 +0900 From: Norihiro Tanaka To: Shlomi Fish Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 In-Reply-To: <20141024122632.4e1875cd@telaviv1.shlomifish.org> References: <54496DD8.1060203@cs.ucla.edu> <20141024122632.4e1875cd@telaviv1.shlomifish.org> Message-Id: <20141025014542.6143.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_544A7F58000000006133_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 18806 Cc: 18806@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --------_544A7F58000000006133_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Shlomi Fish write: > `which grep` --color -rP getline grep-test If -o or --color option is specified, may be line_end < validated in longest exact match. As a result, a negative value is set to `search_bytes'. I improved validation for input buffer in order to fix the bug. However, possibly it may cause slowdown. --------_544A7F58000000006133_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-improvement-of-validation-for-input-buffer-in-g.patch" Content-Disposition: attachment; filename="0001-grep-improvement-of-validation-for-input-buffer-in-g.patch" Content-Transfer-Encoding: base64 RnJvbSAwNjQzZjVjNjg3N2E0ZmE3YTBhYTFkMTA2NzA1NThjNWUwODllMWYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDI1IE9jdCAyMDE0IDAxOjA1OjU3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogaW1wcm92ZW1lbnQgb2YgdmFsaWRhdGlvbiBmb3IgaW5wdXQgYnVmZmVyIGluIGdyZXAgLVAK Ciogc3JjL2dyZXAuYyBzcmMvZ3JlcC5oIHNyYy9wY3Jlc2VhcmNoLmMgKHZhbGlkYXRlZF9ib3Vu ZGFyeSk6IFJlbW92ZSB2YXIuCiogc3JjL3BjcmVzZWFyY2guYyAocHJldl92YWxpZCk6IE5ldyB2 YXIuCihQZXhlY3V0ZSk6IGltcHJvdmVtZW50IG9mIHZhbGlkYXRpb24gZm9yIGlucHV0IGJ1ZmZl ci4KLS0tCiBzcmMvZ3JlcC5jICAgICAgIHwgICAzIC0tCiBzcmMvZ3JlcC5oICAgICAgIHwgICA0 IC0tLQogc3JjL3BjcmVzZWFyY2guYyB8IDEwMyArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiB0ZXN0cy9wY3JlLW8gICAgIHwgIDE3ICsrKysr KysrKwogNCBmaWxlcyBjaGFuZ2VkLCA3NSBpbnNlcnRpb25zKCspLCA1MiBkZWxldGlvbnMoLSkK IGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0cy9wY3JlLW8KCmRpZmYgLS1naXQgYS9zcmMvZ3JlcC5j IGIvc3JjL2dyZXAuYwppbmRleCBhMGYyNjIwLi4wYTRhYzI3IDEwMDY0NAotLS0gYS9zcmMvZ3Jl cC5jCisrKyBiL3NyYy9ncmVwLmMKQEAgLTM1Miw3ICszNTIsNiBAQCBib29sIG1hdGNoX3dvcmRz OwogYm9vbCBtYXRjaF9saW5lczsKIGNoYXIgZW9sYnl0ZTsKIGVudW0gdGV4dGJpbiBpbnB1dF90 ZXh0YmluOwotY2hhciBjb25zdCAqdmFsaWRhdGVkX2JvdW5kYXJ5OwogCiBzdGF0aWMgY2hhciBj b25zdCAqbWF0Y2hlcjsKIApAQCAtMTIyNiw3ICsxMjI1LDYgQEAgZ3JlcGJ1ZiAoY2hhciBjb25z dCAqYmVnLCBjaGFyIGNvbnN0ICpsaW0pCiAgIGludG1heF90IG91dGxlZnQwID0gb3V0bGVmdDsK ICAgY2hhciBjb25zdCAqcDsKICAgY2hhciBjb25zdCAqZW5kcDsKLSAgdmFsaWRhdGVkX2JvdW5k YXJ5ID0gYmVnOwogCiAgIGZvciAocCA9IGJlZzsgcCA8IGxpbTsgcCA9IGVuZHApCiAgICAgewpA QCAtMjUxNiw3ICsyNTE0LDYgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAvKiBX ZSBuZWVkIG9uZSBieXRlIHByaW9yIGFuZCBvbmUgYWZ0ZXIuICAqLwogICBjaGFyIGVvbGJ5dGVz WzNdID0geyAwLCBlb2xieXRlLCAwIH07CiAgIHNpemVfdCBtYXRjaF9zaXplOwotICB2YWxpZGF0 ZWRfYm91bmRhcnkgPSBlb2xieXRlcyArIDE7CiAgIHNraXBfZW1wdHlfbGluZXMgPSAoKGV4ZWN1 dGUgKGVvbGJ5dGVzICsgMSwgMSwgJm1hdGNoX3NpemUsIE5VTEwpID09IDApCiAgICAgICAgICAg ICAgICAgICAgICAgPT0gb3V0X2ludmVydCk7CiAKZGlmZiAtLWdpdCBhL3NyYy9ncmVwLmggYi9z cmMvZ3JlcC5oCmluZGV4IDg2MjU5ZmIuLjAyMDUyYjQgMTAwNjQ0Ci0tLSBhL3NyYy9ncmVwLmgK KysrIGIvc3JjL2dyZXAuaApAQCAtNDcsOCArNDcsNCBAQCBlbnVtIHRleHRiaW4KIC8qIElucHV0 IGZpbGUgdHlwZS4gICovCiBleHRlcm4gZW51bSB0ZXh0YmluIGlucHV0X3RleHRiaW47CiAKLS8q IFZhbGlkYXRpb24gYm91bmRhcnkuICBFYXJsaWVyIGJ5dGVzIGhhdmUgYWxyZWFkeSBiZWVuIHZh bGlkYXRlZCBieQotICAgdGhlIFBDUkUgbWF0Y2hlciwgd2hpY2ggY2FyZXMgYWJvdXQgdGhpcyBz b3J0IG9mIHRoaW5nLiAgKi8KLWV4dGVybiBjaGFyIGNvbnN0ICp2YWxpZGF0ZWRfYm91bmRhcnk7 Ci0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvc3JjL3BjcmVzZWFyY2guYyBiL3NyYy9wY3Jlc2VhcmNo LmMKaW5kZXggMWZkNWJkZS4uODVjMWFjZCAxMDA2NDQKLS0tIGEvc3JjL3BjcmVzZWFyY2guYwor KysgYi9zcmMvcGNyZXNlYXJjaC5jCkBAIC00Miw2ICs0MiwxMCBAQCBzdGF0aWMgcGNyZV9leHRy YSAqZXh0cmE7CiAgICBzdHJpbmcgbWF0Y2hlcyB3aGVuIHRoYXQgZmxhZyBpcyB1c2VkLiAgKi8K IHN0YXRpYyBpbnQgZW1wdHlfbWF0Y2hbMl07CiAKKy8qIFByZXZpb3VzIHJlc3VsdCBvZiBhIHZh bGlkYXRpb24uICBJZiBpdCdzIHRydWUsIG9taXQgdGhlIHZhbGlkYXRpb24gaW4KKyAgIGxvbmdl c3QgZXhhY3QgbWF0Y2guICAqLworc3RhdGljIGJvb2wgcHJldl92YWxpZDsKKwogLyogVGhpcyBt dXN0IGJlIGF0IGxlYXN0IDI7IGV2ZXJ5dGhpbmcgYWZ0ZXIgdGhhdCBpcyBmb3IgcGVyZm9ybWFu Y2UKICAgIGluIHBjcmVfZXhlYy4gICovCiBlbnVtIHsgTlNVQiA9IDMwMCB9OwpAQCAtMTU2LDcg KzE2MCw3IEBAIFBleGVjdXRlIChjaGFyIGNvbnN0ICpidWYsIHNpemVfdCBzaXplLCBzaXplX3Qg Km1hdGNoX3NpemUsCiAgIGNoYXIgY29uc3QgKmxpbmVfc3RhcnQgPSBidWY7CiAgIGludCBlID0g UENSRV9FUlJPUl9OT01BVENIOwogICBjaGFyIGNvbnN0ICpsaW5lX2VuZDsKLSAgY2hhciBjb25z dCAqdmFsaWRhdGVkID0gdmFsaWRhdGVkX2JvdW5kYXJ5OworICBib29sIHZhbGlkID0gZmFsc2U7 CiAKICAgLyogSWYgdGhlIGlucHV0IHR5cGUgaXMgdW5rbm93biwgdGhlIGNhbGxlciBpcyBzdGls bCB0ZXN0aW5nIHRoZQogICAgICBpbnB1dCwgd2hpY2ggbWVhbnMgdGhlIGN1cnJlbnQgYnVmZmVy IGNhbm5vdCBjb250YWluIGVuY29kaW5nCkBAIC0xNzYsMTEgKzE4MCwxMyBAQCBQZXhlY3V0ZSAo Y2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAg ICAgIHNpemVfdCBzY2FuX3NpemUgPSBNSU4gKHBjcmVfc2l6ZV9tYXggKyAxLCBidWYgKyBzaXpl IC0gcCk7CiAgICAgICAgICAgbGluZV9lbmQgPSBtZW1yY2hyIChwLCBlb2xieXRlLCBzY2FuX3Np emUpOwogICAgICAgICAgIHRvb19iaWcgPSAhIGxpbmVfZW5kOworICAgICAgICAgIHZhbGlkID0g dHJ1ZTsKICAgICAgICAgfQogICAgICAgZWxzZQogICAgICAgICB7CiAgICAgICAgICAgbGluZV9l bmQgPSBtZW1jaHIgKHAsIGVvbGJ5dGUsIGJ1ZiArIHNpemUgLSBwKTsKICAgICAgICAgICB0b29f YmlnID0gSU5UX01BWCA8IGxpbmVfZW5kIC0gcDsKKyAgICAgICAgICB2YWxpZCA9IChwcmV2X3Zh bGlkICYmIHN0YXJ0X3B0ciAhPSBOVUxMKTsKICAgICAgICAgfQogCiAgICAgICBpZiAodG9vX2Jp ZykKQEAgLTE4OCw2OSArMTk0LDc2IEBAIFBleGVjdXRlIChjaGFyIGNvbnN0ICpidWYsIHNpemVf dCBzaXplLCBzaXplX3QgKm1hdGNoX3NpemUsCiAKICAgICAgIGZvciAoOzspCiAgICAgICAgIHsK LSAgICAgICAgICAvKiBTa2lwIHBhc3QgYnl0ZXMgdGhhdCBhcmUgZWFzaWx5IGRldGVybWluZWQg dG8gYmUgZW5jb2RpbmcKLSAgICAgICAgICAgICBlcnJvcnMsIHRyZWF0aW5nIHRoZW0gYXMgZGF0 YSB0aGF0IGNhbm5vdCBtYXRjaC4gIFRoaXMgaXMKLSAgICAgICAgICAgICBmYXN0ZXIgdGhhbiBo YXZpbmcgcGNyZV9leGVjIGNoZWNrIHRoZW0uICAqLwotICAgICAgICAgIHdoaWxlIChtYmNsZW5f Y2FjaGVbdG9fdWNoYXIgKCpwKV0gPT0gKHNpemVfdCkgLTEpCi0gICAgICAgICAgICB7Ci0gICAg ICAgICAgICAgIHArKzsKLSAgICAgICAgICAgICAgYm9sID0gZmFsc2U7Ci0gICAgICAgICAgICB9 CisgICAgICAgICAgaW50IHZhbGlkX2J5dGVzOworICAgICAgICAgIGludCBvcHRpb25zID0gMDsK IAotICAgICAgICAgIC8qIENoZWNrIGZvciBhbiBlbXB0eSBtYXRjaDsgdGhpcyBpcyBmYXN0ZXIg dGhhbiBsZXR0aW5nCi0gICAgICAgICAgICAgcGNyZV9leGVjIGRvIGl0LiAgKi8KLSAgICAgICAg ICBpbnQgc2VhcmNoX2J5dGVzID0gbGluZV9lbmQgLSBwOwotICAgICAgICAgIGlmIChzZWFyY2hf Ynl0ZXMgPT0gMCkKKyAgICAgICAgICBpZiAoIXZhbGlkKQogICAgICAgICAgICAgewotICAgICAg ICAgICAgICBzdWJbMF0gPSBzdWJbMV0gPSAwOwotICAgICAgICAgICAgICBlID0gZW1wdHlfbWF0 Y2hbYm9sXTsKLSAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICB9CisgICAgICAgICAg ICAgIC8qIFNraXAgcGFzdCBieXRlcyB0aGF0IGFyZSBlYXNpbHkgZGV0ZXJtaW5lZCB0byBiZSBl bmNvZGluZworICAgICAgICAgICAgICAgICBlcnJvcnMsIHRyZWF0aW5nIHRoZW0gYXMgZGF0YSB0 aGF0IGNhbm5vdCBtYXRjaC4gIFRoaXMgaXMKKyAgICAgICAgICAgICAgICAgZmFzdGVyIHRoYW4g aGF2aW5nIHBjcmVfZXhlYyBjaGVjayB0aGVtLiAgKi8KKyAgICAgICAgICAgICAgd2hpbGUgKG1i Y2xlbl9jYWNoZVt0b191Y2hhciAoKnApXSA9PSAoc2l6ZV90KSAtMSkKKyAgICAgICAgICAgICAg ICB7CisgICAgICAgICAgICAgICAgICBwKys7CisgICAgICAgICAgICAgICAgICBib2wgPSBmYWxz ZTsKKyAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICBpbnQgb3B0aW9ucyA9IDA7Ci0gICAg ICAgICAgaWYgKCFib2wpCi0gICAgICAgICAgICBvcHRpb25zIHw9IFBDUkVfTk9UQk9MOwotICAg ICAgICAgIGlmIChtdWx0aWxpbmUgfHwgcCArIHNlYXJjaF9ieXRlcyA8PSB2YWxpZGF0ZWQpCi0g ICAgICAgICAgICBvcHRpb25zIHw9IFBDUkVfTk9fVVRGOF9DSEVDSzsKKyAgICAgICAgICAgICAg LyogQ2hlY2sgZm9yIGFuIGVtcHR5IG1hdGNoOyB0aGlzIGlzIGZhc3RlciB0aGFuIGxldHRpbmcK KyAgICAgICAgICAgICAgICAgcGNyZV9leGVjIGRvIGl0LiAgKi8KKyAgICAgICAgICAgICAgaW50 IHNlYXJjaF9ieXRlcyA9IGxpbmVfZW5kIC0gcDsKKyAgICAgICAgICAgICAgaWYgKHNlYXJjaF9i eXRlcyA9PSAwKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAgIHN1YlswXSA9 IHN1YlsxXSA9IDA7CisgICAgICAgICAgICAgICAgICBlID0gZW1wdHlfbWF0Y2hbYm9sXTsKKyAg ICAgICAgICAgICAgICAgIGlmIChwID09IGxpbmVfc3RhcnQpCisgICAgICAgICAgICAgICAgICAg IHZhbGlkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAg IH0KKworICAgICAgICAgICAgICBpZiAoIWJvbCkKKyAgICAgICAgICAgICAgICBvcHRpb25zIHw9 IFBDUkVfTk9UQk9MOwogCi0gICAgICAgICAgaW50IHZhbGlkX2J5dGVzID0gdmFsaWRhdGVkIC0g cDsKLSAgICAgICAgICBpZiAodmFsaWRfYnl0ZXMgPD0gMCkKLSAgICAgICAgICAgIHsKICAgICAg ICAgICAgICAgZSA9IHBjcmVfZXhlYyAoY3JlLCBleHRyYSwgcCwgc2VhcmNoX2J5dGVzLCAwLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25zLCBzdWIsIE5TVUIpOwogICAgICAg ICAgICAgICBpZiAoZSAhPSBQQ1JFX0VSUk9SX0JBRFVURjgpCiAgICAgICAgICAgICAgICAgewot ICAgICAgICAgICAgICAgICAgdmFsaWRhdGVkID0gcCArIHNlYXJjaF9ieXRlczsKLSAgICAgICAg ICAgICAgICAgIGlmICgwIDwgZSAmJiBtdWx0aWxpbmUgJiYgc3ViWzFdIC0gc3ViWzBdICE9IDAp Ci0gICAgICAgICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICAgICAgICBjaGFyIGNvbnN0 ICpubCA9IG1lbWNociAocCArIHN1YlswXSwgZW9sYnl0ZSwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ViWzFdIC0gc3ViWzBdKTsKLSAgICAgICAgICAg ICAgICAgICAgICBpZiAobmwpCi0gICAgICAgICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgIC8qIFRoaXMgbWF0Y2ggY3Jvc3NlcyBhIGxpbmUgYm91bmRhcnk7IHJl amVjdCBpdC4gICovCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHAgKz0gc3ViWzBdOwotICAg ICAgICAgICAgICAgICAgICAgICAgICBsaW5lX2VuZCA9IG5sOwotICAgICAgICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAg ICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgaWYgKHAgPT0gbGluZV9zdGFydCkKKyAgICAg ICAgICAgICAgICAgICAgdmFsaWQgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICB2YWxpZF9ieXRlcyA9IHN1YlswXTsKLSAg ICAgICAgICAgICAgdmFsaWRhdGVkID0gcCArIHZhbGlkX2J5dGVzOwogICAgICAgICAgICAgfQor ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHZhbGlkX2J5dGVzID0gbGluZV9lbmQgLSBwOwog CiAgICAgICAgICAgLyogVHJ5IHRvIG1hdGNoIHRoZSBzdHJpbmcgYmVmb3JlIHRoZSBlbmNvZGlu ZyBlcnJvci4KICAgICAgICAgICAgICBBZ2FpbiwgaGFuZGxlIHRoZSBlbXB0eS1tYXRjaCBjYXNl IHNwZWNpYWxseSwgZm9yIHNwZWVkLiAgKi8KICAgICAgICAgICBpZiAodmFsaWRfYnl0ZXMgPT0g MCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgc3ViWzFdID0gMDsKKyAgICAgICAgICAg ICAgc3ViWzBdID0gc3ViWzFdID0gMDsKICAgICAgICAgICAgICAgZSA9IGVtcHR5X21hdGNoW2Jv bF07CiAgICAgICAgICAgICB9CiAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgZSA9IHBjcmVf ZXhlYyAoY3JlLCBleHRyYSwgcCwgdmFsaWRfYnl0ZXMsIDAsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICBvcHRpb25zIHwgUENSRV9OT19VVEY4X0NIRUNLIHwgUENSRV9OT1RFT0wsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICBzdWIsIE5TVUIpOwotICAgICAgICAgIGlmIChlICE9IFBD UkVfRVJST1JfTk9NQVRDSCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgb3B0aW9ucyB8 PSBQQ1JFX05PX1VURjhfQ0hFQ0s7CisgICAgICAgICAgICAgIGlmICh2YWxpZF9ieXRlcyA8IGxp bmVfZW5kIC0gcCkKKyAgICAgICAgICAgICAgICBvcHRpb25zIHw9IFBDUkVfTk9URU9MOworICAg ICAgICAgICAgICBlID0gcGNyZV9leGVjIChjcmUsIGV4dHJhLCBwLCB2YWxpZF9ieXRlcywgMCwg b3B0aW9ucywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ViLCBOU1VCKTsKKyAgICAg ICAgICAgICAgaWYgKDAgPCBlICYmIG11bHRpbGluZSAmJiBzdWJbMV0gLSBzdWJbMF0gIT0gMCkK KyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICBjaGFyIGNvbnN0ICpubCA9IG1l bWNociAocCArIHN1YlswXSwgZW9sYnl0ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdWJbMV0gLSBzdWJbMF0pOworICAgICAgICAgICAgICAgICAgaWYgKG5s KQorICAgICAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgICAgLyogVGhpcyBt YXRjaCBjcm9zc2VzIGEgbGluZSBib3VuZGFyeTsgcmVqZWN0IGl0LiAgKi8KKyAgICAgICAgICAg ICAgICAgICAgICBwICs9IHN1YlswXTsKKyAgICAgICAgICAgICAgICAgICAgICBsaW5lX2VuZCA9 IG5sOworICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgICAg ICB9CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICAgIGlmIChlICE9 IFBDUkVfRVJST1JfTk9NQVRDSCB8fCBwICsgdmFsaWRfYnl0ZXMgPj0gbGluZV9lbmQpCiAgICAg ICAgICAgICBicmVhazsKIAogICAgICAgICAgIC8qIFRyZWF0IHRoZSBlbmNvZGluZyBlcnJvciBh cyBkYXRhIHRoYXQgY2Fubm90IG1hdGNoLiAgKi8KQEAgLTI2Myw3ICsyNzYsNyBAQCBQZXhlY3V0 ZSAoY2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAg ICAgYm9sID0gdHJ1ZTsKICAgICB9CiAKLSAgdmFsaWRhdGVkX2JvdW5kYXJ5ID0gdmFsaWRhdGVk OworICBwcmV2X3ZhbGlkID0gdmFsaWQ7CiAKICAgaWYgKGUgPD0gMCkKICAgICB7CmRpZmYgLS1n aXQgYS90ZXN0cy9wY3JlLW8gYi90ZXN0cy9wY3JlLW8KbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5k ZXggMDAwMDAwMC4uNWY1ODkxZQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzL3BjcmUtbwpAQCAt MCwwICsxLDE3IEBACisjISAvYmluL3NoCisjIEVuc3VyZSB0aGF0LCBncmVwIC1vUCBkb2Vzbid0 IGNhdXNlIGludGVybmFsIGVycm9yIGF0IG1hdGNoLgorIworIyBDb3B5cmlnaHQgKEMpIDIwMTQg RnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjCisjIENvcHlpbmcgYW5kIGRpc3RyaWJ1 dGlvbiBvZiB0aGlzIGZpbGUsIHdpdGggb3Igd2l0aG91dCBtb2RpZmljYXRpb24sCisjIGFyZSBw ZXJtaXR0ZWQgaW4gYW55IG1lZGl1bSB3aXRob3V0IHJveWFsdHkgcHJvdmlkZWQgdGhlIGNvcHly aWdodAorIyBub3RpY2UgYW5kIHRoaXMgbm90aWNlIGFyZSBwcmVzZXJ2ZWQuCisKKy4gIiR7c3Jj ZGlyPS59L2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4uL3NyYworcmVxdWlyZV9wY3JlXworCitm YWlsPTAKKworZWNobyBhYiB8IGdyZXAgLW9QICdhJyB8fCBmYWlsPTEKKworRXhpdCAkZmFpbAot LSAKMi4xLjEKCg== --------_544A7F58000000006133_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 12:50:34 2014 Received: (at 18806) by debbugs.gnu.org; 24 Oct 2014 16:50:34 +0000 Received: from localhost ([127.0.0.1]:34254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhi4O-0008KV-L8 for submit@debbugs.gnu.org; Fri, 24 Oct 2014 12:50:33 -0400 Received: from gateway12.websitewelcome.com ([69.56.148.16]:58706) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhi4L-0008KJ-Ne for 18806@debbugs.gnu.org; Fri, 24 Oct 2014 12:50:30 -0400 Received: by gateway12.websitewelcome.com (Postfix, from userid 5007) id E393E6E604D8B; Fri, 24 Oct 2014 11:50:28 -0500 (CDT) Received: from gator4065.hostgator.com (gator4065.hostgator.com [192.185.4.76]) by gateway12.websitewelcome.com (Postfix) with ESMTP id DAD956E604D65 for <18806@debbugs.gnu.org>; Fri, 24 Oct 2014 11:50:28 -0500 (CDT) Received: from [109.66.121.211] (port=58006 helo=telaviv1.shlomifish.org) by gator4065.hostgator.com with esmtpa (Exim 4.82) (envelope-from ) id 1Xhi4K-0003mA-78; Fri, 24 Oct 2014 11:50:28 -0500 Received: from telaviv1.shlomifish.org (telaviv1.shlomifish.org [127.0.0.1]) by telaviv1.shlomifish.org (Postfix) with ESMTP id 0A5E226005F; Fri, 24 Oct 2014 19:50:27 +0300 (IDT) Date: Fri, 24 Oct 2014 19:50:26 +0300 From: Shlomi Fish To: Norihiro Tanaka Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 Message-ID: <20141024195026.0839340f@telaviv1.shlomifish.org> In-Reply-To: <20141025014542.6143.27F6AC2D@kcn.ne.jp> References: <54496DD8.1060203@cs.ucla.edu> <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-mageia-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4065.hostgator.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - shlomifish.org X-BWhitelist: no X-Source-IP: 109.66.121.211 X-Exim-ID: 1Xhi4K-0003mA-78 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (telaviv1.shlomifish.org) [109.66.121.211]:58006 X-Source-Auth: shlomif@shlomifish.org X-Email-Count: 3 X-Source-Cap: c2hsb21pZjtzaGxvbWlmO2dhdG9yNDA2NS5ob3N0Z2F0b3IuY29t X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, 25 Oct 2014 01:45:42 +0900 Norihiro Tanaka wrote: > Shlomi Fish write: > > `which grep` --color -rP getline grep-test > > If -o or --color option is specified, may be line_end < validated in > longest exact match. As a result, a negative value is set to > `search_bytes'. > > I improved validation for input buffer in order to fix the bug. > However, possibly it may cause slowdown. [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.56.148.16 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-Debbugs-Envelope-To: 18806 Cc: 18806@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, 25 Oct 2014 01:45:42 +0900 Norihiro Tanaka wrote: > Shlomi Fish write: > > `which grep` --color -rP getline grep-test > > If -o or --color option is specified, may be line_end < validated in > longest exact match. As a result, a negative value is set to > `search_bytes'. > > I improved validation for input buffer in order to fix the bug. > However, possibly it may cause slowdown. [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.56.148.16 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) On Sat, 25 Oct 2014 01:45:42 +0900 Norihiro Tanaka wrote: > Shlomi Fish write: > > `which grep` --color -rP getline grep-test >=20 > If -o or --color option is specified, may be line_end < validated in > longest exact match. As a result, a negative value is set to > `search_bytes'. >=20 > I improved validation for input buffer in order to fix the bug. > However, possibly it may cause slowdown. thanks for the patch! Regards, -- Shlomi Fish --=20 ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ Star Trek: =E2=80=9CWe, the Living Dead=E2=80=9D - http://shlom.in/st-wtld Yesterday I asked one of my students if she knew what an encyclopedia is, a= nd she said: =E2=80=9CIs it something like Wikipedia?=E2=80=9D. =E2=80=94 http://twitter.com/alisonclement/status/8421314259 Please reply to list if it's a mailing list post - http://shlom.in/reply . From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 13:23:39 2014 Received: (at 18806) by debbugs.gnu.org; 24 Oct 2014 17:23:39 +0000 Received: from localhost ([127.0.0.1]:34259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhiaP-0000hQ-Go for submit@debbugs.gnu.org; Fri, 24 Oct 2014 13:23:38 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:33508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhiaL-0000h8-4W for 18806@debbugs.gnu.org; Fri, 24 Oct 2014 13:23:35 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 084ABE8001F for <18806@debbugs.gnu.org>; Sat, 25 Oct 2014 02:23:26 +0900 (JST) Received: from mail02.kcn.ne.jp ([61.86.6.181]) by imp01 with bizsmtp id 75PR1p00F3uLcVp015PRSZ; Sat, 25 Oct 2014 02:23:25 +0900 X-OrgRCPT: 18806@debbugs.gnu.org Received: from [10.120.1.49] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail02.kcn.ne.jp (Postfix) with ESMTPA id A658AF1002D; Sat, 25 Oct 2014 02:23:25 +0900 (JST) Date: Sat, 25 Oct 2014 02:23:24 +0900 From: Norihiro Tanaka To: 18806@debbugs.gnu.org Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 In-Reply-To: <20141025014542.6143.27F6AC2D@kcn.ne.jp> References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> Message-Id: <20141025022324.614B.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_544A8AA3000000006154_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 18806 Cc: Paul Eggert , Shlomi Fish X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --------_544A8AA3000000006154_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit I added a rule to run the test to the patch. --------_544A8AA3000000006154_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-improvement-of-validation-for-input-buffer-in-g.patch" Content-Disposition: attachment; filename="0001-grep-improvement-of-validation-for-input-buffer-in-g.patch" Content-Transfer-Encoding: base64 RnJvbSA4MDIxZGMyYWM3MjhjNTI3Y2JhNjQ4ZWRmYTU4NDJjN2E4MGE4YTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTYXQsIDI1IE9jdCAyMDE0IDAxOjA1OjU3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogaW1wcm92ZW1lbnQgb2YgdmFsaWRhdGlvbiBmb3IgaW5wdXQgYnVmZmVyIGluIGdyZXAgLVAK Ciogc3JjL2dyZXAuYyBzcmMvZ3JlcC5oIHNyYy9wY3Jlc2VhcmNoLmMgKHZhbGlkYXRlZF9ib3Vu ZGFyeSk6IFJlbW92ZSB2YXIuCiogc3JjL3BjcmVzZWFyY2guYyAocHJldl92YWxpZCk6IE5ldyB2 YXIuCihQZXhlY3V0ZSk6IGltcHJvdmVtZW50IG9mIHZhbGlkYXRpb24gZm9yIGlucHV0IGJ1ZmZl ci4KKiB0ZXN0cy9wY3JlLW86IE5ldyB0ZXN0IGZvciB0aGlzIGNoYW5nZS4KKiB0ZXN0cy9NYWtl ZmlsZS5hbTogQWRkIGEgcnVsZSB0byBydW4gbmV3IHRlc3QuCi0tLQogc3JjL2dyZXAuYyAgICAg ICAgfCAgIDMgLS0KIHNyYy9ncmVwLmggICAgICAgIHwgICA0IC0tLQogc3JjL3BjcmVzZWFyY2gu YyAgfCAxMDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiB0ZXN0cy9NYWtlZmlsZS5hbSB8ICAgMSArCiB0ZXN0cy9wY3JlLW8gICAgICB8ICAx NyArKysrKysrKysKIDUgZmlsZXMgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygrKSwgNTIgZGVsZXRp b25zKC0pCiBjcmVhdGUgbW9kZSAxMDA3NTUgdGVzdHMvcGNyZS1vCgpkaWZmIC0tZ2l0IGEvc3Jj L2dyZXAuYyBiL3NyYy9ncmVwLmMKaW5kZXggYTBmMjYyMC4uMGE0YWMyNyAxMDA2NDQKLS0tIGEv c3JjL2dyZXAuYworKysgYi9zcmMvZ3JlcC5jCkBAIC0zNTIsNyArMzUyLDYgQEAgYm9vbCBtYXRj aF93b3JkczsKIGJvb2wgbWF0Y2hfbGluZXM7CiBjaGFyIGVvbGJ5dGU7CiBlbnVtIHRleHRiaW4g aW5wdXRfdGV4dGJpbjsKLWNoYXIgY29uc3QgKnZhbGlkYXRlZF9ib3VuZGFyeTsKIAogc3RhdGlj IGNoYXIgY29uc3QgKm1hdGNoZXI7CiAKQEAgLTEyMjYsNyArMTIyNSw2IEBAIGdyZXBidWYgKGNo YXIgY29uc3QgKmJlZywgY2hhciBjb25zdCAqbGltKQogICBpbnRtYXhfdCBvdXRsZWZ0MCA9IG91 dGxlZnQ7CiAgIGNoYXIgY29uc3QgKnA7CiAgIGNoYXIgY29uc3QgKmVuZHA7Ci0gIHZhbGlkYXRl ZF9ib3VuZGFyeSA9IGJlZzsKIAogICBmb3IgKHAgPSBiZWc7IHAgPCBsaW07IHAgPSBlbmRwKQog ICAgIHsKQEAgLTI1MTYsNyArMjUxNCw2IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikK ICAgLyogV2UgbmVlZCBvbmUgYnl0ZSBwcmlvciBhbmQgb25lIGFmdGVyLiAgKi8KICAgY2hhciBl b2xieXRlc1szXSA9IHsgMCwgZW9sYnl0ZSwgMCB9OwogICBzaXplX3QgbWF0Y2hfc2l6ZTsKLSAg dmFsaWRhdGVkX2JvdW5kYXJ5ID0gZW9sYnl0ZXMgKyAxOwogICBza2lwX2VtcHR5X2xpbmVzID0g KChleGVjdXRlIChlb2xieXRlcyArIDEsIDEsICZtYXRjaF9zaXplLCBOVUxMKSA9PSAwKQogICAg ICAgICAgICAgICAgICAgICAgID09IG91dF9pbnZlcnQpOwogCmRpZmYgLS1naXQgYS9zcmMvZ3Jl cC5oIGIvc3JjL2dyZXAuaAppbmRleCA4NjI1OWZiLi4wMjA1MmI0IDEwMDY0NAotLS0gYS9zcmMv Z3JlcC5oCisrKyBiL3NyYy9ncmVwLmgKQEAgLTQ3LDggKzQ3LDQgQEAgZW51bSB0ZXh0YmluCiAv KiBJbnB1dCBmaWxlIHR5cGUuICAqLwogZXh0ZXJuIGVudW0gdGV4dGJpbiBpbnB1dF90ZXh0Ymlu OwogCi0vKiBWYWxpZGF0aW9uIGJvdW5kYXJ5LiAgRWFybGllciBieXRlcyBoYXZlIGFscmVhZHkg YmVlbiB2YWxpZGF0ZWQgYnkKLSAgIHRoZSBQQ1JFIG1hdGNoZXIsIHdoaWNoIGNhcmVzIGFib3V0 IHRoaXMgc29ydCBvZiB0aGluZy4gICovCi1leHRlcm4gY2hhciBjb25zdCAqdmFsaWRhdGVkX2Jv dW5kYXJ5OwotCiAjZW5kaWYKZGlmZiAtLWdpdCBhL3NyYy9wY3Jlc2VhcmNoLmMgYi9zcmMvcGNy ZXNlYXJjaC5jCmluZGV4IDFmZDViZGUuLjg1YzFhY2QgMTAwNjQ0Ci0tLSBhL3NyYy9wY3Jlc2Vh cmNoLmMKKysrIGIvc3JjL3BjcmVzZWFyY2guYwpAQCAtNDIsNiArNDIsMTAgQEAgc3RhdGljIHBj cmVfZXh0cmEgKmV4dHJhOwogICAgc3RyaW5nIG1hdGNoZXMgd2hlbiB0aGF0IGZsYWcgaXMgdXNl ZC4gICovCiBzdGF0aWMgaW50IGVtcHR5X21hdGNoWzJdOwogCisvKiBQcmV2aW91cyByZXN1bHQg b2YgYSB2YWxpZGF0aW9uLiAgSWYgaXQncyB0cnVlLCBvbWl0IHRoZSB2YWxpZGF0aW9uIGluCisg ICBsb25nZXN0IGV4YWN0IG1hdGNoLiAgKi8KK3N0YXRpYyBib29sIHByZXZfdmFsaWQ7CisKIC8q IFRoaXMgbXVzdCBiZSBhdCBsZWFzdCAyOyBldmVyeXRoaW5nIGFmdGVyIHRoYXQgaXMgZm9yIHBl cmZvcm1hbmNlCiAgICBpbiBwY3JlX2V4ZWMuICAqLwogZW51bSB7IE5TVUIgPSAzMDAgfTsKQEAg LTE1Niw3ICsxNjAsNyBAQCBQZXhlY3V0ZSAoY2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwg c2l6ZV90ICptYXRjaF9zaXplLAogICBjaGFyIGNvbnN0ICpsaW5lX3N0YXJ0ID0gYnVmOwogICBp bnQgZSA9IFBDUkVfRVJST1JfTk9NQVRDSDsKICAgY2hhciBjb25zdCAqbGluZV9lbmQ7Ci0gIGNo YXIgY29uc3QgKnZhbGlkYXRlZCA9IHZhbGlkYXRlZF9ib3VuZGFyeTsKKyAgYm9vbCB2YWxpZCA9 IGZhbHNlOwogCiAgIC8qIElmIHRoZSBpbnB1dCB0eXBlIGlzIHVua25vd24sIHRoZSBjYWxsZXIg aXMgc3RpbGwgdGVzdGluZyB0aGUKICAgICAgaW5wdXQsIHdoaWNoIG1lYW5zIHRoZSBjdXJyZW50 IGJ1ZmZlciBjYW5ub3QgY29udGFpbiBlbmNvZGluZwpAQCAtMTc2LDExICsxODAsMTMgQEAgUGV4 ZWN1dGUgKGNoYXIgY29uc3QgKmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwK ICAgICAgICAgICBzaXplX3Qgc2Nhbl9zaXplID0gTUlOIChwY3JlX3NpemVfbWF4ICsgMSwgYnVm ICsgc2l6ZSAtIHApOwogICAgICAgICAgIGxpbmVfZW5kID0gbWVtcmNociAocCwgZW9sYnl0ZSwg c2Nhbl9zaXplKTsKICAgICAgICAgICB0b29fYmlnID0gISBsaW5lX2VuZDsKKyAgICAgICAgICB2 YWxpZCA9IHRydWU7CiAgICAgICAgIH0KICAgICAgIGVsc2UKICAgICAgICAgewogICAgICAgICAg IGxpbmVfZW5kID0gbWVtY2hyIChwLCBlb2xieXRlLCBidWYgKyBzaXplIC0gcCk7CiAgICAgICAg ICAgdG9vX2JpZyA9IElOVF9NQVggPCBsaW5lX2VuZCAtIHA7CisgICAgICAgICAgdmFsaWQgPSAo cHJldl92YWxpZCAmJiBzdGFydF9wdHIgIT0gTlVMTCk7CiAgICAgICAgIH0KIAogICAgICAgaWYg KHRvb19iaWcpCkBAIC0xODgsNjkgKzE5NCw3NiBAQCBQZXhlY3V0ZSAoY2hhciBjb25zdCAqYnVm LCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogCiAgICAgICBmb3IgKDs7KQogICAg ICAgICB7Ci0gICAgICAgICAgLyogU2tpcCBwYXN0IGJ5dGVzIHRoYXQgYXJlIGVhc2lseSBkZXRl cm1pbmVkIHRvIGJlIGVuY29kaW5nCi0gICAgICAgICAgICAgZXJyb3JzLCB0cmVhdGluZyB0aGVt IGFzIGRhdGEgdGhhdCBjYW5ub3QgbWF0Y2guICBUaGlzIGlzCi0gICAgICAgICAgICAgZmFzdGVy IHRoYW4gaGF2aW5nIHBjcmVfZXhlYyBjaGVjayB0aGVtLiAgKi8KLSAgICAgICAgICB3aGlsZSAo bWJjbGVuX2NhY2hlW3RvX3VjaGFyICgqcCldID09IChzaXplX3QpIC0xKQotICAgICAgICAgICAg ewotICAgICAgICAgICAgICBwKys7Ci0gICAgICAgICAgICAgIGJvbCA9IGZhbHNlOwotICAgICAg ICAgICAgfQorICAgICAgICAgIGludCB2YWxpZF9ieXRlczsKKyAgICAgICAgICBpbnQgb3B0aW9u cyA9IDA7CiAKLSAgICAgICAgICAvKiBDaGVjayBmb3IgYW4gZW1wdHkgbWF0Y2g7IHRoaXMgaXMg ZmFzdGVyIHRoYW4gbGV0dGluZwotICAgICAgICAgICAgIHBjcmVfZXhlYyBkbyBpdC4gICovCi0g ICAgICAgICAgaW50IHNlYXJjaF9ieXRlcyA9IGxpbmVfZW5kIC0gcDsKLSAgICAgICAgICBpZiAo c2VhcmNoX2J5dGVzID09IDApCisgICAgICAgICAgaWYgKCF2YWxpZCkKICAgICAgICAgICAgIHsK LSAgICAgICAgICAgICAgc3ViWzBdID0gc3ViWzFdID0gMDsKLSAgICAgICAgICAgICAgZSA9IGVt cHR5X21hdGNoW2JvbF07Ci0gICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQorICAg ICAgICAgICAgICAvKiBTa2lwIHBhc3QgYnl0ZXMgdGhhdCBhcmUgZWFzaWx5IGRldGVybWluZWQg dG8gYmUgZW5jb2RpbmcKKyAgICAgICAgICAgICAgICAgZXJyb3JzLCB0cmVhdGluZyB0aGVtIGFz IGRhdGEgdGhhdCBjYW5ub3QgbWF0Y2guICBUaGlzIGlzCisgICAgICAgICAgICAgICAgIGZhc3Rl ciB0aGFuIGhhdmluZyBwY3JlX2V4ZWMgY2hlY2sgdGhlbS4gICovCisgICAgICAgICAgICAgIHdo aWxlIChtYmNsZW5fY2FjaGVbdG9fdWNoYXIgKCpwKV0gPT0gKHNpemVfdCkgLTEpCisgICAgICAg ICAgICAgICAgeworICAgICAgICAgICAgICAgICAgcCsrOworICAgICAgICAgICAgICAgICAgYm9s ID0gZmFsc2U7CisgICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgaW50IG9wdGlvbnMgPSAw OwotICAgICAgICAgIGlmICghYm9sKQotICAgICAgICAgICAgb3B0aW9ucyB8PSBQQ1JFX05PVEJP TDsKLSAgICAgICAgICBpZiAobXVsdGlsaW5lIHx8IHAgKyBzZWFyY2hfYnl0ZXMgPD0gdmFsaWRh dGVkKQotICAgICAgICAgICAgb3B0aW9ucyB8PSBQQ1JFX05PX1VURjhfQ0hFQ0s7CisgICAgICAg ICAgICAgIC8qIENoZWNrIGZvciBhbiBlbXB0eSBtYXRjaDsgdGhpcyBpcyBmYXN0ZXIgdGhhbiBs ZXR0aW5nCisgICAgICAgICAgICAgICAgIHBjcmVfZXhlYyBkbyBpdC4gICovCisgICAgICAgICAg ICAgIGludCBzZWFyY2hfYnl0ZXMgPSBsaW5lX2VuZCAtIHA7CisgICAgICAgICAgICAgIGlmIChz ZWFyY2hfYnl0ZXMgPT0gMCkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICBz dWJbMF0gPSBzdWJbMV0gPSAwOworICAgICAgICAgICAgICAgICAgZSA9IGVtcHR5X21hdGNoW2Jv bF07CisgICAgICAgICAgICAgICAgICBpZiAocCA9PSBsaW5lX3N0YXJ0KQorICAgICAgICAgICAg ICAgICAgICB2YWxpZCA9IHRydWU7CisgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgICAgICB9CisKKyAgICAgICAgICAgICAgaWYgKCFib2wpCisgICAgICAgICAgICAgICAgb3B0 aW9ucyB8PSBQQ1JFX05PVEJPTDsKIAotICAgICAgICAgIGludCB2YWxpZF9ieXRlcyA9IHZhbGlk YXRlZCAtIHA7Ci0gICAgICAgICAgaWYgKHZhbGlkX2J5dGVzIDw9IDApCi0gICAgICAgICAgICB7 CiAgICAgICAgICAgICAgIGUgPSBwY3JlX2V4ZWMgKGNyZSwgZXh0cmEsIHAsIHNlYXJjaF9ieXRl cywgMCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3B0aW9ucywgc3ViLCBOU1VCKTsK ICAgICAgICAgICAgICAgaWYgKGUgIT0gUENSRV9FUlJPUl9CQURVVEY4KQogICAgICAgICAgICAg ICAgIHsKLSAgICAgICAgICAgICAgICAgIHZhbGlkYXRlZCA9IHAgKyBzZWFyY2hfYnl0ZXM7Ci0g ICAgICAgICAgICAgICAgICBpZiAoMCA8IGUgJiYgbXVsdGlsaW5lICYmIHN1YlsxXSAtIHN1Ylsw XSAhPSAwKQotICAgICAgICAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgICAgICAgY2hh ciBjb25zdCAqbmwgPSBtZW1jaHIgKHAgKyBzdWJbMF0sIGVvbGJ5dGUsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN1YlsxXSAtIHN1YlswXSk7Ci0gICAg ICAgICAgICAgICAgICAgICAgaWYgKG5sKQotICAgICAgICAgICAgICAgICAgICAgICAgewotICAg ICAgICAgICAgICAgICAgICAgICAgICAvKiBUaGlzIG1hdGNoIGNyb3NzZXMgYSBsaW5lIGJvdW5k YXJ5OyByZWplY3QgaXQuICAqLwotICAgICAgICAgICAgICAgICAgICAgICAgICBwICs9IHN1Ylsw XTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgbGluZV9lbmQgPSBubDsKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgICAgICAgICB9Ci0gICAg ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgIGlmIChwID09IGxpbmVfc3RhcnQp CisgICAgICAgICAgICAgICAgICAgIHZhbGlkID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgdmFsaWRfYnl0ZXMgPSBzdWJb MF07Ci0gICAgICAgICAgICAgIHZhbGlkYXRlZCA9IHAgKyB2YWxpZF9ieXRlczsKICAgICAgICAg ICAgIH0KKyAgICAgICAgICBlbHNlCisgICAgICAgICAgICB2YWxpZF9ieXRlcyA9IGxpbmVfZW5k IC0gcDsKIAogICAgICAgICAgIC8qIFRyeSB0byBtYXRjaCB0aGUgc3RyaW5nIGJlZm9yZSB0aGUg ZW5jb2RpbmcgZXJyb3IuCiAgICAgICAgICAgICAgQWdhaW4sIGhhbmRsZSB0aGUgZW1wdHktbWF0 Y2ggY2FzZSBzcGVjaWFsbHksIGZvciBzcGVlZC4gICovCiAgICAgICAgICAgaWYgKHZhbGlkX2J5 dGVzID09IDApCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIHN1YlsxXSA9IDA7CisgICAg ICAgICAgICAgIHN1YlswXSA9IHN1YlsxXSA9IDA7CiAgICAgICAgICAgICAgIGUgPSBlbXB0eV9t YXRjaFtib2xdOwogICAgICAgICAgICAgfQogICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGUg PSBwY3JlX2V4ZWMgKGNyZSwgZXh0cmEsIHAsIHZhbGlkX2J5dGVzLCAwLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgb3B0aW9ucyB8IFBDUkVfTk9fVVRGOF9DSEVDSyB8IFBDUkVfTk9URU9M LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgc3ViLCBOU1VCKTsKLSAgICAgICAgICBpZiAo ZSAhPSBQQ1JFX0VSUk9SX05PTUFUQ0gpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgIG9w dGlvbnMgfD0gUENSRV9OT19VVEY4X0NIRUNLOworICAgICAgICAgICAgICBpZiAodmFsaWRfYnl0 ZXMgPCBsaW5lX2VuZCAtIHApCisgICAgICAgICAgICAgICAgb3B0aW9ucyB8PSBQQ1JFX05PVEVP TDsKKyAgICAgICAgICAgICAgZSA9IHBjcmVfZXhlYyAoY3JlLCBleHRyYSwgcCwgdmFsaWRfYnl0 ZXMsIDAsIG9wdGlvbnMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN1YiwgTlNVQik7 CisgICAgICAgICAgICAgIGlmICgwIDwgZSAmJiBtdWx0aWxpbmUgJiYgc3ViWzFdIC0gc3ViWzBd ICE9IDApCisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgY2hhciBjb25zdCAq bmwgPSBtZW1jaHIgKHAgKyBzdWJbMF0sIGVvbGJ5dGUsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3ViWzFdIC0gc3ViWzBdKTsKKyAgICAgICAgICAgICAgICAg IGlmIChubCkKKyAgICAgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICAgIC8q IFRoaXMgbWF0Y2ggY3Jvc3NlcyBhIGxpbmUgYm91bmRhcnk7IHJlamVjdCBpdC4gICovCisgICAg ICAgICAgICAgICAgICAgICAgcCArPSBzdWJbMF07CisgICAgICAgICAgICAgICAgICAgICAgbGlu ZV9lbmQgPSBubDsKKyAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAg ICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgICBp ZiAoZSAhPSBQQ1JFX0VSUk9SX05PTUFUQ0ggfHwgcCArIHZhbGlkX2J5dGVzID49IGxpbmVfZW5k KQogICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAvKiBUcmVhdCB0aGUgZW5jb2Rpbmcg ZXJyb3IgYXMgZGF0YSB0aGF0IGNhbm5vdCBtYXRjaC4gICovCkBAIC0yNjMsNyArMjc2LDcgQEAg UGV4ZWN1dGUgKGNoYXIgY29uc3QgKmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6 ZSwKICAgICAgIGJvbCA9IHRydWU7CiAgICAgfQogCi0gIHZhbGlkYXRlZF9ib3VuZGFyeSA9IHZh bGlkYXRlZDsKKyAgcHJldl92YWxpZCA9IHZhbGlkOwogCiAgIGlmIChlIDw9IDApCiAgICAgewpk aWZmIC0tZ2l0IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtlZmlsZS5hbQppbmRleCBj Mjk4ODM1Li5mNmYwNTFjIDEwMDY0NAotLS0gYS90ZXN0cy9NYWtlZmlsZS5hbQorKysgYi90ZXN0 cy9NYWtlZmlsZS5hbQpAQCAtOTAsNiArOTAsNyBAQCBURVNUUyA9CQkJCQkJXAogICBwY3JlLWFi b3J0CQkJCQlcCiAgIHBjcmUtaW5mbG9vcAkJCQkJXAogICBwY3JlLWludmFsaWQtdXRmOC1pbnB1 dAkJCVwKKyAgcGNyZS1vCQkJCQlcCiAgIHBjcmUtdXRmOAkJCQkJXAogICBwY3JlLXcJCQkJCVwK ICAgcGNyZS13eC1iYWNrcmVmCQkJCVwKZGlmZiAtLWdpdCBhL3Rlc3RzL3BjcmUtbyBiL3Rlc3Rz L3BjcmUtbwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi41ZjU4OTFlCi0tLSAv ZGV2L251bGwKKysrIGIvdGVzdHMvcGNyZS1vCkBAIC0wLDAgKzEsMTcgQEAKKyMhIC9iaW4vc2gK KyMgRW5zdXJlIHRoYXQsIGdyZXAgLW9QIGRvZXNuJ3QgY2F1c2UgaW50ZXJuYWwgZXJyb3IgYXQg bWF0Y2guCisjCisjIENvcHlyaWdodCAoQykgMjAxNCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24s IEluYy4KKyMKKyMgQ29weWluZyBhbmQgZGlzdHJpYnV0aW9uIG9mIHRoaXMgZmlsZSwgd2l0aCBv ciB3aXRob3V0IG1vZGlmaWNhdGlvbiwKKyMgYXJlIHBlcm1pdHRlZCBpbiBhbnkgbWVkaXVtIHdp dGhvdXQgcm95YWx0eSBwcm92aWRlZCB0aGUgY29weXJpZ2h0CisjIG5vdGljZSBhbmQgdGhpcyBu b3RpY2UgYXJlIHByZXNlcnZlZC4KKworLiAiJHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJl cGVuZF8gLi4vc3JjCityZXF1aXJlX3BjcmVfCisKK2ZhaWw9MAorCitlY2hvIGFiIHwgZ3JlcCAt b1AgJ2EnIHx8IGZhaWw9MQorCitFeGl0ICRmYWlsCi0tIAoyLjEuMQoK --------_544A8AA3000000006154_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 16:38:40 2014 Received: (at 18806-done) by debbugs.gnu.org; 24 Oct 2014 20:38:41 +0000 Received: from localhost ([127.0.0.1]:34338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhld9-0005Ta-HU for submit@debbugs.gnu.org; Fri, 24 Oct 2014 16:38:40 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:55579) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhld4-0005TN-SY for 18806-done@debbugs.gnu.org; Fri, 24 Oct 2014 16:38:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A6A23A600A8; Fri, 24 Oct 2014 13:38:28 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kcAX3267a0iF; Fri, 24 Oct 2014 13:38:24 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6142EA600A9; Fri, 24 Oct 2014 13:38:24 -0700 (PDT) Message-ID: <544AB8BB.9080600@cs.ucla.edu> Date: Fri, 24 Oct 2014 13:38:19 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Norihiro Tanaka , 18806-done@debbugs.gnu.org Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> <20141025022324.614B.27F6AC2D@kcn.ne.jp> In-Reply-To: <20141025022324.614B.27F6AC2D@kcn.ne.jp> Content-Type: multipart/mixed; boundary="------------050608090100050303070005" X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 18806-done Cc: Shlomi Fish X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) This is a multi-part message in MIME format. --------------050608090100050303070005 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for looking into this. I added that test case, but took a more-conservative approach to fixing the bug, by disabling the optimization that's causing this problem; please see attached patches. The optimization was a hack anyway, and these bugs suggest that it's not a hack worth keeping. --------------050608090100050303070005 Content-Type: text/x-patch; name="0001-grep-fix-grep-P-crash.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-grep-fix-grep-P-crash.patch" >From c4d6d577820f6d40cc0f34be56fc8d8795381fef Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 24 Oct 2014 13:27:29 -0700 Subject: [PATCH 1/2] grep: fix grep -P crash Reported by Shlomi Fish in: http://bugs.gnu.org/18806 Commit 9fa500407137f49f6edc3c6b4ee6c7096f0190c5 (2014-09-16) is a hack that I put in to speed up 'grep -P'. Unfortunately, not only is it violation of modularity, it's also a bug magnet, as we have found out with Bug#18738 and Bug#18806. Remove the optimization instead of applying more bandaids. Perhaps we can think of a better way of doing the optimization, or perhaps we can just live with a slower grep -P (as -P is inherently slower anyway...). * src/grep.c, src/grep.h (validated_boundary): Remove. All uses removed. * src/pcresearch.c (Pexecute): Do not worry about validated_boundary. --- src/grep.c | 3 --- src/grep.h | 4 ---- src/pcresearch.c | 37 ++++++++++++++----------------------- 3 files changed, 14 insertions(+), 30 deletions(-) diff --git a/src/grep.c b/src/grep.c index a0f2620..0a4ac27 100644 --- a/src/grep.c +++ b/src/grep.c @@ -352,7 +352,6 @@ bool match_words; bool match_lines; char eolbyte; enum textbin input_textbin; -char const *validated_boundary; static char const *matcher; @@ -1226,7 +1225,6 @@ grepbuf (char const *beg, char const *lim) intmax_t outleft0 = outleft; char const *p; char const *endp; - validated_boundary = beg; for (p = beg; p < lim; p = endp) { @@ -2516,7 +2514,6 @@ main (int argc, char **argv) /* We need one byte prior and one after. */ char eolbytes[3] = { 0, eolbyte, 0 }; size_t match_size; - validated_boundary = eolbytes + 1; skip_empty_lines = ((execute (eolbytes + 1, 1, &match_size, NULL) == 0) == out_invert); diff --git a/src/grep.h b/src/grep.h index 86259fb..02052b4 100644 --- a/src/grep.h +++ b/src/grep.h @@ -47,8 +47,4 @@ enum textbin /* Input file type. */ extern enum textbin input_textbin; -/* Validation boundary. Earlier bytes have already been validated by - the PCRE matcher, which cares about this sort of thing. */ -extern char const *validated_boundary; - #endif diff --git a/src/pcresearch.c b/src/pcresearch.c index 1fd5bde..5451029 100644 --- a/src/pcresearch.c +++ b/src/pcresearch.c @@ -156,7 +156,6 @@ Pexecute (char const *buf, size_t size, size_t *match_size, char const *line_start = buf; int e = PCRE_ERROR_NOMATCH; char const *line_end; - char const *validated = validated_boundary; /* If the input type is unknown, the caller is still testing the input, which means the current buffer cannot contain encoding @@ -210,34 +209,28 @@ Pexecute (char const *buf, size_t size, size_t *match_size, int options = 0; if (!bol) options |= PCRE_NOTBOL; - if (multiline || p + search_bytes <= validated) + if (multiline) options |= PCRE_NO_UTF8_CHECK; - int valid_bytes = validated - p; - if (valid_bytes <= 0) + e = pcre_exec (cre, extra, p, search_bytes, 0, + options, sub, NSUB); + if (e != PCRE_ERROR_BADUTF8) { - e = pcre_exec (cre, extra, p, search_bytes, 0, - options, sub, NSUB); - if (e != PCRE_ERROR_BADUTF8) + if (0 < e && multiline && sub[1] - sub[0] != 0) { - validated = p + search_bytes; - if (0 < e && multiline && sub[1] - sub[0] != 0) + char const *nl = memchr (p + sub[0], eolbyte, + sub[1] - sub[0]); + if (nl) { - char const *nl = memchr (p + sub[0], eolbyte, - sub[1] - sub[0]); - if (nl) - { - /* This match crosses a line boundary; reject it. */ - p += sub[0]; - line_end = nl; - continue; - } + /* This match crosses a line boundary; reject it. */ + p += sub[0]; + line_end = nl; + continue; } - break; } - valid_bytes = sub[0]; - validated = p + valid_bytes; + break; } + int valid_bytes = sub[0]; /* Try to match the string before the encoding error. Again, handle the empty-match case specially, for speed. */ @@ -263,8 +256,6 @@ Pexecute (char const *buf, size_t size, size_t *match_size, bol = true; } - validated_boundary = validated; - if (e <= 0) { switch (e) -- 1.9.3 --------------050608090100050303070005 Content-Type: text/x-patch; name="0002-tests-add-test-for-grep-P-fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-tests-add-test-for-grep-P-fix.patch" >From f79cd1bbd135f7c1751059be9d1d785598a7759b Mon Sep 17 00:00:00 2001 From: Norihiro Tanaka Date: Fri, 24 Oct 2014 13:33:04 -0700 Subject: [PATCH 2/2] tests: add test for grep -P fix * tests/pcre-o: New test for this change. * tests/Makefile.am (TESTS): Add it. --- tests/Makefile.am | 1 + tests/pcre-o | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100755 tests/pcre-o diff --git a/tests/Makefile.am b/tests/Makefile.am index c298835..f6f051c 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -90,6 +90,7 @@ TESTS = \ pcre-abort \ pcre-infloop \ pcre-invalid-utf8-input \ + pcre-o \ pcre-utf8 \ pcre-w \ pcre-wx-backref \ diff --git a/tests/pcre-o b/tests/pcre-o new file mode 100755 index 0000000..3d0677c --- /dev/null +++ b/tests/pcre-o @@ -0,0 +1,17 @@ +#! /bin/sh +# Ensure that grep -oP doesn't cause internal error at match. +# +# Copyright (C) 2014 Free Software Foundation, Inc. +# +# Copying and distribution of this file, with or without modification, +# are permitted in any medium without royalty provided the copyright +# notice and this notice are preserved. + +. "${srcdir=.}/init.sh"; path_prepend_ ../src +require_pcre_ + +fail=0 + +echo ab | grep -oP 'a' || fail=1 + +Exit $fail -- 1.9.3 --------------050608090100050303070005-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 24 19:58:15 2014 Received: (at 18806-done) by debbugs.gnu.org; 24 Oct 2014 23:58:15 +0000 Received: from localhost ([127.0.0.1]:34421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhokI-0001rp-Me for submit@debbugs.gnu.org; Fri, 24 Oct 2014 19:58:14 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:51407) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XhokF-0001rb-L2 for 18806-done@debbugs.gnu.org; Fri, 24 Oct 2014 19:58:12 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 7D0D7C8008 for <18806-done@debbugs.gnu.org>; Sat, 25 Oct 2014 08:58:04 +0900 (JST) Received: from mail05.kcn.ne.jp ([61.86.6.184]) by imp01 with bizsmtp id 7By41p00E3yDdWd01By4QF; Sat, 25 Oct 2014 08:58:04 +0900 X-OrgRCPT: 18806-done@debbugs.gnu.org Received: from [10.120.1.9] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail05.kcn.ne.jp (Postfix) with ESMTPA id 37F8E7D0099; Sat, 25 Oct 2014 08:58:04 +0900 (JST) Date: Sat, 25 Oct 2014 08:58:02 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 In-Reply-To: <544AB8BB.9080600@cs.ucla.edu> References: <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> Message-Id: <20141025085802.D868.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 18806-done Cc: 18806-done@debbugs.gnu.org, Shlomi Fish X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Paul Eggert wrote: > The optimization was a hack anyway, and these bugs suggest that it's> > not a hack worth keeping. Thanks. I improved this hack instead of removal, but it had little effect in comparison with your patch, even if `execute' ran for each character. $ yes j | head -1000000 >k (Current master): $ time -p src/grep -Po j ../k >/dev/null real 0.46 user 0.40 sys 0.02 (My patch): $ time -p src/grep -Po j ../k >/dev/null real 0.46 user 0.41 sys 0.01 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 25 03:22:14 2014 Received: (at 18806-done) by debbugs.gnu.org; 25 Oct 2014 07:22:15 +0000 Received: from localhost ([127.0.0.1]:34521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhvfy-00041X-5H for submit@debbugs.gnu.org; Sat, 25 Oct 2014 03:22:14 -0400 Received: from gateway13.websitewelcome.com ([67.18.106.10]:47541) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xhvfv-00041M-1J for 18806-done@debbugs.gnu.org; Sat, 25 Oct 2014 03:22:11 -0400 Received: by gateway13.websitewelcome.com (Postfix, from userid 5007) id 58EA55408CA8C; Sat, 25 Oct 2014 02:22:09 -0500 (CDT) Received: from gator4065.hostgator.com (gator4065.hostgator.com [192.185.4.76]) by gateway13.websitewelcome.com (Postfix) with ESMTP id 531B35408CA6B for <18806-done@debbugs.gnu.org>; Sat, 25 Oct 2014 02:22:09 -0500 (CDT) Received: from [109.66.121.211] (port=58796 helo=telaviv1.shlomifish.org) by gator4065.hostgator.com with esmtpa (Exim 4.82) (envelope-from ) id 1Xhvfs-0001NI-Pe; Sat, 25 Oct 2014 02:22:08 -0500 Received: from telaviv1.shlomifish.org (telaviv1.shlomifish.org [127.0.0.1]) by telaviv1.shlomifish.org (Postfix) with ESMTP id 729C42600AB; Sat, 25 Oct 2014 10:22:07 +0300 (IDT) Date: Sat, 25 Oct 2014 10:22:07 +0300 From: Shlomi Fish To: Norihiro Tanaka Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 Message-ID: <20141025102207.365fb00a@telaviv1.shlomifish.org> In-Reply-To: <20141025085802.D868.27F6AC2D@kcn.ne.jp> References: <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> <20141025085802.D868.27F6AC2D@kcn.ne.jp> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-mageia-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4065.hostgator.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - shlomifish.org X-BWhitelist: no X-Source-IP: 109.66.121.211 X-Exim-ID: 1Xhvfs-0001NI-Pe X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (telaviv1.shlomifish.org) [109.66.121.211]:58796 X-Source-Auth: shlomif@shlomifish.org X-Email-Count: 2 X-Source-Cap: c2hsb21pZjtzaGxvbWlmO2dhdG9yNDA2NS5ob3N0Z2F0b3IuY29t X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18806-done Cc: 18806-done@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Hi all, On Sat, 25 Oct 2014 08:58:02 +0900 Norihiro Tanaka wrote: > Paul Eggert wrote: > > The optimization was a hack anyway, and these bugs suggest that it's> > > not a hack worth keeping. >=20 > Thanks. I improved this hack instead of removal, but it had little > effect in comparison with your patch, even if `execute' ran for each > character. >=20 Thank you both for the fix. =E2=99=A5! Regards, Shlomi Fish --=20 ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ Optimising Code for Speed - http://shlom.in/optimise Chuck Norris has 99 problems including a bitch. =E2=80=94 http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply . From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 25 14:07:20 2014 Received: (at 18806) by debbugs.gnu.org; 25 Oct 2014 18:07:20 +0000 Received: from localhost ([127.0.0.1]:35471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xi5kG-0006hM-CC for submit@debbugs.gnu.org; Sat, 25 Oct 2014 14:07:20 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:46027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xi5kE-0006gy-2z; Sat, 25 Oct 2014 14:07:18 -0400 Received: by mail-wi0-f170.google.com with SMTP id n3so3277627wiv.3 for ; Sat, 25 Oct 2014 11:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=FyPt6EAxCFFN2neLOu4jvxqz63avpbCu/ZRMOYRq6+o=; b=n9ZN0ApUAyc7uTmr2zn200nKxO9/eLV5ZdWGMG+kEF4xLwyBSV8+wjJoEWv5jaZut7 1/Tkmm2pG1NShKcYzq0JDtcsbQuJZLc9YDpfQhlpwEroCiiBZDv7+6AnrwgVo0yRpNKg w6PAo+DoJsnW+0K2p/1uUP2oDDuo7ss9UTxPIaAZkygkF9SsyhdgoJKpKog88iGQP8Ps SJ57yCtUZw5fS/PtJNmkwL2c0M7aMdZI8OoxTomW7+7/7lf3tbV6tcJw62DZe8haafMU 3U0db5IZi/hAs1R74dq7JENV/o9TU9VhGK0ayUlc2jAFiTGWvUSS+eR9uYtztw/726E4 8Wng== X-Received: by 10.194.236.232 with SMTP id ux8mr21398wjc.96.1414260432109; Sat, 25 Oct 2014 11:07:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.86.131 with HTTP; Sat, 25 Oct 2014 11:06:51 -0700 (PDT) In-Reply-To: <544AB8BB.9080600@cs.ucla.edu> References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> From: Jim Meyering Date: Sat, 25 Oct 2014 11:06:51 -0700 X-Google-Sender-Auth: laPwZVbcGX5d0tXhXYiz4yc-cOA Message-ID: Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 To: 18806@debbugs.gnu.org, Paul Eggert , Shlomi Fish Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18806 Cc: 18806-done@debbugs.gnu.org, Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Oct 24, 2014 at 1:38 PM, Paul Eggert wrote: > Thanks for looking into this. I added that test case, but took a > more-conservative approach to fixing the bug, by disabling the optimization > that's causing this problem; please see attached patches. The optimization > was a hack anyway, and these bugs suggest that it's not a hack worth > keeping. Hi Paul, At first I thought "ok, either way." But then I found that after your change, our pcre-invalid-utf8-input hangs. That happens because the following infloops (stuck in pcre_exec) on a CentOS6 system: printf 'j\202j\nj\nk\202\n' > in; LC_ALL=en_US.utf8 src/grep -P 'k$' in That binary was linked with the libpcre from this package: pcre-7.8-4.el6.x86_64 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 25 19:11:48 2014 Received: (at 18806) by debbugs.gnu.org; 25 Oct 2014 23:11:48 +0000 Received: from localhost ([127.0.0.1]:35548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiAUu-0005U7-4X for submit@debbugs.gnu.org; Sat, 25 Oct 2014 19:11:48 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:51333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiAUr-0005Tn-3Z; Sat, 25 Oct 2014 19:11:46 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1E9CA60010; Sat, 25 Oct 2014 16:11:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U-H5yI4-MWym; Sat, 25 Oct 2014 16:11:33 -0700 (PDT) Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id A958C39E807B; Sat, 25 Oct 2014 16:11:33 -0700 (PDT) Message-ID: <544C2E25.3090908@cs.ucla.edu> Date: Sat, 25 Oct 2014 16:11:33 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jim Meyering , 18806@debbugs.gnu.org, Shlomi Fish Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> In-Reply-To: Content-Type: multipart/mixed; boundary="------------000801030509080803010606" X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 18806 Cc: 18806-done@debbugs.gnu.org, Norihiro Tanaka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) This is a multi-part message in MIME format. --------------000801030509080803010606 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Jim Meyering wrote: > after your change, > our pcre-invalid-utf8-input hangs. That happens because the following > infloops (stuck in pcre_exec) on a CentOS6 system: > > printf 'j\202j\nj\nk\202\n' > in; LC_ALL=en_US.utf8 src/grep -P 'k$' in > > That binary was linked with the libpcre from this package: > > pcre-7.8-4.el6.x86_64 I'm getting a failure in pcre-invalid-utf8-input both before and after the change, with CentOS 6.5 and pcre-7.8-6.el6.x86_64. In my case the failures are segmentation violations; perhaps 7.8-4 has a different failure mode, or perhaps there's some other minor change to your platform that causes libpcre to infloop. Either way, this appears to be a PCRE bug that grep can't be expected to work around. Does the attached patch cause the test to fail reliably for you, instead of looping? By the way, I'm not sure why tests distinguish between require_en_utf8_locale_ and require_compiled_in_MB_support; the latter requires the former, and there's no point requiring the former unless we also require the latter. --------------000801030509080803010606 Content-Type: text/plain; charset=UTF-8; name="pcre.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pcre.diff" ZGlmZiAtLWdpdCBhL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0IGIvdGVzdHMvcGNy ZS1pbnZhbGlkLXV0ZjgtaW5wdXQKaW5kZXggNzhiZDFjZi4uNzFkNDg3NyAxMDA3NTUKLS0t IGEvdGVzdHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5wdXQKKysrIGIvdGVzdHMvcGNyZS1pbnZh bGlkLXV0ZjgtaW5wdXQKQEAgLTksMjEgKzksMjMgQEAKIAogLiAiJHtzcmNkaXI9Ln0vaW5p dC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3JjCiByZXF1aXJlX3BjcmVfCityZXF1aXJlX3Rp bWVvdXRfCiByZXF1aXJlX2VuX3V0ZjhfbG9jYWxlXworcmVxdWlyZV9jb21waWxlZF9pbl9N Ql9zdXBwb3J0CiAKIGZhaWw9MAogCiBwcmludGYgJ2pcMjAyalxualxua1wyMDJcbicgPiBp biB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KIAotTENfQUxMPWVuX1VTLlVURi04IGdyZXAgLVAg aiBpbgorTENfQUxMPWVuX1VTLlVURi04IHRpbWVvdXQgMyBncmVwIC1QIGogaW4KIHRlc3Qg JD8gLWVxIDAgfHwgZmFpbD0xCiAKLUxDX0FMTD1lbl9VUy5VVEYtOCBncmVwIC1QICdrJCcg aW4KK0xDX0FMTD1lbl9VUy5VVEYtOCB0aW1lb3V0IDMgZ3JlcCAtUCAnayQnIGluCiB0ZXN0 ICQ/IC1lcSAxIHx8IGZhaWw9MQogCiBlY2hvIGsgPmV4cAogCi1MQ19BTEw9ZW5fVVMuVVRG LTggZ3JlcCAtYW9QICdrKicgaW4gPm91dCB8fCBmYWlsPTEKK0xDX0FMTD1lbl9VUy5VVEYt OCB0aW1lb3V0IDMgZ3JlcCAtYW9QICdrKicgaW4gPm91dCB8fCBmYWlsPTEKIGNvbXBhcmUg ZXhwIG91dCB8fCBmYWlsPTEKIAogRXhpdCAkZmFpbAo= --------------000801030509080803010606-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 25 21:24:55 2014 Received: (at 18806) by debbugs.gnu.org; 26 Oct 2014 01:24:55 +0000 Received: from localhost ([127.0.0.1]:35594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiCZi-0000At-I7 for submit@debbugs.gnu.org; Sat, 25 Oct 2014 21:24:54 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:47106) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiCZe-0000AD-VD; Sat, 25 Oct 2014 21:24:52 -0400 Received: by mail-wi0-f177.google.com with SMTP id ex7so3844362wid.4 for ; Sat, 25 Oct 2014 18:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=QGQDkRm5voNLQa8LtCW7Q/RPMpVBkDWC4ONE1Zde7wE=; b=Eh058Km59HlpFl82IRc3loLGNPduOJmN+aOm5iDWSQ1K5Ua4bKtUJRs60PEBvlDiYB J1fVGRNqGJve2qNyxr7ztncYkK63kcX6rsYsPEjh8dvRHEmpf0F+tVt9ncwgocVehO/o p/iCh46OgY1OJ7GvIdsWwuz9CVaotARBQ+CBwga7dyk9gc0eGPuf9oD0tSmo09LYMlUT YwrUO2gyQKlgxG0PkR/+iVmf5T0ni390oLhwCQ+NBMhRG+Dhqdvc4j51RkgwndOsHkW4 qvEAftavtrCtgV/2vk+XXMzoT9rUetyE//t1LF7h2efqMz6ZLFCXmbaYWM+il4ILXEpf DRcg== X-Received: by 10.180.8.233 with SMTP id u9mr12936214wia.19.1414286684962; Sat, 25 Oct 2014 18:24:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.86.131 with HTTP; Sat, 25 Oct 2014 18:24:24 -0700 (PDT) In-Reply-To: <544C2E25.3090908@cs.ucla.edu> References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> <544C2E25.3090908@cs.ucla.edu> From: Jim Meyering Date: Sat, 25 Oct 2014 18:24:24 -0700 X-Google-Sender-Auth: fb3vJWAvOH8eYb86k4CA2rI8SGQ Message-ID: Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 To: Paul Eggert Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18806 Cc: 18806 <18806@debbugs.gnu.org>, 18806-done <18806-done@debbugs.gnu.org>, Norihiro Tanaka , Shlomi Fish X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Oct 25, 2014 at 4:11 PM, Paul Eggert wrote: > I'm getting a failure in pcre-invalid-utf8-input both before and after the > change, with CentOS 6.5 and pcre-7.8-6.el6.x86_64. In my case the failures > are segmentation violations; perhaps 7.8-4 has a different failure mode, or > perhaps there's some other minor change to your platform that causes libpcre > to infloop. Either way, this appears to be a PCRE bug that grep can't be > expected to work around. > > Does the attached patch cause the test to fail reliably for you, instead of > looping? Yes. And a timeout of 3s should be fine. Thanks. Please push that. I've just built grep against the latest pcre from git (an Oct 10 commit with this hash: cc48a55a5de9c2103f6657147149bcf63ff61579), and then all of grep's tests pass. Ideally, we would detect and warn about inadequate versions of pcre, but that certainly need not block the release. > By the way, I'm not sure why tests distinguish between > require_en_utf8_locale_ and require_compiled_in_MB_support; the latter > requires the former, and there's no point requiring the former unless we > also require the latter. It looks like I added the require_compiled_in_MB_support function in grep commit v2.9-27-g46e5cc6, yet never realized that it subsumed require_en_utf8_locale_. You're welcome to clean up after the release. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 26 01:49:50 2014 Received: (at 18806) by debbugs.gnu.org; 26 Oct 2014 05:49:50 +0000 Received: from localhost ([127.0.0.1]:35662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiGi5-0006gY-Rj for submit@debbugs.gnu.org; Sun, 26 Oct 2014 01:49:50 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:34317) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XiGi3-0006gG-85; Sun, 26 Oct 2014 01:49:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0084E39E8017; Sat, 25 Oct 2014 22:49:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s7jjF5ZFei71; Sat, 25 Oct 2014 22:49:37 -0700 (PDT) Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id D902D39E8014; Sat, 25 Oct 2014 22:49:36 -0700 (PDT) Message-ID: <544C8B6C.7010002@cs.ucla.edu> Date: Sat, 25 Oct 2014 22:49:32 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#18806: grep -rP getline crashes prematurely (without displaying all results) on invalid UTF-8 input with LC_ALL=en_US.UTF-8 References: <20141024122632.4e1875cd@telaviv1.shlomifish.org> <20141025014542.6143.27F6AC2D@kcn.ne.jp> <20141025022324.614B.27F6AC2D@kcn.ne.jp> <544AB8BB.9080600@cs.ucla.edu> <544C2E25.3090908@cs.ucla.edu> In-Reply-To: Content-Type: multipart/mixed; boundary="------------040204020205090407000405" X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 18806 Cc: 18806 <18806@debbugs.gnu.org>, 18806-done <18806-done@debbugs.gnu.org>, Norihiro Tanaka , Shlomi Fish X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) This is a multi-part message in MIME format. --------------040204020205090407000405 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Jim Meyering wrote: > Yes. And a timeout of 3s should be fine. Thanks. Please push that. Done, with the attached patch. --------------040204020205090407000405 Content-Type: text/plain; charset=UTF-8; name="0001-tests-work-around-older-libpcre-bugs-when-testing-P-.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-tests-work-around-older-libpcre-bugs-when-testing-P-.pa"; filename*1="tch" RnJvbSBlZTA1ZDNjOTcwMzVjYmM2N2JkYWU3MGM3ZDdlNmE0ZTQ3ZjBjYjFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDI1IE9jdCAyMDE0IDIyOjQ3OjM5IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gdGVzdHM6IHdvcmsgYXJvdW5kIG9sZGVyIGxpYnBjcmUgYnVncyB3aGVuIHRlc3Rpbmcg LVAgYW5kCiBVVEYtOAoKKiB0ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbnB1dDogQWRkIHJl cXVpcmVfdGltZW91dF8gYW5kCnJlcXVpcmVfY29tcGlsZWRfaW5fTUJfc3VwcG9ydC4gIFB1 dCBhIHRpbWVvdXQgb2YgMyBzZWNvbmRzIG9uCmdyZXAsIHRvIGF2b2lkIGhhdmluZyB0aGlz IHRlc3QgY2FzZSBsb29wIGZvcmV2ZXIgd2l0aCBvbGRlcgp2ZXJzaW9ucyBvZiBsaWJwY3Jl LCBzdWNoIGFzIHRob3NlIGZvdW5kIG9uIFJIRUwgNi41LgpSZXBvcnRlZCBieSBKaW0gTWV5 ZXJpbmcgaW46IGh0dHA6Ly9idWdzLmdudS5vcmcvMTg4MDYjMzQKLS0tCiB0ZXN0cy9wY3Jl LWludmFsaWQtdXRmOC1pbnB1dCB8IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvdGVzdHMvcGNyZS1p bnZhbGlkLXV0ZjgtaW5wdXQgYi90ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbnB1dAppbmRl eCA3OGJkMWNmLi43MWQ0ODc3IDEwMDc1NQotLS0gYS90ZXN0cy9wY3JlLWludmFsaWQtdXRm OC1pbnB1dAorKysgYi90ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbnB1dApAQCAtOSwyMSAr OSwyMyBAQAogCiAuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0aF9wcmVwZW5kXyAuLi9z cmMKIHJlcXVpcmVfcGNyZV8KK3JlcXVpcmVfdGltZW91dF8KIHJlcXVpcmVfZW5fdXRmOF9s b2NhbGVfCityZXF1aXJlX2NvbXBpbGVkX2luX01CX3N1cHBvcnQKIAogZmFpbD0wCiAKIHBy aW50ZiAnalwyMDJqXG5qXG5rXDIwMlxuJyA+IGluIHx8IGZyYW1ld29ya19mYWlsdXJlXwog Ci1MQ19BTEw9ZW5fVVMuVVRGLTggZ3JlcCAtUCBqIGluCitMQ19BTEw9ZW5fVVMuVVRGLTgg dGltZW91dCAzIGdyZXAgLVAgaiBpbgogdGVzdCAkPyAtZXEgMCB8fCBmYWlsPTEKIAotTENf QUxMPWVuX1VTLlVURi04IGdyZXAgLVAgJ2skJyBpbgorTENfQUxMPWVuX1VTLlVURi04IHRp bWVvdXQgMyBncmVwIC1QICdrJCcgaW4KIHRlc3QgJD8gLWVxIDEgfHwgZmFpbD0xCiAKIGVj aG8gayA+ZXhwCiAKLUxDX0FMTD1lbl9VUy5VVEYtOCBncmVwIC1hb1AgJ2sqJyBpbiA+b3V0 IHx8IGZhaWw9MQorTENfQUxMPWVuX1VTLlVURi04IHRpbWVvdXQgMyBncmVwIC1hb1AgJ2sq JyBpbiA+b3V0IHx8IGZhaWw9MQogY29tcGFyZSBleHAgb3V0IHx8IGZhaWw9MQogCiBFeGl0 ICRmYWlsCi0tIAoxLjkuMwoK --------------040204020205090407000405-- From unknown Wed Jun 18 23:12:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Nov 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator