GNU bug report logs - #18800
[PATCH 1/2] dfa: prefer bool at DFA interfaces

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18800 in the body.
You can then email your comments to 18800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH 1/2] dfa: prefer bool at DFA interfaces
Date: Thu, 23 Oct 2014 08:02:49 +0900

[Message part 1 (text/plain, inline)]

This change is use bool for booleans at DFA interfaces.  Callers in Gawk
have already used bool instead of int for them.  Second patch changes
caller with change in first patch.

[0001-dfa-prefer-bool-at-DFA-externals.patch (text/plain, attachment)]

[0002-grep-change-caller-for-previous-change.patch (text/plain, attachment)]

Message #8 received at 18800 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: 18800 <at> debbugs.gnu.org
Subject: Re: bug#18800: [PATCH 1/2] dfa: prefer bool at DFA interfaces
Date: Thu, 23 Oct 2014 08:25:32 +0900

[Message part 1 (text/plain, inline)]

Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> This change is use bool for booleans at DFA interfaces.  Callers in Gawk
> have already used bool instead of int for them.  Second patch changes
> caller with change in first patch.

Sorry, Previous change was imcomplete.  I fixed it, and added a third
patch.

[0001-dfa-prefer-bool-at-DFA-interfaces.patch (text/plain, attachment)]

[0002-grep-change-caller-for-previous-change.patch (text/plain, attachment)]

[0003-dfa-change-internal-functions-into-static.patch (text/plain, attachment)]

Message #11 received at 18800 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18800 <at> debbugs.gnu.org
Subject: Re: bug#18800: dfa: prefer bool at DFA interfaces
Date: Wed, 20 Apr 2016 23:57:46 -0700

[Message part 1 (text/plain, inline)]

In updating Bug#18000's patches to the current grep source, I couldn't build 
with just the first patch installed, so I squashed the first two patches into 
one. Also, I changed a few more 'int's into 'bool's and fixed a comment or two. 
The result is attached. Again, I'm not installing this yet, as we're expecting a 
new release soon.

[0001-dfa-prefer-bool-at-DFA-interfaces.patch (text/x-diff, attachment)]

[0002-dfa-stop-exporting-internal-functions.patch (text/x-diff, attachment)]

Message #14 received at 18800 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 18800 <at> debbugs.gnu.org
Subject: Re: bug#18800: dfa: prefer bool at DFA interfaces
Date: Sun, 24 Apr 2016 22:15:08 +0900

On Wed, 20 Apr 2016 23:57:46 -0700
Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> In updating Bug#18000's patches to the current grep source, I couldn't build with just the first patch installed, so I squashed the first two patches into one. Also, I changed a few more 'int's into 'bool's and fixed a comment or two. The result is attached. Again, I'm not installing this yet, as we're expecting a new release soon.

Thanks for updating, and I'm glad about release of grep-2.25.

Message #19 received at 18800-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 18800-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] dfa: prefer bool at DFA interfaces
Date: Sun, 1 May 2016 23:02:00 -0700

[Message part 1 (text/plain, inline)]

I installed these patches, along with the attached further patch along the same
lines.

[0001-dfa-prefer-bool-for-boolean.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.