GNU bug report logs - #18762
[PATCH] dfa: don't consider RE_DOT_NEWLINE and RE_DOT_NOT_NULL in matching with a bracket expression

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 18 Oct 2014 12:41:03 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 18762 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 18762 <at> debbugs.gnu.org
Subject: Re: bug#18762: [PATCH] dfa: don't consider RE_DOT_NEWLINE and
 RE_DOT_NOT_NULL in matching with a bracket expression
Date: Sun, 19 Oct 2014 08:30:06 +0900

Thanks for the review.

This is a potential bug fix.  However, match_mb_charset function isn't
used in grep and gawk, as DFA treats MBCSET as BACKREF by following code
if `backref' is provided.  Therefore the fix never induces any semantic
change in grep and gawk.

              if (d->states[s].has_mbcset && backref)
                {
                  *backref = 1;
                  goto done;
                }

Essentially, the function is able to be removed.  However, if we regard
DFA as a library,  we should keep it.
This bug report was last modified 10 years and 276 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.