From unknown Wed Jun 25 10:55:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18738: Reference of a uninitialized variable in grep -P Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Wed, 15 Oct 2014 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18738 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: 18738@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14133910525180 (code B ref -1); Wed, 15 Oct 2014 16:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Oct 2014 16:37:32 +0000 Received: from localhost ([127.0.0.1]:44666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeRZr-0001LT-Qe for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36697) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeRZp-0001LJ-8e for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeRZe-0001GD-PF for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZe-0001G9-NJ for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZW-0005kC-0i for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeRZN-00016c-9t for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:09 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:48210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZN-000165-1B for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:01 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 10420E8001F for ; Thu, 16 Oct 2014 00:57:13 +0900 (JST) Received: from mail04.kcn.ne.jp ([61.86.6.183]) by imp02 with bizsmtp id 3TxC1p00J3wvxAM01TxCgk; Thu, 16 Oct 2014 00:57:12 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.77] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail04.kcn.ne.jp (Postfix) with ESMTPA id B8E28129009A for ; Thu, 16 Oct 2014 00:57:12 +0900 (JST) Date: Thu, 16 Oct 2014 00:57:07 +0900 From: Norihiro Tanaka Message-Id: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) A variable validated_boundary is used in grep -P. However, it isn't initialized correctly. I found that it causes reference of the uninitialized variable and wrong result. $ echo . | env LC_ALL=C src/grep -P . $ echo . | env LC_ALL=en_US.utf8 src/grep -P . We expect that they return each one line, but return each no line. Their test cases are also used to judge whether pcre option is enabled in tests. So all tests with pcre option will be skipped by the bug. Sorry, I have no idea to fix the bug. BTW, the bug isn't reproduced in grep-2.20 or prior. From unknown Wed Jun 25 10:55:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Norihiro Tanaka Subject: bug#18738: closed (Re: bug#18738: Reference of a uninitialized variable in grep -P) Message-ID: References: <543EC24D.9010503@cs.ucla.edu> <20141016005706.62FE.27F6AC2D@kcn.ne.jp> X-Gnu-PR-Message: they-closed 18738 X-Gnu-PR-Package: grep Reply-To: 18738@debbugs.gnu.org Date: Wed, 15 Oct 2014 18:53:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1413399183-23947-1" This is a multi-part message in MIME format... ------------=_1413399183-23947-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18738: Reference of a uninitialized variable in grep -P which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18738@debbugs.gnu.org. --=20 18738: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18738 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1413399183-23947-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18738-done) by debbugs.gnu.org; 15 Oct 2014 18:52:04 +0000 Received: from localhost ([127.0.0.1]:44767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeTg3-0006C9-18 for submit@debbugs.gnu.org; Wed, 15 Oct 2014 14:52:03 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:38886) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeTg0-0006Bj-5J for 18738-done@debbugs.gnu.org; Wed, 15 Oct 2014 14:52:01 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DD561A6001D; Wed, 15 Oct 2014 11:51:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JTW3OCeXfRhf; Wed, 15 Oct 2014 11:51:57 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9C5F3A6001A; Wed, 15 Oct 2014 11:51:57 -0700 (PDT) Message-ID: <543EC24D.9010503@cs.ucla.edu> Date: Wed, 15 Oct 2014 11:51:57 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Norihiro Tanaka , 18738-done@debbugs.gnu.org Subject: Re: bug#18738: Reference of a uninitialized variable in grep -P References: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> In-Reply-To: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> Content-Type: multipart/mixed; boundary="------------070604040001060501090907" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18738-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------070604040001060501090907 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. It's a bug in one of the optimizations I recently added to work around the libpcre slownesses with UTF-8. It's also a bug in our test cases, which should have caught the bug. I fixed it with the attached patch. --------------070604040001060501090907 Content-Type: text/x-patch; name="0001-grep-fix-off-by-one-bug-in-P-optimization.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-grep-fix-off-by-one-bug-in-P-optimization.patch" >From bc66a23879afc54063708afce4f79d0928e444c0 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 15 Oct 2014 11:49:49 -0700 Subject: [PATCH] grep: fix off-by-one bug in -P optimization Reported by Norihiro Tanaka in: http://bugs.gnu.org/18738 * src/pcresearch.c (Pexecute): Fix off-by-one bug with validation_boundary. * tests/init.cfg (envvar_check_fail): Catch off-by-one bug. --- src/pcresearch.c | 2 +- tests/init.cfg | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pcresearch.c b/src/pcresearch.c index 6f016b6..1fd5bde 100644 --- a/src/pcresearch.c +++ b/src/pcresearch.c @@ -214,7 +214,7 @@ Pexecute (char const *buf, size_t size, size_t *match_size, options |= PCRE_NO_UTF8_CHECK; int valid_bytes = validated - p; - if (valid_bytes < 0) + if (valid_bytes <= 0) { e = pcre_exec (cre, extra, p, search_bytes, 0, options, sub, NSUB); diff --git a/tests/init.cfg b/tests/init.cfg index 3e9ab03..882feb1 100644 --- a/tests/init.cfg +++ b/tests/init.cfg @@ -47,7 +47,11 @@ require_timeout_() require_pcre_() { - echo . | grep -P . 2>err || skip_ no PCRE support + echo . | grep -P . 2>err + echo . | grep -P . 2>err || { + test $? -eq 1 && fail_ PCRE available, but does not work. + skip_ no PCRE support + } compare /dev/null err || fail_ PCRE available, but stderr not empty. } -- 1.9.3 --------------070604040001060501090907-- ------------=_1413399183-23947-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Oct 2014 16:37:32 +0000 Received: from localhost ([127.0.0.1]:44666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeRZr-0001LT-Qe for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36697) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeRZp-0001LJ-8e for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeRZe-0001GD-PF for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZe-0001G9-NJ for submit@debbugs.gnu.org; Wed, 15 Oct 2014 12:37:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZW-0005kC-0i for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeRZN-00016c-9t for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:09 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:48210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeRZN-000165-1B for bug-grep@gnu.org; Wed, 15 Oct 2014 12:37:01 -0400 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 10420E8001F for ; Thu, 16 Oct 2014 00:57:13 +0900 (JST) Received: from mail04.kcn.ne.jp ([61.86.6.183]) by imp02 with bizsmtp id 3TxC1p00J3wvxAM01TxCgk; Thu, 16 Oct 2014 00:57:12 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.77] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail04.kcn.ne.jp (Postfix) with ESMTPA id B8E28129009A for ; Thu, 16 Oct 2014 00:57:12 +0900 (JST) Date: Thu, 16 Oct 2014 00:57:07 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: Reference of a uninitialized variable in grep -P Message-Id: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) A variable validated_boundary is used in grep -P. However, it isn't initialized correctly. I found that it causes reference of the uninitialized variable and wrong result. $ echo . | env LC_ALL=C src/grep -P . $ echo . | env LC_ALL=en_US.utf8 src/grep -P . We expect that they return each one line, but return each no line. Their test cases are also used to judge whether pcre option is enabled in tests. So all tests with pcre option will be skipped by the bug. Sorry, I have no idea to fix the bug. BTW, the bug isn't reproduced in grep-2.20 or prior. ------------=_1413399183-23947-1-- From unknown Wed Jun 25 10:55:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18738: Reference of a uninitialized variable in grep -P Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Wed, 15 Oct 2014 23:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18738 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Paul Eggert Cc: 18738-done@debbugs.gnu.org Received: via spool by 18738-done@debbugs.gnu.org id=D18738.141341737726645 (code D ref 18738); Wed, 15 Oct 2014 23:57:01 +0000 Received: (at 18738-done) by debbugs.gnu.org; 15 Oct 2014 23:56:17 +0000 Received: from localhost ([127.0.0.1]:44999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeYQS-0006vf-Tu for submit@debbugs.gnu.org; Wed, 15 Oct 2014 19:56:17 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:40140) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeYQO-0006vP-Hr for 18738-done@debbugs.gnu.org; Wed, 15 Oct 2014 19:56:14 -0400 Received: from imp03 (mailgw7.kcn.ne.jp [61.86.15.238]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 28EF7C8004 for <18738-done@debbugs.gnu.org>; Thu, 16 Oct 2014 08:56:10 +0900 (JST) Received: from mail06.kcn.ne.jp ([61.86.6.185]) by imp03 with bizsmtp id 3bwA1p0033zXHqt01bwAqn; Thu, 16 Oct 2014 08:56:10 +0900 X-OrgRCPT: 18738-done@debbugs.gnu.org Received: from [10.120.1.30] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail06.kcn.ne.jp (Postfix) with ESMTPA id D74451BF0021; Thu, 16 Oct 2014 08:56:09 +0900 (JST) Date: Thu, 16 Oct 2014 08:56:05 +0900 From: Norihiro Tanaka In-Reply-To: <543EC24D.9010503@cs.ucla.edu> References: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> <543EC24D.9010503@cs.ucla.edu> Message-Id: <20141016085548.0497.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_543F081D000000000492_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --------_543F081D000000000492_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Paul Eggert wrote: > Thanks for reporting that. It's a bug in one of the optimizations I > recently added to work around the libpcre slownesses with UTF-8. > It's also a bug in our test cases, which should have caught the bug. > I fixed it with the attached patch. Thanks for fixing that. BTW, validation_boundary isn't initialized before pre-searching for an empty line clearly. As it's set to 0 (NULL pointer in many machine) implicitly, it isn't a bug. However, if you don't avoid to initialize it by intent, could you consider an attached patch? --------_543F081D000000000492_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-grep-initialized-validation_boundary-before-pre-sear.patch" Content-Disposition: attachment; filename="0001-grep-initialized-validation_boundary-before-pre-sear.patch" Content-Transfer-Encoding: base64 RnJvbSAzYjJmYjJlODY2ZTNhMGJhNjE1Nzc0ZjFlNzkwYWM2YjRhZThmM2ZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBUaHUsIDE2IE9jdCAyMDE0IDA4OjMyOjU3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gZ3Jl cDogaW5pdGlhbGl6ZWQgdmFsaWRhdGlvbl9ib3VuZGFyeSBiZWZvcmUgcHJlLXNlYXJjaGluZwog Zm9yIGFuIGVtcHR5IGxpbmUgY2xlYXJseS4KCiogc3JjL2dyZXAuYyAobWFpbik6IEluaXRpYWxp emUgdmFsaWRhdGlvbl9ib3VuZGFyeSBiZWZvcmUgcHJlLXNlYXJjaGluZwpmb3IgYW4gZW1wdHkg bGluZSBjbGVhcmx5LgotLS0KIHNyYy9ncmVwLmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL3NyYy9ncmVwLmMgYi9zcmMvZ3JlcC5jCmluZGV4IGRm YzBlNTEuLmEwZjI2MjAgMTAwNjQ0Ci0tLSBhL3NyYy9ncmVwLmMKKysrIGIvc3JjL2dyZXAuYwpA QCAtMjUxNiw2ICsyNTE2LDcgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAvKiBX ZSBuZWVkIG9uZSBieXRlIHByaW9yIGFuZCBvbmUgYWZ0ZXIuICAqLwogICBjaGFyIGVvbGJ5dGVz WzNdID0geyAwLCBlb2xieXRlLCAwIH07CiAgIHNpemVfdCBtYXRjaF9zaXplOworICB2YWxpZGF0 ZWRfYm91bmRhcnkgPSBlb2xieXRlcyArIDE7CiAgIHNraXBfZW1wdHlfbGluZXMgPSAoKGV4ZWN1 dGUgKGVvbGJ5dGVzICsgMSwgMSwgJm1hdGNoX3NpemUsIE5VTEwpID09IDApCiAgICAgICAgICAg ICAgICAgICAgICAgPT0gb3V0X2ludmVydCk7CiAKLS0gCjIuMS4xCgo= --------_543F081D000000000492_MULTIPART_MIXED_-- From unknown Wed Jun 25 10:55:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18738: Reference of a uninitialized variable in grep -P Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Thu, 16 Oct 2014 04:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18738 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: Norihiro Tanaka Cc: 18738-done@debbugs.gnu.org Received: via spool by 18738-done@debbugs.gnu.org id=D18738.141343457227425 (code D ref 18738); Thu, 16 Oct 2014 04:43:02 +0000 Received: (at 18738-done) by debbugs.gnu.org; 16 Oct 2014 04:42:52 +0000 Received: from localhost ([127.0.0.1]:45086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xectn-00078G-7I for submit@debbugs.gnu.org; Thu, 16 Oct 2014 00:42:51 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:37741) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xectj-000786-9J for 18738-done@debbugs.gnu.org; Thu, 16 Oct 2014 00:42:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 111FAA6001A; Wed, 15 Oct 2014 21:42:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lgPRFXZIoxaD; Wed, 15 Oct 2014 21:42:37 -0700 (PDT) Received: from [192.168.1.9] (pool-71-177-17-123.lsanca.dsl-w.verizon.net [71.177.17.123]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 60920A60008; Wed, 15 Oct 2014 21:42:37 -0700 (PDT) Message-ID: <543F4CBC.1030201@cs.ucla.edu> Date: Wed, 15 Oct 2014 21:42:36 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 References: <20141016005706.62FE.27F6AC2D@kcn.ne.jp> <543EC24D.9010503@cs.ucla.edu> <20141016085548.0497.27F6AC2D@kcn.ne.jp> In-Reply-To: <20141016085548.0497.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Norihiro Tanaka wrote: > BTW, validation_boundary isn't initialized before pre-searching for an > empty line Oh, so *that's* the uninitialized variable you were referring to! Sorry, I didn't know. Yes, it should be initialized; it's not portable to assume that NULL < valid pointers. I installed your patch. This whole area should be cleaned up, I think, but not just before a release.