GNU bug report logs - #18736
chroot regression - chroot avoids the chroot() call too eagerly.

Previous Next

Full log

View this message in rfc822 format

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>,  Rogier <rogier777 <at> gmail.com>
Cc: 18736 <at> debbugs.gnu.org
Subject: bug#18736: chroot regression - chroot avoids the chroot() call too eagerly.
Date: Wed, 15 Oct 2014 23:55:11 +0200

On 10/15/2014 07:17 PM, Pádraig Brady wrote:
> I agree with your analysis and that we should revert
> to the previous behavior here, which is done in
> the attached patch.

Hi Padraig,

I also agree that chroot(1) should chroot(2) in such a case, but wouldn't
be the obvious fix to STREQ() the canonicalized DIR against "/" rather
than reverting the whole change - something like the following?

Have a nice day,
Berny

diff --git a/src/chroot.c b/src/chroot.c
index 171ced9..7f60106 100644
--- a/src/chroot.c
+++ b/src/chroot.c
@@ -175,7 +175,13 @@ is_root (const char* dir)
     error (EXIT_CANCELED, errno, _("failed to get attributes of %s"),
            quote (dir));

-  return SAME_INODE (root_ino, arg_st);
+  if (! SAME_INODE (root_ino, arg_st))
+    return false;
+
+  char *resolved = canonicalize_file_name (dir);
+  bool is_res_root = resolved && STREQ ("/", resolved);
+  free (resolved);
+  return is_res_root;
 }

 void
-- 
1.8.4.5

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.