GNU bug report logs - #18734
[PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Colomban Wendling <lists.ban <at> herbesfolles.org>
To: bug-automake <at> gnu.org
Subject: [PATCH] vala: Improper parsing of valac arguments leads to garbage
 in DIST_COMMON
Date: Wed, 15 Oct 2014 17:17:00 +0200

[Message part 1 (text/plain, inline)]

Hi,

The parsing of valac flags is too permissive and incorrectly matches
some input, possibly leading to garbage in DIST_COMMON -- and then,
build failures.

The problem is that parsing of valac flags uses a non-anchored pattern
and so any argument happening to be a subset of a parsed argument will
match it, e.g. `vapi` will match against `--vapi` or `--internal-vapi`.

E.g. when using the following:

	something_VALAFLAGS = --vapidir vapi --pkg foo

`--pkg` is recognized as an interesting argument (and so, added to
`DIST_COMMON`) because `vapi` (the argument for `--vapidir`) matched
against `--vapi`.

Please find attached a patch fixing the issue.

Regards,
Colomban

[0001-vala-Fix-parsing-valac-flags.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.