From unknown Sun Aug 17 00:58:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON Resent-From: Colomban Wendling Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 15 Oct 2014 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18734 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: 18734@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141338779826953 (code B ref -1); Wed, 15 Oct 2014 15:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Oct 2014 15:43:18 +0000 Received: from localhost ([127.0.0.1]:44605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeQjM-00070d-Pz for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:43:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeQKK-0006LI-03 for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeQKD-0007J0-IO for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQKD-0007Iu-GO for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQK8-0008Oe-A1 for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeQK0-0007GF-Tl for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:12 -0400 Received: from a4nancy.globenet.org ([80.67.172.114]:54148 helo=mail.herbesfolles.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQK0-0007F2-L8 for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:04 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) with ESMTPSA id AE51022BB3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=herbesfolles.org; s=alternc; t=1413386221; bh=UxmiLOJN9pBf84yuRk87q7ceM18YLYlhSA/ns8e9C0Q=; h=Date:From:To:Subject; b=UIWStTtSSW776tTOVV+2NDIRWNPTKXZaxTTilP2hN/9iAItmJBWxtIppn+ljQetWb 5XmrsVh8879oEkzpZRULJ+5qia55aWvXOmiGzNbApAhWAN7SLZGv2RfE671KiY9Ztn Aor4fzD4rRbkwbHg7nrE/Rjsad0R9LVPVNPqN3KE= Message-ID: <543E8FEC.7030007@herbesfolles.org> Date: Wed, 15 Oct 2014 17:17:00 +0200 From: Colomban Wendling User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.1.2 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020005010504040701000400" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Wed, 15 Oct 2014 11:43:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------020005010504040701000400 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, The parsing of valac flags is too permissive and incorrectly matches some input, possibly leading to garbage in DIST_COMMON -- and then, build failures. The problem is that parsing of valac flags uses a non-anchored pattern and so any argument happening to be a subset of a parsed argument will match it, e.g. `vapi` will match against `--vapi` or `--internal-vapi`. E.g. when using the following: something_VALAFLAGS = --vapidir vapi --pkg foo `--pkg` is recognized as an interesting argument (and so, added to `DIST_COMMON`) because `vapi` (the argument for `--vapidir`) matched against `--vapi`. Please find attached a patch fixing the issue. Regards, Colomban --------------020005010504040701000400 Content-Type: text/x-patch; name="0001-vala-Fix-parsing-valac-flags.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-vala-Fix-parsing-valac-flags.patch" >From 16bb54572db217e14e0a024bacf33ab693ea10ec Mon Sep 17 00:00:00 2001 From: Colomban Wendling Date: Wed, 15 Oct 2014 16:22:13 +0200 Subject: [PATCH] vala: Fix parsing valac flags To: lists.ban@herbesfolles.org When parsing valac flags, ensure complete matches not to e.g. match `vapi` against `--vapi` or `--internal-vapi`. This fixes parsing when one of the flags value is a subset of one of the flags we match. E.g. when using the following: something_VALAFLAGS=--vapidir vapi --pkg foo `--pkg` used to be recognized as an interesting argument (and so, added to `DIST_COMMON`) because `vapi` (the argument for `--vapidir`) matched against `--vapi`. --- bin/automake.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/automake.in b/bin/automake.in index 4cee0d0..832b208 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -5436,8 +5436,8 @@ sub lang_vala_finish_target my $lastflag = ''; foreach my $flag ($flags->value_as_list_recursive) { - if (grep (/$lastflag/, ('-H', '-h', '--header', '--internal-header', - '--vapi', '--internal-vapi', '--gir'))) + if (grep (/^$lastflag$/, ('-H', '-h', '--header', '--internal-header', + '--vapi', '--internal-vapi', '--gir'))) { my $headerfile = "\$(srcdir)/$flag"; $output_rules .= "$headerfile: \$(srcdir)/${derived}_vala.stamp\n" -- 2.1.1 --------------020005010504040701000400-- From unknown Sun Aug 17 00:58:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON References: <543E8FEC.7030007@herbesfolles.org> Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 02 Apr 2020 01:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18734 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: lists.ban@herbesfolles.org Cc: 18734@debbugs.gnu.org Received: via spool by 18734-submit@debbugs.gnu.org id=B18734.15857899905076 (code B ref 18734); Thu, 02 Apr 2020 01:14:02 +0000 Received: (at 18734) by debbugs.gnu.org; 2 Apr 2020 01:13:10 +0000 Received: from localhost ([127.0.0.1]:38912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJoPu-0001Jo-5T for submit@debbugs.gnu.org; Wed, 01 Apr 2020 21:13:10 -0400 Received: from freefriends.org ([96.88.95.60]:39088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jJoPs-0001Ja-1M for 18734@debbugs.gnu.org; Wed, 01 Apr 2020 21:13:08 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 0321D60J030101 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Apr 2020 19:13:07 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 0321D4Dq030100; Wed, 1 Apr 2020 19:13:04 -0600 Date: Wed, 1 Apr 2020 19:13:04 -0600 Message-Id: <202004020113.0321D4Dq030100@freefriends.org> From: Karl Berry In-Reply-To: <543E8FEC.7030007@herbesfolles.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Colomban - back on your automake bug report from six years ago (sorry!): Date: Wed, 15 Oct 2014 17:17:00 +0200 From: Colomban Wendling [...] The problem is that parsing of valac flags uses a non-anchored pattern and so any argument happening to be a subset of a parsed argument will match it, e.g. `vapi` will match against `--vapi` or `--internal-vapi`. [... patch ...] --- a/bin/automake.in +++ b/bin/automake.in @@ -5436,8 +5436,8 @@ sub lang_vala_finish_target foreach my $flag ($flags->value_as_list_recursive) { - if (grep (/$lastflag/, ('-H', '-h', '--header', '--internal-header', - '--vapi', '--internal-vapi', '--gir'))) + if (grep (/^$lastflag$/, ('-H', '-h', '--header', '--internal-header', + '--vapi', '--internal-vapi', '--gir'))) { Indeed. I don't see a problem with applying your patch, but before I do, I just wondered if anything else had come up with vala that needs to be fixed? Please advise if you can. I've never used vala myself, so wouldn't know. --thanks, karl. From unknown Sun Aug 17 00:58:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON References: <543E8FEC.7030007@herbesfolles.org> Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 06 Apr 2020 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18734 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: lists.ban@herbesfolles.org Cc: 18734@debbugs.gnu.org Received: via spool by 18734-submit@debbugs.gnu.org id=B18734.158613354532124 (code B ref 18734); Mon, 06 Apr 2020 00:40:02 +0000 Received: (at 18734) by debbugs.gnu.org; 6 Apr 2020 00:39:05 +0000 Received: from localhost ([127.0.0.1]:46933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLFn6-0008M3-Op for submit@debbugs.gnu.org; Sun, 05 Apr 2020 20:39:04 -0400 Received: from freefriends.org ([96.88.95.60]:60654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLFn5-0008Lm-5A; Sun, 05 Apr 2020 20:39:03 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 0360d14Y005486 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 5 Apr 2020 18:39:02 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 0360d1cf005485; Sun, 5 Apr 2020 18:39:01 -0600 Date: Sun, 5 Apr 2020 18:39:01 -0600 Message-Id: <202004060039.0360d1cf005485@freefriends.org> From: Karl Berry In-Reply-To: <543E8FEC.7030007@herbesfolles.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) - if (grep (/$lastflag/, ('-H', '-h', '--header', '--internal-header', - '--vapi', '--internal-vapi', '--gir'))) + if (grep (/^$lastflag$/, ('-H', '-h', '--header', '--internal-header', + '--vapi', '--internal-vapi', '--gir'))) { I installed this change and am closing the bug. Thanks. --karl From unknown Sun Aug 17 00:58:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Colomban Wendling Subject: bug#18734: closed (Re: bug#18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON) Message-ID: References: <202004060039.0360d1cf005485@freefriends.org> <543E8FEC.7030007@herbesfolles.org> X-Gnu-PR-Message: they-closed 18734 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: patch Reply-To: 18734@debbugs.gnu.org Date: Mon, 06 Apr 2020 00:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1586133602-32310-1" This is a multi-part message in MIME format... ------------=_1586133602-32310-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage = in DIST_COMMON which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18734@debbugs.gnu.org. --=20 18734: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18734 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1586133602-32310-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18734-done) by debbugs.gnu.org; 6 Apr 2020 00:39:05 +0000 Received: from localhost ([127.0.0.1]:46935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLFn6-0008M5-VU for submit@debbugs.gnu.org; Sun, 05 Apr 2020 20:39:05 -0400 Received: from freefriends.org ([96.88.95.60]:60654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jLFn5-0008Lm-5A; Sun, 05 Apr 2020 20:39:03 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 0360d14Y005486 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 5 Apr 2020 18:39:02 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 0360d1cf005485; Sun, 5 Apr 2020 18:39:01 -0600 Date: Sun, 5 Apr 2020 18:39:01 -0600 Message-Id: <202004060039.0360d1cf005485@freefriends.org> From: Karl Berry To: lists.ban@herbesfolles.org Subject: Re: bug#18734: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON In-Reply-To: <543E8FEC.7030007@herbesfolles.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18734-done Cc: 18734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) - if (grep (/$lastflag/, ('-H', '-h', '--header', '--internal-header', - '--vapi', '--internal-vapi', '--gir'))) + if (grep (/^$lastflag$/, ('-H', '-h', '--header', '--internal-header', + '--vapi', '--internal-vapi', '--gir'))) { I installed this change and am closing the bug. Thanks. --karl ------------=_1586133602-32310-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Oct 2014 15:43:18 +0000 Received: from localhost ([127.0.0.1]:44605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeQjM-00070d-Pz for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:43:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeQKK-0006LI-03 for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeQKD-0007J0-IO for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQKD-0007Iu-GO for submit@debbugs.gnu.org; Wed, 15 Oct 2014 11:17:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQK8-0008Oe-A1 for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XeQK0-0007GF-Tl for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:12 -0400 Received: from a4nancy.globenet.org ([80.67.172.114]:54148 helo=mail.herbesfolles.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XeQK0-0007F2-L8 for bug-automake@gnu.org; Wed, 15 Oct 2014 11:17:04 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) with ESMTPSA id AE51022BB3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=herbesfolles.org; s=alternc; t=1413386221; bh=UxmiLOJN9pBf84yuRk87q7ceM18YLYlhSA/ns8e9C0Q=; h=Date:From:To:Subject; b=UIWStTtSSW776tTOVV+2NDIRWNPTKXZaxTTilP2hN/9iAItmJBWxtIppn+ljQetWb 5XmrsVh8879oEkzpZRULJ+5qia55aWvXOmiGzNbApAhWAN7SLZGv2RfE671KiY9Ztn Aor4fzD4rRbkwbHg7nrE/Rjsad0R9LVPVNPqN3KE= Message-ID: <543E8FEC.7030007@herbesfolles.org> Date: Wed, 15 Oct 2014 17:17:00 +0200 From: Colomban Wendling User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.1.2 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: [PATCH] vala: Improper parsing of valac arguments leads to garbage in DIST_COMMON Content-Type: multipart/mixed; boundary="------------020005010504040701000400" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 15 Oct 2014 11:43:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------020005010504040701000400 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, The parsing of valac flags is too permissive and incorrectly matches some input, possibly leading to garbage in DIST_COMMON -- and then, build failures. The problem is that parsing of valac flags uses a non-anchored pattern and so any argument happening to be a subset of a parsed argument will match it, e.g. `vapi` will match against `--vapi` or `--internal-vapi`. E.g. when using the following: something_VALAFLAGS = --vapidir vapi --pkg foo `--pkg` is recognized as an interesting argument (and so, added to `DIST_COMMON`) because `vapi` (the argument for `--vapidir`) matched against `--vapi`. Please find attached a patch fixing the issue. Regards, Colomban --------------020005010504040701000400 Content-Type: text/x-patch; name="0001-vala-Fix-parsing-valac-flags.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-vala-Fix-parsing-valac-flags.patch" >From 16bb54572db217e14e0a024bacf33ab693ea10ec Mon Sep 17 00:00:00 2001 From: Colomban Wendling Date: Wed, 15 Oct 2014 16:22:13 +0200 Subject: [PATCH] vala: Fix parsing valac flags To: lists.ban@herbesfolles.org When parsing valac flags, ensure complete matches not to e.g. match `vapi` against `--vapi` or `--internal-vapi`. This fixes parsing when one of the flags value is a subset of one of the flags we match. E.g. when using the following: something_VALAFLAGS=--vapidir vapi --pkg foo `--pkg` used to be recognized as an interesting argument (and so, added to `DIST_COMMON`) because `vapi` (the argument for `--vapidir`) matched against `--vapi`. --- bin/automake.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/automake.in b/bin/automake.in index 4cee0d0..832b208 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -5436,8 +5436,8 @@ sub lang_vala_finish_target my $lastflag = ''; foreach my $flag ($flags->value_as_list_recursive) { - if (grep (/$lastflag/, ('-H', '-h', '--header', '--internal-header', - '--vapi', '--internal-vapi', '--gir'))) + if (grep (/^$lastflag$/, ('-H', '-h', '--header', '--internal-header', + '--vapi', '--internal-vapi', '--gir'))) { my $headerfile = "\$(srcdir)/$flag"; $output_rules .= "$headerfile: \$(srcdir)/${derived}_vala.stamp\n" -- 2.1.1 --------------020005010504040701000400-- ------------=_1586133602-32310-1--