From unknown Tue Aug 19 12:50:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18718 <18718@debbugs.gnu.org> To: bug#18718 <18718@debbugs.gnu.org> Subject: Status: Encrypted messages expose Bcc identities Reply-To: bug#18718 <18718@debbugs.gnu.org> Date: Tue, 19 Aug 2025 19:50:36 +0000 retitle 18718 Encrypted messages expose Bcc identities reassign 18718 emacs,gnus submitter 18718 Jens Lechtenboerger severity 18718 important tag 18718 fixed security thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 14 12:01:13 2014 Received: (at submit) by debbugs.gnu.org; 14 Oct 2014 16:01:13 +0000 Received: from localhost ([127.0.0.1]:43438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xe4XA-0000YQ-3E for submit@debbugs.gnu.org; Tue, 14 Oct 2014 12:01:12 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:54709) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xe4X6-0000TH-7h for submit@debbugs.gnu.org; Tue, 14 Oct 2014 12:01:10 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 38F584657A for ; Tue, 14 Oct 2014 18:01:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) (using TLS with cipher AES256-GCM-SHA384) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTPS id 2QN3ZDqjT2nC for ; Tue, 14 Oct 2014 18:01:03 +0200 (CEST) From: Jens Lechtenboerger To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: Encrypted messages expose Bcc identities X-Debbugs-Version: 5.130012 X-Debbugs-Package: gnus Date: Tue, 14 Oct 2014 18:01:02 +0200 Message-ID: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi there, the Bcc handling of Message is broken for encrypted e-mails, as Bcc=E2=80=99ed identities are exposed. I only tested GnuPG via epa, but I believe all methods to be affected. Steps to reproduce. 1. Get rid of encrypt-to, default-recipient, and the like in gpg.conf. 2. Set epg-debug to t. 3. Send an encrypted e-mail to yourself (just one To address, no Bcc yet). Read it. Note that buffer *epg-debug* mentions that the message was encrypted to just one key (including key ID and e-mail address). 4. Send an encrypted e-mail to yourself, with one To address and one Bcc address. Read the mail received under the To address, where you should not be able to identify the Bcc recipient. Note that buffer *epg-debug* mentions that the message was encrypted to two keys (including both key IDs and e-mail addresses). The Bcc recipient is clearly visible. The identities of *blind* recipients must not be exposed in this way. The Right Thing is explained there: http://lists.gnupg.org/pipermail/gnupg-users/2014-April/049394.html An academic paper explaining the problem is available there: http://crypto.stanford.edu/portia/papers/bb-bcc.pdf On 2014-09-21 I posted some suggestions to the ding mailing list concerning my package DefaultEncrypt, which contains a workaround. As I don=E2=80=99t know how to link to that message, I=E2=80=99m copying re= levant parts here. A discussion version of DefaultEncrypt is available there: http://informationelle-selbstbestimmung-im-internet.de/emacs/jl-encrypt-4.1= -discussion.el http://informationelle-selbstbestimmung-im-internet.de/emacs/jl-encrypt-4.1= -discussion.el.asc (No new functionality is added. This is not a regular release.) In DefaultEncrypt I added a test to warn against such cases. In the version linked above, mml-secure-bcc-is-safe implements that test. I suggest to copy that function (and its prerequisites) into mml-sec.el. Then, mml-secure-bcc-is-safe can be added as message-send-hook, which I suggest as default until proper Bcc handling is implemented. Best wishes Jens Ma Gnus v0.12 GNU Emacs 24.3.94.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0) of 2014-10-02 on PC From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 03 16:23:51 2015 Received: (at control) by debbugs.gnu.org; 3 Feb 2015 21:23:51 +0000 Received: from localhost ([127.0.0.1]:33189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIkwo-0004AI-VZ for submit@debbugs.gnu.org; Tue, 03 Feb 2015 16:23:51 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:55300 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YIkwm-0004A8-KX for control@debbugs.gnu.org; Tue, 03 Feb 2015 16:23:49 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YIkwm-0003cO-6D for control@debbugs.gnu.org; Tue, 03 Feb 2015 16:23:48 -0500 Date: Tue, 03 Feb 2015 16:23:48 -0500 Message-Id: Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 18718 19407 19479 19548 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 16:34:59 2015 Received: (at 18718) by debbugs.gnu.org; 26 Dec 2015 21:34:59 +0000 Received: from localhost ([127.0.0.1]:42219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCwUN-0002S0-4F for submit@debbugs.gnu.org; Sat, 26 Dec 2015 16:34:59 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45055) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCwUM-0002Rs-2S for 18718@debbugs.gnu.org; Sat, 26 Dec 2015 16:34:58 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCwU0-0005Nh-U2; Sat, 26 Dec 2015 22:34:37 +0100 From: Lars Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> Date: Sat, 26 Dec 2015 22:34:36 +0100 In-Reply-To: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Tue, 14 Oct 2014 18:01:02 +0200") Message-ID: <8737uoq4gj.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCwU0-0005Nh-U2 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451770477.42107@vxOUqNPpGrU7WO7ddVIFiQ X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > 4. Send an encrypted e-mail to yourself, with one To address and one > Bcc address. Read the mail received under the To address, where > you should not be able to identify the Bcc recipient. > Note that buffer *epg-debug* mentions that the message was > encrypted to two keys (including both key IDs and e-mail > addresses). The Bcc recipient is clearly visible. [...] > On 2014-09-21 I posted some suggestions to the ding mailing list > concerning my package DefaultEncrypt, which contains a workaround. Would it be possible for you to create a patch for this against the version of Message in 25.1? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 10:51:55 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 15:51:55 +0000 Received: from localhost ([127.0.0.1]:44510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDDbu-0004gb-Kt for submit@debbugs.gnu.org; Sun, 27 Dec 2015 10:51:54 -0500 Received: from mx1.mailbox.org ([80.241.60.212]:35697) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDDbt-0004gM-7N for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 10:51:53 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id E357F42218; Sun, 27 Dec 2015 16:51:46 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id X_ZpRS65LTZ4; Sun, 27 Dec 2015 16:51:42 +0100 (CET) From: Jens Lechtenboerger To: Lars Ingebrigtsen Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> OpenPGP: id=0xA142FD84; url=http://www.informationelle-selbstbestimmung-im-internet.de/A142FD84.asc Date: Sun, 27 Dec 2015 16:51:40 +0100 In-Reply-To: <8737uoq4gj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 26 Dec 2015 22:34:36 +0100") Message-ID: <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015-12-26, at 22:34, Lars Ingebrigtsen wrote: > Jens Lechtenboerger writes: > >> 4. Send an encrypted e-mail to yourself, with one To address and one >> Bcc address. Read the mail received under the To address, where >> you should not be able to identify the Bcc recipient. >> Note that buffer *epg-debug* mentions that the message was >> encrypted to two keys (including both key IDs and e-mail >> addresses). The Bcc recipient is clearly visible. > > [...] > >> On 2014-09-21 I posted some suggestions to the ding mailing list >> concerning my package DefaultEncrypt, which contains a workaround. > > Would it be possible for you to create a patch for this against the > version of Message in 25.1? A patch is attached. The new function mml-secure-bcc-is-safe does nothing on its own but can be added to message-send-hook or called from message-send and friends. Concerning documentation: I=E2=80=99m currently involved in a refactoring effort for encryption related functionality, which takes place in the Gnus git under branch mml-refactoring. There, Message documentation is already extended with a section =E2=80=9CBcc Warning=E2=80= =9D which could be extended. (Also, gnus-subsetp, which is part of this patch, is already present in the branch mml-refactoring.) Best wishes Jens --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Identify-unsafe-combinations-of-Bcc-and-encryption.patch >From f9fb01a6b013963e0d8021b5da587cc548c1ea9a Mon Sep 17 00:00:00 2001 From: Jens Lechtenboerger Date: Sun, 27 Dec 2015 16:29:02 +0100 Subject: [PATCH] Identify unsafe combinations of Bcc and encryption --- ChangeLog.2 | 8 ++++++++ lisp/gnus/gnus-util.el | 10 ++++++++++ lisp/gnus/mml-sec.el | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 64 insertions(+) diff --git a/ChangeLog.2 b/ChangeLog.2 index 6d72663..971a3b5 100644 --- a/ChangeLog.2 +++ b/ChangeLog.2 @@ -1,3 +1,11 @@ +2015-12-27 Jens Lechtenboerger + + Identify unsafe combinations of Bcc and encryption + + * lisp/gnus/gnus-util.el (gnus-subsetp): New function + * lisp/gnus/mml-sec.el (mml-secure-safe-bcc-list): New variable + * lisp/gnus/mml-sec.el (mml-secure-bcc-is-safe): New function + 2015-12-27 Lars Ingebrigtsen * shr.el (shr-descend): Allow using lambdas in external functions. diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el index 40e2dcf..933387d 100644 --- a/lisp/gnus/gnus-util.el +++ b/lisp/gnus/gnus-util.el @@ -1989,6 +1989,16 @@ to case differences." (defun gnus-timer--function (timer) (elt timer 5))) +(defun gnus-subsetp (list1 list2) + "Return t if LIST1 is a subset of LIST2. +Similar to `subsetp' but use member for element test so that this works for +lists of strings." + (when (and (listp list1) (listp list2)) + (if list1 + (and (member (car list1) list2) + (gnus-subsetp (cdr list1) list2)) + t))) + (provide 'gnus-util) ;;; gnus-util.el ends here diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index 45da937..dbae280 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -122,6 +122,21 @@ Whether the passphrase is cached at all is controlled by :group 'message :type 'integer) +(defcustom mml-secure-safe-bcc-list nil + "List of e-mail addresses that are safe to use in Bcc headers. +EasyPG encrypts e-mails to Bcc addresses, and the encrypted e-mail +by default identifies the used encryption keys, giving away the +Bcc'ed identities. Clearly, this contradicts the original goal of +*blind* copies. +For an academic paper explaining the problem, see URL +`http://crypto.stanford.edu/portia/papers/bb-bcc.pdf'. +Use this variable to specify e-mail addresses whose owners do not +mind if they are identifiable as recipients. This may be useful if +you use Bcc headers to encrypt e-mails to yourself." + :version "25.1" + :group 'message + :type '(repeat string)) + ;;; Configuration/helper functions (defun mml-signencrypt-style (method &optional style) @@ -272,6 +287,37 @@ Use METHOD if given. Else use `mml-secure-method' or (interactive) (mml-secure-part "smime")) +(defun mml-secure-is-encrypted-p () + "Check whether secure encrypt tag is present." + (save-excursion + (goto-char (point-min)) + (re-search-forward + (concat "^" (regexp-quote mail-header-separator) "\n" + "<#secure[^>]+encrypt") + nil t))) + +(defun mml-secure-bcc-is-safe () + "Check whether usage of Bcc is safe (or absent). +Bcc usage is safe in two cases: first, if the current message does +not contain an MML secure encrypt tag; +second, if the Bcc addresses are a subset of `mml-secure-safe-bcc-list'. +In all other cases, ask the user whether Bcc usage is safe. +Raise error if user answers no. +Note that this function does not produce a meaningful return value: +either an error is raised or not." + (when (mml-secure-is-encrypted-p) + (let ((bcc (mail-strip-quoted-names (message-fetch-field "bcc")))) + (when bcc + ;; Split recipients at "," boundary, omit empty strings (t), + ;; and strip whitespace. + (let ((bcc-list (split-string hdr "," t "\\s-+"))) + (unless (gnus-subsetp bcc-list mml-secure-safe-bcc-list) + (unless (yes-or-no-p "Message for encryption contains Bcc header.\ + This may give away all Bcc'ed identities to all recipients.\ + Are you sure that this is safe?\ + (Customize `mml-secure-safe-bcc-list' to avoid this warning.) ") + (error "Aborted")))))))) + ;; defuns that add the proper <#secure ...> tag to the top of the message body (defun mml-secure-message (method &optional modesym) (let ((mode (prin1-to-string modesym)) -- 1.9.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 12:59:34 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 17:59:34 +0000 Received: from localhost ([127.0.0.1]:44666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDFbR-0002hw-R4 for submit@debbugs.gnu.org; Sun, 27 Dec 2015 12:59:33 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:55716) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDFbP-0002hk-EL for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 12:59:32 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDFb3-0001UO-1d; Sun, 27 Dec 2015 18:59:09 +0100 From: Lars Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> Date: Sun, 27 Dec 2015 18:59:08 +0100 In-Reply-To: <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Sun, 27 Dec 2015 16:51:40 +0100") Message-ID: <87vb7jepsj.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDFb3-0001UO-1d X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451843950.02812@dzKKKlwwzF8zCZTrz/MHZg X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > A patch is attached. The new function mml-secure-bcc-is-safe does > nothing on its own but can be added to message-send-hook or called > from message-send and friends. Looks good. Do you have Emacs copyright assignment papers on file? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 13:19:30 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 18:19:30 +0000 Received: from localhost ([127.0.0.1]:44699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDFuj-0003DW-Ro for submit@debbugs.gnu.org; Sun, 27 Dec 2015 13:19:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46273) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDFuf-0003DF-CE for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 13:19:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDFuW-0000wU-Gc for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 13:19:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDFuW-0000wL-ES; Sun, 27 Dec 2015 13:19:16 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3293 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aDFuU-0008Jg-5b; Sun, 27 Dec 2015 13:19:15 -0500 Date: Sun, 27 Dec 2015 20:20:02 +0200 Message-Id: <83wprzg3e5.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87vb7jepsj.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 27 Dec 2015 18:59:08 +0100) Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> <87vb7jepsj.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 18718 Cc: jens.lechtenboerger@fsfe.org, 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Lars Ingebrigtsen > Date: Sun, 27 Dec 2015 18:59:08 +0100 > Cc: 18718@debbugs.gnu.org > > Jens Lechtenboerger writes: > > > A patch is attached. The new function mml-secure-bcc-is-safe does > > nothing on its own but can be added to message-send-hook or called > > from message-send and friends. > > Looks good. Do you have Emacs copyright assignment papers on file? He does. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 13:27:11 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 18:27:11 +0000 Received: from localhost ([127.0.0.1]:44717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDG2B-0003QR-9O for submit@debbugs.gnu.org; Sun, 27 Dec 2015 13:27:11 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:49125) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDG2A-0003QK-6r for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 13:27:10 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDG1p-0001rk-4S; Sun, 27 Dec 2015 19:26:49 +0100 From: Lars Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> Date: Sun, 27 Dec 2015 19:26:48 +0100 In-Reply-To: <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Sun, 27 Dec 2015 16:51:40 +0100") Message-ID: <87h9j3eoif.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDG1p-0001rk-4S X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451845609.38189@Wt5FplwpvV115Q5fyd57IA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > A patch is attached. The new function mml-secure-bcc-is-safe does > nothing on its own but can be added to message-send-hook or called > from message-send and friends. I've applied the patch, but there were bugs. It referred to an unbound variable called "hdr", which I've changed to bcc. Please look over the resulting code. Also, I get these warnings: In end of data: gnus/mml-sec.el:429:1:Warning: the following functions are not known to be defined: mail-strip-quoted-names, message-fetch-field, gnus-subsetp -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 15:09:28 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 20:09:28 +0000 Received: from localhost ([127.0.0.1]:44832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHdA-00042q-HA for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:09:28 -0500 Received: from mx1.mailbox.org ([80.241.60.212]:50181) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHd8-00042c-NY for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 15:09:27 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 9239042218; Sun, 27 Dec 2015 21:09:20 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id VyJi6dGYaFKP; Sun, 27 Dec 2015 21:09:19 +0100 (CET) From: Jens Lechtenboerger To: Lars Ingebrigtsen Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> <87h9j3eoif.fsf@gnus.org> OpenPGP: id=0xA142FD84; url=http://www.informationelle-selbstbestimmung-im-internet.de/A142FD84.asc Date: Sun, 27 Dec 2015 21:09:17 +0100 In-Reply-To: <87h9j3eoif.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 27 Dec 2015 19:26:48 +0100") Message-ID: <87h9j37ixe.fsf@informationelle-selbstbestimmung-im-internet.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain On 2015-12-27, at 19:26, Lars Ingebrigtsen wrote: > Jens Lechtenboerger writes: > >> A patch is attached. The new function mml-secure-bcc-is-safe does >> nothing on its own but can be added to message-send-hook or called >> from message-send and friends. > > I've applied the patch, but there were bugs. It referred to an unbound > variable called "hdr", which I've changed to bcc. Please look over the > resulting code. You are right. I tested against the wrong load-path. Sorry. > Also, I get these warnings: > > In end of data: > gnus/mml-sec.el:429:1:Warning: the following functions are not known to be > defined: mail-strip-quoted-names, message-fetch-field, gnus-subsetp Indeed. Actually, when should I use require, when autoload? In particular, for gnus-util both variants are used in different files, and I fail to see a pattern. As mml-sec just uses autoloads, the attached patch adds more of them to avoid the warnings. Best wishes Jens --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-More-autoloads-to-avoid-compile-warnings.patch >From 1f54b417fd487880f794cfff2eecceb87a07d4d8 Mon Sep 17 00:00:00 2001 From: Jens Lechtenboerger Date: Sun, 27 Dec 2015 20:40:15 +0100 Subject: [PATCH 2/2] More autoloads to avoid compile warnings --- lisp/gnus/mml-sec.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index dbae280..d7702d7 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -25,10 +25,13 @@ (eval-when-compile (require 'cl)) +(autoload 'gnus-subsetp "gnus-util") +(autoload 'mail-strip-quoted-names "mail-utils") (autoload 'mml2015-sign "mml2015") (autoload 'mml2015-encrypt "mml2015") (autoload 'mml1991-sign "mml1991") (autoload 'mml1991-encrypt "mml1991") +(autoload 'message-fetch-field "message") (autoload 'message-goto-body "message") (autoload 'mml-insert-tag "mml") (autoload 'mml-smime-sign "mml-smime") -- 1.9.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 15:13:56 2015 Received: (at 18718) by debbugs.gnu.org; 27 Dec 2015 20:13:56 +0000 Received: from localhost ([127.0.0.1]:44842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHhU-00049Y-3C for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:13:56 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53511) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHhQ-00049O-Rh for 18718@debbugs.gnu.org; Sun, 27 Dec 2015 15:13:54 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDHh4-0003DZ-Uc; Sun, 27 Dec 2015 21:13:31 +0100 From: Lars Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: Encrypted messages expose Bcc identities References: <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <8737uoq4gj.fsf@gnus.org> <8760zjyjn7.fsf@informationelle-selbstbestimmung-im-internet.de> <87h9j3eoif.fsf@gnus.org> <87h9j37ixe.fsf@informationelle-selbstbestimmung-im-internet.de> Date: Sun, 27 Dec 2015 21:13:30 +0100 In-Reply-To: <87h9j37ixe.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Sun, 27 Dec 2015 21:09:17 +0100") Message-ID: <87a8ovd505.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDHh4-0003DZ-Uc X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451852011.27381@7Al/nMjsaUoWRHZwI0Eehg X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > Indeed. Actually, when should I use require, when autoload? In > particular, for gnus-util both variants are used in different files, > and I fail to see a pattern. As mml-sec just uses autoloads, the > attached patch adds more of them to avoid the warnings. Thanks; applied. There's no hard and fast rule, especially with these libraries that tend to infloop if you add too many requires. :-) (That is, a requires b that requires c that requires a...) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 15:14:08 2015 Received: (at control) by debbugs.gnu.org; 27 Dec 2015 20:14:08 +0000 Received: from localhost ([127.0.0.1]:44847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHhg-0004AZ-Ah for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:14:08 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53517) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDHhe-0004AR-Mv for control@debbugs.gnu.org; Sun, 27 Dec 2015 15:14:06 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDHhJ-0003Dm-ME for control@debbugs.gnu.org; Sun, 27 Dec 2015 21:13:45 +0100 Date: Sun, 27 Dec 2015 21:13:44 +0100 Message-Id: <878u4fd4zr.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18718 X-MailScanner-ID: 1aDHhJ-0003Dm-ME X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451852025.91881@RgtY/kKdnXTqfZMTjCAHpQ X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 18718 fixed close 18718 25.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 02 09:49:50 2016 Received: (at 18718) by debbugs.gnu.org; 2 Jan 2016 14:49:50 +0000 Received: from localhost ([127.0.0.1]:34341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFNV8-000192-8e for submit@debbugs.gnu.org; Sat, 02 Jan 2016 09:49:50 -0500 Received: from mx1.mailbox.org ([80.241.60.212]:45837) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFNV6-00018o-I0 for 18718@debbugs.gnu.org; Sat, 02 Jan 2016 09:49:48 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 4D597417D1 for <18718@debbugs.gnu.org>; Sat, 2 Jan 2016 15:49:42 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id ct2bvLVY8AQn for <18718@debbugs.gnu.org>; Sat, 2 Jan 2016 15:49:41 +0100 (CET) From: Jens Lechtenboerger To: 18718@debbugs.gnu.org Subject: Re: bug#18718 acknowledged by developer (control message for bug #18718) References: <878u4fd4zr.fsf@gnus.org> <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> OpenPGP: id=0xA142FD84; url=http://www.informationelle-selbstbestimmung-im-internet.de/A142FD84.asc Date: Sat, 02 Jan 2016 15:49:40 +0100 In-Reply-To: (GNU bug Tracking System's message of "Sun, 27 Dec 2015 15:15:02 -0500") Message-ID: <878u48m3y3.fsf@informationelle-selbstbestimmung-im-internet.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18718 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I don=E2=80=99t think that mml-secure-bcc-is-safe gets called so far, which means that the bug still exists. As I wrote concerning the patch, the function could be added to message-send-hook or called from message-send. I don=E2=80=99t know what would be preferable. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 04:08:34 2016 Received: (at 18718) by debbugs.gnu.org; 3 Jan 2016 09:08:34 +0000 Received: from localhost ([127.0.0.1]:35788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFeeQ-0003z4-7X for submit@debbugs.gnu.org; Sun, 03 Jan 2016 04:08:34 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:39900) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFeeO-0003yw-OJ for 18718@debbugs.gnu.org; Sun, 03 Jan 2016 04:08:33 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aFee0-0007GJ-Ub; Sun, 03 Jan 2016 10:08:08 +0100 From: Lars Magne Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: acknowledged by developer (control message for bug #18718) References: <878u4fd4zr.fsf@gnus.org> <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <878u48m3y3.fsf@informationelle-selbstbestimmung-im-internet.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEWHMoVCPKpCPq1IQayQ ue9CP68pCyFqVZxeOpp9JYcVl66TAAACP0lEQVQ4jXXSPW/bMBAGYDaJEmWUunQsLyCQbkYCN/FW oISFbgqDA5ytQ0C7mwCrproJsBXLW4CisfNve0cpqo3aN/iDD44vKZ1QYrfCy0394QpAjISB64vr 99e+5uHq8rW3+WNQiAC3qnrdDOrnVYUE2+vYb7+p43gHyrNb4dIwzaZbcF/PcRrWLkzLtA7+wUC4 LOz9FMt5Goqy6rJHJ1rr5Bjv+U8qQhEAKv691lxZ1WSbc3EEAAj44Nd1EnYQgCGCZQtZc2DJHVEU wwUlfJuQOJ9p7kJxFDF8pDVrGTa0DkZSuJQRxLzTj9NcJy6jo0gPFGCAz/r9xUPF2dJvRZ0EibUL giIwSJt4iOET7y7sI4F7p0zMEMgoRs7O9cs4pw5KB/DhwIea2bW1lsCVaEA2GRHcEHDlzrkVnSbi DEmw1E+8PiaoS4K3DFg3kPFHqUzbITuwj66oy74yLUQETcbCuYIBmowYfuuhhzHB6qoJDyiJQBct uFW/PRV9SnqGX98gQz4vgaEL3hBw/Jgu+Av5hrQVSv86hjM7oYelkx4D8FZ3kWzglkFn/k359+Gf 7tDxPQgK/26pQ0FsLnI9TOzQQzNo1GFMjOZEJ4n93IHyQHOlltpN7ZMda/2l33WAQjrWlDImDNhm UKdSakRzYAV3HHdgaEB5dIfudEbcDC/6DoZUJ0Uxyf0tOvDTfqZd7vIk2AZfDyfJQutz/A+wR0Mn qj2Ag+fzPu6DnToE94dAHICRQLG/AhSvO/UGFf4FD4c1mTjj/FoAAAAASUVORK5CYII= Date: Sun, 03 Jan 2016 10:08:08 +0100 In-Reply-To: <878u48m3y3.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Sat, 02 Jan 2016 15:49:40 +0100") Message-ID: User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1aFee0-0007GJ-Ub X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1452416890.67044@rD7zcJh+8BTHVib/wvqa8g X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > I don=92t think that mml-secure-bcc-is-safe gets called so far, which > means that the bug still exists. > > As I wrote concerning the patch, the function could be added to > message-send-hook or called from message-send. I don=92t know what > would be preferable. Calling from message-send sounds better, I think. Could you send a patch? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 09:57:46 2016 Received: (at 18718) by debbugs.gnu.org; 3 Jan 2016 14:57:46 +0000 Received: from localhost ([127.0.0.1]:36781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFk6L-00047A-Vd for submit@debbugs.gnu.org; Sun, 03 Jan 2016 09:57:46 -0500 Received: from mx1.mailbox.org ([80.241.60.212]:44563) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFk6K-00046w-2O for 18718@debbugs.gnu.org; Sun, 03 Jan 2016 09:57:44 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id D34574049C; Sun, 3 Jan 2016 15:57:37 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id 1Rnp368W2s7T; Sun, 3 Jan 2016 15:57:36 +0100 (CET) From: Jens Lechtenboerger To: Lars Magne Ingebrigtsen Subject: Re: bug#18718: acknowledged by developer (control message for bug #18718) References: <878u4fd4zr.fsf@gnus.org> <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <878u48m3y3.fsf@informationelle-selbstbestimmung-im-internet.de> OpenPGP: id=0xA142FD84; url=http://www.informationelle-selbstbestimmung-im-internet.de/A142FD84.asc Date: Sun, 03 Jan 2016 15:57:35 +0100 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 03 Jan 2016 10:08:08 +0100") Message-ID: <87k2nqogm8.fsf@informationelle-selbstbestimmung-im-internet.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain On 2016-01-03, at 10:08, Lars Magne Ingebrigtsen wrote: > Calling from message-send sounds better, I think. Could you send a > patch? This should do it. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Call-mml-secure-bcc-is-safe-for-bug-18718.patch >From c1cae98181cb05a001a4b0b3216f4aa072aaed6c Mon Sep 17 00:00:00 2001 From: Jens Lechtenboerger Date: Sun, 3 Jan 2016 15:48:43 +0100 Subject: [PATCH] Call mml-secure-bcc-is-safe for bug#18718 * lisp/gnus/message.el (message-send): Call mml-secure-bcc-is-safe --- lisp/gnus/message.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index a6c8282..1e2e3bd 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4227,6 +4227,8 @@ Instead, just auto-save the buffer and then bury it." (if message-return-action (apply (car message-return-action) (cdr message-return-action)))) +(autoload 'mml-secure-bcc-is-safe "mml-sec") + (defun message-send (&optional arg) "Send the message in the current buffer. If `message-interactive' is non-nil, wait for success indication or @@ -4241,6 +4243,7 @@ It should typically alter the sending method in some way or other." (let ((inhibit-read-only t)) (put-text-property (point-min) (point-max) 'read-only nil)) (message-fix-before-sending) + (mml-secure-bcc-is-safe) (run-hooks 'message-send-hook) (when message-confirm-send (or (y-or-n-p "Send message? ") -- 1.9.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 19:57:48 2016 Received: (at 18718) by debbugs.gnu.org; 4 Jan 2016 00:57:49 +0000 Received: from localhost ([127.0.0.1]:37009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFtT2-0004jF-NW for submit@debbugs.gnu.org; Sun, 03 Jan 2016 19:57:48 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:49568) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFtT1-0004j4-B9 for 18718@debbugs.gnu.org; Sun, 03 Jan 2016 19:57:47 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aFtSf-0000iq-D7; Mon, 04 Jan 2016 01:57:25 +0100 From: Lars Magne Ingebrigtsen To: Jens Lechtenboerger Subject: Re: bug#18718: acknowledged by developer (control message for bug #18718) References: <878u4fd4zr.fsf@gnus.org> <86y4sitzcx.fsf@informationelle-selbstbestimmung-im-internet.de> <878u48m3y3.fsf@informationelle-selbstbestimmung-im-internet.de> <87k2nqogm8.fsf@informationelle-selbstbestimmung-im-internet.de> Date: Mon, 04 Jan 2016 01:57:25 +0100 In-Reply-To: <87k2nqogm8.fsf@informationelle-selbstbestimmung-im-internet.de> (Jens Lechtenboerger's message of "Sun, 03 Jan 2016 15:57:35 +0100") Message-ID: User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aFtSf-0000iq-D7 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1452473845.54169@xG7GOD0BWwmHT8/JkalVQQ X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18718 Cc: 18718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Jens Lechtenboerger writes: > On 2016-01-03, at 10:08, Lars Magne Ingebrigtsen wrote: > >> Calling from message-send sounds better, I think. Could you send a >> patch? > > This should do it. Thanks; applied to Emacs 25.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 12:50:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Feb 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator