GNU bug report logs - #18707
[PATCH] dfa: print detail of DFA states in a debug mode

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Mon, 13 Oct 2014 10:40:03 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 18707-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18707-done <at> debbugs.gnu.org
Subject: Re: bug#18707: [PATCH] dfa: print detail of DFA states in a debug mode
Date: Sun, 19 Jul 2015 20:17:40 -0700
On Sun, Jul 19, 2015 at 6:33 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Sun, 19 Jul 2015 14:59:41 -0700
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> On Mon, Nov 24, 2014 at 4:26 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> > On Mon, 13 Oct 2014 19:39:21 +0900
>> > Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> >> If compile grep with -DDEBUG option, it outputs tokens etc.  In addition
>> >> to them, DFA states and transitions are output by this patch.  Debugging
>> >> them, the patch will be very useful.
>> >>
>> >> BTW, the patch doesn't make any changes without -DDEBUG option.
>> >
>> > I fixed some warnings output in compilation, and rebased it.
>>
>> Thank you for your patience.
>> I applied this, changed many %zd to %zu (to ensure compilation
>> succeeded with -DDEBUG also when configured with
>> --enable-gcc-warnings) and adjusted the commit log entry. Will push
>> once you've ACK'd the result.
>
> Thanks for changes and adjustment.  I agree all of them.

Thanks. Pushed.




This bug report was last modified 9 years and 308 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.