GNU bug report logs - #18685
[PATCH] dfa: treat a multibyte character even with constraints

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 11 Oct 2014 03:30:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Subject: bug#18685: closed (Re: bug#18685: [PATCH] dfa: treat a multibyte
 character even with constraints)
Date: Sun, 26 Oct 2014 15:08:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#18685: [PATCH] dfa: treat a multibyte character even with constraints

which was filed against the grep package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 18685 <at> debbugs.gnu.org.

-- 
18685: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18685
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18685-done <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sun, 26 Oct 2014 08:06:51 -0700
> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

Thanks.  FYI, it was a doubled "is", s/is is/is/.
Good reason for me to ensure flyspell-mode is enabled
all the time: it would have highlighted that.
Pushed.

On Sat, Oct 25, 2014 at 11:39 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

[Message part 3 (message/rfc822, inline)]
From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: treat a multibyte character even with constraints
Date: Sat, 11 Oct 2014 12:11:02 +0900
[Message part 4 (text/plain, inline)]
Set constraint, may be caused wrong result in non-UTF8 locales.  Below
fails in a current master.

  $ pattern=$(printf '^x\|\244\263')
  $ printf '\263\244\263\244\n' |
     env LC_ALL=ja_JP.eucJP src/grep "$pattern" && echo FAIL

skip_remains_mb runs in only state 0, but it's wrong.  Set constraint,
may transit to a state besides state 0 after failure.
[0001-dfa-treat-a-multibyte-character-even-with-constraint.patch (text/plain, attachment)]

This bug report was last modified 10 years and 260 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.