GNU bug report logs - #18685
[PATCH] dfa: treat a multibyte character even with constraints

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18685: closed ([PATCH] dfa: treat a multibyte character even
 with constraints)
Date: Sun, 26 Oct 2014 15:08:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 Oct 2014 08:06:51 -0700
with message-id <CA+8g5KETmr1uAD8Hp-rUvHdKRnt6wVs9WU9EGak-sUnCPYGHfw <at> mail.gmail.com>
and subject line Re: bug#18685: [PATCH] dfa: treat a multibyte character even with constraints
has caused the debbugs.gnu.org bug report #18685,
regarding [PATCH] dfa: treat a multibyte character even with constraints
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18685: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18685
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: treat a multibyte character even with constraints
Date: Sat, 11 Oct 2014 12:11:02 +0900

[Message part 3 (text/plain, inline)]

Set constraint, may be caused wrong result in non-UTF8 locales.  Below
fails in a current master.

  $ pattern=$(printf '^x\|\244\263')
  $ printf '\263\244\263\244\n' |
     env LC_ALL=ja_JP.eucJP src/grep "$pattern" && echo FAIL

skip_remains_mb runs in only state 0, but it's wrong.  Set constraint,
may transit to a state besides state 0 after failure.

[0001-dfa-treat-a-multibyte-character-even-with-constraint.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18685-done <at> debbugs.gnu.org
Subject: Re: bug#18685: [PATCH] dfa: treat a multibyte character even with
 constraints
Date: Sun, 26 Oct 2014 08:06:51 -0700

> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

Thanks.  FYI, it was a doubled "is", s/is is/is/.
Good reason for me to ensure flyspell-mode is enabled
all the time: it would have highlighted that.
Pushed.

On Sat, Oct 25, 2014 at 11:39 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Thanks for the review and changes.  I agree them, but I fixed a typo in
> commit log.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.