From unknown Sat Jun 14 19:10:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18683: Patch for wish-list item: 560 Resent-From: Matthew Leach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Oct 2014 23:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18683@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141298205313753 (code B ref -1); Fri, 10 Oct 2014 23:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Oct 2014 23:00:53 +0000 Received: from localhost ([127.0.0.1]:40514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcjB7-0003Zl-1T for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:00:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55730) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcjB5-0003Zd-FF for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:00:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcjAz-0000Kt-A8 for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:00:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcjAz-0000Kp-6t for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:00:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcjAt-0000MC-QL for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2014 19:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XcjAo-0000J3-7s for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2014 19:00:39 -0400 Received: from mx0.mattleach.net ([176.58.118.143]:47298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XcjAo-0000Ih-1O for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2014 19:00:34 -0400 Received: by mx0.mattleach.net (Postfix, from userid 99) id 27A9761C96; Sat, 11 Oct 2014 00:00:32 +0100 (BST) Received: from matt-desktop.home.mattleach.net (host86-151-46-58.range86-151.btcentralplus.com [86.151.46.58]) by mx0.mattleach.net (Postfix) with ESMTPSA id 9938461C7E for ; Sat, 11 Oct 2014 00:00:27 +0100 (BST) From: Matthew Leach User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Date: Fri, 10 Oct 2014 23:58:44 +0100 Message-ID: <87wq87ttuj.fsf@matt-desktop.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hello, Attached is a simple patch that adds {+-}90 degree rotation to image mode as requested in [1]. Any comments welcome. [1]: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=560 2014-10-10 Matthew Leach * image-mode.el (image-mode-map): map 'r' and 'l' to rotation functions. (image-rotate-90-right): New method. (image-rotate-90-left): --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=img-90-rotation.patch diff --git a/lisp/image-mode.el b/lisp/image-mode.el index b94162d..de75f4a 100644 --- a/lisp/image-mode.el +++ b/lisp/image-mode.el @@ -375,6 +375,8 @@ call." (define-key map "f" 'image-next-frame) (define-key map "b" 'image-previous-frame) (define-key map "n" 'image-next-file) + (define-key map "r" 'image-rotate-90-right) + (define-key map "l" 'image-rotate-90-left) (define-key map "p" 'image-previous-file) (define-key map "a+" 'image-increase-speed) (define-key map "a-" 'image-decrease-speed) @@ -1106,6 +1108,16 @@ Emacs is compiled with ImageMagick support." (setq image-transform-rotation (float (mod rotation 360))) (image-toggle-display-image)) +(defun image-rotate-90-right () + "Increase the rotation of the current image by 90 degrees." + (interactive) + (image-transform-set-rotation (+ image-transform-rotation 90))) + +(defun image-rotate-90-left () + "Decrease the rotation of the current image by 90 degrees." + (interactive) + (image-transform-set-rotation (- image-transform-rotation 90))) + (defun image-transform-reset () "Display the current image with the default size and rotation. This command has no effect unless Emacs is compiled with --=-=-= Content-Type: text/plain -- Matt --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 10 19:03:19 2014 Received: (at control) by debbugs.gnu.org; 10 Oct 2014 23:03:19 +0000 Received: from localhost ([127.0.0.1]:40519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcjDS-0003eL-U0 for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:03:19 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:32968) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcjDQ-0003e9-6q for control@debbugs.gnu.org; Fri, 10 Oct 2014 19:03:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XcjDP-0003zi-Q5 for control@debbugs.gnu.org; Fri, 10 Oct 2014 19:03:15 -0400 Date: Fri, 10 Oct 2014 19:03:15 -0400 Message-Id: Subject: control message for bug 18683 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) forcemerge 560 18683 From unknown Sat Jun 14 19:10:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18683: Patch for wish-list item: 560 Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Oct 2014 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthew Leach Cc: 18683@debbugs.gnu.org, Vitalie Spinu Received: via spool by 18683-submit@debbugs.gnu.org id=B18683.141298487323553 (code B ref 18683); Fri, 10 Oct 2014 23:48:02 +0000 Received: (at 18683) by debbugs.gnu.org; 10 Oct 2014 23:47:53 +0000 Received: from localhost ([127.0.0.1]:40606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xcjub-00067p-B1 for submit@debbugs.gnu.org; Fri, 10 Oct 2014 19:47:53 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33727) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcjuZ-00067h-J2 for 18683@debbugs.gnu.org; Fri, 10 Oct 2014 19:47:52 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XcjuY-0004CH-0C; Fri, 10 Oct 2014 19:47:50 -0400 From: Glenn Morris References: <87wq87ttuj.fsf@matt-desktop.home> X-Spook: illuminati AGT. AMME MD4 CESID DES enemy of the state KGB X-Ran: bxGzI]^O-FP%acJ0{\Q[/bC/}\hD+J'>bFR0 (Matthew Leach's message of "Fri, 10 Oct 2014 23:58:44 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Matthew Leach wrote: > Attached is a simple patch that adds {+-}90 degree rotation to image > mode as requested in [1]. Thanks. It would have better to send this to the existing report, rather than creating a new one, but no worries. Anyway, see also unfinished (as far as I know?) patch to do this and more at: http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html From unknown Sat Jun 14 19:10:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18683: Patch for wish-list item: 560 Resent-From: Matthew Leach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Oct 2014 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 18683@debbugs.gnu.org, Vitalie Spinu Received: via spool by 18683-submit@debbugs.gnu.org id=B18683.141302113820584 (code B ref 18683); Sat, 11 Oct 2014 09:53:01 +0000 Received: (at 18683) by debbugs.gnu.org; 11 Oct 2014 09:52:18 +0000 Received: from localhost ([127.0.0.1]:40765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XctLV-0005Lv-J1 for submit@debbugs.gnu.org; Sat, 11 Oct 2014 05:52:18 -0400 Received: from mx0.mattleach.net ([176.58.118.143]:42679) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XctLS-0005Lk-Lr for 18683@debbugs.gnu.org; Sat, 11 Oct 2014 05:52:15 -0400 Received: by mx0.mattleach.net (Postfix, from userid 99) id 9DDF461C96; Sat, 11 Oct 2014 10:52:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mx0.mattleach.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mbp.home.mattleach.net (host86-151-46-58.range86-151.btcentralplus.com [86.151.46.58]) by mx0.mattleach.net (Postfix) with ESMTPSA id 72DDC61C7E; Sat, 11 Oct 2014 10:52:09 +0100 (BST) From: Matthew Leach In-Reply-To: (Glenn Morris's message of "Fri, 10 Oct 2014 19:47:43 -0400") References: <87wq87ttuj.fsf@matt-desktop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (darwin) Date: Sat, 11 Oct 2014 10:52:08 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Matthew Leach wrote: > >> Attached is a simple patch that adds {+-}90 degree rotation to image >> mode as requested in [1]. > > Thanks. It would have better to send this to the existing report, rather > than creating a new one, but no worries. Oops, sorry. > > > Anyway, see also unfinished (as far as I know?) patch to do this and > more at: > > http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html > http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html Ah, I didn't know there were already candidate patches written, apologies for that. -- Matt From unknown Sat Jun 14 19:10:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18683: Patch for wish-list item: 560 Resent-From: Vitalie Spinu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Oct 2014 11:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18683 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthew Leach Cc: Glenn Morris , 18683@debbugs.gnu.org Received: via spool by 18683-submit@debbugs.gnu.org id=B18683.14130284775618 (code B ref 18683); Sat, 11 Oct 2014 11:55:01 +0000 Received: (at 18683) by debbugs.gnu.org; 11 Oct 2014 11:54:37 +0000 Received: from localhost ([127.0.0.1]:40810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcvFt-0001SX-7X for submit@debbugs.gnu.org; Sat, 11 Oct 2014 07:54:37 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35142) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcvFr-0001SP-5A for 18683@debbugs.gnu.org; Sat, 11 Oct 2014 07:54:35 -0400 Received: by mail-oi0-f49.google.com with SMTP id a3so8967147oib.8 for <18683@debbugs.gnu.org>; Sat, 11 Oct 2014 04:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=3khxzJk0fIvpdzpWzTOp69ni7x9tS3xTBges27JFd38=; b=XLhUtT4oTflLIGn+TbYa5/46DVKE2fL+9Z+/Ce0I+HDsqU/aNIZ1bM5mMGO2hdnPHo cPdWqDqgU783MsWClj0rLtXv8LKAYplb3K2QEpj+qBBhI+rLiuPsxQhLX7lbyz4zp15H hWs2EpNetxSdLz5WoyMsohfKWxZXsWT/bNnDwIrN9xXejr2oCL+OO2mIeBJgdRUZlhpg qt8myUMLGbvHFs3hE6//b0TRY3dNBsXojCMHl59dZ8J7Br1f2r4Zk4eaX4uHi17FhD0y bNVesJyqVHwNi1kIhrQAfYE+rY+wRdVT+2hUtEYwhcJChB99zoi9FEK4MzQ6aeIynr3A RETQ== X-Received: by 10.202.65.138 with SMTP id o132mr1620920oia.59.1413028473913; Sat, 11 Oct 2014 04:54:33 -0700 (PDT) Received: from localhost ([2602:306:cf9d:36e0:5e4:e60:aea3:3340]) by mx.google.com with ESMTPSA id a37sm3280532oic.16.2014.10.11.04.54.30 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 11 Oct 2014 04:54:32 -0700 (PDT) From: Vitalie Spinu Organization: UCLA Anderson School of Management References: <87wq87ttuj.fsf@matt-desktop.home> Date: Sat, 11 Oct 2014 04:54:30 -0700 In-Reply-To: (Matthew Leach's message of "Sat, 11 Oct 2014 10:52:08 +0100") Message-ID: <87zjd2akjt.fsf@gmail.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) The work is here https://github.com/vitoshka/image-transform/ It's an uniform and extensible interface to internal imagemagic and convert backends. Virtually any type of transformation could be done from inside of emacs and multiple transformation can be stacked. The reason I got stuck back then is that I wanted to implement interactive cropping with the mouse. I have looked into that but couldn't figure a good way to do so. In hindsight, I should have finished that I had and pushed to emacs and only then think about the rest. Within a week or two I will have loads of free time again so I will be finishing it for sure this time. Vitalie >>> Matthew Leach on Sat, 11 Oct 2014 10:52:08 +0100 wrote: > Glenn Morris writes: >> Matthew Leach wrote: >> >>> Attached is a simple patch that adds {+-}90 degree rotation to image >>> mode as requested in [1]. >> >> Thanks. It would have better to send this to the existing report, rather >> than creating a new one, but no worries. > Oops, sorry. >> >> >> Anyway, see also unfinished (as far as I know?) patch to do this and >> more at: >> >> http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00610.html> http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00264.html > Ah, I didn't know there were already candidate patches written, > apologies for that. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 18:36:15 2018 Received: (at control) by debbugs.gnu.org; 13 Apr 2018 22:36:15 +0000 Received: from localhost ([127.0.0.1]:51052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f77Il-0008G0-8O for submit@debbugs.gnu.org; Fri, 13 Apr 2018 18:36:15 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:46969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f77Ii-0008Ff-97 for control@debbugs.gnu.org; Fri, 13 Apr 2018 18:36:12 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f77If-0007q7-UG for control@debbugs.gnu.org; Sat, 14 Apr 2018 00:36:11 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f77IZ-0003ZG-TD for control@debbugs.gnu.org; Sat, 14 Apr 2018 00:36:03 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #560 Message-Id: Date: Sat, 14 Apr 2018 00:36:03 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 560