From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 05 12:38:04 2014 Received: (at submit) by debbugs.gnu.org; 5 Oct 2014 16:38:04 +0000 Received: from localhost ([127.0.0.1]:34844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xaoot-0000ON-EE for submit@debbugs.gnu.org; Sun, 05 Oct 2014 12:38:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xamdw-0005Tl-NY for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xamdn-0007bh-87 for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:18:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xamdn-0007bZ-5C for submit@debbugs.gnu.org; Sun, 05 Oct 2014 10:18:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xamde-0002jA-3Z for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XamdV-0007Cx-3Z for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:18:18 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:50327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XamdU-0007CY-Ry for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 10:18:09 -0400 Received: by mail-wi0-f176.google.com with SMTP id hi2so2434064wib.9 for ; Sun, 05 Oct 2014 07:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:user-agent:date:message-id:mime-version :content-type:content-transfer-encoding; bh=U0Tau354R2ilztzdS1Rdfvo4+Zgre8CFheapBayo4BA=; b=WLl8k3pQf010fA9f4JHiez3i41Z1CX27E0t8zRrbSkmnbD0D7lgIOQF9E2kZI0drxM QwFHAPeIDGxjSbC/37gR013uBDqg11CTQyURmMHkvbiJ2vWkaZrY5rbQ6dc325qeTaON eIGHFnjSd45ouc3R/RpiXsRqnS52X2004X3hUzlyGS2xJKqZe5RWapLa7MF2qpvXpSCt 8pe68QO/X8DaiUMh2VdoiapeBzq8T1tn03RQsKggk35t+85vwmULHMUyOr+nIBcZSHU5 lwJ0zVNNZIwiOC+UJ9F8u2H/BVgVqDYZVreVJbxWpsYZBM5XRElK6CI0MXegLj3zQ6T9 vuvw== X-Received: by 10.194.77.195 with SMTP id u3mr3478610wjw.115.1412518687539; Sun, 05 Oct 2014 07:18:07 -0700 (PDT) Received: from herakleitos.herakleitos (gw106-105-sasova.imafex.sk. [188.123.106.105]) by mx.google.com with ESMTPSA id u10sm5356002wix.8.2014.10.05.07.18.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 Oct 2014 07:18:06 -0700 (PDT) From: =?utf-8?B?TWF0w7rFoQ==?= Goljer To: bug-gnu-emacs@gnu.org Subject: 24.3; `customize-save-customized' should be handled as a transaction User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.2 (x86_64-unknown-linux-gnu) Date: Sun, 05 Oct 2014 16:18:00 +0200 Message-ID: <8761fyd2hz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 05 Oct 2014 12:38:01 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) If `customize-save-customized' is issued (through M-x or any other way, such as C-x C-s in customize buffer), and during the run of the function "exit" is called (e.g. using C-g), the routine writes garbage into the `custom-set-variables' form in `custom-file'. We should first construct the form in a temporary buffer and then write it at once into the output file. Another (simpler) solution is to use `atomic-change-group' from subr.el Had I not kept the file under git, I would've lost most of my settings. It seems like a good idea to handle a critical operation like this atomically. Cheers. --=20 Best regards, Mat=C3=BA=C5=A1 Goljer From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 06:15:59 2020 Received: (at 18633) by debbugs.gnu.org; 4 Dec 2020 11:15:59 +0000 Received: from localhost ([127.0.0.1]:43025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl94A-0007L4-Sg for submit@debbugs.gnu.org; Fri, 04 Dec 2020 06:15:59 -0500 Received: from quimby.gnus.org ([95.216.78.240]:57858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl949-0007F5-Dg for 18633@debbugs.gnu.org; Fri, 04 Dec 2020 06:15:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=goUqtDHkCFvTN8MQK4dSouqzcUixb+mxiJsS4DKNzQI=; b=jTnLh9HQ62DAcB0726gAelSav/ fVQl0p82iZOEwbdW+J/hQ7EtZi/XgIDenOr7TzRH0IGN8vMbFgHx2mdY/S/8fYuDa4L71TEi4xJwk p/0wSatf5N4QhG/OFxi5YpNMVXHcSN0oGIPqCpqoa3AXor/rt37PK0zBYeBWb54CygqE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl940-0007rc-Rc; Fri, 04 Dec 2020 12:15:51 +0100 From: Lars Ingebrigtsen To: =?utf-8?B?TWF0w7rFoQ==?= Goljer Subject: Re: bug#18633: 24.3; `customize-save-customized' should be handled as a transaction References: <8761fyd2hz.fsf@gmail.com> X-Now-Playing: The Matthew Herbert Big Band's _The State Between Us (1)_: "The Tower" Date: Fri, 04 Dec 2020 12:15:47 +0100 In-Reply-To: <8761fyd2hz.fsf@gmail.com> (=?utf-8?B?Ik1hdMO6xaE=?= Goljer"'s message of "Sun, 05 Oct 2014 16:18:00 +0200") Message-ID: <87lfedkejg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matúš Goljer writes: > We should first construct the form in a temporary buffer and then write > it at once into the output file. Another (simpler) solution is to use > `atomic-change-group' from subr.el Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18633 Cc: 18633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mat=C3=BA=C5=A1 Goljer writes: > We should first construct the form in a temporary buffer and then write > it at once into the output file. Another (simpler) solution is to use > `atomic-change-group' from subr.el (This bug report unfortunately got no response at the time.) I've now done the latter in Emacs 28. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 06:16:05 2020 Received: (at control) by debbugs.gnu.org; 4 Dec 2020 11:16:05 +0000 Received: from localhost ([127.0.0.1]:43029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl94H-0007R1-5o for submit@debbugs.gnu.org; Fri, 04 Dec 2020 06:16:05 -0500 Received: from quimby.gnus.org ([95.216.78.240]:57872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl94F-0007Kl-Or for control@debbugs.gnu.org; Fri, 04 Dec 2020 06:16:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UvA+DbeIu1OGjmiVjJdw6OPWSRQwrzC3Q4C3C6K1808=; b=ORXJef1PGbbf0S9ufoFsDUrhpK 7bw+IWDUb8lUhTg8pr1E5rTQBwu7PyS0KYrLOfg3ngl9zW+EyzR+MZ7j/Utz8yGsSFFG7iVODed+V xymGLayXbkNuy3lfa0i8MYlEgBpati5H4LHZ+devmGrQJnlvqsLkC/9h1DrGp/DUotnE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl948-0007rk-4E for control@debbugs.gnu.org; Fri, 04 Dec 2020 12:15:58 +0100 Date: Fri, 04 Dec 2020 12:15:54 +0100 Message-Id: <87k0txkej9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18633 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 18633 fixed close 18633 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 18633 fixed close 18633 28.1 quit From unknown Thu Aug 14 22:17:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Jan 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator