GNU bug report logs - #18631
[PATCH] dfa: return NULL as can't find any predicates

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sun, 5 Oct 2014 03:43:01 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 18631-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18631-done <at> debbugs.gnu.org
Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
Date: Sat, 25 Apr 2015 12:48:46 -0700
[Message part 1 (text/plain, inline)]
On Sun, Dec 7, 2014 at 6:06 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Sun, 05 Oct 2014 12:33:45 +0900
> Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
>> find_pred function is return an address to NULL pointer, but I think we
>> don't hope it.  So fix it.
>>
>> BTW, it could never happen, as the syntax is checked in regex prior to it.
>
> I wrote and added a test driver for this bug which uses a program
> `dfa-match-aux' added for tests recently.
>
> The program will generate a core dump before the change.

Thank you for the patch.
I have added to the commit log and adjusted the Makefile.am change
to insert the new test name in alphabetical order. I will push this shortly:
[0001-dfa-make-find_pred-return-NULL-for-an-invalid-predic.patch (application/octet-stream, attachment)]

This bug report was last modified 10 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.