GNU bug report logs - #18631
[PATCH] dfa: return NULL as can't find any predicates

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18631: closed ([PATCH] dfa: return NULL as can't find any
 predicates)
Date: Sat, 25 Apr 2015 19:50:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 Apr 2015 12:48:46 -0700
with message-id <CA+8g5KHwD8jRwXoYWsXc-6APTcJ89Wh48hYSR2usyWup4u1ytA <at> mail.gmail.com>
and subject line Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
has caused the debbugs.gnu.org bug report #18631,
regarding [PATCH] dfa: return NULL as can't find any predicates
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18631: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18631
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: bug-grep <at> gnu.org
Subject: [PATCH] dfa: return NULL as can't find any predicates
Date: Sun, 05 Oct 2014 12:33:45 +0900

[Message part 3 (text/plain, inline)]

find_pred function is return an address to NULL pointer, but I think we
don't hope it.  So fix it.

BTW, it could never happen, as the syntax is checked in regex prior to it.

[0001-dfa-return-NULL-as-can-t-find-any-predicates.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 18631-done <at> debbugs.gnu.org
Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates
Date: Sat, 25 Apr 2015 12:48:46 -0700

[Message part 6 (text/plain, inline)]

On Sun, Dec 7, 2014 at 6:06 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> On Sun, 05 Oct 2014 12:33:45 +0900
> Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
>> find_pred function is return an address to NULL pointer, but I think we
>> don't hope it.  So fix it.
>>
>> BTW, it could never happen, as the syntax is checked in regex prior to it.
>
> I wrote and added a test driver for this bug which uses a program
> `dfa-match-aux' added for tests recently.
>
> The program will generate a core dump before the change.

Thank you for the patch.
I have added to the commit log and adjusted the Makefile.am change
to insert the new test name in alphabetical order. I will push this shortly:

[0001-dfa-make-find_pred-return-NULL-for-an-invalid-predic.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.