From unknown Tue Aug 19 02:58:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18631: [PATCH] dfa: return NULL as can't find any predicates Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sun, 05 Oct 2014 03:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18631 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 18631@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141248054719550 (code B ref -1); Sun, 05 Oct 2014 03:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2014 03:42:27 +0000 Received: from localhost ([127.0.0.1]:33405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaciI-00055F-Nn for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaciG-000555-4T for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xaci7-0006tE-9w for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xaci7-0006tA-6X for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xachz-0001iv-HT for bug-grep@gnu.org; Sat, 04 Oct 2014 23:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xachr-0006sW-Og for bug-grep@gnu.org; Sat, 04 Oct 2014 23:42:07 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:59586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xachr-0006sM-Fa for bug-grep@gnu.org; Sat, 04 Oct 2014 23:41:59 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 7D66AC8001 for ; Sun, 5 Oct 2014 12:33:52 +0900 (JST) Received: from mail06.kcn.ne.jp ([61.86.6.185]) by imp01 with bizsmtp id zFZs1o00a3zXHqt01FZs48; Sun, 05 Oct 2014 12:33:52 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.47] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail06.kcn.ne.jp (Postfix) with ESMTPA id 52B971BF0021 for ; Sun, 5 Oct 2014 12:33:52 +0900 (JST) Date: Sun, 05 Oct 2014 12:33:45 +0900 From: Norihiro Tanaka Message-Id: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5430B9DE00000000D9D9_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5430B9DE00000000D9D9_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit find_pred function is return an address to NULL pointer, but I think we don't hope it. So fix it. BTW, it could never happen, as the syntax is checked in regex prior to it. --------_5430B9DE00000000D9D9_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Disposition: attachment; filename="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Transfer-Encoding: base64 RnJvbSBmZjdlNmY1OTk0YjhmOTBhYWViODVkYTZiMzE1NjlmMDFmOTdmMmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDUgT2N0IDIwMTQgMTI6MDk6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IHJldHVybiBOVUxMIGFzIGNhbid0IGZpbmQgYW55IHByZWRpY2F0ZXMKCiogc3JjL2RmYS5jIChm aW5kX3ByZWQpOiBSZXR1cm4gTlVMTCBhcyBjYW4ndCBmaW5kIGFueSBwcmVkaWNhdGVzLgotLS0K IHNyYy9kZmEuYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggNGY0 NWZmZi4uZDI1MTVmYyAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAt OTY1LDkgKzk2NSw5IEBAIGZpbmRfcHJlZCAoY29uc3QgY2hhciAqc3RyKQogICB1bnNpZ25lZCBp bnQgaTsKICAgZm9yIChpID0gMDsgcHJlZG5hbWVzW2ldLm5hbWU7ICsraSkKICAgICBpZiAoU1RS RVEgKHN0ciwgcHJlZG5hbWVzW2ldLm5hbWUpKQotICAgICAgYnJlYWs7CisgICAgICByZXR1cm4g JnByZWRuYW1lc1tpXTsKIAotICByZXR1cm4gJnByZWRuYW1lc1tpXTsKKyAgcmV0dXJuIE5VTEw7 CiB9CiAKIC8qIE11bHRpYnl0ZSBjaGFyYWN0ZXIgaGFuZGxpbmcgc3ViLXJvdXRpbmUgZm9yIGxl eC4KLS0gCjIuMS4xCgo= --------_5430B9DE00000000D9D9_MULTIPART_MIXED_-- From unknown Tue Aug 19 02:58:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18631: [PATCH] dfa: return NULL as can't find any predicates Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sun, 07 Dec 2014 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18631 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: 18631@debbugs.gnu.org X-Debbugs-Original-Cc: 18631@debbugs.gnu.org Received: via spool by 18631-submit@debbugs.gnu.org id=B18631.141796118426325 (code B ref 18631); Sun, 07 Dec 2014 14:07:01 +0000 Received: (at 18631) by debbugs.gnu.org; 7 Dec 2014 14:06:24 +0000 Received: from localhost ([127.0.0.1]:56070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxcTf-0006qX-Rf for submit@debbugs.gnu.org; Sun, 07 Dec 2014 09:06:24 -0500 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:46748) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxcTc-0006qL-7F for 18631@debbugs.gnu.org; Sun, 07 Dec 2014 09:06:22 -0500 Received: from imp02 (mailgw6.kcn.ne.jp [61.86.15.232]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 8E2066C0B11 for <18631@debbugs.gnu.org>; Sun, 7 Dec 2014 23:06:17 +0900 (JST) Received: from mail09.kcn.ne.jp ([61.86.6.188]) by imp02 with bizsmtp id Qe6H1p00343QJrh01e6Hmc; Sun, 07 Dec 2014 23:06:17 +0900 X-OrgRCPT: 18631@debbugs.gnu.org Received: from [10.120.1.76] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail09.kcn.ne.jp (Postfix) with ESMTPA id 2164D1BD0097; Sun, 7 Dec 2014 23:06:17 +0900 (JST) Date: Sun, 07 Dec 2014 23:06:17 +0900 From: Norihiro Tanaka In-Reply-To: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> References: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> Message-Id: <20141207230550.5F9D.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_54845D65000000005FAC_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --------_54845D65000000005FAC_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Sun, 05 Oct 2014 12:33:45 +0900 Norihiro Tanaka wrote: > find_pred function is return an address to NULL pointer, but I think we > don't hope it. So fix it. > > BTW, it could never happen, as the syntax is checked in regex prior to it. I wrote and added a test driver for this bug which uses a program `dfa-match-aux' added for tests recently. The program will generate a core dump before the change. --------_54845D65000000005FAC_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Disposition: attachment; filename="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Transfer-Encoding: base64 RnJvbSA0YTI4ZjU4M2Y0NWI2OWIyZWYwY2UzY2Q3Mzc1Y2M4YjQyMjYyNjAwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDUgT2N0IDIwMTQgMTI6MDk6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IHJldHVybiBOVUxMIGFzIGNhbid0IGZpbmQgYW55IHByZWRpY2F0ZXMuCgoqIHNyYy9kZmEuYyAo ZmluZF9wcmVkKTogUmV0dXJuIE5VTEwgYXMgY2FuJ3QgZmluZCBhbnkgcHJlZGljYXRlcy4KKiB0 ZXN0cy9pbnZhbGlkLWNoYXItY2xhc3M6IEFkZCBhIG5ldyB0ZXN0LgoqIHRlc3RzL01ha2VmaWxl LmFtOiBBZGQgYSBydWxlIHRvIGJ1aWxkIG5ldyB0ZXN0LgooVEVTVFMpOiBBZGQgaW52YWxpZC1j aGFyLWNsYXNzLgotLS0KIHNyYy9kZmEuYyAgICAgICAgICAgICAgICB8ICA1ICsrLS0tCiB0ZXN0 cy9NYWtlZmlsZS5hbSAgICAgICAgfCAgMSArCiB0ZXN0cy9pbnZhbGlkLWNoYXItY2xhc3MgfCAz MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMzMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0cy9pbnZh bGlkLWNoYXItY2xhc3MKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXgg ODA2Y2IwNC4uMTMzYjQzZCAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisrKyBiL3NyYy9kZmEuYwpA QCAtOTcxLDkgKzk3MSw4IEBAIGZpbmRfcHJlZCAoY29uc3QgY2hhciAqc3RyKQogICB1bnNpZ25l ZCBpbnQgaTsKICAgZm9yIChpID0gMDsgcHJlZG5hbWVzW2ldLm5hbWU7ICsraSkKICAgICBpZiAo U1RSRVEgKHN0ciwgcHJlZG5hbWVzW2ldLm5hbWUpKQotICAgICAgYnJlYWs7Ci0KLSAgcmV0dXJu ICZwcmVkbmFtZXNbaV07CisgICAgICByZXR1cm4gJnByZWRuYW1lc1tpXTsKKyAgcmV0dXJuIE5V TEw7CiB9CiAKIC8qIE11bHRpYnl0ZSBjaGFyYWN0ZXIgaGFuZGxpbmcgc3ViLXJvdXRpbmUgZm9y IGxleC4KZGlmZiAtLWdpdCBhL3Rlc3RzL01ha2VmaWxlLmFtIGIvdGVzdHMvTWFrZWZpbGUuYW0K aW5kZXggNjdjMTY1ZC4uY2UwMTE0ZiAxMDA2NDQKLS0tIGEvdGVzdHMvTWFrZWZpbGUuYW0KKysr IGIvdGVzdHMvTWFrZWZpbGUuYW0KQEAgLTc0LDYgKzc0LDcgQEAgVEVTVFMgPQkJCQkJCVwKICAg aW5jbHVkZS1leGNsdWRlCQkJCVwKICAgaW5jb25zaXN0ZW50LXJhbmdlCQkJCVwKICAgaW52YWxp ZC1tdWx0aWJ5dGUtaW5mbG9vcAkJCVwKKyAgaW52YWxpZC1jaGFyLWNsYXNzCQkJCVwKICAga2hh ZGFmeQkJCQkJXAogICBsb25nLWxpbmUtdnMtMkdpQi1yZWFkCQkJXAogICBtYXRjaC1saW5lcwkJ CQkJXApkaWZmIC0tZ2l0IGEvdGVzdHMvaW52YWxpZC1jaGFyLWNsYXNzIGIvdGVzdHMvaW52YWxp ZC1jaGFyLWNsYXNzCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAuLjBjYjA4N2YK LS0tIC9kZXYvbnVsbAorKysgYi90ZXN0cy9pbnZhbGlkLWNoYXItY2xhc3MKQEAgLTAsMCArMSwz MCBAQAorIyEvYmluL3NoCisjIFRoaXMgd291bGQgZmFpbCBmb3IgZ3JlcC0yLjIxLgorCisjIENv cHlyaWdodCAyMDE0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMgcHJv Z3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9k aWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxh dGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3Bl IHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0 aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUgcmVj ZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3 aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5z ZXMvPi4KKworLiAiJHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3JjCisK KyMgQWRkICIuIiB0byBQQVRIIGZvciB0aGUgdXNlIG9mIGRmYS1tYXRjaC1hdXguCitwYXRoX3By ZXBlbmRfIC4KKworZmFpbD0wCisKK2VjaG8gJ2RmYWVycm9yOiBpbnZhbGlkIGNoYXJhY3RlciBj bGFzcycgPiBleHAKK0xDX0FMTD1DIGRmYS1tYXRjaC1hdXggJ1tbOmZvbzpdXScgYSA+IG91dCAy PiYxCitjb21wYXJlIGV4cCBvdXQgfHwgZmFpbD0xCisKK0V4aXQgJGZhaWwKLS0gCjIuMi4wCgo= --------_54845D65000000005FAC_MULTIPART_MIXED_-- From unknown Tue Aug 19 02:58:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Norihiro Tanaka Subject: bug#18631: closed (Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates) Message-ID: References: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> X-Gnu-PR-Message: they-closed 18631 X-Gnu-PR-Package: grep X-Gnu-PR-Keywords: patch Reply-To: 18631@debbugs.gnu.org Date: Sat, 25 Apr 2015 19:50:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1429991403-7291-1" This is a multi-part message in MIME format... ------------=_1429991403-7291-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18631: [PATCH] dfa: return NULL as can't find any predicates which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18631@debbugs.gnu.org. --=20 18631: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18631 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1429991403-7291-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18631-done) by debbugs.gnu.org; 25 Apr 2015 19:49:17 +0000 Received: from localhost ([127.0.0.1]:39967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym64j-0001sb-6t for submit@debbugs.gnu.org; Sat, 25 Apr 2015 15:49:17 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:36176) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym64f-0001sM-C8 for 18631-done@debbugs.gnu.org; Sat, 25 Apr 2015 15:49:14 -0400 Received: by igblo3 with SMTP id lo3so37558842igb.1 for <18631-done@debbugs.gnu.org>; Sat, 25 Apr 2015 12:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=piJX1M+weZDiS4IWdbUzc7L3dJnv49AkpvYeknfED8U=; b=jfCE0BlnRoIoK1j4h6Db5AYqns03yeZdDtFhoeApVRWQtPKNytdLAY7HhQK7IW81hn al49sl9gm6mvn9Tj1F6hWSyJztOkMpR/m0nDUCM+Q4i6CzYRGj9737HMx9pMi9rXwfHa 9X7lmrGTbAihlgMa7PEmNA/dzJ8ABMc/AR9Z1sIFuibKksdPwYyDWVCZ2o0UdRO0W8fR W2sJz2OTJaPSbrD7PWumhu66rhF91v0v8wDpyIw5QPTFvd/GegfyjxvlQsQnXfGcjSyT F+21UtWdAvp7CLq6VF3l6URPsrFPcvoC/4Y/+NosVxB/qBf8x9gs3oaBxFex2DUq2+ob Rq1w== X-Received: by 10.50.50.148 with SMTP id c20mr574696igo.0.1429991347370; Sat, 25 Apr 2015 12:49:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Sat, 25 Apr 2015 12:48:46 -0700 (PDT) In-Reply-To: <20141207230550.5F9D.27F6AC2D@kcn.ne.jp> References: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> <20141207230550.5F9D.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sat, 25 Apr 2015 12:48:46 -0700 X-Google-Sender-Auth: z2v8To2otUqjDEXUB_ymbE6hvAk Message-ID: Subject: Re: bug#18631: [PATCH] dfa: return NULL as can't find any predicates To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=047d7bd764be4b19c5051491ce4d X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18631-done Cc: 18631-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bd764be4b19c5051491ce4d Content-Type: text/plain; charset=ISO-8859-1 On Sun, Dec 7, 2014 at 6:06 AM, Norihiro Tanaka wrote: > On Sun, 05 Oct 2014 12:33:45 +0900 > Norihiro Tanaka wrote: > >> find_pred function is return an address to NULL pointer, but I think we >> don't hope it. So fix it. >> >> BTW, it could never happen, as the syntax is checked in regex prior to it. > > I wrote and added a test driver for this bug which uses a program > `dfa-match-aux' added for tests recently. > > The program will generate a core dump before the change. Thank you for the patch. I have added to the commit log and adjusted the Makefile.am change to insert the new test name in alphabetical order. I will push this shortly: --047d7bd764be4b19c5051491ce4d Content-Type: application/octet-stream; name="0001-dfa-make-find_pred-return-NULL-for-an-invalid-predic.patch" Content-Disposition: attachment; filename="0001-dfa-make-find_pred-return-NULL-for-an-invalid-predic.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i8xfwc4v1 RnJvbSAwNDg3NTYzMTQ3MDljNTdkNThlNmM0ODk0YjQ0YzdjMjMyZjE5ZWFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDUgT2N0IDIwMTQgMTI6MDk6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IG1ha2UgZmluZF9wcmVkIHJldHVybiBOVUxMIGZvciBhbiBpbnZhbGlkIHByZWRpY2F0ZQoKVGhp cyBjb3VsZCBuZXZlciBoYXBwZW4gd2hlbiBpbnZva2VkIHZpYSBncmVwLCBidXQgY291bGQgaGF2 ZSB0cmlnZ2VyZWQKYSBidWcgaWYgZGZhLmMncyBmaW5kX3ByZWQgZnVuY3Rpb24gd2VyZSBpbnZv a2VkIGJ5IHNvbWUgb3RoZXIgcHJvZ3JhbS4KKiBzcmMvZGZhLmMgKGZpbmRfcHJlZCk6IFJldHVy biBOVUxMIGZvciBhbiBpbnZhbGlkIHByZWRpY2F0ZS4KKiB0ZXN0cy9pbnZhbGlkLWNoYXItY2xh c3M6IE5ldyBmaWxlIHRvIHRlc3QgZm9yIHRoaXMuCiogdGVzdHMvTWFrZWZpbGUuYW0gKFRFU1RT KTogQWRkIHRoYXQgbmV3IGZpbGUgbmFtZSB0byB0aGUgbGlzdC4KVGhpcyBhZGRyZXNzZXMgaHR0 cDovL2RlYmJ1Z3MuZ251Lm9yZy8xODYzMQotLS0KIHNyYy9kZmEuYyAgICAgICAgICAgICAgICB8 ICA1ICsrLS0tCiB0ZXN0cy9NYWtlZmlsZS5hbSAgICAgICAgfCAgMSArCiB0ZXN0cy9pbnZhbGlk LWNoYXItY2xhc3MgfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMg Y2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEw MDc1NSB0ZXN0cy9pbnZhbGlkLWNoYXItY2xhc3MKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9z cmMvZGZhLmMKaW5kZXggNTJlYWMzNy4uM2I5MzZjOCAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisr KyBiL3NyYy9kZmEuYwpAQCAtOTcxLDkgKzk3MSw4IEBAIGZpbmRfcHJlZCAoY29uc3QgY2hhciAq c3RyKQogICB1bnNpZ25lZCBpbnQgaTsKICAgZm9yIChpID0gMDsgcHJlZG5hbWVzW2ldLm5hbWU7 ICsraSkKICAgICBpZiAoU1RSRVEgKHN0ciwgcHJlZG5hbWVzW2ldLm5hbWUpKQotICAgICAgYnJl YWs7Ci0KLSAgcmV0dXJuICZwcmVkbmFtZXNbaV07CisgICAgICByZXR1cm4gJnByZWRuYW1lc1tp XTsKKyAgcmV0dXJuIE5VTEw7CiB9CgogLyogTXVsdGlieXRlIGNoYXJhY3RlciBoYW5kbGluZyBz dWItcm91dGluZSBmb3IgbGV4LgpkaWZmIC0tZ2l0IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0 cy9NYWtlZmlsZS5hbQppbmRleCAzM2I2YWRjLi41M2MyZjk0IDEwMDY0NAotLS0gYS90ZXN0cy9N YWtlZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmlsZS5hbQpAQCAtNzMsNiArNzMsNyBAQCBURVNU UyA9CQkJCQkJXAogICBpbi1lcS1vdXQtaW5mbG9vcAkJCQlcCiAgIGluY2x1ZGUtZXhjbHVkZQkJ CQlcCiAgIGluY29uc2lzdGVudC1yYW5nZQkJCQlcCisgIGludmFsaWQtY2hhci1jbGFzcwkJCQlc CiAgIGludmFsaWQtbXVsdGlieXRlLWluZmxvb3AJCQlcCiAgIGtoYWRhZnkJCQkJCVwKICAga3dz ZXQtYWJ1c2UJCQkJCVwKZGlmZiAtLWdpdCBhL3Rlc3RzL2ludmFsaWQtY2hhci1jbGFzcyBiL3Rl c3RzL2ludmFsaWQtY2hhci1jbGFzcwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAw Li41MDYwYjUwCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHMvaW52YWxpZC1jaGFyLWNsYXNzCkBA IC0wLDAgKzEsMzAgQEAKKyMhL2Jpbi9zaAorIyBUaGlzIHVzZSBvZiBvdXIgREZBLXRlc3Rpbmcg aGVscGVyIHdvdWxkIGZhaWwgZm9yIGdyZXAtMi4yMS4KKworIyBDb3B5cmlnaHQgMjAxNC0yMDE1 IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVl IHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlz aGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMg b2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24u CisKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2ls bCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRo ZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgZm9yIG1vcmUgZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5 IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJv Z3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworLiAi JHtzcmNkaXI9Ln0vaW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi4vc3JjCisKKyMgQWRkICIuIiB0 byBQQVRIIGZvciB0aGUgdXNlIG9mIGRmYS1tYXRjaC1hdXguCitwYXRoX3ByZXBlbmRfIC4KKwor ZmFpbD0wCisKK2VjaG8gJ2RmYWVycm9yOiBpbnZhbGlkIGNoYXJhY3RlciBjbGFzcycgPiBleHAK K0xDX0FMTD1DIGRmYS1tYXRjaC1hdXggJ1tbOmZvbzpdXScgYSA+IG91dCAyPiYxCitjb21wYXJl IGV4cCBvdXQgfHwgZmFpbD0xCisKK0V4aXQgJGZhaWwKLS0gCjIuMy42Cgo= --047d7bd764be4b19c5051491ce4d-- ------------=_1429991403-7291-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Oct 2014 03:42:27 +0000 Received: from localhost ([127.0.0.1]:33405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaciI-00055F-Nn for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XaciG-000555-4T for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xaci7-0006tE-9w for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xaci7-0006tA-6X for submit@debbugs.gnu.org; Sat, 04 Oct 2014 23:42:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xachz-0001iv-HT for bug-grep@gnu.org; Sat, 04 Oct 2014 23:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xachr-0006sW-Og for bug-grep@gnu.org; Sat, 04 Oct 2014 23:42:07 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:59586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xachr-0006sM-Fa for bug-grep@gnu.org; Sat, 04 Oct 2014 23:41:59 -0400 Received: from imp01 (mailgw5.kcn.ne.jp [61.86.15.231]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 7D66AC8001 for ; Sun, 5 Oct 2014 12:33:52 +0900 (JST) Received: from mail06.kcn.ne.jp ([61.86.6.185]) by imp01 with bizsmtp id zFZs1o00a3zXHqt01FZs48; Sun, 05 Oct 2014 12:33:52 +0900 X-OrgRCPT: bug-grep@gnu.org Received: from [10.120.1.47] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail06.kcn.ne.jp (Postfix) with ESMTPA id 52B971BF0021 for ; Sun, 5 Oct 2014 12:33:52 +0900 (JST) Date: Sun, 05 Oct 2014 12:33:45 +0900 From: Norihiro Tanaka To: bug-grep@gnu.org Subject: [PATCH] dfa: return NULL as can't find any predicates Message-Id: <20141005123344.D9E1.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5430B9DE00000000D9D9_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --------_5430B9DE00000000D9D9_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit find_pred function is return an address to NULL pointer, but I think we don't hope it. So fix it. BTW, it could never happen, as the syntax is checked in regex prior to it. --------_5430B9DE00000000D9D9_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Disposition: attachment; filename="0001-dfa-return-NULL-as-can-t-find-any-predicates.patch" Content-Transfer-Encoding: base64 RnJvbSBmZjdlNmY1OTk0YjhmOTBhYWViODVkYTZiMzE1NjlmMDFmOTdmMmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBTdW4sIDUgT2N0IDIwMTQgMTI6MDk6MjQgKzA5MDAKU3ViamVjdDogW1BBVENIXSBkZmE6 IHJldHVybiBOVUxMIGFzIGNhbid0IGZpbmQgYW55IHByZWRpY2F0ZXMKCiogc3JjL2RmYS5jIChm aW5kX3ByZWQpOiBSZXR1cm4gTlVMTCBhcyBjYW4ndCBmaW5kIGFueSBwcmVkaWNhdGVzLgotLS0K IHNyYy9kZmEuYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggNGY0 NWZmZi4uZDI1MTVmYyAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAt OTY1LDkgKzk2NSw5IEBAIGZpbmRfcHJlZCAoY29uc3QgY2hhciAqc3RyKQogICB1bnNpZ25lZCBp bnQgaTsKICAgZm9yIChpID0gMDsgcHJlZG5hbWVzW2ldLm5hbWU7ICsraSkKICAgICBpZiAoU1RS RVEgKHN0ciwgcHJlZG5hbWVzW2ldLm5hbWUpKQotICAgICAgYnJlYWs7CisgICAgICByZXR1cm4g JnByZWRuYW1lc1tpXTsKIAotICByZXR1cm4gJnByZWRuYW1lc1tpXTsKKyAgcmV0dXJuIE5VTEw7 CiB9CiAKIC8qIE11bHRpYnl0ZSBjaGFyYWN0ZXIgaGFuZGxpbmcgc3ViLXJvdXRpbmUgZm9yIGxl eC4KLS0gCjIuMS4xCgo= --------_5430B9DE00000000D9D9_MULTIPART_MIXED_-- ------------=_1429991403-7291-1-- From unknown Tue Aug 19 02:58:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18631: [PATCH] dfa: return NULL as can't find any predicates Resent-From: Norihiro Tanaka Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sun, 26 Apr 2015 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18631 X-GNU-PR-Package: grep X-GNU-PR-Keywords: patch To: Jim Meyering Cc: 18631-done@debbugs.gnu.org Received: via spool by 18631-done@debbugs.gnu.org id=D18631.143008741115900 (code D ref 18631); Sun, 26 Apr 2015 22:31:01 +0000 Received: (at 18631-done) by debbugs.gnu.org; 26 Apr 2015 22:30:11 +0000 Received: from localhost ([127.0.0.1]:40712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmV3w-00048L-1X for submit@debbugs.gnu.org; Sun, 26 Apr 2015 18:30:09 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:47054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YmV3o-00047P-RC for 18631-done@debbugs.gnu.org; Sun, 26 Apr 2015 18:30:03 -0400 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 737716C1556 for <18631-done@debbugs.gnu.org>; Mon, 27 Apr 2015 07:29:56 +0900 (JST) X-matriXscan-loop-detect: 9605cfc9e4bcd2cf52da78b7ab8fb8a0bb240f47 Received: from mail09.kcn.ne.jp ([61.86.6.188]) by mxs02-s with ESMTP; Mon, 27 Apr 2015 07:29:54 +0900 (JST) Received: from [10.120.1.14] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail09.kcn.ne.jp (Postfix) with ESMTPA id 3285F1BD0096; Mon, 27 Apr 2015 07:29:54 +0900 (JST) Date: Mon, 27 Apr 2015 07:29:54 +0900 From: Norihiro Tanaka In-Reply-To: References: <20141207230550.5F9D.27F6AC2D@kcn.ne.jp> Message-Id: <20150427072954.13CB.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, 25 Apr 2015 12:48:46 -0700 Jim Meyering wrote: > Thank you for the patch. > I have added to the commit log and adjusted the Makefile.am change > to insert the new test name in alphabetical order. I will push this shortly: Thanks for review and ajustment. I confirmed them.