From unknown Sun Jun 22 17:18:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18620: 25.0.50; cfengine3-make-syntax-cache Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: tzz@lifelogs.com, bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Oct 2014 10:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18620@debbugs.gnu.org Cc: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Received: via spool by submit@debbugs.gnu.org id=B.141233214227721 (code B ref -1); Fri, 03 Oct 2014 10:30:04 +0000 Received: (at submit) by debbugs.gnu.org; 3 Oct 2014 10:29:02 +0000 Received: from localhost ([127.0.0.1]:59817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xa06f-0007Cr-3Z for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:29:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55137) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xa06b-0007Cb-Vu for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xa06S-0004gN-KC for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa06S-0004gJ-HH for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa06J-0005lZ-6z for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xa06A-0004eC-70 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:39 -0400 Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:48140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa069-0004e2-V9 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:30 -0400 Received: by mail-pd0-f169.google.com with SMTP id w10so2412769pde.14 for ; Fri, 03 Oct 2014 03:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Rd8uPXyVdFwTP469G9ZycPw03t5WVVNrqgsgTKNNQog=; b=BuVZyj+GTP5PwZEcCKorg8hQ31/6fItiSnZnleA4hsAKjrNfB6tNBBQkNgsFuwUjXt ep2A+CPDRQBa1Mvj75HCpWXNcv+MzU1QZsuM82Z+vJCxRmYyllfZQfvRoyiEQI/rIC5c AJTFp4tbxFhJbFsQqMs5OulFVnIkwCSkSRLRkG/zs+F+Qvo0atzoot1oRcmB8TPwGK6r OSF7IjXrT/nlr1T/JgWG7fBMMAeTksvPFo5smEt2+tbAq0tsnKaReFPbY9Zzdp3riPcI J8azMTmUVdGS5Fp01KRBzQmdJGRQLQU5c/yHpImkTMFNptVVBr2A7I/G72ByMD4106cK jfzQ== X-Received: by 10.66.139.106 with SMTP id qx10mr6124186pab.126.1412332108742; Fri, 03 Oct 2014 03:28:28 -0700 (PDT) Received: from fortuna ([221.222.147.223]) by mx.google.com with ESMTPSA id xf9sm6266065pab.2.2014.10.03.03.28.26 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 03 Oct 2014 03:28:28 -0700 (PDT) From: Leo Liu Date: Fri, 03 Oct 2014 18:28:22 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There are multiple problems with cfengine3-make-syntax-cache: 1. call-process-shell-command changed in trunk; simply replace it with process-file. 2. it doesn't always return a `syntax' value 3. cf-promises doesn't have -s option in Centos 6.5 (cfengine 3.3) HTH, Leo From unknown Sun Jun 22 17:18:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18620: 25.0.50; cfengine3-make-syntax-cache Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Oct 2014 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 18620@debbugs.gnu.org Received: via spool by 18620-submit@debbugs.gnu.org id=B18620.141264907620723 (code B ref 18620); Tue, 07 Oct 2014 02:32:01 +0000 Received: (at 18620) by debbugs.gnu.org; 7 Oct 2014 02:31:16 +0000 Received: from localhost ([127.0.0.1]:36061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbKYV-0005OA-5a for submit@debbugs.gnu.org; Mon, 06 Oct 2014 22:31:15 -0400 Received: from mail-vc0-f170.google.com ([209.85.220.170]:50210) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbKYS-0005O2-ME for 18620@debbugs.gnu.org; Mon, 06 Oct 2014 22:31:13 -0400 Received: by mail-vc0-f170.google.com with SMTP id hy10so4107089vcb.15 for <18620@debbugs.gnu.org>; Mon, 06 Oct 2014 19:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=qdRSyBgbnQZ2jLcCAHIOvTZQYh2rfPYU9y8MItAZrmc=; b=V6WB1tgOSMmhgVV7RpBFqtGCn/rMteHVUSoCRN5utR0tQR5a94enlxLH0dAPgxQl2G qrqrYlRl1R8AADmV6RhAkKqw0DgmPqTb64ztwsWxLFEvGR4C/bXrh+3U1FgB7fP+0v8c PFSV+NB1dkFVlAV9ZiUSRTyDNfaTIWRqUUxNM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=qdRSyBgbnQZ2jLcCAHIOvTZQYh2rfPYU9y8MItAZrmc=; b=UOnBRhBndTICnX4OfGCZES0n/yeorVOXdISlq+J8A5PEVpeOBQ9Xrja5BSvgrMVASm Gyw/En5lAnU5Ays5jvapIyEB1p8P61BZR4rECHl2Pq7XeRrLr+G9LD5ZWp9pw8KdsoSg rca4dX1l9fWNkEKJbuqTJf7f0pZ44PepvdeXVSDm2A1KRP72oF+sGdV1V/CBjlA/MK3R 1byc/HIbHskC3CjARcRC/2HRNffZJPUTOjHkvN2SNnwO3cFQqaOclGaeilHXf4XppwWL ZyOB7Xrcgl24zMo38azx5KiD5EaHe789V+ZTLh73deDg3uNkGndL0KbTCrHPFT8Oy3TF QZXA== X-Gm-Message-State: ALoCoQmR6R1fYo/zyNFjbP9URNOphL3IUmDmxt8KGOclX4uTPe630Y+T4Ua7CN4B5VaD5VsMcfxr X-Received: by 10.52.166.2 with SMTP id zc2mr555069vdb.4.1412649071751; Mon, 06 Oct 2014 19:31:11 -0700 (PDT) Received: from bug.local ([166.170.35.2]) by mx.google.com with ESMTPSA id pj5sm1631894vdb.21.2014.10.06.19.31.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Oct 2014 19:31:11 -0700 (PDT) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 06 Oct 2014 22:31:09 -0400 In-Reply-To: (Leo Liu's message of "Fri, 03 Oct 2014 18:28:22 +0800") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain On Fri, 03 Oct 2014 18:28:22 +0800 Leo Liu wrote: LL> There are multiple problems with cfengine3-make-syntax-cache: LL> 1. call-process-shell-command changed in trunk; simply replace it with LL> process-file. LL> 2. it doesn't always return a `syntax' value Thanks for catching this, I had not noticed it sooner. Please see the patch below; does it work for you? If so I will commit and close the bug. LL> 3. cf-promises doesn't have -s option in Centos 6.5 (cfengine 3.3) I think that's all right, we will default to the fallback syntax. The `-s' option was added after 3.3 but IMO the fallback syntax is good enough for all 3.x work. (Unfortunately the Red Hat ecosystem has no CFEngine package maintainers so to get the latest you have to install from the official CFEngine package repo as directed by their website.) Thanks Ted --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=18620-cfengine-syntax.patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-10-06 17:47:56 +0000 +++ lisp/ChangeLog 2014-10-07 02:18:14 +0000 @@ -1,3 +1,9 @@ +2014-10-07 Teodor Zlatanov + + * progmodes/cfengine.el (cfengine3-make-syntax-cache): Use + `process-file' instead of `call-process-shell-command'. Check if + the returned CFEngine syntax is reasonably valid (bug#18620). + 2014-10-06 Stefan Monnier * term/w32-win.el: Move all code from 32-common-fns.el here. === modified file 'lisp/progmodes/cfengine.el' --- lisp/progmodes/cfengine.el 2014-01-30 07:42:57 +0000 +++ lisp/progmodes/cfengine.el 2014-10-07 02:15:16 +0000 @@ -1238,21 +1238,25 @@ (or syntax (with-demoted-errors (with-temp-buffer - (call-process-shell-command cfengine-cf-promises - nil ; no input - t ; current buffer - nil ; no redisplay - "-s" "json") + (process-file cfengine-cf-promises + nil ; no input + t ; current buffer + nil ; no redisplay + "-s" "json") (goto-char (point-min)) (setq syntax (json-read)) - (setq cfengine-mode-syntax-cache - (cons (cons cfengine-cf-promises syntax) - cfengine-mode-syntax-cache)) - (setq cfengine-mode-syntax-functions-regex - (regexp-opt (mapcar (lambda (def) - (format "%s" (car def))) - (cdr (assq 'functions syntax))) - 'symbols)))))) + + ;; if we got a valid syntax... + (when (and (listp syntax) + (assq 'functions syntax)) + (setq cfengine-mode-syntax-cache + (cons (cons cfengine-cf-promises syntax) + cfengine-mode-syntax-cache)) + (setq cfengine-mode-syntax-functions-regex + (regexp-opt (mapcar (lambda (def) + (format "%s" (car def))) + (cdr (assq 'functions syntax))) + 'symbols))))))) cfengine3-fallback-syntax)) (defun cfengine3-documentation-function () --=-=-=-- From unknown Sun Jun 22 17:18:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18620: 25.0.50; cfengine3-make-syntax-cache Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Oct 2014 03:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18620@debbugs.gnu.org Received: via spool by 18620-submit@debbugs.gnu.org id=B18620.141265217530504 (code B ref 18620); Tue, 07 Oct 2014 03:23:02 +0000 Received: (at 18620) by debbugs.gnu.org; 7 Oct 2014 03:22:55 +0000 Received: from localhost ([127.0.0.1]:36095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbLMU-0007vu-Di for submit@debbugs.gnu.org; Mon, 06 Oct 2014 23:22:54 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:55823) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbLMS-0007vm-KO for 18620@debbugs.gnu.org; Mon, 06 Oct 2014 23:22:53 -0400 Received: by mail-pd0-f181.google.com with SMTP id z10so4301290pdj.40 for <18620@debbugs.gnu.org>; Mon, 06 Oct 2014 20:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=eZkFc2cYylPCmwo5zjmahAb2SANXQnL3cezfpBAvH38=; b=obaGmvBaMZNkrZrVK4VpUKhgJfIdjZlk/MWi5IAkHu4pC64MJG8n33swAEvludWhw9 BnoWVUw5KCVHSo9ntk4Q2gIiVlQtgTWwTOBlXjeKHAOfhl1ZKReVo6SKwaihIqvy15+B m5EXc7EQPum6y2eT1QviNZRKQQMc5Xe7WePu+oLFVg1NpKmZFT+yiX7g4GhzdlkKf8TT ssO5dGZK4uoymMW5Ree4wjeBDnqHsbb7iWXaRyt+20d/8HTBlIzFrXf9HSZwJcPG5fwc /MY7Myml/XlEfmXagh6EoyHUGMrmzYMEWH7XervVDaxYoDkeWdBRP0DJ8XIOsT2+hwqz bLAQ== X-Received: by 10.68.102.100 with SMTP id fn4mr953149pbb.46.1412652171566; Mon, 06 Oct 2014 20:22:51 -0700 (PDT) Received: from fortuna ([221.222.150.213]) by mx.google.com with ESMTPSA id pg2sm14534512pbb.43.2014.10.06.20.22.49 for <18620@debbugs.gnu.org> (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 06 Oct 2014 20:22:50 -0700 (PDT) From: Leo Liu References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Tue, 07 Oct 2014 11:22:46 +0800 In-Reply-To: (Ted Zlatanov's message of "Mon, 06 Oct 2014 22:31:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-10-06 22:31 -0400, Ted Zlatanov wrote: > Thanks for catching this, I had not noticed it sooner. Please see the > patch below; does it work for you? If so I will commit and close the > bug. cfengine3-make-syntax-cache may still return a regexp and it won't fall back on cfengine3-fallback-syntax when `cf-promises -s json' fails; how about something along these lines? =3D=3D=3D modified file 'lisp/progmodes/cfengine.el' --- lisp/progmodes/cfengine.el 2014-01-30 07:42:57 +0000 +++ lisp/progmodes/cfengine.el 2014-10-07 03:10:44 +0000 @@ -1231,29 +1231,31 @@ (setq cfengine-mode-syntax-cache nil)) =20 (defun cfengine3-make-syntax-cache () - "Build the CFEngine 3 syntax cache. + "Build the CFEngine 3 syntax cache and return it. Calls `cfengine-cf-promises' with \"-s json\"" - (let ((syntax (cddr (assoc cfengine-cf-promises cfengine-mode-syntax-cac= he)))) - (if cfengine-cf-promises - (or syntax - (with-demoted-errors - (with-temp-buffer - (call-process-shell-command cfengine-cf-promises - nil ; no input - t ; current buffer - nil ; no redisplay - "-s" "json") - (goto-char (point-min)) - (setq syntax (json-read)) - (setq cfengine-mode-syntax-cache - (cons (cons cfengine-cf-promises syntax) - cfengine-mode-syntax-cache)) - (setq cfengine-mode-syntax-functions-regex - (regexp-opt (mapcar (lambda (def) - (format "%s" (car def))) - (cdr (assq 'functions syntax))) - 'symbols)))))) - cfengine3-fallback-syntax)) + (or (cddr (assoc cfengine-cf-promises cfengine-mode-syntax-cache)) + (when cfengine-cf-promises + (with-demoted-errors "cfengine3-make-syntax-cache: %S" + (with-temp-buffer + (process-file cfengine-cf-promises + nil ; no input + t ; current buffer + nil ; no redisplay + "-s" "json") + (goto-char (point-min)) + (let ((syntax (json-read))) + (when (and (listp syntax) + (assq 'functions syntax)) + (setq cfengine-mode-syntax-cache + (cons (cons cfengine-cf-promises syntax) + cfengine-mode-syntax-cache)) + (setq cfengine-mode-syntax-functions-regex + (regexp-opt (mapcar (lambda (def) + (format "%s" (car def))) + (cdr (assq 'functions syntax))) + 'symbols)) + syntax))))) + cfengine3-fallback-syntax)) =20 (defun cfengine3-documentation-function () "Document CFengine 3 functions around point. @@ -1265,7 +1267,6 @@ =20 (defun cfengine3-completion-function () "Return completions for function name around or before point." - (cfengine3-make-syntax-cache) (let* ((bounds (save-excursion (let ((p (point))) (skip-syntax-backward "w_" (point-at-bol)) > > LL> 3. cf-promises doesn't have -s option in Centos 6.5 (cfengine 3.3) > > I think that's all right, we will default to the fallback syntax. The > `-s' option was added after 3.3 but IMO the fallback syntax is good > enough for all 3.x work. > > (Unfortunately the Red Hat ecosystem has no CFEngine package maintainers > so to get the latest you have to install from the official CFEngine > package repo as directed by their website.) Agreed. Sad to see this and the cf community seems not very active. BTW, do you know if CF is still part of GNU? I only see version 2 on GNU=B9. > > Thanks > Ted Thanks, Leo Footnotes:=20 =B9 http://www.gnu.org/software/cfengine/ From unknown Sun Jun 22 17:18:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18620: 25.0.50; cfengine3-make-syntax-cache In-Reply-To: Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Oct 2014 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18620@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141277630930381 (code B ref -1); Wed, 08 Oct 2014 13:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Oct 2014 13:51:49 +0000 Received: from localhost ([127.0.0.1]:37568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xbree-0007tw-UD for submit@debbugs.gnu.org; Wed, 08 Oct 2014 09:51:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33761) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xbrec-0007to-TD for submit@debbugs.gnu.org; Wed, 08 Oct 2014 09:51:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbreS-00065T-Sv for submit@debbugs.gnu.org; Wed, 08 Oct 2014 09:51:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,RCVD_NUMERIC_HELO, T_FSL_HELO_BARE_IP_2 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbreS-00065P-QY for submit@debbugs.gnu.org; Wed, 08 Oct 2014 09:51:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbreL-0001h6-BO for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:51:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbreD-00060o-SC for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:51:29 -0400 Received: from plane.gmane.org ([80.91.229.3]:52335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbreD-00060Z-MU for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 09:51:21 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XbreC-0006Iw-2a for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2014 15:51:20 +0200 Received: from 198.0.146.153 ([198.0.146.153]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Oct 2014 15:51:20 +0200 Received: from tzz by 198.0.146.153 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 08 Oct 2014 15:51:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org From: Ted Zlatanov Date: Wed, 08 Oct 2014 09:51:09 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Lines: 37 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 198.0.146.153 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (darwin) Cancel-Lock: sha1:+47xwYmNKyhVYP51uLLHq+JW8RE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On Tue, 07 Oct 2014 11:22:46 +0800 Leo Liu wrote: LL> On 2014-10-06 22:31 -0400, Ted Zlatanov wrote: >> Thanks for catching this, I had not noticed it sooner. Please see the >> patch below; does it work for you? If so I will commit and close the >> bug. LL> cfengine3-make-syntax-cache may still return a regexp and it won't fall LL> back on cfengine3-fallback-syntax when `cf-promises -s json' fails; how LL> about something along these lines? I like your patch better :) Can you commit or let me know and I will? It will close this ticket, I hope. LL> 3. cf-promises doesn't have -s option in Centos 6.5 (cfengine 3.3) >> >> I think that's all right, we will default to the fallback syntax. The >> `-s' option was added after 3.3 but IMO the fallback syntax is good >> enough for all 3.x work. >> >> (Unfortunately the Red Hat ecosystem has no CFEngine package maintainers >> so to get the latest you have to install from the official CFEngine >> package repo as directed by their website.) LL> Agreed. Sad to see this and the cf community seems not very active. BTW, LL> do you know if CF is still part of GNU? I only see version 2 on GNUš. CFEngine 3 was a rewrite of version 2. It's still under the GPL but no longer part of the GNU project AFAIK. IMO it's quite good (the latest release is 3.6.2) and it's actively maintained by CFEngine Inc, but the proprietary non-free extensions in their Enterprise version and the corporate ownership of the codebase make it unlikely it can be part of the GNU project in this incarnation. Ted From unknown Sun Jun 22 17:18:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#18620: closed (Re: bug#18620: 25.0.50; cfengine3-make-syntax-cache) Message-ID: References: X-Gnu-PR-Message: they-closed 18620 X-Gnu-PR-Package: emacs Reply-To: 18620@debbugs.gnu.org Date: Wed, 08 Oct 2014 16:04:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1412784242-15875-1" This is a multi-part message in MIME format... ------------=_1412784242-15875-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18620: 25.0.50; cfengine3-make-syntax-cache which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18620@debbugs.gnu.org. --=20 18620: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18620 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1412784242-15875-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18620-done) by debbugs.gnu.org; 8 Oct 2014 16:03:39 +0000 Received: from localhost ([127.0.0.1]:38198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbtiE-00047W-P2 for submit@debbugs.gnu.org; Wed, 08 Oct 2014 12:03:39 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:48659) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbtiC-00047M-L9 for 18620-done@debbugs.gnu.org; Wed, 08 Oct 2014 12:03:37 -0400 Received: by mail-pa0-f42.google.com with SMTP id bj1so9324467pad.15 for <18620-done@debbugs.gnu.org>; Wed, 08 Oct 2014 09:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=DMYsr9l38tBRf/aCA3kAOE/3eGgirEgFR4WgAmxRTlI=; b=KMDcPzIfy9ew5HeZ+vgLomUrY/H+6PYuZwKy6ZWURDHbTzaGgE4JAm9RWdPBzMfAKM +X9sTTGU/nZHEy+PCYGipXeV99exgRCCuxaN49GmyHVj/iB5TVIqLHaVnYykdrHYRSrB GKEyitZ3Rql8Lh/hyDIHijAZnvDsym89aDDGNPVG4kp9GpUU0V4pyWibDzKrYZnjD0rz EUN9FNQVnCoMO9n99d7+B/84WH+P6eQqfRvODdO7ZUZVL2jm1otUlaoVG5ALlzztulFW tE4LkKtj6myCA/eEEIIuKx/AjZVk8jpolf130YsYEQx46rBzdkvuuyAwgQT52vWe4RXF PeZA== X-Received: by 10.70.12.65 with SMTP id w1mr11988620pdb.3.1412784215508; Wed, 08 Oct 2014 09:03:35 -0700 (PDT) Received: from fortuna ([221.222.150.213]) by mx.google.com with ESMTPSA id t9sm404673pdo.37.2014.10.08.09.03.33 for <18620-done@debbugs.gnu.org> (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 08 Oct 2014 09:03:34 -0700 (PDT) From: Leo Liu To: 18620-done@debbugs.gnu.org Subject: Re: bug#18620: 25.0.50; cfengine3-make-syntax-cache References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Thu, 09 Oct 2014 00:03:29 +0800 In-Reply-To: (Ted Zlatanov's message of "Wed, 08 Oct 2014 09:51:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (CentOS 6.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 18620-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-10-08 09:51 -0400, Ted Zlatanov wrote: > On Tue, 07 Oct 2014 11:22:46 +0800 Leo Liu wrote: [snipped 9 lines] > > I like your patch better :) > > Can you commit or let me know and I will? It will close this ticket, I > hope. OK, I am committing the patch (it's been 30 minutes, it hurts when it is this slow). I have discovered a few other issues and fixed them along the way. If you have time could you test it to make sure I don't break something else. [snipped 12 lines] > > CFEngine 3 was a rewrite of version 2. It's still under the GPL but no > longer part of the GNU project AFAIK. IMO it's quite good (the latest > release is 3.6.2) and it's actively maintained by CFEngine Inc, but the > proprietary non-free extensions in their Enterprise version and the > corporate ownership of the codebase make it unlikely it can be part of > the GNU project in this incarnation. > > Ted I'll take your word for it ;) Thanks for the info. Leo ------------=_1412784242-15875-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Oct 2014 10:29:02 +0000 Received: from localhost ([127.0.0.1]:59817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xa06f-0007Cr-3Z for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:29:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55137) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xa06b-0007Cb-Vu for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xa06S-0004gN-KC for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa06S-0004gJ-HH for submit@debbugs.gnu.org; Fri, 03 Oct 2014 06:28:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa06J-0005lZ-6z for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xa06A-0004eC-70 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:39 -0400 Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:48140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xa069-0004e2-V9 for bug-gnu-emacs@gnu.org; Fri, 03 Oct 2014 06:28:30 -0400 Received: by mail-pd0-f169.google.com with SMTP id w10so2412769pde.14 for ; Fri, 03 Oct 2014 03:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Rd8uPXyVdFwTP469G9ZycPw03t5WVVNrqgsgTKNNQog=; b=BuVZyj+GTP5PwZEcCKorg8hQ31/6fItiSnZnleA4hsAKjrNfB6tNBBQkNgsFuwUjXt ep2A+CPDRQBa1Mvj75HCpWXNcv+MzU1QZsuM82Z+vJCxRmYyllfZQfvRoyiEQI/rIC5c AJTFp4tbxFhJbFsQqMs5OulFVnIkwCSkSRLRkG/zs+F+Qvo0atzoot1oRcmB8TPwGK6r OSF7IjXrT/nlr1T/JgWG7fBMMAeTksvPFo5smEt2+tbAq0tsnKaReFPbY9Zzdp3riPcI J8azMTmUVdGS5Fp01KRBzQmdJGRQLQU5c/yHpImkTMFNptVVBr2A7I/G72ByMD4106cK jfzQ== X-Received: by 10.66.139.106 with SMTP id qx10mr6124186pab.126.1412332108742; Fri, 03 Oct 2014 03:28:28 -0700 (PDT) Received: from fortuna ([221.222.147.223]) by mx.google.com with ESMTPSA id xf9sm6266065pab.2.2014.10.03.03.28.26 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Fri, 03 Oct 2014 03:28:28 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 25.0.50; cfengine3-make-syntax-cache X-Debbugs-CC: Date: Fri, 03 Oct 2014 18:28:22 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There are multiple problems with cfengine3-make-syntax-cache: 1. call-process-shell-command changed in trunk; simply replace it with process-file. 2. it doesn't always return a `syntax' value 3. cf-promises doesn't have -s option in Centos 6.5 (cfengine 3.3) HTH, Leo ------------=_1412784242-15875-1-- From unknown Sun Jun 22 17:18:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18620: 25.0.50; cfengine3-make-syntax-cache Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Oct 2014 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 18620-done@debbugs.gnu.org Cc: sdl.web@gmail.com Received: via spool by 18620-done@debbugs.gnu.org id=D18620.141286085026405 (code D ref 18620); Thu, 09 Oct 2014 13:21:02 +0000 Received: (at 18620-done) by debbugs.gnu.org; 9 Oct 2014 13:20:50 +0000 Received: from localhost ([127.0.0.1]:38687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcDeD-0006rp-Qq for submit@debbugs.gnu.org; Thu, 09 Oct 2014 09:20:50 -0400 Received: from mail-qg0-f50.google.com ([209.85.192.50]:52202) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XcDeA-0006rf-Fp for 18620-done@debbugs.gnu.org; Thu, 09 Oct 2014 09:20:47 -0400 Received: by mail-qg0-f50.google.com with SMTP id q108so1913112qgd.23 for <18620-done@debbugs.gnu.org>; Thu, 09 Oct 2014 06:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=BYvmjqhjEQ/HRJc7EMfoOojM2flQ1kaluYUJ7Fi0J7s=; b=sx+jxwwrY8bK2b7eahkKU5mKqr4pTeVdvmAHVwiFm0IesKQ/qwgYk/lWgY3R783ZwM lTDjPmgsqvm4sqp1Cm0wUHE09NLlcZkmMGJKkWaI520qhm3mcwp5G/Szl7GKORJ5dneG 46bEuBzO7XrkceiCWX7QsJFDQMj8rfUyifOCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=BYvmjqhjEQ/HRJc7EMfoOojM2flQ1kaluYUJ7Fi0J7s=; b=WhVsPGV5vOcn1+pfEPX+YJxSA4QPBguiqhy8MwIcYtsFRsUJ6IFpgUh8y7Nol2Xr2S x3X2sHDIyTyrP66SN5o8YoYd0v9eXX0Sx9yeVrbKpI0qsiYJd8djHFO/+mvF4A77z8ii 9/scYzUcXkGufBhkKDKfWNdV79z7ZIrRIfqJrN6j+tawYTRdZEqTrL18S1mfYZL8DGfK cxKbtTGVTPAJOqcbOeBFryMAmweALCp5uXisRLTxXWY/6aYA4UTBe/bKbuskMFmjQoJK r0sreQtu1waaR1SYIxDgzmVrVl5KDlO22p0sMEKaBgulv2Sk4leNU244AmoMB34AyPIR y0ig== X-Gm-Message-State: ALoCoQnpzRJRtzdUzsdhT4b4Ik8qz3HPZDQqqAXaxRLYqOXKepX7dL8Xpe2nt2qs4R9TQVStmG+D X-Received: by 10.224.75.73 with SMTP id x9mr23978282qaj.63.1412860846002; Thu, 09 Oct 2014 06:20:46 -0700 (PDT) Received: from bug.local ([198.0.146.153]) by mx.google.com with ESMTPSA id c108sm2325427qgc.23.2014.10.09.06.20.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Oct 2014 06:20:45 -0700 (PDT) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 09 Oct 2014 09:20:42 -0400 In-Reply-To: (Leo Liu's message of "Thu, 09 Oct 2014 00:03:29 +0800") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, 09 Oct 2014 00:03:29 +0800 Leo Liu wrote: LL> OK, I am committing the patch (it's been 30 minutes, it hurts when it is LL> this slow). I have discovered a few other issues and fixed them along LL> the way. If you have time could you test it to make sure I don't break LL> something else. It's good. I'll keep testing it; marking the bug done. Thanks for the help! Ted