GNU bug report logs - #18614
Fix gui selection on OSX

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18614 in the body.
You can then email your comments to 18614 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Raynes <rayners <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix gui selection on OSX
Date: Thu, 2 Oct 2014 16:04:34 -0400

To reproduce: open ./nextstep/Emacs.app/Contents/MacOS/Emacs -q, hit
cmd-a to select all.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index ce62957..98a299b 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,6 @@
+2014-10-02  David Raynes  <rayners <at> gmail.com>
+       * term/ns-win.el: Add functions to ns frame, not x frame.
+
 2014-10-02  Stefan Monnier  <monnier <at> iro.umontreal.ca>

        * obsolete/lucid.el (read-number): Remove, redundant.
diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index 5889baf..b1d3a00 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -971,10 +971,10 @@ See the documentation of
`create-fontset-from-fontset-spec' for the format.")
                      (when gui-select-enable-clipboard
                        (ns-set-pasteboard text))))

-(gui-method-define gui-own-selection x #'ns-own-selection-internal)
-(gui-method-define gui-disown-selection x #'ns-disown-selection-internal)
-(gui-method-define gui-selection-owner-p x #'ns-selection-owner-p)
-(gui-method-define gui-get-selection x #'x-get-selection-internal) ;FIXME:name!
+(gui-method-define gui-own-selection ns #'ns-own-selection-internal)
+(gui-method-define gui-disown-selection ns #'ns-disown-selection-internal)
+(gui-method-define gui-selection-owner-p ns #'ns-selection-owner-p)
+(gui-method-define gui-get-selection ns #'x-get-selection-internal)
;FIXME:name!

 (provide 'ns-win)

Message #10 received at 18614-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: David Raynes <rayners <at> gmail.com>
Cc: 18614-done <at> debbugs.gnu.org
Subject: Re: bug#18614: Fix gui selection on OSX
Date: Thu, 02 Oct 2014 20:16:00 -0400

> -(gui-method-define gui-own-selection x #'ns-own-selection-internal)
> -(gui-method-define gui-disown-selection x #'ns-disown-selection-internal)
> -(gui-method-define gui-selection-owner-p x #'ns-selection-owner-p)
> -(gui-method-define gui-get-selection x #'x-get-selection-internal) ;FIXME:name!
> +(gui-method-define gui-own-selection ns #'ns-own-selection-internal)
> +(gui-method-define gui-disown-selection ns #'ns-disown-selection-internal)
> +(gui-method-define gui-selection-owner-p ns #'ns-selection-owner-p)
> +(gui-method-define gui-get-selection ns #'x-get-selection-internal) ;FIXME:name!
 
Oops, thanks, installed,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.