GNU bug report logs - #18599
erc-input-ring-setup: do not reset the ring when there already is one

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ivan Shmakov <ivan <at> siamics.net>
Subject: bug#18599: closed (Re: bug#18599: erc-input-ring-setup: do not
 reset the ring when there already is one )
Date: Fri, 21 Nov 2014 19:33:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#18599: erc-input-ring-setup: do not reset the ring when there already is one

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 18599 <at> debbugs.gnu.org.

-- 
18599: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18599
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: 18599-done <at> debbugs.gnu.org
Cc: erc-discuss <at> gnu.org
Subject: Re: bug#18599: erc-input-ring-setup: do not reset the ring when there
 already is one 
Date: Fri, 21 Nov 2014 19:31:24 +0000

Version: 24.5

	I no longer observe the issue (as of 2014-11-18 build,
	cb4f666ade76.)  Per my reading of the Git log, it was fixed in
	Git master back this October:

commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae
Author:     Ivan Shmakov <ivan <at> siamics.net>
AuthorDate: Thu Oct 2 07:31:56 2014 -0400
Commit:     Kelvin White <kwhite <at> gnu.org>
CommitDate: Thu Oct 2 07:31:56 2014 -0400

    Do not reset input ring if one exists
    
    Fixes: debbugs:18599

	In emacs-24, this bug was fixed as part of the following
	“backport” change:

commit d1036d288de1e047f7f6043188a1063f0d6b044d
Author:     l3thal <l3thal <at> debian>
AuthorDate: Sat Nov 8 20:51:43 2014 -0500
Commit:     l3thal <l3thal <at> debian>
CommitDate: Sat Nov 8 20:51:43 2014 -0500

    backport: erc bugfixes

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 3 (message/rfc822, inline)]

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: erc-input-ring-setup: do not reset the ring when there already is one
Date: Thu, 02 Oct 2014 05:11:03 +0000

[Message part 4 (text/plain, inline)]

Package: emacs
X-Debbugs-Cc: erc-discuss <at> gnu.org, Kashish Sharma <music.kashish <at> gmail.com>

>>>>> Kashish Sharma <music.kashish <at> gmail.com> writes:

[…]

 > 2. (what seems like another bug -) Input history is lost if one
 > disconnects/reconnects.

	Please consider the patch MIMEd.

	(This one was also recently pointed out on IRC, BTW.)

 > Wishlist - input history remembered across Emacs sessions.  Perhaps
 > with the option of setting the history size.

[…]

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 5 (text/diff, inline)]

--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
 (defun erc-input-ring-setup ()
   "Do the setup required so that we can use comint style input rings.
 Call this function when setting up the mode."
-  (setq erc-input-ring (make-ring comint-input-ring-size))
+  (unless (ring-p erc-input-ring)
+    (setq erc-input-ring (make-ring comint-input-ring-size)))
   (setq erc-input-ring-index nil))
 
 (defun erc-add-to-input-ring (s)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.