GNU bug report logs - #18599
erc-input-ring-setup: do not reset the ring when there already is one

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: erc-input-ring-setup: do not reset the ring when there already is one
Date: Thu, 02 Oct 2014 05:11:03 +0000

[Message part 1 (text/plain, inline)]

Package: emacs
X-Debbugs-Cc: erc-discuss <at> gnu.org, Kashish Sharma <music.kashish <at> gmail.com>

>>>>> Kashish Sharma <music.kashish <at> gmail.com> writes:

[…]

 > 2. (what seems like another bug -) Input history is lost if one
 > disconnects/reconnects.

	Please consider the patch MIMEd.

	(This one was also recently pointed out on IRC, BTW.)

 > Wishlist - input history remembered across Emacs sessions.  Perhaps
 > with the option of setting the history size.

[…]

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[Message part 2 (text/diff, inline)]

--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
 (defun erc-input-ring-setup ()
   "Do the setup required so that we can use comint style input rings.
 Call this function when setting up the mode."
-  (setq erc-input-ring (make-ring comint-input-ring-size))
+  (unless (ring-p erc-input-ring)
+    (setq erc-input-ring (make-ring comint-input-ring-size)))
   (setq erc-input-ring-index nil))
 
 (defun erc-add-to-input-ring (s)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.