From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 02 01:11:18 2014 Received: (at submit) by debbugs.gnu.org; 2 Oct 2014 05:11:18 +0000 Received: from localhost ([127.0.0.1]:57949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZYfd-0001PE-O4 for submit@debbugs.gnu.org; Thu, 02 Oct 2014 01:11:18 -0400 Received: from fely.am-1.org ([78.47.74.50]:34862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZYfa-0001P3-Ox for submit@debbugs.gnu.org; Thu, 02 Oct 2014 01:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=t0N/uWIZd/YQixpgWDYSAX7VAKupaQ5EbO+EFjwa0oY=; b=iXMiwnQogSUPjQZnG85LZTrrR9+0lpwXpLrJBlGo85EgPjHE5spZyOb5HmT/jqojKhu/Gf1Z7xG4M5z97YNP50kSTNuRN1dHiiGviFgNB50YuIILTH6J9E6N+sQT/2UFKsq+F5r98Mdtw4LDA8uW+kHy7fSn6ADWZ7Gdl4ieaqM=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XZYfY-0004tV-F6 for submit@debbugs.gnu.org; Thu, 02 Oct 2014 05:11:12 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XZYfQ-0000Od-3M for submit@debbugs.gnu.org; Thu, 02 Oct 2014 12:11:04 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: erc-input-ring-setup: do not reset the ring when there already is one References: Date: Thu, 02 Oct 2014 05:11:03 +0000 In-Reply-To: (Kashish Sharma's message of "Thu, 2 Oct 2014 02:23:54 +0530") Message-ID: <87egurf448.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs X-Debbugs-Cc: erc-discuss@gnu.org, Kashish Sharma >>>>> Kashish Sharma writes: [=E2=80=A6] > 2. (what seems like another bug -) Input history is lost if one > disconnects/reconnects. Please consider the patch MIMEd. (This one was also recently pointed out on IRC, BTW.) > Wishlist - input history remembered across Emacs sessions. Perhaps > with the option of setting the history size. [=E2=80=A6] --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/erc/erc-ring.el +++ b/lisp/erc/erc-ring.el @@ -67,7 +67,8 @@ (defun erc-input-ring-setup () "Do the setup required so that we can use comint style input rings. Call this function when setting up the mode." - (setq erc-input-ring (make-ring comint-input-ring-size)) + (unless (ring-p erc-input-ring) + (setq erc-input-ring (make-ring comint-input-ring-size))) (setq erc-input-ring-index nil)) (defun erc-add-to-input-ring (s) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 21 14:32:34 2014 Received: (at 18599-done) by debbugs.gnu.org; 21 Nov 2014 19:32:34 +0000 Received: from localhost ([127.0.0.1]:41239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrtwY-00056Z-7B for submit@debbugs.gnu.org; Fri, 21 Nov 2014 14:32:34 -0500 Received: from fely.am-1.org ([78.47.74.50]:41777) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrtwW-00056R-4V for 18599-done@debbugs.gnu.org; Fri, 21 Nov 2014 14:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:Cc:To:From; bh=+ks3dRucbU4uqfoR0SB/r3OAGww4JNFf6oKGl7LioDc=; b=hVluxwMIfwC4J5wpp42/i3JdL1xW9wKGlPR7eYGage6NMwjlTwKXjrDdSOOqazkQmw0o11ltC2a48B3Q2cXEK8DUwzZkYJF85Uz9w1qCs/4l3TQEWkbImQwzihm7QPiKTm7neigBICLZHTP8jInd+e2pCyn7JyjPZ76w93HWSwU=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xrtvh-0003kZ-Av; Fri, 21 Nov 2014 19:32:30 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrtvQ-0007vc-Nu; Sat, 22 Nov 2014 02:31:24 +0700 From: Ivan Shmakov To: 18599-done@debbugs.gnu.org Subject: Re: bug#18599: erc-input-ring-setup: do not reset the ring when there already is one References: <87egurf448.fsf@violet.siamics.net> Date: Fri, 21 Nov 2014 19:31:24 +0000 In-Reply-To: <87egurf448.fsf@violet.siamics.net> (Ivan Shmakov's message of "Thu, 02 Oct 2014 05:11:03 +0000") Message-ID: <87sihcwdtf.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18599-done Cc: erc-discuss@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 24.5 I no longer observe the issue (as of 2014-11-18 build, cb4f666ade76.) Per my reading of the Git log, it was fixed in Git master back this October: commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae Author: Ivan Shmakov AuthorDate: Thu Oct 2 07:31:56 2014 -0400 Commit: Kelvin White CommitDate: Thu Oct 2 07:31:56 2014 -0400 Do not reset input ring if one exists =20=20=20=20 Fixes: debbugs:18599 In emacs-24, this bug was fixed as part of the following =E2=80=9Cbackport=E2=80=9D change: commit d1036d288de1e047f7f6043188a1063f0d6b044d Author: l3thal AuthorDate: Sat Nov 8 20:51:43 2014 -0500 Commit: l3thal CommitDate: Sat Nov 8 20:51:43 2014 -0500 backport: erc bugfixes --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Sat Jun 21 03:21:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Dec 2014 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator