From unknown Mon Aug 11 12:54:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18551 <18551@debbugs.gnu.org> To: bug#18551 <18551@debbugs.gnu.org> Subject: Status: regression: erc-format-nick is now essentially an alias to erc-format-@nick Reply-To: bug#18551 <18551@debbugs.gnu.org> Date: Mon, 11 Aug 2025 19:54:35 +0000 retitle 18551 regression: erc-format-nick is now essentially an alias to er= c-format-@nick reassign 18551 emacs submitter 18551 Ivan Shmakov severity 18551 normal tag 18551 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 24 17:34:09 2014 Received: (at submit) by debbugs.gnu.org; 24 Sep 2014 21:34:09 +0000 Received: from localhost ([127.0.0.1]:51090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWuCO-0004xd-52 for submit@debbugs.gnu.org; Wed, 24 Sep 2014 17:34:08 -0400 Received: from fely.am-1.org ([78.47.74.50]:34104) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWuCL-0004xV-Sb for submit@debbugs.gnu.org; Wed, 24 Sep 2014 17:34:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=ArV9XKOjsCokkR+v7nYHVG6Dxawa1/47Ii7Ojvdh9Lc=; b=WGDZ1pwIGWKjCY+Svk27S/ZIOFur4PxkEsoUy+6NhMSqfRBo2Av15RPOfnyss9K8m6NREVd6BLAdAyDGCvdgGUlYwR/WM0CLQRz9WrzAD3dPTb2WWZDrN+OeCeeUBDcjcz85PO43OiGjPDFYIe3TVoaasJCd2VXEqUdjpw5IqHg=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XWuCK-0007PH-MI for submit@debbugs.gnu.org; Wed, 24 Sep 2014 21:34:05 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XWuCD-0004PD-Nt for submit@debbugs.gnu.org; Thu, 25 Sep 2014 04:33:57 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: regression: erc-format-nick is now essentially an alias to eww-format-@nick Date: Wed, 24 Sep 2014 21:33:57 +0000 Message-ID: <87ppekn1oa.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs X-Debbugs-Cc: Kelvin White The following change (present as of 0ee10aff098b) was introduced into lisp/erc/erc.el back this June: commit b45734ee82eecb91010eb3055c8c8bafb73a3ade Author: Kelvin White AuthorDate: Thu Jun 19 12:56:18 2014 -0400 ERC: Better user mode support --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el =E2=80=A6 @@ -4190,7 +4223,24 @@ (defun erc-format-nick (&optional user _channel-data) "Return the nickname of USER. See also `erc-format-nick-function'." - (when user (erc-server-user-nickname user))) + (let ((nick (erc-server-user-nickname user))) + (concat (erc-propertize + (erc-get-user-mode-prefix nick) + 'face 'erc-nick-prefix-face) nick))) =E2=80=A6 This added the =E2=80=9Cuser mode=E2=80=9D sign =E2=80=93 previously kind = of specific to erc-format-@nick =E2=80=93 into the string returned by erc-format-nick. Thus, the only code difference left between the two is the (presumably accidental) lack of the (when user =E2=80=A6) in the former: 4227 (defun erc-format-nick (&optional user _channel-data) =E2=80=A6 4230 (let ((nick (erc-server-user-nickname user))) 4231 (concat (erc-propertize 4232 (erc-get-user-mode-prefix nick) 4233 'face 'erc-nick-prefix-face) 4234 nick))) 4250 (defun erc-format-@nick (&optional user channel-data) =E2=80=A6 4256 (when user 4257 (let ((nick (erc-server-user-nickname user))) 4258 (concat (erc-propertize 4259 (erc-get-user-mode-prefix nick) 4260 'face 'erc-nick-prefix-face) 4261 nick)))) I believe that this change was unintended, is not helpful in any way (if the intent was to get rid of the former, it should=E2=80=99ve been aliased over, not redefined, shouldn=E2=80=99t it?), and should thus be reverted. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -4227,11 +4227,7 @@ (defun erc-format-nick (&optional user _channel-data) "Return the nickname of USER. See also `erc-format-nick-function'." - (let ((nick (erc-server-user-nickname user))) - (concat (erc-propertize - (erc-get-user-mode-prefix nick) - 'face 'erc-nick-prefix-face) - nick))) + (when user (erc-server-user-nickname user))) (defun erc-get-user-mode-prefix (user) (when user --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 24 17:40:22 2014 Received: (at control) by debbugs.gnu.org; 24 Sep 2014 21:40:22 +0000 Received: from localhost ([127.0.0.1]:51094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWuIP-00057t-MH for submit@debbugs.gnu.org; Wed, 24 Sep 2014 17:40:21 -0400 Received: from fely.am-1.org ([78.47.74.50]:34107) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWuIM-00057h-EP for control@debbugs.gnu.org; Wed, 24 Sep 2014 17:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=jW0KyO38HomDy362+1CaPWmXUjfVpzfa4L9KHn9rME4=; b=i7mAQ0oiKlvc5XUtDKxaZzayHfveHUSnan6Bgz1EH49awcvnGQ8QXbPDMdylbWjR3j7dLH3OhEcRW+WNsot5BZx+K/Gy/92uLFoHt9Frm326h6rb6bQypWH1uo1HUqATBzqXJ0gX9ZELp5p++zakE/J4j8DnO/6/gLBts4ILACQ=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XWuIL-0007SU-PI for control@debbugs.gnu.org; Wed, 24 Sep 2014 21:40:17 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XWuIE-0004Q7-QC for control@debbugs.gnu.org; Thu, 25 Sep 2014 04:40:10 +0700 From: Ivan Shmakov To: control@debbugs.gnu.org Subject: tweaking recent reports Date: Wed, 24 Sep 2014 21:40:10 +0000 Message-ID: <87fvfgn1dx.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) retitle 18551 regression: erc-format-nick is now essentially an alias to er= c-format-@nick=20 tag 18551 + patch tag 18550 + patch thanks --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 21 14:31:50 2014 Received: (at 18551-done) by debbugs.gnu.org; 21 Nov 2014 19:31:50 +0000 Received: from localhost ([127.0.0.1]:41220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrtvm-00053l-FF for submit@debbugs.gnu.org; Fri, 21 Nov 2014 14:31:50 -0500 Received: from fely.am-1.org ([78.47.74.50]:41762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrtvh-00053W-Ak for 18551-done@debbugs.gnu.org; Fri, 21 Nov 2014 14:31:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=cto5PiXrDd46IuHcG3R4IdGTI2sLRg+o1bRKL/HYp+o=; b=rN60eTzLpoc0DIK1Ee9y7LS3sEQaotyRzEFRa2H5FAorQaN/mqhmJij7RLa5wBG6l9PoBQbhirM3WtlnKD3bu+d7aQRaprsgs9v4JAnopVu7hW2fwwprWHE90EFNd8GG7rHak6fiYMEjcHkMPzSlBXhWk3/BDLo6BD0Rttc6yHI=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xrtve-0003kV-P7 for 18551-done@debbugs.gnu.org; Fri, 21 Nov 2014 19:31:39 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XrtvN-0007vY-Pq for 18551-done@debbugs.gnu.org; Sat, 22 Nov 2014 02:31:21 +0700 From: Ivan Shmakov To: 18551-done@debbugs.gnu.org Subject: Re: bug#18551: regression: erc-format-nick is now essentially an alias to eww-format-@nick References: <87ppekn1oa.fsf@violet.siamics.net> Date: Fri, 21 Nov 2014 19:31:21 +0000 In-Reply-To: <87ppekn1oa.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 24 Sep 2014 21:33:57 +0000") Message-ID: <87tx1swdti.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18551-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 25.1 I no longer observe the issue (as of 2014-11-18 build, cb4f666ade76.) Per my reading of the Git log, it was fixed in Git master back this September: Author: Kelvin White AuthorDate: Fri Sep 26 09:22:47 2014 -0400 Commit: Kelvin White CommitDate: Fri Sep 26 09:22:47 2014 -0400 Regression fix - #bug18551 As it seems, the emacs-24 branch was never affected by this bug. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Mon Aug 11 12:54:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Dec 2014 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator