Subject: bug#18551: closed (Re: bug#18551: regression: erc-format-nick is now essentially an alias to eww-format-@nick )

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 21 Nov 2014 19:32:04 +0000

Your bug report

#18551: regression: erc-format-nick is now essentially an alias to erc-format-@nick

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
18551: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18551
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#18551: regression: erc-format-nick is now essentially an alias to eww-format-@nick
From: Ivan Shmakov <[email-masked]>
To: [email-masked]
Date: Fri, 21 Nov 2014 19:31:21 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 25.1

	I no longer observe the issue (as of 2014-11-18 build,
	cb4f666ade76.)  Per my reading of the Git log, it was fixed in
	Git master back this September:

Author:     Kelvin White <[email-masked]>
AuthorDate: Fri Sep 26 09:22:47 2014 -0400
Commit:     Kelvin White <[email-masked]>
CommitDate: Fri Sep 26 09:22:47 2014 -0400

    Regression fix - #bug18551

	As it seems, the emacs-24 branch was never affected by this bug.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

Subject: regression: erc-format-nick is now essentially an alias to eww-format-@nick
From: Ivan Shmakov <[email-masked]>
To: [email-masked]
Date: Wed, 24 Sep 2014 21:33:57 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Package:  emacs
X-Debbugs-Cc: Kelvin White <[email-masked]>

	The following change (present as of 0ee10aff098b) was introduced
	into lisp/erc/erc.el back this June:

commit b45734ee82eecb91010eb3055c8c8bafb73a3ade
Author:     Kelvin White <[email-masked]>
AuthorDate: Thu Jun 19 12:56:18 2014 -0400

    ERC: Better user mode support

--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
…
@@ -4190,7 +4223,24 @@
 (defun erc-format-nick (&optional user _channel-data)
   "Return the nickname of USER.
 See also `erc-format-nick-function'."
-  (when user (erc-server-user-nickname user)))
+  (let ((nick (erc-server-user-nickname user)))
+    (concat (erc-propertize
+             (erc-get-user-mode-prefix nick)
+             'face 'erc-nick-prefix-face) nick)))
…

	This added the “user mode” sign – previously kind of specific to
	erc-format-@nick – into the string returned by erc-format-nick.
	Thus, the only code difference left between the two is the
	(presumably accidental) lack of the (when user …) in the former:

  4227	(defun erc-format-nick (&optional user _channel-data)
…
  4230	  (let ((nick (erc-server-user-nickname user)))
  4231	    (concat (erc-propertize
  4232	             (erc-get-user-mode-prefix nick)
  4233	             'face 'erc-nick-prefix-face)
  4234		    nick)))

  4250	(defun erc-format-@nick (&optional user channel-data)
…
  4256	  (when user
  4257	    (let ((nick (erc-server-user-nickname user)))
  4258	      (concat (erc-propertize
  4259	               (erc-get-user-mode-prefix nick)
  4260	               'face 'erc-nick-prefix-face)
  4261		      nick))))

	I believe that this change was unintended, is not helpful in any
	way (if the intent was to get rid of the former, it should’ve
	been aliased over, not redefined, shouldn’t it?), and should
	thus be reverted.

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4227,11 +4227,7 @@
 (defun erc-format-nick (&optional user _channel-data)
   "Return the nickname of USER.
 See also `erc-format-nick-function'."
-  (let ((nick (erc-server-user-nickname user)))
-    (concat (erc-propertize
-             (erc-get-user-mode-prefix nick)
-             'face 'erc-nick-prefix-face)
-	    nick)))
+  (when user (erc-server-user-nickname user)))
 
 (defun erc-get-user-mode-prefix (user)
   (when user