GNU bug report logs - #18550
eww-history-browse may end up calling eww-restore-history in an arbitrary buffer

Previous Next

Full log

View this message in rfc822 format

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 18550 <at> debbugs.gnu.org
Subject: bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer
Date: Wed, 19 Nov 2014 18:25:57 +0100

Ivan Shmakov <ivan <at> siamics.net> writes:

> I see no reason to abuse quit-window for what’s essentially
> switching to a buffer to edit one.  That is: the
> eww-restore-history call right after quit-window edits the
> /current/ buffer.  Thus, it indeed makes sense to explicitly use
> set-buffer before that.  (Or to wrap the call in
> with-current-buffer, anyway.)
>
> Moreover, vc.el already uses a dedicated buffer-local variable
> for a similar purpose, and so does rcirc.el, and perhaps a few
> more modes out there.

I think you're arguing against yourself here.  If this is such a common
thing to do, then something in this setup should provide this
functionality, so that all these modes don't have to implement it again
and again.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.