GNU bug report logs - #18545
24.4.50: Bug - forward-line inside with-selected-window

Previous Next

Full log

Message #137 received at 18545 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: lompik <at> voila.fr, 18545 <at> debbugs.gnu.org
Subject: Re: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window
Date: Sun, 28 Sep 2014 21:04:00 +0200

>>   >> I don't
>>   >> understand cursor_row_fully_visible_p much.
>>   >
>>   > Which part of it do you not understand?
>>
>> Why it should return 1 in these two cases
>>
>>     if (!MATRIX_ROW_PARTIALLY_VISIBLE_P (w, row))
>>       return 1;
>
> If a row is _not_ partially visible, it is _fully_ visible, right?

Hmmm ... yes.  Unless it's completely invisible.  I was probably fooled
by the inverted uses of fully and partially visible.

>> and
>>
>>     if (row->height >= window_height)
>>       {
>>         if (!force_p || MINI_WINDOW_P (w)
>> 	  || w->vscroll || w->cursor.vpos == 0)
>> 	return 1;
>>       }
>
> There's a comment that that's supposed to explain this.

I don't understand the

	  || w->vscroll || w->cursor.vpos == 0

disjuncts in the second conditional.  But I presume that this case is
too obscure anyway.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.