Subject: 24.4.50; USE_STACK_LISP_OBJECTS change breaks the build on many platforms

From: Ken Brown <[email-masked]>
Date: Wed, 24 Sep 2014 09:22:59 -0400

bzr rev 117935 breaks the build on all platforms other than GNU/Linux. 
The following patch restores the code to what I think was intended:

=== modified file 'src/lisp.h'
--- src/lisp.h  2014-09-24 11:59:13 +0000
+++ src/lisp.h  2014-09-24 12:59:07 +0000
@@ -290,9 +290,9 @@
  #ifndef USE_STACK_LISP_OBJECTS
  # if defined (GNU_LINUX) && defined (__GNUC__) && !defined (__clang__)
  #   define USE_STACK_LISP_OBJECTS true
+# else
+#   define USE_STACK_LISP_OBJECTS false
  # endif
-#else
-# define USE_STACK_LISP_OBJECTS false
  #endif

  #if defined HAVE_STRUCT_ATTRIBUTE_ALIGNED && USE_STACK_LISP_OBJECTS

In GNU Emacs 24.4.50.2 (x86_64-unknown-cygwin)
  of 2014-09-24 on fiona
Repository revision: 117935 
[email-masked]
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
  `configure --with-w32 --with-file-notification=no
  --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3''

Configured features:
XPM JPEG TIFF GIF PNG IMAGEMAGICK DBUS ACL GNUTLS LIBXML2 ZLIB

Important settings:
   value of $LANG: en_US.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t

Recent input:
M-x r e p o r t - e m <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind w32
multi-tty emacs)

Memory information:
((conses 16 78103 5040)
  (symbols 48 17816 0)
  (miscs 40 43 115)
  (strings 32 12754 3583)
  (string-bytes 1 313824)
  (vectors 16 10021)
  (vector-slots 8 382326 12678)
  (floats 8 70 196)
  (intervals 56 202 12)
  (buffers 976 12))