From unknown Mon Jun 23 04:15:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18536: [PATCH] Fix unread-string for characters 0x80 <= c < 0xf0 in UTF-8 Resent-From: David Kastrup Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 23 Sep 2014 15:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18536 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 18536@debbugs.gnu.org Cc: David Kastrup X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141148526713908 (code B ref -1); Tue, 23 Sep 2014 15:15:03 +0000 Received: (at submit) by debbugs.gnu.org; 23 Sep 2014 15:14:27 +0000 Received: from localhost ([127.0.0.1]:50093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWRnP-0003cG-1U for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53976) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWRnM-0003c7-Is for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWRnH-0001lZ-HS for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRnH-0001kY-FC for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjr-0002Wl-P3 for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWRjq-00013z-IP for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:47 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjp-00012g-OF for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:45 -0400 Received: from localhost ([127.0.0.1]:38654 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjk-0005MO-6J; Tue, 23 Sep 2014 11:10:40 -0400 Received: by lola (Postfix, from userid 1000) id 3D530E61BB; Tue, 23 Sep 2014 17:10:28 +0200 (CEST) From: David Kastrup Date: Tue, 23 Sep 2014 17:10:19 +0200 Message-Id: <1411485019-768-1-git-send-email-dak@gnu.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.7 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) * libguile/ports.c (scm_ungetc_unlocked): Fix bad reencoding. The code (with-input-from-string "" (lambda () (unread-string "\"=C3=A4\"" (current-input-port)) (read))) returns "?" instead of "=C3=A4". This bug was introduced in commit be7ecef05c1eea66f30360f658c610710c5cb22e Signed-off-by: David Kastrup --- libguile/ports.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/ports.c b/libguile/ports.c index 8185d85..3129282 100644 --- a/libguile/ports.c +++ b/libguile/ports.c @@ -2139,7 +2139,7 @@ scm_ungetc_unlocked (scm_t_wchar c, SCM port) =20 if (pti->encoding_mode =3D=3D SCM_PORT_ENCODING_MODE_UTF8) { - if (c < 0xf0) + if (c < 0x80) { result_buf[0] =3D (char) c; result =3D result_buf; --=20 1.9.1 From unknown Mon Jun 23 04:15:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Kastrup Subject: bug#18536: closed (Re: bug#18536: [PATCH] Fix unread-string for characters 0x80 <= c < 0xf0 in UTF-8) Message-ID: References: <87zjdphjw9.fsf@yeeloong.lan> <1411485019-768-1-git-send-email-dak@gnu.org> X-Gnu-PR-Message: they-closed 18536 X-Gnu-PR-Package: guile X-Gnu-PR-Keywords: patch Reply-To: 18536@debbugs.gnu.org Date: Wed, 24 Sep 2014 01:47:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1411523223-11502-1" This is a multi-part message in MIME format... ------------=_1411523223-11502-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #18536: [PATCH] Fix unread-string for characters 0x80 <=3D c < 0xf0 in UTF-8 which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 18536@debbugs.gnu.org. --=20 18536: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D18536 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1411523223-11502-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 18536-done) by debbugs.gnu.org; 24 Sep 2014 01:46:41 +0000 Received: from localhost ([127.0.0.1]:50355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWbfE-0002yx-NI for submit@debbugs.gnu.org; Tue, 23 Sep 2014 21:46:41 -0400 Received: from world.peace.net ([96.39.62.75]:52600) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWbfB-0002yo-Qc for 18536-done@debbugs.gnu.org; Tue, 23 Sep 2014 21:46:38 -0400 Received: from c-24-62-95-23.hsd1.ma.comcast.net ([24.62.95.23] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XWbf4-00061H-Qh; Tue, 23 Sep 2014 21:46:30 -0400 From: Mark H Weaver To: David Kastrup Subject: Re: bug#18536: [PATCH] Fix unread-string for characters 0x80 <= c < 0xf0 in UTF-8 References: <1411485019-768-1-git-send-email-dak@gnu.org> Date: Tue, 23 Sep 2014 21:44:38 -0400 In-Reply-To: <1411485019-768-1-git-send-email-dak@gnu.org> (David Kastrup's message of "Tue, 23 Sep 2014 17:10:19 +0200") Message-ID: <87zjdphjw9.fsf@yeeloong.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18536-done Cc: 18536-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Pushed to master, commit f7582f9807d9a10fba86f54c4aeaa7444c51a315. I'm closing this bug now. Thanks, Mark ------------=_1411523223-11502-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Sep 2014 15:14:27 +0000 Received: from localhost ([127.0.0.1]:50093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWRnP-0003cG-1U for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53976) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWRnM-0003c7-Is for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWRnH-0001lZ-HS for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRnH-0001kY-FC for submit@debbugs.gnu.org; Tue, 23 Sep 2014 11:14:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjr-0002Wl-P3 for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWRjq-00013z-IP for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:47 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjp-00012g-OF for bug-guile@gnu.org; Tue, 23 Sep 2014 11:10:45 -0400 Received: from localhost ([127.0.0.1]:38654 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWRjk-0005MO-6J; Tue, 23 Sep 2014 11:10:40 -0400 Received: by lola (Postfix, from userid 1000) id 3D530E61BB; Tue, 23 Sep 2014 17:10:28 +0200 (CEST) From: David Kastrup To: bug-guile@gnu.org Subject: [PATCH] Fix unread-string for characters 0x80 <= c < 0xf0 in UTF-8 Date: Tue, 23 Sep 2014 17:10:19 +0200 Message-Id: <1411485019-768-1-git-send-email-dak@gnu.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit Cc: David Kastrup X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) * libguile/ports.c (scm_ungetc_unlocked): Fix bad reencoding. The code (with-input-from-string "" (lambda () (unread-string "\"=C3=A4\"" (current-input-port)) (read))) returns "?" instead of "=C3=A4". This bug was introduced in commit be7ecef05c1eea66f30360f658c610710c5cb22e Signed-off-by: David Kastrup --- libguile/ports.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/ports.c b/libguile/ports.c index 8185d85..3129282 100644 --- a/libguile/ports.c +++ b/libguile/ports.c @@ -2139,7 +2139,7 @@ scm_ungetc_unlocked (scm_t_wchar c, SCM port) =20 if (pti->encoding_mode =3D=3D SCM_PORT_ENCODING_MODE_UTF8) { - if (c < 0xf0) + if (c < 0x80) { result_buf[0] =3D (char) c; result =3D result_buf; --=20 1.9.1 ------------=_1411523223-11502-1--