GNU bug report logs - #18531
[PATCH] man: Fix an inverted test that prevented dummy-man from working

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18531: closed ([PATCH] man: Fix an inverted test that
 prevented dummy-man from working)
Date: Mon, 22 Sep 2014 20:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 22 Sep 2014 21:02:02 +0100
with message-id <5420803A.6090308 <at> draigBrady.com>
and subject line Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working
has caused the debbugs.gnu.org bug report #18531,
regarding [PATCH] man: Fix an inverted test that prevented dummy-man from working
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18531: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18531
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alban Bedel <alban.bedel <at> avionic-design.de>
To: bug-coreutils <at> gnu.org
Cc: Alban Bedel <alban.bedel <at> avionic-design.de>
Subject: [PATCH] man: Fix an inverted test that prevented dummy-man from
 working
Date: Mon, 22 Sep 2014 11:53:13 +0200

The test for the argument count was broken, the upper limit test used
less-or-equal 1 instead of greater than 1.
---
 man/dummy-man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/dummy-man b/man/dummy-man
index bf31912..65b85d5 100755
--- a/man/dummy-man
+++ b/man/dummy-man
@@ -39,7 +39,7 @@ while test $# -gt 0; do
 done
 
 test $# -gt 0 || fatal_ "missing argument"
-test $# -le 1 || fatal_ "too many non-option arguments"
+test $# -gt 1 || fatal_ "too many non-option arguments"
 
 baseout=`basename_ "$output"`
 sed 's/^/WARNING: /' >&2 <<END
-- 
2.1.0

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: 18531-done <at> debbugs.gnu.org
Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented
 dummy-man from working
Date: Mon, 22 Sep 2014 21:02:02 +0100

On 09/22/2014 10:53 AM, Alban Bedel wrote:
> The test for the argument count was broken, the upper limit test used
> less-or-equal 1 instead of greater than 1.
> ---
>  man/dummy-man | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/dummy-man b/man/dummy-man
> index bf31912..65b85d5 100755
> --- a/man/dummy-man
> +++ b/man/dummy-man
> @@ -39,7 +39,7 @@ while test $# -gt 0; do
>  done
>  
>  test $# -gt 0 || fatal_ "missing argument"
> -test $# -le 1 || fatal_ "too many non-option arguments"
> +test $# -gt 1 || fatal_ "too many non-option arguments"
>  
>  baseout=`basename_ "$output"`
>  sed 's/^/WARNING: /' >&2 <<END

Nice one.

I've pushed that at:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=1f994f3

thanks!
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.