GNU bug report logs - #18531
[PATCH] man: Fix an inverted test that prevented dummy-man from working

Previous Next

Package: coreutils;

Reported by: Alban Bedel <alban.bedel <at> avionic-design.de>

Date: Mon, 22 Sep 2014 17:57:03 UTC

Severity: normal

Tags: fixed, patch

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 18531 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: 18531 <at> debbugs.gnu.org
Cc: alban.bedel <at> avionic-design.de, P <at> draigBrady.com
Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented
 dummy-man from working
Date: Mon, 22 Sep 2014 22:11:53 +0200

Pádraig Brady <P <at> draigBrady.com> writes:

> On 09/22/2014 10:53 AM, Alban Bedel wrote:
>> The test for the argument count was broken, the upper limit test used
>> less-or-equal 1 instead of greater than 1.
>> ---
>>  man/dummy-man | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/man/dummy-man b/man/dummy-man
>> index bf31912..65b85d5 100755
>> --- a/man/dummy-man
>> +++ b/man/dummy-man
>> @@ -39,7 +39,7 @@ while test $# -gt 0; do
>>  done
>>  
>>  test $# -gt 0 || fatal_ "missing argument"
>> -test $# -le 1 || fatal_ "too many non-option arguments"
>> +test $# -gt 1 || fatal_ "too many non-option arguments"
>>  
>>  baseout=`basename_ "$output"`
>>  sed 's/^/WARNING: /' >&2 <<END
>
> Nice one.

Huh?

$ man/dummy-man foo
man/dummy-man: too many non-option arguments

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
This bug report was last modified 6 years and 221 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.