From unknown Mon Jun 16 23:39:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18531 <18531@debbugs.gnu.org> To: bug#18531 <18531@debbugs.gnu.org> Subject: Status: [PATCH] man: Fix an inverted test that prevented dummy-man from working Reply-To: bug#18531 <18531@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:39:11 +0000 retitle 18531 [PATCH] man: Fix an inverted test that prevented dummy-man fr= om working reassign 18531 coreutils submitter 18531 Alban Bedel severity 18531 normal tag 18531 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 22 13:56:10 2014 Received: (at submit) by debbugs.gnu.org; 22 Sep 2014 17:56:10 +0000 Received: from localhost ([127.0.0.1]:49104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XW7qL-0007IK-Jw for submit@debbugs.gnu.org; Mon, 22 Sep 2014 13:56:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45386) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XW0LJ-00081A-AD for submit@debbugs.gnu.org; Mon, 22 Sep 2014 05:55:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW0L3-0003q5-WE for submit@debbugs.gnu.org; Mon, 22 Sep 2014 05:55:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0L3-0003nT-TE for submit@debbugs.gnu.org; Mon, 22 Sep 2014 05:55:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0JW-0001q4-QD for bug-coreutils@gnu.org; Mon, 22 Sep 2014 05:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW0JP-0003JG-1e for bug-coreutils@gnu.org; Mon, 22 Sep 2014 05:53:46 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW0JO-0003Iz-O4 for bug-coreutils@gnu.org; Mon, 22 Sep 2014 05:53:38 -0400 Received: from mailbox.adnet.avionic-design.de (mailbox.avionic-design.de [109.75.18.3]) by mrelayeu.kundenserver.de (node=mreue103) with ESMTP (Nemesis) id 0Lwnl2-1YOkct2YlU-016L0b; Mon, 22 Sep 2014 11:53:31 +0200 Received: from localhost (localhost [127.0.0.1]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id 4A68A2A2812E; Mon, 22 Sep 2014 11:53:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at avionic-design.de Received: from mailbox.adnet.avionic-design.de ([127.0.0.1]) by localhost (mailbox.avionic-design.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NqUrCwKjSMzB; Mon, 22 Sep 2014 11:53:29 +0200 (CEST) Received: from avionic-0020.adnet.avionic-design.de (avionic-0020.adnet.avionic-design.de [172.20.31.243]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id C82F62A28122; Mon, 22 Sep 2014 11:53:29 +0200 (CEST) From: Alban Bedel To: bug-coreutils@gnu.org Subject: [PATCH] man: Fix an inverted test that prevented dummy-man from working Date: Mon, 22 Sep 2014 11:53:13 +0200 Message-Id: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> X-Mailer: git-send-email 2.1.0 X-Provags-ID: V02:K0:U8q5i7yiGfA1AHSHGPo0sN4Jx0pVbV43hB5NPtXvQqs XD1Dr9UiXPfeN//wRyttyTmocZxO++LWhwfq0mw+cVAF4bbzYo H4QMhPPBWKEJkDMrxZsrh7eliXFZYh8WeoAaIEnMGuKjFQ/3gg tIhjdsO/RhNt9JFyUuhqpCsTO0EdElA4L7Y6PJt+lauzdOFIwc ZUTUSigqb8oCWXP392ASQ4LTBojONfYIzKTGw3J9erwoHm4+O7 Y4EhtB5QkUgPb0CXIwLHTLNTL3oSQYb/obe/EWx2YqnVvoG3ze 3ja8JuUz0t+jM/Dn6WW99rkM3Q33S/3Xv7FOEtVur2NXl422wD TRKoyweobucC1/CufcN/kgvkiXCu/X3dJJqXDGaWg9WZ3ZXiOd t9Q2kMzk8oHQMIE5qyedsBm7jZgiQRzicYnvpnz2j5yE4HxcHx krrOb X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 22 Sep 2014 13:56:06 -0400 Cc: Alban Bedel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The test for the argument count was broken, the upper limit test used less-or-equal 1 instead of greater than 1. --- man/dummy-man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/dummy-man b/man/dummy-man index bf31912..65b85d5 100755 --- a/man/dummy-man +++ b/man/dummy-man @@ -39,7 +39,7 @@ while test $# -gt 0; do done test $# -gt 0 || fatal_ "missing argument" -test $# -le 1 || fatal_ "too many non-option arguments" +test $# -gt 1 || fatal_ "too many non-option arguments" baseout=`basename_ "$output"` sed 's/^/WARNING: /' >&2 <) id 1XW9oc-0001z2-ET for submit@debbugs.gnu.org; Mon, 22 Sep 2014 16:02:30 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:14172) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XW9oZ-0001yq-S4 for 18531-done@debbugs.gnu.org; Mon, 22 Sep 2014 16:02:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqoBAFl/IFRtTsx//2dsb2JhbAANU4NhVwHKU4dNAYEpAYR+AQEEMgFWCw0LCRYPCQMCAQIBRRMIAQGIPwitepZrARePIg1eFoQ1BY9Ahk+OfI97gURsAYEEAYFDAQEB Received: from unknown (HELO [192.168.1.79]) ([109.78.204.127]) by mail1.vodafone.ie with ESMTP; 22 Sep 2014 21:02:04 +0100 Message-ID: <5420803A.6090308@draigBrady.com> Date: Mon, 22 Sep 2014 21:02:02 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: 18531-done@debbugs.gnu.org Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> In-Reply-To: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/22/2014 10:53 AM, Alban Bedel wrote: > The test for the argument count was broken, the upper limit test used > less-or-equal 1 instead of greater than 1. > --- > man/dummy-man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/dummy-man b/man/dummy-man > index bf31912..65b85d5 100755 > --- a/man/dummy-man > +++ b/man/dummy-man > @@ -39,7 +39,7 @@ while test $# -gt 0; do > done > > test $# -gt 0 || fatal_ "missing argument" > -test $# -le 1 || fatal_ "too many non-option arguments" > +test $# -gt 1 || fatal_ "too many non-option arguments" > > baseout=`basename_ "$output"` > sed 's/^/WARNING: /' >&2 <) id 1XW9xn-0002Cg-Lj for submit@debbugs.gnu.org; Mon, 22 Sep 2014 16:11:59 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:56184) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XW9xk-0002CW-T8 for 18531@debbugs.gnu.org; Mon, 22 Sep 2014 16:11:57 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3j1xd72HTBz3hlTK; Mon, 22 Sep 2014 22:11:55 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3j1xd71TjXzvh26; Mon, 22 Sep 2014 22:11:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 72F91C0CQQXk; Mon, 22 Sep 2014 22:11:54 +0200 (CEST) X-Auth-Info: kMqi7bowhuuXgejqdXP2akstjQ0MbhjcVU4XJ5kVZuOe80zXLZz6VSLyZPRNaG1w Received: from igel.home (ppp-93-104-158-140.dynamic.mnet-online.de [93.104.158.140]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 22 Sep 2014 22:11:54 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 0542B2C30B4; Mon, 22 Sep 2014 22:11:54 +0200 (CEST) From: Andreas Schwab To: 18531@debbugs.gnu.org Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> <5420803A.6090308@draigBrady.com> X-Yow: I was born in a Hostess Cupcake factory before the sexual revolution! Date: Mon, 22 Sep 2014 22:11:53 +0200 In-Reply-To: <5420803A.6090308@draigBrady.com> (=?utf-8?Q?=22P=C3=A1draig?= Brady"'s message of "Mon, 22 Sep 2014 21:02:02 +0100") Message-ID: <87mw9rbek6.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531 Cc: alban.bedel@avionic-design.de, P@draigBrady.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Pádraig Brady writes: > On 09/22/2014 10:53 AM, Alban Bedel wrote: >> The test for the argument count was broken, the upper limit test used >> less-or-equal 1 instead of greater than 1. >> --- >> man/dummy-man | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/man/dummy-man b/man/dummy-man >> index bf31912..65b85d5 100755 >> --- a/man/dummy-man >> +++ b/man/dummy-man >> @@ -39,7 +39,7 @@ while test $# -gt 0; do >> done >> >> test $# -gt 0 || fatal_ "missing argument" >> -test $# -le 1 || fatal_ "too many non-option arguments" >> +test $# -gt 1 || fatal_ "too many non-option arguments" >> >> baseout=`basename_ "$output"` >> sed 's/^/WARNING: /' >&2 < > Nice one. Huh? $ man/dummy-man foo man/dummy-man: too many non-option arguments Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 22 17:27:15 2014 Received: (at 18531-done) by debbugs.gnu.org; 22 Sep 2014 21:27:15 +0000 Received: from localhost ([127.0.0.1]:49257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWB8d-0004BJ-29 for submit@debbugs.gnu.org; Mon, 22 Sep 2014 17:27:15 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:49535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWB8b-0004B9-IX for 18531-done@debbugs.gnu.org; Mon, 22 Sep 2014 17:27:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqcBAMSSIFRtTgpu/2dsb2JhbAANU4NhWNIhAYEqAYR+AQUyAUYQCw0LCRYPCQMCAQIBRQYNAQcBAYg/rg6XDY8iDVcHhEsFlg+OfI97gUSBcQGBQwEBAQ Received: from unknown (HELO [192.168.1.79]) ([109.78.10.110]) by mail2.vodafone.ie with ESMTP; 22 Sep 2014 19:39:05 +0100 Message-ID: <54206CC8.3000002@draigBrady.com> Date: Mon, 22 Sep 2014 19:39:04 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Alban Bedel Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> In-Reply-To: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531-done Cc: 18531-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/22/2014 10:53 AM, Alban Bedel wrote: > The test for the argument count was broken, the upper limit test used > less-or-equal 1 instead of greater than 1. > --- > man/dummy-man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/dummy-man b/man/dummy-man > index bf31912..65b85d5 100755 > --- a/man/dummy-man > +++ b/man/dummy-man > @@ -39,7 +39,7 @@ while test $# -gt 0; do > done > > test $# -gt 0 || fatal_ "missing argument" > -test $# -le 1 || fatal_ "too many non-option arguments" > +test $# -gt 1 || fatal_ "too many non-option arguments" > > baseout=`basename_ "$output"` > sed 's/^/WARNING: /' >&2 < Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Mon, 22 Sep 2014 21:37:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 22 17:42:42 2014 Received: (at 18531) by debbugs.gnu.org; 22 Sep 2014 21:42:42 +0000 Received: from localhost ([127.0.0.1]:49269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWBNa-0004Zr-Az for submit@debbugs.gnu.org; Mon, 22 Sep 2014 17:42:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:51175) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWBNX-0004Zh-3f for 18531@debbugs.gnu.org; Mon, 22 Sep 2014 17:42:39 -0400 Received: from [192.168.1.10] (pD957CBB4.dip0.t-ipconnect.de [217.87.203.180]) by mrelayeu.kundenserver.de (node=mreue104) with ESMTP (Nemesis) id 0M7az9-1YTD3M1tfL-00xKVj; Mon, 22 Sep 2014 23:42:35 +0200 Message-ID: <542097CA.2010702@bernhard-voelker.de> Date: Mon, 22 Sep 2014 23:42:34 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Andreas Schwab , 18531@debbugs.gnu.org Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> <5420803A.6090308@draigBrady.com> <87mw9rbek6.fsf@igel.home> In-Reply-To: <87mw9rbek6.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:FdCTR0roK04UAaiFpuYlG1jI4a/HGEVwxFNOIGfCpIm hetT+6Gef+tj9TZHnTEAAkL+FDEDj1WIzAVLhFVtcppjYl3IdS gxFL/Tz88fOUEFi0eSy7R4pwXDvdIvcxe8eSisRSggtLdQda+7 qVziU8wDkHm40v7xEGYxiWj4nrhIeVq7lcc76Ao2k76x4jnkbv S8t+nLSoaijmTev38XWNRNFsbW33ad3/0EoIfd4+ZY8GblojGq 7xcSHcqYUKhsJPg37NZZwOvo7BHdIpm1upxWd4wTQ+iN5hWMLZ uEzzMCfgqqr/e8ctZqMPH2TaWb+SQL/I7YpN55FhbtXUPj6nVD 2GEftkifbSISM7bf4l/LK0l1aCUD9/IewRAMZwBYY X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531 Cc: alban.bedel@avionic-design.de, P@draigBrady.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/22/2014 10:11 PM, Andreas Schwab wrote: > Pádraig Brady writes: > >> On 09/22/2014 10:53 AM, Alban Bedel wrote: >>> diff --git a/man/dummy-man b/man/dummy-man >>> index bf31912..65b85d5 100755 >>> --- a/man/dummy-man >>> +++ b/man/dummy-man >>> @@ -39,7 +39,7 @@ while test $# -gt 0; do >>> done >>> >>> test $# -gt 0 || fatal_ "missing argument" >>> -test $# -le 1 || fatal_ "too many non-option arguments" >>> +test $# -gt 1 || fatal_ "too many non-option arguments" >>> >>> baseout=`basename_ "$output"` >>> sed 's/^/WARNING: /' >&2 <> >> Nice one. > > Huh? > > $ man/dummy-man foo > man/dummy-man: too many non-option arguments > > Andreas. > oops, in commit b3578fc9ffe70b9466687f9f6470a85f1a0ab14f I added the --info-page=... option _after_ the program argument in local.mk. The original help2man doesn't have a problem with that, as it does the normal GNU option parsing, but the parsing loop in dummy-man stops parsing when it hit the program argument, thus leaving $# = 2 (and the --info-page option unused). I'll propose a fix for both the test in dummy-man and local.mk soon. Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 22 19:53:15 2014 Received: (at 18531) by debbugs.gnu.org; 22 Sep 2014 23:53:15 +0000 Received: from localhost ([127.0.0.1]:49288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWDPu-0000jq-Cr for submit@debbugs.gnu.org; Mon, 22 Sep 2014 19:53:14 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:50687) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWDPq-0000jg-Eh for 18531@debbugs.gnu.org; Mon, 22 Sep 2014 19:53:11 -0400 Received: from [192.168.1.10] (pD957CBB4.dip0.t-ipconnect.de [217.87.203.180]) by mrelayeu.kundenserver.de (node=mreue105) with ESMTP (Nemesis) id 0LfSUj-1Y3JF7066j-00p4Up; Tue, 23 Sep 2014 01:53:08 +0200 Message-ID: <5420B663.2090702@bernhard-voelker.de> Date: Tue, 23 Sep 2014 01:53:07 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Andreas Schwab , 18531@debbugs.gnu.org, P@draigBrady.com Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> <5420803A.6090308@draigBrady.com> <87mw9rbek6.fsf@igel.home> <542097CA.2010702@bernhard-voelker.de> In-Reply-To: <542097CA.2010702@bernhard-voelker.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:XHPfs9crRsP70Ya8I/0dCm4aFlvJZ8qTBtf+Te362Tw tFj0PSSXt8urnwH8IHu1TGqNzaZ6Ny0PSzndHMKGPbXAyNG4wZ xAN2k5KlCXrOTMFQLAorHZuzQUN9H/Gf36vsswlHM82uwX3Mam bKq7WfkNGLRKzBFv9bNlXL6IUsQFV62rxShiUyEj5ku4fYlbt5 G8rK+JivTXq2uAhI180CqtfPJ+P1IkamsP7zyz/PBPgBoDXFf1 IzmfoYnZzwSKwrUiRAT/eTSy5Ap7wa20Yr68tKz43IZui2iaPP 4J/6uUKj2h5ki7rGOddfqmGDgVLzimPsPc0So7MeDd5zH3YDsr yHArfPioapfjNqV9gtXmanbjVPoJpMiCxM2MUeUni X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531 Cc: alban.bedel@avionic-design.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/22/2014 11:42 PM, Bernhard Voelker wrote: > On 09/22/2014 10:11 PM, Andreas Schwab wrote: >> Pádraig Brady writes: >>> On 09/22/2014 10:53 AM, Alban Bedel wrote: >> Huh? >> >> $ man/dummy-man foo >> man/dummy-man: too many non-option arguments >> >> Andreas. >> > > oops, in commit b3578fc9ffe70b9466687f9f6470a85f1a0ab14f > I added the --info-page=... option _after_ the program argument > in local.mk. The original help2man doesn't have a problem with > that, as it does the normal GNU option parsing, but the parsing > loop in dummy-man stops parsing when it hit the program argument, > thus leaving $# = 2 (and the --info-page option unused). > > I'll propose a fix for both the test in dummy-man and local.mk > soon. The proper fix for 'dummy-man' would have been to read the program name argument in the above while loop, checking that such a non-option argument has only been passed once, and then check the final remaining argument count again. I took the easier road, and only fixed the error condition in patch 1, while patch 2 fixes the caller in local.mk. Have a nice day, Berny >From bf2057b20b6c84d792816898dcded905bfdb146f Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 23 Sep 2014 01:44:51 +0200 Subject: [PATCH 1/2] build: fix argument count check in dummy-man again * man/dummy-man: Fix argument count check, now only permitting exactly 1 argument, the program name. Reported by Andreas Schwab --- man/dummy-man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/dummy-man b/man/dummy-man index 65b85d5..bf31912 100755 --- a/man/dummy-man +++ b/man/dummy-man @@ -39,7 +39,7 @@ while test $# -gt 0; do done test $# -gt 0 || fatal_ "missing argument" -test $# -gt 1 || fatal_ "too many non-option arguments" +test $# -le 1 || fatal_ "too many non-option arguments" baseout=`basename_ "$output"` sed 's/^/WARNING: /' >&2 <From d2bcb04400cb00ffd55e7a1d4e5a8e3e7329c062 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Tue, 23 Sep 2014 01:49:47 +0200 Subject: [PATCH 2/2] build: pass program name to help2man after other options * man/local.mk (.x.1): Move the program name argument down after the last option argument when calling $(run_help2man). While the other way would be accepted for the GNU help2man program, it is not for the 'dummy-man' script (called as a fallback on systems lacking perl). The wrong order was introduced in commit v8.21-119-gb3578fc while adding the --info-page option. --- man/local.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man/local.mk b/man/local.mk index 61ecd00..24cdce0 100644 --- a/man/local.mk +++ b/man/local.mk @@ -187,8 +187,9 @@ endif && $(run_help2man) \ --source='$(PACKAGE_STRING)' \ --include=$(srcdir)/man/$$name.x \ - --output=$$t/$$name.1 $$t/$$argv \ + --output=$$t/$$name.1 \ --info-page='\(aq(coreutils) '$$name' invocation\(aq' \ + $$t/$$argv \ && sed \ -e 's|$*\.td/||g' \ -e '/For complete documentation/d' \ -- 1.8.4.5 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 22 20:55:12 2014 Received: (at 18531) by debbugs.gnu.org; 23 Sep 2014 00:55:12 +0000 Received: from localhost ([127.0.0.1]:49295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWENr-0002IK-MY for submit@debbugs.gnu.org; Mon, 22 Sep 2014 20:55:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37602) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWENo-0002I9-1t for 18531@debbugs.gnu.org; Mon, 22 Sep 2014 20:55:09 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8N0swke028438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Sep 2014 20:54:58 -0400 Received: from [10.36.116.31] (ovpn-116-31.ams2.redhat.com [10.36.116.31]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8N0ssUJ010806 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 22 Sep 2014 20:54:56 -0400 Message-ID: <5420C4DD.7040003@draigBrady.com> Date: Tue, 23 Sep 2014 01:54:53 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> <5420803A.6090308@draigBrady.com> <87mw9rbek6.fsf@igel.home> <542097CA.2010702@bernhard-voelker.de> <5420B663.2090702@bernhard-voelker.de> In-Reply-To: <5420B663.2090702@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 18531 Cc: alban.bedel@avionic-design.de, 18531@debbugs.gnu.org, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 09/23/2014 12:53 AM, Bernhard Voelker wrote: > On 09/22/2014 11:42 PM, Bernhard Voelker wrote: >> On 09/22/2014 10:11 PM, Andreas Schwab wrote: >>> Pádraig Brady writes: >>>> On 09/22/2014 10:53 AM, Alban Bedel wrote: >>> Huh? >>> >>> $ man/dummy-man foo >>> man/dummy-man: too many non-option arguments >>> >>> Andreas. >>> >> >> oops, in commit b3578fc9ffe70b9466687f9f6470a85f1a0ab14f >> I added the --info-page=... option _after_ the program argument >> in local.mk. The original help2man doesn't have a problem with >> that, as it does the normal GNU option parsing, but the parsing >> loop in dummy-man stops parsing when it hit the program argument, >> thus leaving $# = 2 (and the --info-page option unused). >> >> I'll propose a fix for both the test in dummy-man and local.mk >> soon. > > The proper fix for 'dummy-man' would have been to read the program > name argument in the above while loop, checking that such a non-option > argument has only been passed once, and then check the final remaining > argument count again. > I took the easier road, and only fixed the error condition in patch 1, > while patch 2 fixes the caller in local.mk. > > Have a nice day, > Berny > > >>>From bf2057b20b6c84d792816898dcded905bfdb146f Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker > Date: Tue, 23 Sep 2014 01:44:51 +0200 > Subject: [PATCH 1/2] build: fix argument count check in dummy-man again > > * man/dummy-man: Fix argument count check, now only permitting > exactly 1 argument, the program name. > Reported by Andreas Schwab > --- > man/dummy-man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/dummy-man b/man/dummy-man > index 65b85d5..bf31912 100755 > --- a/man/dummy-man > +++ b/man/dummy-man > @@ -39,7 +39,7 @@ while test $# -gt 0; do > done > > test $# -gt 0 || fatal_ "missing argument" > -test $# -gt 1 || fatal_ "too many non-option arguments" > +test $# -le 1 || fatal_ "too many non-option arguments" > > baseout=`basename_ "$output"` > sed 's/^/WARNING: /' >&2 <) id 1XWKS0-0003pG-Ky for submit@debbugs.gnu.org; Tue, 23 Sep 2014 03:23:53 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61463) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWKRy-0003p8-E9 for 18531@debbugs.gnu.org; Tue, 23 Sep 2014 03:23:51 -0400 Received: from [10.0.4.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreue104) with ESMTP (Nemesis) id 0LoZ6A-1YCqHB3GlG-00gUuo; Tue, 23 Sep 2014 09:23:48 +0200 Message-ID: <54212002.1030504@bernhard-voelker.de> Date: Tue, 23 Sep 2014 09:23:46 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working References: <1411379593-22830-1-git-send-email-alban.bedel@avionic-design.de> <5420803A.6090308@draigBrady.com> <87mw9rbek6.fsf@igel.home> <542097CA.2010702@bernhard-voelker.de> <5420B663.2090702@bernhard-voelker.de> <5420C4DD.7040003@draigBrady.com> In-Reply-To: <5420C4DD.7040003@draigBrady.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:RTGmHFOyVRahIk39vjuzI3qjJy6+PtymuLnfFcX5aSr 4AW6SL2B+OXE/p1npVeKFXRSYqOU7bQf6a4Mf357Hm4ZyZliqK YYzFfPOGtA7r7KYq6Ygp9KTL5Gj6sbmBLh4WEr6W9YYvbYfP/B tkP9U2qxOZKwRovGdrvQlWILnq/Gbv5S3yD9nx3I6cQqLaX+CW 7vzez0BvDez13ANqCwLssPM4dfmNpqfoRxyiJqAHC1pOKkgVrp XOTv2ZW+ONI1o5GN8mjDlom6dAGpE3lBC1HRDuQCCHtlfNk7Zi ClRiy7D7E/I0qztArTitl35frrsqbAnt4+93+NroQV/iFeI7TK h5d4H+QDBSifK/aZD9sK0iD9pLdlV0SH8S8rlH6Kg X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18531 Cc: alban.bedel@avionic-design.de, 18531@debbugs.gnu.org, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/23/2014 02:54 AM, Pádraig Brady wrote: > [...]The above two patches are obviously > the correct fix. Thanks, pushed. Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 10 11:53:16 2018 Received: (at control) by debbugs.gnu.org; 10 Oct 2018 15:53:16 +0000 Received: from localhost ([127.0.0.1]:43702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAGnR-0000aZ-Uf for submit@debbugs.gnu.org; Wed, 10 Oct 2018 11:53:16 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:43337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAGnQ-0000aN-Dj for control@debbugs.gnu.org; Wed, 10 Oct 2018 11:53:12 -0400 Received: by mail-pl1-f176.google.com with SMTP id 30-v6so2728944plb.10 for ; Wed, 10 Oct 2018 08:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=GBwryLuVyf0v48fz8kIG9SeN9dZF9WX518JvUYXRzMs=; b=QYSiDeNW8t0owFlJ28HOKvmPYHzGSWf2nYGxZ8T1HdvbB+IiSs8G7b0o7TvChKAyCp es+SjGkYr9FZPafWGeYCYJR7LRSdLM/UTEWcTztXQUDzjVxUUEwBAiOsUrGmMyIZRW39 Rs2GHVMvRrgHZnnJP7rH6nTnnsxyoD1grbpvPE+MKh8Gw2+YpRjuCPv6RTVSskmQeLr7 S8GqjZ+Lfz5pe1Aoy40EJXZTH9AkbUbq+mpxuvBlvIYHVNe/Wn5FQc/CgOwBPnJG8FUi XZNeHI6sIUk4L8L4m3oOY66RsbOWPx6IDGTn9kN0b6v1gmfNwEb+gOvkJg8cNI099ANH 8esA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=GBwryLuVyf0v48fz8kIG9SeN9dZF9WX518JvUYXRzMs=; b=PqU1gVt9I6HM61N1xSR+ea6A7Hp+Py3CQnde9n0rpIcYhkmqSK9XlEHH6PCwTEilpt 55PyhHW/BxksjObIQ7zf6PGmtdwLpa9ijau67sFhYEo1yFcROElR/gsLCX6mt+xda75R OlkcAqrs+G4gZkWqwYbiuh9lTCnco6pNJwmsfNolmums26YMlmBG/QaXEqeI4R2Ar1Q2 Dlh4d7cpt08BKCZUqVRnmkMRHLztTh3cJg3RhmQpbx3ivq8SrFjXELNbctczhk72iDtK lyqCFNgIYa/By9SXpFMT1V2evSM/12RcVmzMOy95tBQF4cXH83l4vdJoWKh15xa+XDWO x6Bw== X-Gm-Message-State: ABuFfojCxaB3839ouAoYHA/CAWS/F07PKTVvvVUU5cC9jU9mhCcg5C5F eBG9j2eb27aH49af5QOy+05XGZMM+q4= X-Google-Smtp-Source: ACcGV63be+PgrpFXoZPsRxQsyfXfn0CMPG3CQsuaMS6Yy5+2z2tfPnEZ9Vt4BMc8Lkgx/+L/DKzPfQ== X-Received: by 2002:a17:902:b482:: with SMTP id y2-v6mr315322plr.322.1539186785953; Wed, 10 Oct 2018 08:53:05 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id b62-v6sm35892109pfa.159.2018.10.10.08.53.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Oct 2018 08:53:04 -0700 (PDT) To: control@debbugs.gnu.org From: Assaf Gordon Message-ID: <85104995-e015-d1c8-a457-7ac3b4349742@gmail.com> Date: Wed, 10 Oct 2018 09:53:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 18062 fixed close 18062 tags 16940 fixed close 16940 tags 17590 fixed close 17590 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.214.176 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (assafgordon[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 18062 fixed close 18062 tags 16940 fixed close 16940 tags 17590 fixed close 17590 tags 18316 fixed close 18316 tags 18531 fixed close 18531 From unknown Mon Jun 16 23:39:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Nov 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator