Subject: bug#18531: closed (Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 22 Sep 2014 20:03:02 +0000

Your bug report

#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
18531: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18531
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working
From: Pádraig Brady <[email-masked]>
To: [email-masked]
Date: Mon, 22 Sep 2014 21:02:02 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On 09/22/2014 10:53 AM, Alban Bedel wrote:
> The test for the argument count was broken, the upper limit test used
> less-or-equal 1 instead of greater than 1.
> ---
>  man/dummy-man | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/dummy-man b/man/dummy-man
> index bf31912..65b85d5 100755
> --- a/man/dummy-man
> +++ b/man/dummy-man
> @@ -39,7 +39,7 @@ while test $# -gt 0; do
>  done
>  
>  test $# -gt 0 || fatal_ "missing argument"
> -test $# -le 1 || fatal_ "too many non-option arguments"
> +test $# -gt 1 || fatal_ "too many non-option arguments"
>  
>  baseout=`basename_ "$output"`
>  sed 's/^/WARNING: /' >&2 <<END

Nice one.

I've pushed that at:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=1f994f3

thanks!
Pádraig.

Subject: [PATCH] man: Fix an inverted test that prevented dummy-man from working
From: Alban Bedel <[email-masked]>
To: [email-masked]
Cc: Alban Bedel <[email-masked]>
Date: Mon, 22 Sep 2014 11:53:13 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

The test for the argument count was broken, the upper limit test used
less-or-equal 1 instead of greater than 1.
---
 man/dummy-man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/dummy-man b/man/dummy-man
index bf31912..65b85d5 100755
--- a/man/dummy-man
+++ b/man/dummy-man
@@ -39,7 +39,7 @@ while test $# -gt 0; do
 done
 
 test $# -gt 0 || fatal_ "missing argument"
-test $# -le 1 || fatal_ "too many non-option arguments"
+test $# -gt 1 || fatal_ "too many non-option arguments"
 
 baseout=`basename_ "$output"`
 sed 's/^/WARNING: /' >&2 <<END
-- 
2.1.0