Subject: Re: bug#18531: [PATCH] man: Fix an inverted test that prevented dummy-man from working

From: Bernhard Voelker <[email-masked]>
Date: Mon, 22 Sep 2014 23:42:34 +0200

On 09/22/2014 10:11 PM, Andreas Schwab wrote:
> Pádraig Brady <[email-masked]> writes:
> 
>> On 09/22/2014 10:53 AM, Alban Bedel wrote:
>>> diff --git a/man/dummy-man b/man/dummy-man
>>> index bf31912..65b85d5 100755
>>> --- a/man/dummy-man
>>> +++ b/man/dummy-man
>>> @@ -39,7 +39,7 @@ while test $# -gt 0; do
>>>  done
>>>  
>>>  test $# -gt 0 || fatal_ "missing argument"
>>> -test $# -le 1 || fatal_ "too many non-option arguments"
>>> +test $# -gt 1 || fatal_ "too many non-option arguments"
>>>  
>>>  baseout=`basename_ "$output"`
>>>  sed 's/^/WARNING: /' >&2 <<END
>>
>> Nice one.
> 
> Huh?
> 
> $ man/dummy-man foo
> man/dummy-man: too many non-option arguments
> 
> Andreas.
> 

oops, in commit b3578fc9ffe70b9466687f9f6470a85f1a0ab14f
I added the --info-page=... option _after_ the program argument
in local.mk.  The original help2man doesn't have a problem with
that, as it does the normal GNU option parsing, but the parsing
loop in dummy-man stops parsing when it hit the program argument,
thus leaving $# = 2 (and the --info-page option unused).

I'll propose a fix for both the test in dummy-man and local.mk
soon.

Have a nice day,
Berny