From stephen.berman@gmx.net Sat Jan 10 13:20:24 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 10 Jan 2009 21:20:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0ALKKQA024489 for ; Sat, 10 Jan 2009 13:20:21 -0800 Received: from mail.gnu.org ([199.232.76.166]:49804 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LLlEW-0005yO-AP for emacs-pretest-bug@gnu.org; Sat, 10 Jan 2009 16:19:04 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LLlFi-0003uH-Ka for emacs-pretest-bug@gnu.org; Sat, 10 Jan 2009 16:20:19 -0500 Received: from mail.gmx.net ([213.165.64.20]:47121) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LLlFh-0003sn-UQ for emacs-pretest-bug@gnu.org; Sat, 10 Jan 2009 16:20:18 -0500 Received: (qmail invoked by alias); 10 Jan 2009 21:20:14 -0000 Received: from i59F5760E.versanet.de (EHLO escher.local.home) [89.245.118.14] by mail.gmx.net (mp041) with SMTP; 10 Jan 2009 22:20:14 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+pSiw8xX6pCnSuls6DCJU2sUrJT5GkCfMB4IhheL nqr3MlUP/QiPmM Received: by escher.local.home (Postfix, from userid 1000) id 2131A1D105D; Sat, 10 Jan 2009 22:20:14 +0100 (CET) From: Stephen Berman To: emacs-pretest-bug@gnu.org Subject: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) Sender: steve@escher.local.home Date: Sat, 10 Jan 2009 22:20:13 +0100 Message-ID: <87y6xieu42.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.49 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) The bug described below still exists in GNU Emacs 23.0.60.28 (i686-pc-linux-gnu, GTK+ Version 2.14.4) of 2009-01-09 on escher, so I'm submitting it to the bug tracker. Note that the cited sexp from faces.el is now at line 1360, not 1307. From: Stephen Berman Subject: describe-face: Wrong type argument: symbolp, (:slant oblique) Newsgroups: gmane.emacs.devel To: emacs-devel@gnu.org Date: Mon, 26 May 2008 00:59:57 +0200 In GNU Emacs 23.0.60.4 (i686-pc-linux-gnu, GTK+ Version 2.12.0) of 2008-05-25 on escher 1. emacs -q 2. Put the cursor on any of the characters in the phrase "ABSOLUTELY NO WARRANTY" in the splash screen. 3. Type C-u C-x = 4. In the resulting *Help* buffer click on the link labelled "(variable-pitch (:slant oblique))" => Emacs beeps and throws the error in the Subject line. This happens at line 1307 in faces.el, which is this sexp: (insert "Face: " (symbol-name f)) when `f' gets the value `(:slant oblique)', which it does because the list '(variable-pitch (:slant oblique)) is the value of 'face in the plist of the character at point (as shown by text-properties-at). I don't know what the best fix is. (In earlier versions of Emacs, including CVS trunk of 2007-08-24, this value was '(variable-pitch :slant oblique), and doing the above steps does not raise an error, but the resulting *Help* buffer contains these dubious lines: Face: :slant undefined face. Face: oblique undefined face. But in this version a wrong type argument error is also raised by the above recipe for plist 'face values such as '(variable-pitch :foreground "red"), on the string. I could not determine when the change in the representation of the plist value of 'face occurred, because I couldn't figure out which part of the code constructs this plist.) Steve Berman From cyd@stupidchicken.com Sun Jan 11 09:28:59 2009 Received: (at 1852-done) by emacsbugs.donarmstrong.com; 11 Jan 2009 17:28:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0BHSuxL009338 for <1852-done@emacsbugs.donarmstrong.com>; Sun, 11 Jan 2009 09:28:57 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 2791657E18A; Sun, 11 Jan 2009 12:29:10 -0500 (EST) From: Chong Yidong To: Stephen Berman Cc: 1852-done@debbugs.gnu.org Subject: Re: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) Date: Sun, 11 Jan 2009 12:29:10 -0500 Message-ID: <87tz8569ax.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > 1. emacs -q > 2. Put the cursor on any of the characters in the phrase "ABSOLUTELY NO > WARRANTY" in the splash screen. > 3. Type C-u C-x = > 4. In the resulting *Help* buffer click on the link labelled > "(variable-pitch (:slant oblique))" > => Emacs beeps and throws the error in the Subject line. Since anonymous faces can't be usefully customized, I've changed describe-face to ignore those. Thanks for the bug report. From stephen.berman@gmx.net Sun Jan 11 14:29:45 2009 Received: (at 1852) by emacsbugs.donarmstrong.com; 11 Jan 2009 22:29:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.0 required=4.0 tests=FAKE_REPLY_C autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n0BMTap8021364 for <1852@emacsbugs.donarmstrong.com>; Sun, 11 Jan 2009 14:29:38 -0800 Received: (qmail invoked by alias); 11 Jan 2009 22:29:31 -0000 Received: from i59F55CA7.versanet.de (EHLO escher.local.home) [89.245.92.167] by mail.gmx.net (mp068) with SMTP; 11 Jan 2009 23:29:31 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+zJOBUZmWzSOpl65vjYygqySIECtl+HqNQM7LH2u f4EB9cNWs/iOWM Received: by escher.local.home (Postfix, from userid 1000) id 241E31D103C; Sun, 11 Jan 2009 23:29:30 +0100 (CET) From: Stephen Berman To: 1852@debbugs.gnu.org Cc: Chong Yidong Subject: Re: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) Sender: steve@escher.local.home Date: Sun, 11 Jan 2009 23:29:29 +0100 Message-ID: <87vdslfpdi.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.58 >> 1. emacs -q >> 2. Put the cursor on any of the characters in the phrase "ABSOLUTELY NO >> WARRANTY" in the splash screen. >> 3. Type C-u C-x = >> 4. In the resulting *Help* buffer click on the link labelled >> "(variable-pitch (:slant oblique))" >> => Emacs beeps and throws the error in the Subject line. > > Since anonymous faces can't be usefully customized, I've changed > describe-face to ignore those. Thanks for the bug report. Your fix prevents the error from being raised at step 4 above; however, the behavior is nevertheless still not what I would naively expect: namely, now it switches to a *Help* buffer describing variable-pitch face, containing the line Slant: unspecified i.e., this is not the face that I clicked to get a description of (as the tooltip also promises). Wouldn't it be better (if readily implementable) to exclude `(:slant oblique)' from the the describe-face link? Steve Berman From cyd@stupidchicken.com Sun Jan 11 18:38:34 2009 Received: (at 1852) by emacsbugs.donarmstrong.com; 12 Jan 2009 02:38:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0C2cW9H020124 for <1852@emacsbugs.donarmstrong.com>; Sun, 11 Jan 2009 18:38:33 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id D1C1057E18A; Sun, 11 Jan 2009 21:38:45 -0500 (EST) From: Chong Yidong To: Stephen Berman Cc: 1852@debbugs.gnu.org Subject: Re: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) References: <87vdslfpdi.fsf@escher.local.home> Date: Sun, 11 Jan 2009 21:38:45 -0500 In-Reply-To: <87vdslfpdi.fsf@escher.local.home> (Stephen Berman's message of "Sun, 11 Jan 2009 23:29:29 +0100") Message-ID: <87ljthfdu2.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stephen Berman writes: > Your fix prevents the error from being raised at step 4 above; however, > the behavior is nevertheless still not what I would naively expect: > namely, now it switches to a *Help* buffer describing variable-pitch > face, containing the line > Slant: unspecified > i.e., this is not the face that I clicked to get a description of (as > the tooltip also promises). Wouldn't it be better (if readily > implementable) to exclude `(:slant oblique)' from the the describe-face > link? The "face" you are trying to customize is actually two faces---the `variable-pitch' face plus an anonymous face consisting of the property-value pair (:slant oblique). The best that Custom can do is to allow you to customize the former. The latter can't be customized because it lacks a face name (how would we save the customized face?). From stephen.berman@gmx.net Mon Jan 12 04:19:23 2009 Received: (at 1852) by emacsbugs.donarmstrong.com; 12 Jan 2009 12:19:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n0CCJFMd006294 for <1852@emacsbugs.donarmstrong.com>; Mon, 12 Jan 2009 04:19:17 -0800 Received: (qmail invoked by alias); 12 Jan 2009 12:19:09 -0000 Received: from i59F5702E.versanet.de (EHLO escher.local.home) [89.245.112.46] by mail.gmx.net (mp047) with SMTP; 12 Jan 2009 13:19:09 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+y1cVwAJiyyTXxoGsIMedw3oCZqoJDqVYb+8t+ik 7+5bxLCeqoucRZ Received: by escher.local.home (Postfix, from userid 1000) id 705051D103C; Mon, 12 Jan 2009 13:19:07 +0100 (CET) From: Stephen Berman To: Chong Yidong Cc: 1852@debbugs.gnu.org Subject: Re: bug#1852: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) References: <87vdslfpdi.fsf@escher.local.home> <87ljthfdu2.fsf@cyd.mit.edu> Sender: steve@escher.local.home Date: Mon, 12 Jan 2009 13:19:07 +0100 In-Reply-To: <87ljthfdu2.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 11 Jan 2009 21:38:45 -0500") Message-ID: <87iqokra2s.fsf@escher.local.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 On Sun, 11 Jan 2009 21:38:45 -0500 Chong Yidong wrote: > Stephen Berman writes: > >> Your fix prevents the error from being raised at step 4 above; however, >> the behavior is nevertheless still not what I would naively expect: >> namely, now it switches to a *Help* buffer describing variable-pitch >> face, containing the line >> Slant: unspecified >> i.e., this is not the face that I clicked to get a description of (as >> the tooltip also promises). Wouldn't it be better (if readily >> implementable) to exclude `(:slant oblique)' from the the describe-face >> link? > > The "face" you are trying to customize is actually two faces---the > `variable-pitch' face plus an anonymous face consisting of the > property-value pair (:slant oblique). I was obviously confused above, but I also think it's confusing to say there are two faces here and to call `(:slant oblique)' an anonymous face. `(variable-pitch (:slant oblique))' is simply the value of the face property (as indeed the *Help* buffer explicitly says; I don't know why I was confused). > The best that Custom can do is to > allow you to customize the former. The latter can't be customized > because it lacks a face name (how would we save the customized face?). Since the value of the face property can contain named faces, I expect these to be customizable, and indeed, when I type `C-u C-x =' on the `A' of `Authors' in the *About GNU Emacs* buffer, the *Help* buffer shows this: There are text properties here: face (link variable-pitch) and when I click on this value I do indeed get a buffer describing both the link and variable-pitch faces, each with an accompanying customize button. Since `(:slant oblique)' in the previous case is not a named face, it cannot, as you say, be customized. But for this reason, I think it would be better, as I suggested, to have `(:slant oblique)' not be clickable in the output of `C-u C-x ='. I found two other cases that seem buggy: (a) Type `C-u C-x =' on any of the letters in `GNU Emacs' or `GNU/Linux' in the line directly below the Emacs logo in the *About GNU Emacs* buffer. The resulting *Help* buffer shows this as the value of the face property: face (link (variable-pitch (:foreground "red"))) This is not a valid value of the face property; instead, it should be this: face (link variable-pitch (:foreground "red")) Moreover, I would expect clicking on the value to show me descriptions of the link and variable-pitch faces, as above. Instead, there is only a description of the link face. (I would recommend two clickable links here, one for each named face, and none for the property-value pair.) (b) In a Text mode buffer, mark a region of text, click the menu entry Edit->Text Properties->Foreground Color->red, and on one of the resulting red characters type `C-u C-x ='. The *Help* buffers shows: face ((:foreground "red")) which is fine, but when I click on the value, I get an empty *Help* buffer. This is another reason for this type of face value not to be overlayed with a clickable link. Steve Berman From unknown Sat Aug 16 16:06:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Feb 2009 15:24:11 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator