GNU bug report logs - #18512
no startup warning if user-emacs-directory is modfied and added to load-path

Previous Next

Full log

Message #45 received at 18512 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 18512 <at> debbugs.gnu.org
Cc: rgm <at> gnu.org, david.reitter <at> gmail.com
Subject: Re: bug#18512: 24.3.93;
 tramp persistency file: incompatible with old versions? Tramp won't
 start!
Date: Sat, 04 Oct 2014 18:34:04 -0400

> *** lisp/startup.el	2014-10-02 13:26:23 +0000
> --- lisp/startup.el	2014-10-04 18:53:16 +0000
> ***************
> *** 1286,1292 ****
>     (let (warned)
>       (dolist (dir load-path)
>         (and (not warned)
> ! 	   (string-match-p "/[._]emacs\\.d/?\\'" dir)
>   	   (string-equal (file-name-as-directory (expand-file-name dir))
>   			 (expand-file-name user-emacs-directory))
>   	   (setq warned t)
> --- 1286,1296 ----
>     (let (warned)
>       (dolist (dir load-path)
>         (and (not warned)
> ! 	   (string-match-p
> ! 	    (format "/%s/?\\'"
> ! 		    (regexp-quote
> ! 		     (file-name-nondirectory
> ! 		      (directory-file-name user-emacs-directory)))) dir)
>   	   (string-equal (file-name-as-directory (expand-file-name dir))
>   			 (expand-file-name user-emacs-directory))
>   	   (setq warned t)

Why not simply remove the (string-match-p "/[._]emacs\\.d/?\\'" dir) test?
AFAICT the next string-equal test (which should/could probably be
replaced by a file-equal-p test) is already more strict than what
you added.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.