From unknown Thu Aug 14 17:27:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#18510 <18510@debbugs.gnu.org> To: bug#18510 <18510@debbugs.gnu.org> Subject: Status: 24.4.50; ERC doesn't update mode line frequently enough Reply-To: bug#18510 <18510@debbugs.gnu.org> Date: Fri, 15 Aug 2025 00:27:49 +0000 retitle 18510 24.4.50; ERC doesn't update mode line frequently enough reassign 18510 emacs submitter 18510 Tom Tromey severity 18510 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 19 10:29:54 2014 Received: (at submit) by debbugs.gnu.org; 19 Sep 2014 14:29:54 +0000 Received: from localhost ([127.0.0.1]:45942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUzC5-0007Ym-Dy for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:29:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39727) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUzC0-0007Yb-Qq for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUzBs-0003w2-Ek for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:29:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUzBs-0003vX-BP for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:29:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUzBd-0003fQ-VK for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:29:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUzBW-0003pw-QB for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:29:25 -0400 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:54866) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1XUzBW-0003o7-DL for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:29:18 -0400 Received: (qmail 23736 invoked by uid 0); 19 Sep 2014 14:29:04 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy4.mail.unifiedlayer.com with SMTP; 19 Sep 2014 14:29:04 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id t2Uy1o0012f2jeq012V1i1; Fri, 19 Sep 2014 08:29:03 -0600 X-Authority-Analysis: v=2.1 cv=e5mVF8Z/ c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=sAADcRMKGQsA:10 a=ruZM3MTjnQMA:10 a=_cZRQKYwz3QA:10 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=oMhZhQ4-4PIA:10 a=ktvOOkRkwIv1B7CDl_kA:9 a=iM77WeTdlKR9zGjL:21 a=k7o-hbjJ6kjJpoF6:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=fqr0vtAnkyf2qKPjCfuUZ/AiFzodJgasSXh/7SGP7BA=; b=K9vD8kFIs7z60ILVBFJRuAkLFT1jVHx51znnD8yKrV+/USKPcZBtvnv6g7C/YEOd7Kf0U3gHGFY7mKsD8BvzP7X2KEKwGpLRfGce/p8hrE6X+J7SURXMpNJM0cCCRxVu; Received: from [71.33.141.119] (port=37285 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.82) (envelope-from ) id 1XUzBC-0006iv-Ji; Fri, 19 Sep 2014 08:28:58 -0600 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 24.4.50; ERC doesn't update mode line frequently enough X-Attribution: Tom Date: Fri, 19 Sep 2014 08:28:54 -0600 Message-ID: <874mw3vg49.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.33.141.119 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When using ERC with the 'track' module, I notice that when I am idle, if a new message comes in then the mode line is not updated. If I type, though, the mode line updates. This defeats the purpose of erc-track. I've worked around it locally by advising erc-update-mode-line to call (force-mode-line-update t). In GNU Emacs 24.4.50.8 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.9) of 2014-09-15 on bapiya Repository revision: 117884 dancol@dancol.org-20140915050944-sqsajysnwef51f9m Windowing system distributor `Fedora Project', version 11.0.11404000 Configured using: `configure --prefix=/home/tromey/Emacs/install' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t flyspell-mode: t eldoc-mode: t which-function-mode: t global-auto-revert-mode: t desktop-save-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill Recent input: C-u C-u C-n C-l C-u C-u C-n C-l C-v C-s c h a n n e l C-r C-r C-r C-a C-s c o m m a n d C-w C-s C-a C-u C-n C-u C-n C-u C-p C-n C-l C-s d e C-w C-w C-s C-s C-s C-v C-l C-v C-l C-v C-v C-v M-v M-v M-v C-r # C-r C-r C-r C-r C-r C-r C-r C-r C-s C-s C-s C-s C-s C-s C-s C-s C-s C-a C-u C-u C-n C-l C-s d e c C-a M-v M-v M-< C-s d e c o d e - s t r i n g C-w C-w C-a C-u C-SPC C-u C-SPC C-s C-s C-a C-n C-n C-u C-n C-u C-n C-u C-u C-p C-u C-p C-u C-p C-s e r C-w C-w C-w C-w C-w C-s C-s C-l C-n C-n C-M-b C-s C-w C-w C-w C-w C-w C-s C-a C-u C-u C-n C-p C-p C-p C-l M-f M-b C-s C-w C-w C-w C-r C-r C-r C-s C-s C-s C-s C-l M-< C-s e r c - g e t - h o o k M-< C-s d e f i n e C-s C-s C-w C-w C-w C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-a C-v C-l C-u C-u C-n C-l C-z n M-x r e p o r t - e m < return> Recent messages: Making completion list... Grep finished (matches found) Mark saved where search started [9 times] Mark set Mark saved where search started [5 times] Mark set Mark saved where search started Mark set Mark saved where search started Load-path shadows: /home/tromey/.emacs.d/elpa/css-mode-1.0/css-mode hides /home/tromey/Emacs/install/share/emacs/24.4.50/lisp/textmodes/css-mode /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/24.4.50/lisp/play/bubbles Features: (shadow emacsbug log-view cus-edit tar-mode bbdb-sc supercite regi debug cl-macs eieio-opt speedbar sb-image ezimage dframe help-mode dabbrev log-edit pcvs-util copyright url-http url-gw url-auth url-queue mailalias misearch multi-isearch mail-hist nnir find-file gnus-fun gnus-html xml url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars shr-color color shr browse-url bbdb-gui bbdb-hooks mule-util sort smiley gnus-cite flow-fill mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings cl gv gnutls network-stream starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-base gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source tls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader mail-utils tcl autoconf autoconf-mode make-mode smerge-mode diff-mode goto-addr python js json vc-arch vc-mtn vc-hg vc-bzr vc-sccs vc-svn vc-cvs vc-rcs bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode dired org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs vc-git add-log flyspell ispell eldoc diminish projectile edmacro kmacro pkg-info find-func lisp-mnt epl grep compile dash s appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu minimap autorevert filenotify desktop frameset cus-start cus-load status erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-button wid-edit cl-loaddefs cl-lib erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio byte-opt bytecomp byte-compile cconv eieio-core gnus-util mm-util mail-prsvr password-cache thingatpt pp advice help-fns vc-dir ewoc vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs bbdb timezone ange-ftp comint ansi-color ring server savehist dwarf-mode-autoloads gdb-shell-autoloads jabber-autoloads lisppaste-autoloads pydoc-info-autoloads info-look info easymenu weblogger-autoloads package bbdb-autoloads time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 977335 198850) (symbols 48 105217 553) (miscs 40 41771 4212) (strings 32 332091 34639) (string-bytes 1 15139520) (vectors 16 97683) (vector-slots 8 2190694 174189) (floats 8 563 901) (intervals 56 49476 1106) (buffers 976 350) (heap 1024 278846 83955)) Tom From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 19 13:25:45 2014 Received: (at 18510) by debbugs.gnu.org; 19 Sep 2014 17:25:45 +0000 Received: from localhost ([127.0.0.1]:46001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XV1wG-0004bI-7o for submit@debbugs.gnu.org; Fri, 19 Sep 2014 13:25:44 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XV1wD-0004b9-Vb for 18510@debbugs.gnu.org; Fri, 19 Sep 2014 13:25:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90304023" Received: from 69-165-145-6.dsl.teksavvy.com (HELO pastel.home) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Sep 2014 13:25:40 -0400 Received: by pastel.home (Postfix, from userid 20848) id C0BE3642C6; Fri, 19 Sep 2014 13:25:40 -0400 (EDT) From: Stefan Monnier To: Tom Tromey Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Message-ID: References: <874mw3vg49.fsf@tromey.com> Date: Fri, 19 Sep 2014 13:25:40 -0400 In-Reply-To: <874mw3vg49.fsf@tromey.com> (Tom Tromey's message of "Fri, 19 Sep 2014 08:28:54 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18510 Cc: 18510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I've worked around it locally by advising erc-update-mode-line to call > (force-mode-line-update t). That's not a workaround, that's a fix. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 19 14:37:12 2014 Received: (at 18510) by debbugs.gnu.org; 19 Sep 2014 18:37:12 +0000 Received: from localhost ([127.0.0.1]:46027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XV33P-0006M0-4a for submit@debbugs.gnu.org; Fri, 19 Sep 2014 14:37:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:48553) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XV33M-0006Ln-Br for 18510@debbugs.gnu.org; Fri, 19 Sep 2014 14:37:09 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIxALNBIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArYGAIDvNVNFpZEG/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIxALNBIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90310534" Received: from 69-165-145-6.dsl.teksavvy.com (HELO pastel.home) ([69.165.145.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Sep 2014 14:37:07 -0400 Received: by pastel.home (Postfix, from userid 20848) id 695ED642C6; Fri, 19 Sep 2014 14:37:07 -0400 (EDT) From: Stefan Monnier To: Tom Tromey Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Message-ID: References: <874mw3vg49.fsf@tromey.com> Date: Fri, 19 Sep 2014 14:37:07 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 19 Sep 2014 13:25:40 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18510 Cc: 18510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> I've worked around it locally by advising erc-update-mode-line to call >> (force-mode-line-update t). > That's not a workaround, that's a fix. Hmm... not sure what that was about, sorry. Of course, the (force-mode-line-update t) should only be called when changing a variable that's visible in the global mode-line-format. Does the patch below work? [ I assume the problem is also present in 24.3.93. ] Stefan === modified file 'lisp/erc/erc-track.el' --- lisp/erc/erc-track.el 2014-02-10 01:34:22 +0000 +++ lisp/erc/erc-track.el 2014-09-19 18:34:57 +0000 @@ -767,8 +765,7 @@ (erc-modified-channels-remove-buffer buffer)))) erc-modified-channels-alist) (when removed-channel - (erc-modified-channels-display) - (force-mode-line-update t))) + (erc-modified-channels-display))) (remove-hook 'post-command-hook 'erc-modified-channels-update))) (defvar erc-track-mouse-face (if (featurep 'xemacs) @@ -825,9 +822,10 @@ ((eq 'importance erc-track-switch-direction) (erc-track-sort-by-importance))) (run-hooks 'erc-track-list-changed-hook) - (unless (eq erc-track-position-in-mode-line nil) - (if (null erc-modified-channels-alist) - (setq erc-modified-channels-object (erc-modified-channels-object nil)) + (when erc-track-position-in-mode-line + (let* ((oldobject erc-modified-channels-object) + (strings + (when erc-modified-channels-alist ;; erc-modified-channels-alist contains all the data we need. To ;; better understand what is going on, we split things up into ;; four lists: BUFFERS, COUNTS, SHORT-NAMES, and FACES. These @@ -858,10 +856,11 @@ buffers (cdr buffers) counts (cdr counts) faces (cdr faces))) - (when (featurep 'xemacs) - (erc-modified-channels-object nil)) - (setq erc-modified-channels-object - (erc-modified-channels-object strings)))))) + strings))) + (newobject (erc-modified-channels-object strings))) + (unless (equal oldobject newobject) + (setq erc-modified-channels-object newobject) + (force-mode-line-update t))))) (defun erc-modified-channels-remove-buffer (buffer) "Remove BUFFER from `erc-modified-channels-alist'." From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 24 09:20:18 2014 Received: (at 18510) by debbugs.gnu.org; 24 Sep 2014 13:20:18 +0000 Received: from localhost ([127.0.0.1]:50532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWmUT-0006NV-F8 for submit@debbugs.gnu.org; Wed, 24 Sep 2014 09:20:17 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWmUQ-0006NJ-Id for 18510@debbugs.gnu.org; Wed, 24 Sep 2014 09:20:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSQTh3EI0hkXjnoHhDgEqwODTCE X-IPAS-Result: ArUGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSQTh3EI0hkXjnoHhDgEqwODTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90749202" Received: from 167-88-23-25.cpe.teksavvy.com (HELO ceviche.home) ([167.88.23.25]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2014 09:20:13 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B36FF66094; Wed, 24 Sep 2014 09:20:13 -0400 (EDT) From: Stefan Monnier To: Tom Tromey Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Message-ID: References: <874mw3vg49.fsf@tromey.com> Date: Wed, 24 Sep 2014 09:20:13 -0400 In-Reply-To: (Stefan Monnier's message of "Fri, 19 Sep 2014 14:37:07 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18510 Cc: 18510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: >>> I've worked around it locally by advising erc-update-mode-line to call >>> (force-mode-line-update t). >> That's not a workaround, that's a fix. > Hmm... not sure what that was about, sorry. Of course, the > (force-mode-line-update t) should only be called when changing > a variable that's visible in the global mode-line-format. > Does the patch below work? > [ I assume the problem is also present in 24.3.93. ] > Stefan > === modified file 'lisp/erc/erc-track.el' > --- lisp/erc/erc-track.el 2014-02-10 01:34:22 +0000 > +++ lisp/erc/erc-track.el 2014-09-19 18:34:57 +0000 > @@ -767,8 +765,7 @@ > (erc-modified-channels-remove-buffer buffer)))) > erc-modified-channels-alist) > (when removed-channel > - (erc-modified-channels-display) > - (force-mode-line-update t))) > + (erc-modified-channels-display))) > (remove-hook 'post-command-hook 'erc-modified-channels-update))) > (defvar erc-track-mouse-face (if (featurep 'xemacs) > @@ -825,9 +822,10 @@ > ((eq 'importance erc-track-switch-direction) > (erc-track-sort-by-importance))) > (run-hooks 'erc-track-list-changed-hook) > - (unless (eq erc-track-position-in-mode-line nil) > - (if (null erc-modified-channels-alist) > - (setq erc-modified-channels-object (erc-modified-channels-object nil)) > + (when erc-track-position-in-mode-line > + (let* ((oldobject erc-modified-channels-object) > + (strings > + (when erc-modified-channels-alist > ;; erc-modified-channels-alist contains all the data we need. To > ;; better understand what is going on, we split things up into > ;; four lists: BUFFERS, COUNTS, SHORT-NAMES, and FACES. These > @@ -858,10 +856,11 @@ > buffers (cdr buffers) > counts (cdr counts) > faces (cdr faces))) > - (when (featurep 'xemacs) > - (erc-modified-channels-object nil)) > - (setq erc-modified-channels-object > - (erc-modified-channels-object strings)))))) > + strings))) > + (newobject (erc-modified-channels-object strings))) > + (unless (equal oldobject newobject) > + (setq erc-modified-channels-object newobject) > + (force-mode-line-update t))))) > (defun erc-modified-channels-remove-buffer (buffer) > "Remove BUFFER from `erc-modified-channels-alist'." From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 24 12:37:48 2014 Received: (at 18510) by debbugs.gnu.org; 24 Sep 2014 16:37:48 +0000 Received: from localhost ([127.0.0.1]:50955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWpZb-0002xd-L3 for submit@debbugs.gnu.org; Wed, 24 Sep 2014 12:37:48 -0400 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:55871) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1XWpZY-0002xS-HT for 18510@debbugs.gnu.org; Wed, 24 Sep 2014 12:37:45 -0400 Received: (qmail 31977 invoked by uid 0); 24 Sep 2014 16:37:41 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy7.mail.unifiedlayer.com with SMTP; 24 Sep 2014 16:37:41 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id vAdV1o00b2f2jeq01AdY34; Wed, 24 Sep 2014 16:37:40 -0600 X-Authority-Analysis: v=2.1 cv=fdw+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=4GsTxW34auoA:10 a=4GAemRXq0RYA:10 a=4KE4hTpTjbkA:10 a=_cZRQKYwz3QA:10 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=oMhZhQ4-4PIA:10 a=tQtEGPCL7yYHnTy4jFwA:9 a=571z6S1eaAYA:10 a=ODaP6L-Lo64A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=iKzaMe+9OoaID/2hVyhFh/i9zJ58wHRk5/9o/k3imiI=; b=k3jI5ocfl82kLLRQS1s1ftQ1Ir2v/EVVPOX1kLjUCSkhKQoKQ053/sfcaPNvbpuiGjTpDkS5G4hziSX3jJmmdkFETuCbT6vr6gR1F4MmCUgavokIP2nKyH9dIP+/dNSj; Received: from [71.33.141.119] (port=53525 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.82) (envelope-from ) id 1XWpZJ-0003Y4-TM; Wed, 24 Sep 2014 10:37:30 -0600 From: Tom Tromey To: Stefan Monnier Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough References: <874mw3vg49.fsf@tromey.com> X-Attribution: Tom Date: Wed, 24 Sep 2014 10:37:24 -0600 In-Reply-To: (Stefan Monnier's message of "Wed, 24 Sep 2014 09:20:13 -0400") Message-ID: <87h9zxrn3v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.33.141.119 authed with tom+tromey.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 18510 Cc: 18510@debbugs.gnu.org, Tom Tromey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan> Ping? I'm sorry about the delay on this. Your patch worked! I applied it to my running Emacs and removed the advice and waited to see if the ERC mode line updated. Tom From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 24 13:32:40 2014 Received: (at 18510-done) by debbugs.gnu.org; 24 Sep 2014 17:32:40 +0000 Received: from localhost ([127.0.0.1]:50971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWqQh-0004OT-SX for submit@debbugs.gnu.org; Wed, 24 Sep 2014 13:32:40 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36393) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XWqQe-0004OJ-Uf for 18510-done@debbugs.gnu.org; Wed, 24 Sep 2014 13:32:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKsDg0wh X-IPAS-Result: ArYGAIDvNVOnWBcZ/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKsDg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90774167" Received: from 167-88-23-25.cpe.teksavvy.com (HELO ceviche.home) ([167.88.23.25]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2014 13:32:36 -0400 Received: by ceviche.home (Postfix, from userid 20848) id DA14C66094; Wed, 24 Sep 2014 13:32:35 -0400 (EDT) From: Stefan Monnier To: Tom Tromey Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Message-ID: References: <874mw3vg49.fsf@tromey.com> <87h9zxrn3v.fsf@tromey.com> Date: Wed, 24 Sep 2014 13:32:35 -0400 In-Reply-To: <87h9zxrn3v.fsf@tromey.com> (Tom Tromey's message of "Wed, 24 Sep 2014 10:37:24 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18510-done Cc: 18510-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Your patch worked! I applied it to my running Emacs and removed the > advice and waited to see if the ERC mode line updated. Thanks, installed, closing, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 11 09:30:53 2014 Received: (at 18510) by debbugs.gnu.org; 11 Oct 2014 13:30:53 +0000 Received: from localhost ([127.0.0.1]:40827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xcwl2-0003yg-Ad for submit@debbugs.gnu.org; Sat, 11 Oct 2014 09:30:52 -0400 Received: from fely.am-1.org ([78.47.74.50]:35864) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xcwkr-0003yK-I0 for 18510@debbugs.gnu.org; Sat, 11 Oct 2014 09:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:References:Subject:To:From; bh=+QyeJMKSyxDcdIftrzuFJqVBCViCDpfGgzaktbXqh14=; b=akBVhx3GSky4HPVQ9AKmx0uJSnIY5mEHTptZVKKWwxl1Bgy3E27bqR5+ry5V25fwEpign2hYlme3BqRZJY17O/ERKl712g45ws3699RAk9GpPuzH2KiqXEYsu+6ZK3pCLCekqiLZjeFSYiDNfsq425ZUHhBV4gR7+zWP6pkZM+g=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xcwko-00051t-Np for 18510@debbugs.gnu.org; Sat, 11 Oct 2014 13:30:39 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xcwkg-0000xT-Tm for 18510@debbugs.gnu.org; Sat, 11 Oct 2014 20:30:31 +0700 From: Ivan Shmakov To: 18510@debbugs.gnu.org Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough References: <874mw3vg49.fsf@tromey.com> <87h9zxrn3v.fsf@tromey.com> Date: Sat, 11 Oct 2014 13:30:30 +0000 Message-ID: <87k3463f9l.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 18510 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Stefan Monnier writes: >> Your patch worked! I applied it to my running Emacs and removed the >> advice and waited to see if the ERC mode line updated. > Thanks, installed, closing, Please consider the patch MIMEd. This should fix the issue introduced in 67c13dfc627d that now prevents erc-modified-channels-object from being updated when the buffer has already seen some activity /and/ then sees some more important (as per erc-track-faces-priority-list) activity in the same buffer. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/erc/erc-track.el +++ b/lisp/erc/erc-track.el @@ -860,7 +860,7 @@ Use `erc-make-mode-line-buffer-name' to create buttons." faces (cdr faces))) strings))) (newobject (erc-modified-channels-object strings))) - (unless (equal oldobject newobject) + (unless (equal-including-properties oldobject newobject) (setq erc-modified-channels-object newobject) (force-mode-line-update t))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 14 21:16:10 2014 Received: (at 18510-done) by debbugs.gnu.org; 15 Oct 2014 01:16:10 +0000 Received: from localhost ([127.0.0.1]:43734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeDCE-0006w9-0P for submit@debbugs.gnu.org; Tue, 14 Oct 2014 21:16:10 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:3596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XeDCB-0006w0-CM for 18510-done@debbugs.gnu.org; Tue, 14 Oct 2014 21:16:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="94223373" Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Oct 2014 21:16:06 -0400 Received: by pastel.home (Postfix, from userid 20848) id 81FF085E4; Tue, 14 Oct 2014 21:16:06 -0400 (EDT) From: Stefan Monnier To: Ivan Shmakov Subject: Re: bug#18510: 24.4.50; ERC doesn't update mode line frequently enough Message-ID: References: <874mw3vg49.fsf@tromey.com> <87h9zxrn3v.fsf@tromey.com> <87k3463f9l.fsf@violet.siamics.net> Date: Tue, 14 Oct 2014 21:16:06 -0400 In-Reply-To: <87k3463f9l.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 11 Oct 2014 13:30:30 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 18510-done Cc: 18510-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > This should fix the issue introduced in 67c13dfc627d that now > prevents erc-modified-channels-object from being updated when > the buffer has already seen some activity /and/ then sees some > more important (as per erc-track-faces-priority-list) activity > in the same buffer. Thanks, installed, Stefan From unknown Thu Aug 14 17:27:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Nov 2014 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator