From unknown Sun Aug 17 02:00:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18509: 24.3.93; [patch] erc completion case inconsistency Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Sep 2014 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 18509@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141113535526515 (code B ref -1); Fri, 19 Sep 2014 14:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Sep 2014 14:02:35 +0000 Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUyle-0006ta-9l for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:02:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XUylb-0006tR-ID for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUylV-0004st-E9 for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:02:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUylV-0004nc-Aw for submit@debbugs.gnu.org; Fri, 19 Sep 2014 10:02:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUylK-00042P-4x for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUylE-0004cz-2l for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:02:14 -0400 Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:60130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUylD-0004c7-VA for bug-gnu-emacs@gnu.org; Fri, 19 Sep 2014 10:02:08 -0400 Received: by mail-qc0-f178.google.com with SMTP id w7so2513588qcr.9 for ; Fri, 19 Sep 2014 07:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=G0Rn0o7xD7hIe9wbL8YpBjeLM+MGsQkPWVIEnAtEYY8=; b=LODQTPXGRR48q72vQd2tltCz2emCgIVzGrR4AznYVCgDtNwjQifR9aznOP4PiyT+a6 THwnAQhn3QqQjOt3CNCZmFWeZXxtPZhC0cxnnCf4j4jRYey5gCcCc6nw95NM4WaeUVZe +0V0fmR0PBgholKHy2bn9rX9/rKAemg5mxlnCME552sEWy0vmqW5Uu4/OuO3EDdynXrZ jjIw/rpcmOzX0McEN2cGqrAbrMDzSSJwL+XlIjx5bpajs6q/kPsRQ0MlyzaNIb/sYpVH YZzt4WXCWo3GAOBel/5dhaYJa6CV/dYM129DNuqrPeaoW4d0YY0SyXZzfIlGFv/dePVC OSfQ== X-Received: by 10.224.125.4 with SMTP id w4mr1027539qar.20.1411135322105; Fri, 19 Sep 2014 07:02:02 -0700 (PDT) Received: from carlos-jampp ([190.18.155.203]) by mx.google.com with ESMTPSA id w8sm1495139qag.2.2014.09.19.07.02.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Sep 2014 07:02:01 -0700 (PDT) From: Carlos Pita Date: Fri, 19 Sep 2014 11:01:58 -0300 Message-ID: <87iokjemjt.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) (The following was a follow up to bug #11360, but I decided to report it separately as they're not quite the same issues and, also, because I know how to fix this one but not the other.) When using the bitlbee channel (this is the example I have, the issue is not specific to bitlbee at all), tab completion on an empty line gives: FirstName SecondName .... But tab completion after /query gives: firstname secondname .... This is not only visually inconsistent but, as the completion is case sensitive, then that a given prefix successfully completes depends on where the completion was triggered. The case inconsistency is due to the fact that users are hashed into erc-server-users using (erc-downcase nick). But then pcomplete-erc-all-nicks builds the completion list from the hash keys. This is wrong because the keys are the downcased nicks, not the real nicks themselves. This is also inconsistent with the way pcomplete-erc-nicks works (this one does use the real nick). Changing (erc-server-user-nickname user) for nick in pcomplete-erc-all-nicks will fix this issue. I'm not attaching an explicit patch as the fix is quite trivial, but the resulting pcomplete-erc-all-nicks should look like: (defun pcomplete-erc-all-nicks (&optional postfix) "Returns a list of all nicks on the current server." (let (nicks) (erc-with-server-buffer (maphash (lambda (nick user) (setq nicks (cons ;; change this -----. ;; v (concat (erc-server-user-nickname user) postfix) nicks))) erc-server-users)) nicks)) Best regards -- Carlos ------------------------------------------------------------ In GNU Emacs 24.3.93.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2) of 2014-09-11 on archiso Windowing system distributor `The X.Org Foundation', version 11.0.11600000 Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' From unknown Sun Aug 17 02:00:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18509: 24.3.93; [patch] erc completion case inconsistency Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Carlos Pita Cc: 18509@debbugs.gnu.org Received: via spool by 18509-submit@debbugs.gnu.org id=B18509.145124902031537 (code B ref 18509); Sun, 27 Dec 2015 20:44:01 +0000 Received: (at 18509) by debbugs.gnu.org; 27 Dec 2015 20:43:40 +0000 Received: from localhost ([127.0.0.1]:44900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIAG-0008Cb-73 for submit@debbugs.gnu.org; Sun, 27 Dec 2015 15:43:40 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:47804) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIAE-0008CR-1e for 18509@debbugs.gnu.org; Sun, 27 Dec 2015 15:43:38 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDI9s-0003bR-W5; Sun, 27 Dec 2015 21:43:17 +0100 From: Lars Ingebrigtsen References: <87iokjemjt.fsf@gmail.com> Date: Sun, 27 Dec 2015 21:43:16 +0100 In-Reply-To: <87iokjemjt.fsf@gmail.com> (Carlos Pita's message of "Fri, 19 Sep 2014 11:01:58 -0300") Message-ID: <87ege7bp23.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDI9s-0003bR-W5 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451853797.52197@WGQSeswV9RwZvva4VwcT1g X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Carlos Pita writes: > Changing (erc-server-user-nickname user) for nick in > pcomplete-erc-all-nicks will fix this issue. I'm not attaching an > explicit patch as the fix is quite trivial, but the resulting > pcomplete-erc-all-nicks should look like: Can you send a patch for this instead? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Aug 17 02:00:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#18509: 24.3.93; [patch] erc completion case inconsistency Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 06:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Carlos Pita Cc: 18509@debbugs.gnu.org Received: via spool by 18509-submit@debbugs.gnu.org id=B18509.145456585621222 (code B ref 18509); Thu, 04 Feb 2016 06:05:02 +0000 Received: (at 18509) by debbugs.gnu.org; 4 Feb 2016 06:04:16 +0000 Received: from localhost ([127.0.0.1]:58788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRD1c-0005WD-OQ for submit@debbugs.gnu.org; Thu, 04 Feb 2016 01:04:16 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:46887) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRD1b-0005W6-Ik for 18509@debbugs.gnu.org; Thu, 04 Feb 2016 01:04:15 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRD1F-00004r-99; Thu, 04 Feb 2016 07:03:53 +0100 From: Lars Ingebrigtsen References: <87iokjemjt.fsf@gmail.com> Date: Thu, 04 Feb 2016 17:03:47 +1100 In-Reply-To: <87iokjemjt.fsf@gmail.com> (Carlos Pita's message of "Fri, 19 Sep 2014 11:01:58 -0300") Message-ID: <87d1sd1070.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aRD1F-00004r-99 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455170634.13365@zWUVJ32t+jMw8QRzIC6Wcg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Carlos Pita writes: > Changing (erc-server-user-nickname user) for nick in > pcomplete-erc-all-nicks will fix this issue. I'm not attaching an > explicit patch as the fix is quite trivial, but the resulting > pcomplete-erc-all-nicks should look like: Thanks; installed in emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 01:04:25 2016 Received: (at control) by debbugs.gnu.org; 4 Feb 2016 06:04:25 +0000 Received: from localhost ([127.0.0.1]:58791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRD1k-0005WZ-UJ for submit@debbugs.gnu.org; Thu, 04 Feb 2016 01:04:25 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:46893) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRD1j-0005WR-Nl for control@debbugs.gnu.org; Thu, 04 Feb 2016 01:04:24 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRD1O-000052-2r for control@debbugs.gnu.org; Thu, 04 Feb 2016 07:04:02 +0100 Date: Thu, 04 Feb 2016 17:03:58 +1100 Message-Id: <87bn7x106p.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #18509 X-MailScanner-ID: 1aRD1O-000052-2r X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455170642.82697@wzqxZf8strEj90+ANG2VfQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 18509 fixed close 18509 25.1