GNU bug report logs - #18506
stty dsusp undef fails.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 18506 in the body.
You can then email your comments to 18506 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Edward Huff <ejhuff <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: stty dsusp undef fails.
Date: Thu, 18 Sep 2014 22:09:40 -0400

$ stty dsusp undef
stty: invalid argument ‘dsusp’
Try 'stty --help' for more information.
$ stty --help | grep dsusp
 * dsusp CHAR    CHAR will send a terminal stop signal once input flushed
$ stty --version
stty (GNU coreutils) 8.21
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David MacKenzie.
$

Message #8 received at 18506 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Edward Huff <ejhuff <at> gmail.com>
Cc: 18506 <at> debbugs.gnu.org
Subject: Re: bug#18506: stty dsusp undef fails.
Date: Fri, 19 Sep 2014 10:05:32 +0100

tag 18506 notabug
close 18506
stop

On 09/19/2014 03:09 AM, Edward Huff wrote:
> $ stty dsusp undef
> stty: invalid argument ‘dsusp’
> Try 'stty --help' for more information.
> $ stty --help | grep dsusp
>  * dsusp CHAR    CHAR will send a terminal stop signal once input flushed
> $ stty --version
> stty (GNU coreutils) 8.21

The dsusp entry is tagged with "*" to indicate it's not a POSIX setting,
and just above the --help says: "The underlying system defines which settings are available."
So it's just the case that this setting is not available on your system,
which is the case for Linux for example. Ideally the listed options would
be dynamic and not list this as an option for you, but this would complicate
the man page generation.

thanks,
Pádraig.

Message #15 received at 18506 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Edward Huff <ejhuff <at> gmail.com>
Cc: 18506 <at> debbugs.gnu.org
Subject: Re: bug#18506: stty dsusp undef fails.
Date: Fri, 19 Sep 2014 16:19:10 +0100

[Message part 1 (text/plain, inline)]

On 09/19/2014 10:05 AM, Pádraig Brady wrote:
> tag 18506 notabug
> close 18506
> stop
> 
> On 09/19/2014 03:09 AM, Edward Huff wrote:
>> $ stty dsusp undef
>> stty: invalid argument ‘dsusp’
>> Try 'stty --help' for more information.
>> $ stty --help | grep dsusp
>>  * dsusp CHAR    CHAR will send a terminal stop signal once input flushed
>> $ stty --version
>> stty (GNU coreutils) 8.21
> 
> The dsusp entry is tagged with "*" to indicate it's not a POSIX setting,
> and just above the --help says: "The underlying system defines which settings are available."
> So it's just the case that this setting is not available on your system,
> which is the case for Linux for example. Ideally the listed options would
> be dynamic and not list this as an option for you, but this would complicate
> the man page generation.

However man pages are generated at build time now,
so we might consider eliding non applicable items?

The caveat to that is that man pages generated and
then copied on the web somewhere would be less general.

I'm leaning towards that actually as currently we
don't distinguish "invalid argument" from "not supported" errors.

Proposed patch attached.

thanks,
Pádraig.

[stty-elide-unsupported.diff (text/x-patch, attachment)]

Message #18 received at 18506 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>, 
 Edward Huff <ejhuff <at> gmail.com>
Cc: 18506 <at> debbugs.gnu.org
Subject: Re: bug#18506: stty dsusp undef fails.
Date: Fri, 19 Sep 2014 20:45:24 +0200

On 09/19/2014 05:19 PM, Pádraig Brady wrote:
> From be1e555db9cfd7e82a0a26e1a612a65ebe93d789 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P <at> draigBrady.com>
> Date: Fri, 19 Sep 2014 16:15:04 +0100
> Subject: [PATCH] stty: only list supported options in --help and man pages
> 
> * src/stty.c (usage): Exclude unsupported options from --help,
> which only impacts the "dsusp" option on GNU/Linux.

that one, too:

-* [\-]cdtrdsr
-enable DTR/DSR handshaking
-.TP


A slightly different idea: as this can only happen for non-POSIX
options, we could change the '*' symbol to e.g. 'S' ("supported
non-POSIX option) and 'U' (unsupported non-POSIX option).
WDYT?

The cleanest solution probably would be to distinguish between
distinguish "invalid argument" from "not supported" errors, as you
aleady said. I'm not sure if it's worthwhile.

Otherwise: +1

Thanks & have a nice day,
Berny

Message #21 received at 18506 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Pádraig Brady <P <at> draigBrady.com>, 
 Edward Huff <ejhuff <at> gmail.com>
Cc: 18506 <at> debbugs.gnu.org
Subject: Re: bug#18506: stty dsusp undef fails.
Date: Fri, 19 Sep 2014 21:13:40 +0200

On 09/19/2014 08:45 PM, Bernhard Voelker wrote:
> On 09/19/2014 05:19 PM, Pádraig Brady wrote:
>> From be1e555db9cfd7e82a0a26e1a612a65ebe93d789 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P <at> draigBrady.com>
>> Date: Fri, 19 Sep 2014 16:15:04 +0100
>> Subject: [PATCH] stty: only list supported options in --help and man pages

oops, the syntax-check doesn't pass:

cppi: src/stty.c: line 570: not properly indented
maint.mk: incorrect preprocessor indentation
make: *** [sc_preprocessor_indentation] Error 1

sed -i -e '570 s/^# ifdef/#ifdef/' src/stty.c

Have a nice day,
Berny

Message #24 received at 18506 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: Edward Huff <ejhuff <at> gmail.com>, 18506 <at> debbugs.gnu.org
Subject: Re: bug#18506: stty dsusp undef fails.
Date: Fri, 19 Sep 2014 23:41:56 +0100

On 09/19/2014 07:45 PM, Bernhard Voelker wrote:
> On 09/19/2014 05:19 PM, Pádraig Brady wrote:
>> From be1e555db9cfd7e82a0a26e1a612a65ebe93d789 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P <at> draigBrady.com>
>> Date: Fri, 19 Sep 2014 16:15:04 +0100
>> Subject: [PATCH] stty: only list supported options in --help and man pages
>>
>> * src/stty.c (usage): Exclude unsupported options from --help,
>> which only impacts the "dsusp" option on GNU/Linux.
> 
> that one, too:
> 
> -* [\-]cdtrdsr
> -enable DTR/DSR handshaking
> -.TP

Oh right, I was comparing against an older stty without that support.

> A slightly different idea: as this can only happen for non-POSIX
> options, we could change the '*' symbol to e.g. 'S' ("supported
> non-POSIX option) and 'U' (unsupported non-POSIX option).
> WDYT?

I did think about that, but err'd on side of
less information, rather than more.

> The cleanest solution probably would be to distinguish between
> distinguish "invalid argument" from "not supported" errors, as you
> aleady said. I'm not sure if it's worthwhile.

I thought of that too, but thought the doc changes enough.

I'll sleep on this one before pushing.

thanks for all the reviews!

Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.