GNU bug report logs - #18495
[PATCH] Fix SCM_SMOB_OBJECT_LOC

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mark H Weaver <mhw <at> netris.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#18495: closed ([PATCH] Fix SCM_SMOB_OBJECT_LOC)
Date: Sat, 20 Sep 2014 12:45:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 20 Sep 2014 08:42:49 -0400
with message-id <871tr6mpiu.fsf <at> yeeloong.lan>
and subject line Re: bug#18495: Alternatives!?!
has caused the debbugs.gnu.org bug report #18495,
regarding [PATCH] Fix SCM_SMOB_OBJECT_LOC
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
18495: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18495
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Kastrup <dak <at> gnu.org>
To: bug-guile <at> gnu.org
Cc: David Kastrup <dak <at> gnu.org>
Subject: [PATCH] Fix SCM_SMOB_OBJECT_LOC
Date: Thu, 18 Sep 2014 09:32:35 +0200

* libguile/smob.h (SCM_SMOB_OBJECT_LOC): This elementary API macro has
  been broken by commit 56164dc47f6616b359f0ad23be208f01a77b55fa in 2009

Signed-off-by: David Kastrup <dak <at> gnu.org>
---
 libguile/smob.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/smob.h b/libguile/smob.h
index 60abe37..e787cb1 100644
--- a/libguile/smob.h
+++ b/libguile/smob.h
@@ -163,7 +163,7 @@ scm_new_double_smob (scm_t_bits tc, scm_t_bits data1,
 
 #define SCM_SMOB_OBJECT(x)		(SCM_SMOB_OBJECT_1 (x))
 #define SCM_SET_SMOB_OBJECT(x,obj)	(SCM_SET_SMOB_OBJECT_1 ((x), (obj)))
-#define SCM_SMOB_OBJECT_LOC(x)		(SCM_SMOB_OBJECT_1_LOC (x)))
+#define SCM_SMOB_OBJECT_LOC(x)		(SCM_SMOB_OBJECT_1_LOC (x))
 
 
 #define SCM_SMOB_APPLY_0(x)		(scm_call_0 (x))
-- 
1.9.1

[Message part 3 (message/rfc822, inline)]

From: Mark H Weaver <mhw <at> netris.org>
To: David Kastrup <dak <at> gnu.org>
Cc: wingo <at> pobox.com, 18495-done <at> debbugs.gnu.org
Subject: Re: bug#18495: Alternatives!?!
Date: Sat, 20 Sep 2014 08:42:49 -0400

David Kastrup <dak <at> gnu.org> writes:

> * libguile/smob.h (SCM_SMOB_OBJECT_LOC, SCM_SMOB_OBJECT_0_LOC)
>   (SCM_SMOB_OBJECT_1_LOC, SCM_SMOB_OBJECT_2_LOC)
>   (SCM_SMOB_OBJECT_3_LOC):  These elementary API macros have been broken
>   by commit 56164dc47f6616b359f0ad23be208f01a77b55fa in 2009

Ouch.  I've pushed this to stable-2.0, commit
8442211ef0029581b35f784489afcf210491fc41.  I'm closing this bug.

> will there be something like an official guarantee that using
> the undocumented SCM_SMOB_OBJECT_N_LOC will be supported for several
> years?

I think that's the best option.  Just use SCM_SMOB_OBJECT_N_LOC.

     Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.